Re: [cmake-developers] PATCH: Bugfix for WIX support

2016-09-06 Thread Nils Gladitz
On 06.09.2016 17:19, Stuermer, Michael SP/HZA-ZSEP wrote: I checked everything on our project. Works as expected so far. I had to add our CSharp patch(es) on top, so this is not a pure WIX feature test, but I think it's good to go. Thanks I reformatted, squashed and merged to "next" for

Re: [cmake-developers] PATCH: Bugfix for WIX support

2016-09-06 Thread Stuermer, Michael SP/HZA-ZSEP
> -Original Message- > From: Nils Gladitz [mailto:nilsglad...@gmail.com] > Sent: Tuesday, September 06, 2016 4:28 PM > To: Stuermer, Michael SP/HZA-ZSEP; CMake Developers > Subject: Re: [cmake-developers] PATCH: Bugfix for WIX support > > On 09/06/2016 03:45 P

Re: [cmake-developers] PATCH: Bugfix for WIX support

2016-09-06 Thread Nils Gladitz
On 09/06/2016 03:45 PM, Nils Gladitz wrote: https://cmake.org/gitweb?p=stage/cmake.git;a=commit;h=fe20015b13d6ccf10d99ff9b3d8f68919164fcf8 Please verify that I haven't broken anything. I broke writing of WIX include files. Should be fixed now:

Re: [cmake-developers] PATCH: Bugfix for WIX support

2016-09-06 Thread Nils Gladitz
On 09/06/2016 01:29 PM, Stuermer, Michael SP/HZA-ZSEP wrote: The generated guid values where not set correctly everywhere. This could lead to WIX build errors when using the CPACK_WIX_SKIP_PROGRAM_FOLDER option. Thanks. I modified the patch to work without the global/public

[cmake-developers] PATCH: Bugfix for WIX support

2016-09-06 Thread Stuermer, Michael SP/HZA-ZSEP
The generated guid values where not set correctly everywhere. This could lead to WIX build errors when using the CPACK_WIX_SKIP_PROGRAM_FOLDER option. Viele Grüße Michael Stürmer    SZ. Prozessdatenverarbeitung SP/HZA-ZSEP  Tel. +499132 82-86350  Mobil.: +49(171)6860010