Re: [cmake-developers] PATCH: add subcommand string(APPEND)

2015-07-07 Thread Brad King
On 07/06/2015 04:47 PM, Daniel Pfeifer wrote: > OK, now with tests and release notes. Applied, thanks: string: add APPEND subcommand http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=2b18cdca > There is a debatable edge case: > When a variable is not-set and zero elements are appended, do we

Re: [cmake-developers] PATCH: add subcommand string(APPEND)

2015-07-06 Thread Daniel Pfeifer
On Mon, Jul 6, 2015 at 10:55 PM, James Bigler wrote: > list(APPEND) requires at least one element argument, right? No, see https://github.com/Kitware/CMake/blob/master/Source/cmListCommand.cxx#L236 -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http:/

Re: [cmake-developers] PATCH: add subcommand string(APPEND)

2015-07-06 Thread James Bigler
list(APPEND) requires at least one element argument, right? Can you require the same thing for string(APPEND)? That would make it symmetric and remove your edge case. On Mon, Jul 6, 2015 at 2:47 PM, Daniel Pfeifer wrote: > On Mon, Jul 6, 2015 at 8:41 PM, Brad King wrote: > > On 07/04/2015 06:

Re: [cmake-developers] PATCH: add subcommand string(APPEND)

2015-07-06 Thread Daniel Pfeifer
On Mon, Jul 6, 2015 at 8:41 PM, Brad King wrote: > On 07/04/2015 06:27 PM, Daniel Pfeifer wrote: >> Attached is a patch that adds a subcommand string(APPEND). >> This allows to write >> >>> string(APPEND string_variable "some string") >> >> instead of >> >>> set(string_variable "${string_variable}

Re: [cmake-developers] PATCH: add subcommand string(APPEND)

2015-07-06 Thread Brad King
On 07/04/2015 06:27 PM, Daniel Pfeifer wrote: > Attached is a patch that adds a subcommand string(APPEND). > This allows to write > >> string(APPEND string_variable "some string") > > instead of > >> set(string_variable "${string_variable}some string") Thanks. Please extend the first patch to