On 27/03/14 16:34, Brad King wrote:
Yes, but let's do only one change to ExternalProject per day so
we can see how the tests do.
Thanks for merging the other patch.
I just rebased and merged this one to next now.
Daniele
--
Powered by www.kitware.com
Please keep messages on-topic and
Hello again,
Sorry for bringing up another old thread, you can find the original
thread here:
http://thread.gmane.org/gmane.comp.programming.tools.cmake.devel/8837
I pushed the topic again with no changes (just a rebase), I've been
using it for a while with no issues at all.
Is it ok to merge
On 03/27/2014 11:34 AM, Brad King wrote:
A simpler way to look for the argument:
if(;${ARGN}; MATCHES ;EXCLUDE_FROM_ALL;([^;]*);)
# ... test CMAKE_MATCH_1
endif()
Actually you don't need to parse the arg ahead of time.
The ALL option to add_custom_target just tells it to
*not* set the
On 27/03/14 16:53, Brad King wrote:
Actually you don't need to parse the arg ahead of time.
The ALL option to add_custom_target just tells it to
*not* set the EXCLUDE_FROM_ALL target property. Instead
you can leave out ALL, parse the args as normal, and
then add
set_property(TARGET ...
On 03/27/2014 12:24 PM, Daniele E. Domenichelli wrote:
+ if(;${ARGN}; MATCHES ;EXCLUDE_FROM_ALL;([^;]*);)
+set(exclude_from_all ${CMAKE_MATCH_1})
+ endif()
+ if(NOT exclude_from_all)
+set(all ALL)
+ endif()
We need to be robust against variables set in outer scopes:
set(all
On 27/03/14 18:50, Brad King wrote:
On 03/27/2014 12:24 PM, Daniele E. Domenichelli wrote:
+ if(;${ARGN}; MATCHES ;EXCLUDE_FROM_ALL;([^;]*);)
+set(exclude_from_all ${CMAKE_MATCH_1})
+ endif()
+ if(NOT exclude_from_all)
+set(all ALL)
+ endif()
Sorry, I made 2 force-pushes (after
On 03/27/2014 02:23 PM, Daniele E. Domenichelli wrote:
The updated code after your second e-mail should be this:
+ get_property(exclude_from_all TARGET ${name} PROPERTY _EP_EXCLUDE_FROM_ALL)
+ if(exclude_from_all)
+set_property(TARGET ${name} PROPERTY EXCLUDE_FROM_ALL TRUE)
+ endif()
On 04/12/13 10:15, Daniele E. Domenichelli wrote:
Please review the topic ExternalProject_exclude-from-all.
I added a second part to the patch to ad an EXCLUDE_FROM_ALL argument to
ExternalProject_Add
If this is set, the all target will not depend on the external project
This might be useful
On 04/12/13 14:28, Brad King wrote:
I think the option should be called EXCLUDE_FROM_MAIN or something
without ALL in it. Otherwise it looks related to the EXCLUDE_FROM_ALL
settings used for the make all CMake builtin target.
Ok, changed to EXCLUDE_FROM_MAIN.
Cheers,
Daniele
--
Powered
On 12/04/2013 04:15 AM, Daniele E. Domenichelli wrote:
Please review the topic ExternalProject_exclude-from-all.
When adding a new step using ExternalProject_Add_Step, the main target
will depend on this step.
This option allows one to add a step that will not be executed when the
main
10 matches
Mail list logo
