Re: [cmake-developers] Suggestion: CMAKE_TOOLCHAIN_FILE warning improvement

2013-04-10 Thread Stephen Kelly
Laszlo Papp wrote: Hi, Just found this post from Brad: http://www.cmake.org/pipermail/cmake/2011-February/042556.html I would suggest to improve the warning message. It is not exactly clear why that happens to a user like me. My colleague saw this warning in his cmake output when he was

Re: [cmake-developers] Suggestion: CMAKE_TOOLCHAIN_FILE warning improvement

2013-04-10 Thread Brad King
On 04/10/2013 07:20 AM, Stephen Kelly wrote: Is there any reason this variable shouldn't be special-cased in the unused variable handling? If the special case is spelled correctly, it should be fine. If you want to add a whitelist to suppress the warning that's fine with me. -Brad --

Re: [cmake-developers] Suggestion: CMAKE_TOOLCHAIN_FILE warning improvement

2013-04-10 Thread Rolf Eike Beer
Am 10.04.2013 16:17, schrieb Brad King: On 04/10/2013 07:20 AM, Stephen Kelly wrote: Is there any reason this variable shouldn't be special-cased in the unused variable handling? If the special case is spelled correctly, it should be fine. If you want to add a whitelist to suppress the

Re: [cmake-developers] Suggestion: CMAKE_TOOLCHAIN_FILE warning improvement

2013-04-10 Thread Brad King
On 04/10/2013 10:30 AM, Rolf Eike Beer wrote: I think what Stephen had in mind (I really hope he had *g*) is to show a different warning in that case, telling the user that the toolchain file is ignored on any subsequent run. Another approach is to not warn when the -DFOO=bar option just

Re: [cmake-developers] Suggestion: CMAKE_TOOLCHAIN_FILE warning improvement

2013-04-10 Thread Rolf Eike Beer
Brad King wrote: On 04/10/2013 10:30 AM, Rolf Eike Beer wrote: I think what Stephen had in mind (I really hope he had *g*) is to show a different warning in that case, telling the user that the toolchain file is ignored on any subsequent run. Another approach is to not warn when the

[cmake-developers] Suggestion: CMAKE_TOOLCHAIN_FILE warning improvement

2013-04-09 Thread Laszlo Papp
Hi, Just found this post from Brad: http://www.cmake.org/pipermail/cmake/2011-February/042556.html I would suggest to improve the warning message. It is not exactly clear why that happens to a user like me. Laszlo -- Powered by www.kitware.com Visit other Kitware open-source projects at