Re: [cmake-developers] Targets for FindGTK2.cmake

2013-10-03 Thread Brad King
On 10/03/2013 11:57 AM, Daniele E. Domenichelli wrote: > According to the latest builds > > http://open.cdash.org/testDetails.php?test=211425751&build=3046984 > http://open.cdash.org/testDetails.php?test=211450654&build=3047132 > > these even thought the target GTK2::gtk exists, but the GTK2Targe

Re: [cmake-developers] Targets for FindGTK2.cmake

2013-10-03 Thread Daniele E. Domenichelli
Hello Brad, On 25/09/13 17:01, Brad King wrote: >> I noticed that on some builds, all the tests for GTK2Targets suddenly >> disappeared: >> >> londinium.kitware: http://open.cdash.org/viewTest.php?buildid=3039037 >> TheGibson.kitware: http://open.cdash.org/viewTest.php?buildid=3039001 >> >> Is i

Re: [cmake-developers] Targets for FindGTK2.cmake

2013-10-02 Thread Brad King
On 10/02/2013 06:13 AM, Daniele E. Domenichelli wrote: > I tried to add some debug output, because I cannot understand what's > going on in the build machines, because the tests are still missing. > Unfortunately I get messages like "The rest of the test output was > removed since it exceeds the th

Re: [cmake-developers] Targets for FindGTK2.cmake

2013-10-02 Thread Rolf Eike Beer
Am 02.10.2013 12:13, schrieb Daniele E. Domenichelli: Hello Brad, On 25/09/13 18:20, Daniele E. Domenichelli wrote: On 25/09/13 17:01, Brad King wrote: On 09/25/2013 09:21 AM, Daniele E. Domenichelli wrote: I noticed that on some builds, all the tests for GTK2Targets suddenly disappeared: I

Re: [cmake-developers] Targets for FindGTK2.cmake

2013-10-02 Thread Daniele E. Domenichelli
Hello Brad, On 25/09/13 18:20, Daniele E. Domenichelli wrote: > On 25/09/13 17:01, Brad King wrote: >> On 09/25/2013 09:21 AM, Daniele E. Domenichelli wrote: >>> I noticed that on some builds, all the tests for GTK2Targets suddenly >>> disappeared: >>> >>> Is it my fault or if they were explicitly

Re: [cmake-developers] Targets for FindGTK2.cmake

2013-09-25 Thread Daniele E. Domenichelli
On 25/09/13 17:01, Brad King wrote: > On 09/25/2013 09:21 AM, Daniele E. Domenichelli wrote: >> I noticed that on some builds, all the tests for GTK2Targets suddenly >> disappeared: >> >> londinium.kitware: http://open.cdash.org/viewTest.php?buildid=3039037 >> TheGibson.kitware: http://open.cdash.o

Re: [cmake-developers] Targets for FindGTK2.cmake

2013-09-25 Thread Brad King
On 09/25/2013 09:21 AM, Daniele E. Domenichelli wrote: > I think I finally fixed it! :) Great, thanks for your persistence on following up with that. > Yesterday all the tests were green, but today there is one failing, > because "The C compiler "/usr/bin/gcc" is not able to compile a simple > te

Re: [cmake-developers] Targets for FindGTK2.cmake

2013-09-25 Thread Daniele E. Domenichelli
Hello Brad, On 20/09/13 15:56, Brad King wrote: > I see failures such as: > > http://open.cdash.org/testDetails.php?test=209170401&build=3034240 > /usr/include/ft2build.h:56:38: fatal error: freetype/config/ftheader.h: No > such file or directory I think I finally fixed it! :) Yesterday all

Re: [cmake-developers] Targets for FindGTK2.cmake

2013-09-20 Thread Brad King
On 09/19/2013 04:46 AM, Daniele E. Domenichelli wrote: > Looks like that all the tests are fixed on all the builds now :) I see failures such as: http://open.cdash.org/testDetails.php?test=209170401&build=3034240 /usr/include/ft2build.h:56:38: fatal error: freetype/config/ftheader.h: No such f

Re: [cmake-developers] Targets for FindGTK2.cmake

2013-09-19 Thread Daniele E. Domenichelli
Hello Brad, Sorry for the delay. On 12/09/13 10:57, Daniele E. Domenichelli wrote: > On 11/09/13 19:21, Brad King wrote: >> Do these tests share a build tree? GTK2Targets.gtk and GTK2Components.gtk >> failed randomly last night: >> >> http://open.cdash.org/viewTest.php?onlyfailed&buildid=30254

Re: [cmake-developers] Targets for FindGTK2.cmake

2013-09-12 Thread Daniele E. Domenichelli
On 11/09/13 19:21, Brad King wrote: > Do these tests share a build tree? GTK2Targets.gtk and GTK2Components.gtk > failed randomly last night: > > http://open.cdash.org/viewTest.php?onlyfailed&buildid=3025432 > > Both start with the output: > > Internal cmake changing into directory: /home/kit

Re: [cmake-developers] Targets for FindGTK2.cmake

2013-09-11 Thread Brad King
On 08/06/2013 05:39 AM, Daniele E. Domenichelli wrote: > I added a commit introducing a couple of unit tests that should run only > if GTK and/or GTKMM are available on the system. Do these tests share a build tree? GTK2Targets.gtk and GTK2Components.gtk failed randomly last night: http://open.

Re: [cmake-developers] Targets for FindGTK2.cmake

2013-09-05 Thread Stephen Kelly
Daniele E. Domenichelli wrote: > Hello Stephen, > > Sorry for the delay, but I was on holiday... > > > On 14/08/13 15:07, Stephen Kelly wrote: >> Daniele E. Domenichelli wrote: >>> I did a few more tests, and it looks like that, at least on my system >>> and on windows, FREETYPE_LIBRARIES are n

Re: [cmake-developers] Targets for FindGTK2.cmake

2013-09-05 Thread Daniele E. Domenichelli
Hello Stephen, Sorry for the delay, but I was on holiday... On 14/08/13 15:07, Stephen Kelly wrote: > Daniele E. Domenichelli wrote: >> I did a few more tests, and it looks like that, at least on my system >> and on windows, FREETYPE_LIBRARIES are not required, they are linked to >> some other l

Re: [cmake-developers] Targets for FindGTK2.cmake

2013-08-14 Thread Stephen Kelly
Daniele E. Domenichelli wrote: > On 12/08/13 15:36, Stephen Kelly wrote: >>> The difference is that if GTK2_USE_IMPORTED_TARGETS the >>> GTK_${_var}_LIBRARY will link the target (and it's dependencies) >>> otherwise it will link only the library (without dependencies) using the >>> DEBUG or RELEAS

Re: [cmake-developers] Targets for FindGTK2.cmake

2013-08-14 Thread Daniele E. Domenichelli
On 12/08/13 15:36, Stephen Kelly wrote: >> The difference is that if GTK2_USE_IMPORTED_TARGETS the >> GTK_${_var}_LIBRARY will link the target (and it's dependencies) >> otherwise it will link only the library (without dependencies) using the >> DEBUG or RELEASE version, depending on what was found

Re: [cmake-developers] Targets for FindGTK2.cmake

2013-08-12 Thread Stephen Kelly
Daniele E. Domenichelli wrote: > Hello Stephen, > > Thanks for the review > > On 09/08/13 10:50, Stephen Kelly wrote: >> * What is GTK2_GDKCONFIG_INCLUDE_DIR compared to GTK2_GDK_INCLUDE_DIR? >> Can you conditionally append GTK2_GDKCONFIG_INCLUDE_DIR if it is not >> STREQUAL GTK2_GDK_INCLUDE_DIR

Re: [cmake-developers] Targets for FindGTK2.cmake

2013-08-12 Thread Daniele E. Domenichelli
Hello Stephen, Thanks for the review On 09/08/13 10:50, Stephen Kelly wrote: > * What is GTK2_GDKCONFIG_INCLUDE_DIR compared to GTK2_GDK_INCLUDE_DIR? Can > you conditionally append GTK2_GDKCONFIG_INCLUDE_DIR if it is not STREQUAL > GTK2_GDK_INCLUDE_DIR? GTK2 has "config" files that usually are

Re: [cmake-developers] Targets for FindGTK2.cmake

2013-08-09 Thread Stephen Kelly
Brad King wrote: > On 08/06/2013 05:39 AM, Daniele E. Domenichelli wrote: >> I added a commit introducing a couple of unit tests that should run only >> if GTK and/or GTKMM are available on the system. > > Thanks. Steve, please take a quick look at this topic to > review how the imported targets

Re: [cmake-developers] Targets for FindGTK2.cmake

2013-08-08 Thread Brad King
On 08/06/2013 05:39 AM, Daniele E. Domenichelli wrote: > I added a commit introducing a couple of unit tests that should run only > if GTK and/or GTKMM are available on the system. Thanks. Steve, please take a quick look at this topic to review how the imported targets are constructed. Thanks, -

Re: [cmake-developers] Targets for FindGTK2.cmake

2013-08-06 Thread Daniele E. Domenichelli
Hello Philip, Thanks for your comments. On 06/08/13 05:43, Philip Lowman wrote: > I'm not sure if there is a way to develop automated unit tests and mark > them to not run by default. That would be useful for regression testing > of modules even if it the tests had to be run manually. I added a

Re: [cmake-developers] Targets for FindGTK2.cmake

2013-08-05 Thread Philip Lowman
Daniele, Your changes look fine to me although my experience with imported targets is limited so someone with more experience should review your changes there. I'm not sure if there is a way to develop automated unit tests and mark them to not run by default. That would be useful for regression

[cmake-developers] Targets for FindGTK2.cmake

2013-08-05 Thread Daniele E. Domenichelli
Hello all, I'd like to introduce imported targets in FindGTK2.cmake, in a similar manner as they are used in FindQT4.cmake. The aim is to be able to do something like: find_package(GTK2 gtk gtkmm) target_link_libraries( GTK2::gtkmm) (In the future I want to handle dependencies on modules