Re: [cmake-developers] VS10-12 generators deserve much more love

2014-02-17 Thread Stephen Kelly
Dan Cristiu wrote: Wanted to add a simple change to the VS11 generator to support non-default toolsets, but after taking another look through the code for the VS10 generator and above, I decided I wasn't happy with the result. It shows those files have been the result of years of patches,

Re: [cmake-developers] VS10-12 generators deserve much more love

2014-02-17 Thread Dan Cristiu
I am not here to build merit. When myself and others start using find replace in the files generated by CMake, that should raise some concerns. For people who have sent me private e-mails, I don't understand why you don't express your frustrations on the mailing list. Apparently people here

Re: [cmake-developers] VS10-12 generators deserve much more love

2014-02-17 Thread Amine Khaldi
Please note that I already expressed how ReactOS sees the current VS support in CMake: http://public.kitware.com/pipermail/cmake-developers/2013-July/007666.html I welcome and support any effort that allows CMake to generate VS solutions that work as VS users expect them to be. Cheers, Amine. --

Re: [cmake-developers] VS10-12 generators deserve much more love

2014-02-17 Thread Stephen Kelly
Dan Cristiu wrote: What I wrote in the previous e-mails weren't attempts to influence the community or your design plans. Reason why I wrote such a big e-mail was to make my intentions to contribute known and get some feedback and guidance. Did you get feedback or guidance? I'm curious to

Re: [cmake-developers] VS10-12 generators deserve much more love

2014-02-17 Thread Brad King
On 02/16/2014 08:25 PM, Dan Cristiu wrote: I've decided to review the code in there and clean it to the point where the duplication is minimal. I would welcome such an effort. Can you cite some examples of duplication that you have in mind to reduce? In any case, was there a reason why the

Re: [cmake-developers] VS10-12 generators deserve much more love

2014-02-17 Thread Dan Cristiu
Good pointers thanks a lot. I can now also see the efforts for supporting WinRT which I applaud. I would like to digress a bit if that's permitted. The whole discussion has put me down a bit. The current approach seems pretty stiff and leaves little room for manoeuvre. When it comes to platforms

Re: [cmake-developers] VS10-12 generators deserve much more love

2014-02-17 Thread Brad King
On 02/17/2014 11:11 AM, Dan Cristiu wrote: Are there any plans to move onto a more extensible approach in the future? No, but there aren't plans to not do it either ;) This is open source. People write the features they need and leave the rest for future work by others that have different

[cmake-developers] VS10-12 generators deserve much more love

2014-02-16 Thread Dan Cristiu
Wanted to add a simple change to the VS11 generator to support non-default toolsets, but after taking another look through the code for the VS10 generator and above, I decided I wasn't happy with the result. It shows those files have been the result of years of patches, with much of the code just