Re: [cmake-developers] cmake -E capabilities [attempt 2]

On 08/03/2016 09:52 AM, Brad King wrote: > I've revised Tobias's commits to rename NewFactory to GetFactory and > explain some rationale in the commit message: > > Refactor extra generator registration to use factories > https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=a354f60c > > Report

Re: [cmake-developers] cmake -E capabilities [attempt 2]

On 08/02/2016 04:48 PM, Stephen Kelly wrote: > The NewFactory methods in your patch don't return a new'd object, but > instead return static locals. The regular generators NewFactory methods > don't work that way, so you're introducing a pattern which is different to > what already exists and

Re: [cmake-developers] cmake -E capabilities [attempt 2]

Tobias Hunger wrote: > Hi Stephen, > > thanks for taking the time to do such a thorough review! Actually my review wasn't thorough at all. I didn't try to review it further. The NewFactory methods in your patch don't return a new'd object, but instead return static locals. The regular

Re: [cmake-developers] cmake -E capabilities [attempt 2]

On 07/29/2016 06:01 AM, Tobias Hunger wrote: > I pushed an update that takes most of the feedback into account. Thanks. I've applied the extra generator refactoring parts first: Refactor extra generator registration to use factories https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=bc44627b

Re: [cmake-developers] cmake -E capabilities [attempt 2]

Hi Stephen, thanks for taking the time to do such a thorough review! I pushed an update that takes most of the feedback into account. Still at: https://github.com/hunger/CMake/commits/cmake-capabilities On Wed, Jul 27, 2016 at 1:11 AM, Stephen Kelly wrote: > Tobias Hunger

Re: [cmake-developers] cmake -E capabilities [attempt 2]

Tobias Hunger wrote: > Did anyone find some time for a review yet? Hi Tobias, I had a look through this this evening. Thanks for working on this. The commit adding the functionality at the end looks much better after the extra generator refactoring. Here are some review notes: * That

Re: [cmake-developers] cmake -E capabilities [attempt 2]

Did anyone find some time for a review yet? Best regards, Tobias Am 22.07.2016 01:37 schrieb "Tobias Hunger" : > Hello fellow developers, > > https://github.com/hunger/CMake/commits/cmake-capabilities > > has my attempt to get "cmake -E capabilities" merged -- in

[cmake-developers] cmake -E capabilities [attempt 2]

Hello fellow developers, https://github.com/hunger/CMake/commits/cmake-capabilities has my attempt to get "cmake -E capabilities" merged -- in preparation of the server mode. Brad already merged a big chunk of the changes, but he wanted to see the extra generator registration cleaned up before