Re: [cmake-developers] install bug on windows

2010-09-22 Thread Eric Noulard
2010/9/22 David Cole : > Please merge the fix to next now and add the test later when you get the > chance. > We definitely need this fix before the final release even if it's still > untested. Done. The corresponding stage branch has just been merged to next: commit 3c3d578d7a05df228f7e22e710e95

Re: [cmake-developers] install bug on windows

2010-09-22 Thread David Cole
Please merge the fix to next now and add the test later when you get the chance. We definitely need this fix before the final release even if it's still untested. Thanks, David On Wed, Sep 22, 2010 at 4:09 PM, Eric Noulard wrote: > 2010/9/20 Eric Noulard : > > > > I pushed a working fix to st

Re: [cmake-developers] install bug on windows

2010-09-22 Thread Eric Noulard
2010/9/20 Eric Noulard : > > I pushed a working fix to stage "fixAbsoluteDestHandlingRegression" > including the CMake coding standard wrt to if {}. > > I did NOT request the merge to next. > I'll wait until I'll try to craft the corresponding new test. > > Should be tomorrow or wednesday. Sorry,

Re: [cmake-developers] install bug on windows

2010-09-20 Thread Eric Noulard
2010/9/20 Eric Noulard : > 2010/9/20 Bill Hoffman : >>> >>>  What do you think? >> >> Seems to be covered: >> (but I am guessing the install is not actually being called in that case...) > > Ok then may be I can try to make install called, after > I found the test which is triggering this coverage.

Re: [cmake-developers] install bug on windows

2010-09-20 Thread Eric Noulard
2010/9/20 Bill Hoffman : >> >>  What do you think? > > Seems to be covered: > (but I am guessing the install is not actually being called in that case...) Ok then may be I can try to make install called, after I found the test which is triggering this coverage. > http://www.cdash.org/CDash/viewCo

Re: [cmake-developers] install bug on windows

2010-09-20 Thread Eric Noulard
2010/9/20 Bill Hoffman : > On 9/20/2010 1:39 PM, Eric Noulard wrote: >> >> 2010/9/20 Eric Noulard: >>> >>> 2010/9/20 Bill Hoffman: Eric, This commit is breaking windows installs: commit 6a521f8604ee4e6a757109e731a36fdc5575f6c8 Author: Eric NOULARD Date:   Mon

Re: [cmake-developers] install bug on windows

2010-09-20 Thread Bill Hoffman
On 9/20/2010 1:39 PM, Eric Noulard wrote: 2010/9/20 Eric Noulard: 2010/9/20 Bill Hoffman: Eric, This commit is breaking windows installs: commit 6a521f8604ee4e6a757109e731a36fdc5575f6c8 Author: Eric NOULARD Date: Mon Aug 23 17:38:33 2010 +0200 CPack Enable better handling of absolut

Re: [cmake-developers] install bug on windows

2010-09-20 Thread Bill Hoffman
On 9/20/2010 1:39 PM, Eric Noulard wrote: 2010/9/20 Eric Noulard: 2010/9/20 Bill Hoffman: Eric, This commit is breaking windows installs: commit 6a521f8604ee4e6a757109e731a36fdc5575f6c8 Author: Eric NOULARD Date: Mon Aug 23 17:38:33 2010 +0200 CPack Enable better handling of absolut

Re: [cmake-developers] install bug on windows

2010-09-20 Thread Eric Noulard
2010/9/20 Eric Noulard : > 2010/9/20 Bill Hoffman : >> >> Eric, >> >> This commit is breaking windows installs: >> >> commit 6a521f8604ee4e6a757109e731a36fdc5575f6c8 >> Author: Eric NOULARD >> Date:   Mon Aug 23 17:38:33 2010 +0200 >> >>    CPack   Enable better handling of absolute installed file

Re: [cmake-developers] install bug on windows

2010-09-20 Thread Eric Noulard
2010/9/20 Bill Hoffman : > > Eric, > > This commit is breaking windows installs: > > commit 6a521f8604ee4e6a757109e731a36fdc5575f6c8 > Author: Eric NOULARD > Date:   Mon Aug 23 17:38:33 2010 +0200 > >    CPack   Enable better handling of absolute installed files > >    The idea of the patch is to

[cmake-developers] install bug on windows

2010-09-20 Thread Bill Hoffman
Eric, This commit is breaking windows installs: commit 6a521f8604ee4e6a757109e731a36fdc5575f6c8 Author: Eric NOULARD Date: Mon Aug 23 17:38:33 2010 +0200 CPack Enable better handling of absolute installed files The idea of the patch is to let the install generator define CPAC