Re: [cmake-developers] [patch] treat .m files as c, not c++

2014-03-20 Thread tim
>> I'll look at integrating the change. > > I've applied the patch here: > > Treat .m files consistently as C across all generators > http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=95cdf132 > > with more detail in the commit message. thanks a lot! tim -- Powered by www.kitware.com Pl

Re: [cmake-developers] [patch] treat .m files as c, not c++

2014-03-20 Thread Brad King
On 03/20/2014 11:38 AM, Steve Wilson wrote: > Took me a bit longer than I expected, but you can find the > 'objective-c-support' topic at: > > https://github.com/swwilso1/CMake.git Great, thanks. I encourage others to look at the topic and the discussion thread I linked earlier in this thread.

Re: [cmake-developers] [patch] treat .m files as c, not c++

2014-03-20 Thread Steve Wilson
Took me a bit longer than I expected, but you can find the 'objective-c-support' topic at: https://github.com/swwilso1/CMake.git On Mar 19, 2014, at 11:55 AM, Steve Wilson wrote: > On Mar 19, 2014, at 11:09 AM, Brad King wrote: > >> On 03/19/2014 12:50 PM, Tim Blechmann wrote: >>> obj-c is

Re: [cmake-developers] [patch] treat .m files as c, not c++

2014-03-20 Thread Brad King
On 03/19/2014 03:58 PM, Brad King wrote: > I'll look at integrating the change. I've applied the patch here: Treat .m files consistently as C across all generators http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=95cdf132 with more detail in the commit message. Thanks, -Brad -- Powered b

Re: [cmake-developers] [patch] treat .m files as c, not c++

2014-03-19 Thread Brad King
On 03/19/2014 01:29 PM, Tim Blechmann wrote: > emulating old bugs is a nice thing, but then maybe the inconsistency between > xcode and make/ninja generators should be be documented or the xcode > generator should emulate wrong behavior to be consistent with make/ninja? On second thought, since

Re: [cmake-developers] [patch] treat .m files as c, not c++

2014-03-19 Thread Steve Wilson
On Mar 19, 2014, at 11:09 AM, Brad King wrote: > On 03/19/2014 12:50 PM, Tim Blechmann wrote: >> obj-c is a superset of c, while obj-c++ is a superset of obj-c >> >> this patch corrects this behavior. > > The incorrect behavior is left from the earliest days of CMake. > Fixing this outright wil

Re: [cmake-developers] [patch] treat .m files as c, not c++

2014-03-19 Thread Brad King
On 03/19/2014 12:50 PM, Tim Blechmann wrote: > obj-c is a superset of c, while obj-c++ is a superset of obj-c > > this patch corrects this behavior. The incorrect behavior is left from the earliest days of CMake. Fixing this outright will change existing build behavior. We would have to do this