Re: [cmake-developers] Developer tasks - Refactoring

2016-09-07 Thread Stephen Kelly
Daniel Pfeifer wrote: > On Wed, Feb 10, 2016 at 12:12 AM, Stephen Kelly > wrote: >> 3) Compute cmGeneratorTarget state non-lazily in its constructor. >> * Historically target state for generators was computed lazily because it >> might need to be cleared and re-computed. That is no-longer true

Re: [cmake-developers] Developer tasks - Refactoring

2016-09-07 Thread Daniel Pfeifer
On Wed, Feb 10, 2016 at 12:12 AM, Stephen Kelly wrote: > 3) Compute cmGeneratorTarget state non-lazily in its constructor. > * Historically target state for generators was computed lazily because it > might need to be cleared and re-computed. That is no-longer true. SourceFilesMap is cleared i

Re: [cmake-developers] Developer tasks - Refactoring

2016-06-06 Thread Stephen Kelly
On 06/06/2016 11:14 PM, Daniel Pfeifer wrote: > Here is what I found. > > * SetLinkScriptShell is called from two places: > cmMakefileExecutableTargetGenerator::WriteExecutableRule and > cmMakefileLibraryTargetGenerator::WriteLibraryRules. > * We can instantiate a cmOutputConverter in those places

Re: [cmake-developers] Developer tasks - Refactoring

2016-06-06 Thread Daniel Pfeifer
On Sun, Jun 5, 2016 at 2:15 PM, Stephen Kelly wrote: > On 05/19/2016 11:27 PM, Daniel Pfeifer wrote: >> On Wed, Feb 10, 2016 at 12:12 AM, Stephen Kelly wrote: >>> 1) Make cmLocalGenerator not inherit cmOutputConverter >>> * Change enums like cmLocalGenerator::START_OUTPUT with sed. See >>> >>>

Re: [cmake-developers] Developer tasks - Refactoring

2016-06-05 Thread Stephen Kelly
On 05/19/2016 11:27 PM, Daniel Pfeifer wrote: > On Wed, Feb 10, 2016 at 12:12 AM, Stephen Kelly wrote: >> 1) Make cmLocalGenerator not inherit cmOutputConverter >> * Change enums like cmLocalGenerator::START_OUTPUT with sed. See >> >>https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=eac1529

Re: [cmake-developers] Developer tasks - Refactoring

2016-06-05 Thread Stephen Kelly
On 05/20/2016 12:06 AM, Daniel Pfeifer wrote: > On Thu, May 19, 2016 at 11:18 PM Daniel Pfeifer > mailto:dan...@pfeifer-mail.de>> wrote: > > On Wed, Feb 10, 2016 at 12:15 AM Stephen Kelly > wrote: > > 1) Make cmLocalGenerator not inherit cmOutputConverter

Re: [cmake-developers] Developer tasks - Refactoring

2016-05-23 Thread Brad King
On 05/19/2016 06:06 PM, Daniel Pfeifer wrote: >>> 1) Make cmLocalGenerator not inherit cmOutputConverter >>> * Change enums like cmLocalGenerator::START_OUTPUT with sed. See > Revised patch attached. Please ignore the previous one. > This one also fully qualifies the enums that were used unqualif

Re: [cmake-developers] Developer tasks - Refactoring

2016-05-19 Thread Daniel Pfeifer
On Thu, May 19, 2016 at 11:18 PM Daniel Pfeifer wrote: > On Wed, Feb 10, 2016 at 12:15 AM Stephen Kelly wrote: > >> 1) Make cmLocalGenerator not inherit cmOutputConverter >> * Change enums like cmLocalGenerator::START_OUTPUT with sed. See > > > Please see attached patch. > Revised patch attach

Re: [cmake-developers] Developer tasks - Refactoring

2016-05-19 Thread Daniel Pfeifer
On Wed, Feb 10, 2016 at 12:12 AM, Stephen Kelly wrote: > 1) Make cmLocalGenerator not inherit cmOutputConverter > * Change enums like cmLocalGenerator::START_OUTPUT with sed. See > >https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=eac15298 > > for a similar sed command to achieve this. >

Re: [cmake-developers] Developer tasks - Refactoring

2016-05-19 Thread Daniel Pfeifer
On Wed, Feb 10, 2016 at 12:15 AM Stephen Kelly wrote: > 1) Make cmLocalGenerator not inherit cmOutputConverter > * Change enums like cmLocalGenerator::START_OUTPUT with sed. See Please see attached patch. From 9e1203308ad79d62b24fe6930501e1013b4e52ec Mon Sep 17 00:00:00 2001 From: Daniel Pfeif