Re: [cmake-developers] Link element in C# project causing issues with binary dir

2018-06-29 Thread Robert Dailey
Submitted a fix here: https://gitlab.kitware.com/cmake/cmake/merge_requests/2177 David: I think the source dir is stripped because that path is effectively the same as source_group() command. It's a path relative to the root of the solution explorer panel. That's a big assumption, I honestly don't

Re: [cmake-developers] Link element in C# project causing issues with binary dir

2018-06-29 Thread David Cole via cmake-developers
The code looks wrong like this, too: You shouldn't strip the source directory from the path of the file name unless the character after the source directory is "/" or "\\", should you? If the thing you're trying to end up with is a path name to the file under the source directory, then this is inc

Re: [cmake-developers] Link element in C# project causing issues with binary dir

2018-06-29 Thread Robert Dailey
According to the code, the logic is wrong: void cmVisualStudio10TargetGenerator::GetCSharpSourceLink( cmSourceFile const* sf, std::string& link) { std::string f = sf->GetFullPath(); if (!this->InSourceBuild) { const std::string stripFromPath = this->Makefile->GetCurrentSourceDirect