[PATCH] 6 patches for buildiso

2011-08-22 Thread Jörgen Maas
I've posted these patches earlier. Had to rework 2 of them after a good suggestion from James. I hope they can get merged into the tree now... Thanks! Grtz, Jörgen Maas From b9f137ada565a483d29b42af82567d2b68855774 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?J=C3=B6rgen=20Maas?= Date: Fri, 19 Aug 2

Re: [PATCH] 6 patches for buildiso

2011-08-22 Thread James Cammarata
On Mon, Aug 22, 2011 at 2:47 AM, Jörgen Maas wrote: > I've posted these patches earlier. Had to rework 2 of them after a > good suggestion from James. > I hope they can get merged into the tree now... > > Thanks! > > Grtz, > Jörgen Maas These look good, but I've only done a visual inspection. Nex

Re: [PATCH] 6 patches for buildiso

2011-08-22 Thread James Cammarata
On Mon, Aug 22, 2011 at 7:01 AM, James Cammarata wrote: > On Mon, Aug 22, 2011 at 2:47 AM, Jörgen Maas wrote: >> I've posted these patches earlier. Had to rework 2 of them after a >> good suggestion from James. >> I hope they can get merged into the tree now... >> >> Thanks! >> >> Grtz, >> Jörgen

Re: [PATCH] 6 patches for buildiso

2011-08-22 Thread James Cammarata
> And they all did apply, I did some basic sync tests to make sure > nothing blew up on cobblerd restart, so I pushed this branch up to my > github: > > https://github.com/jimi1283/cobbler/tree/jorgen > > I haven't done any extensive buildiso testing on this yet, though. > Just fired of a quick te

Re: [PATCH] 6 patches for buildiso

2011-08-22 Thread Jörgen Maas
On Mon, Aug 22, 2011 at 2:01 PM, James Cammarata wrote: > These look good, but I've only done a visual inspection. Next we need > to get you setup on github if you're going to be doing a lot of > patching in the future :) thanks for the review James. https://github.com/jmaas/Cobbler/ Grtz, Jörg

Re: [PATCH] 6 patches for buildiso

2011-08-22 Thread Jörgen Maas
On Mon, Aug 22, 2011 at 2:20 PM, James Cammarata wrote: > And they all did apply, I did some basic sync tests to make sure > nothing blew up on cobblerd restart, so I pushed this branch up to my > github: > > https://github.com/jimi1283/cobbler/tree/jorgen > > I haven't done any extensive buildiso

Re: [PATCH] 6 patches for buildiso

2011-08-22 Thread Jörgen Maas
On Mon, Aug 22, 2011 at 2:25 PM, James Cammarata wrote: > Just fired of a quick test from the webui, and it built an iso > successfully with the selected systems. Two more things I'd like to > see from a usability standpoint: > > 1) Limit profiles to only those of the systems that were selected,