Re: [Cocci] [PATCH] Coccinelle: make DEBUG_FILE option more useful

2017-11-06 Thread Masahiro Yamada
2017-10-26 13:02 GMT+09:00 Julia Lawall : > > > On Thu, 26 Oct 2017, Masahiro Yamada wrote: > >> Hi Julia, >> >> >> 2017-10-15 18:55 GMT+09:00 Julia Lawall : >> > Make coccicheck checked for the existence of DEBUG_FILE on each semantic >> > patch, and bailed if it already existed. This meant that

Re: [Cocci] [PATCH v2 01/31] coccinelle: Improve setup_timer.cocci matching

2017-11-06 Thread Masahiro Yamada
2017-09-24 5:43 GMT+09:00 Julia Lawall : > > > On Wed, 20 Sep 2017, Kees Cook wrote: > >> This improves the patch mode of setup_timer.cocci. Several patterns >> were missing: >> - assignments-before-init_timer() cases >> - limit the .data case removal to the specific struct timer_list instance >>

Re: [Cocci] [PATCH 2/2] scripts: coccinelle: api: detect identical chip data arrays

2017-11-06 Thread Masahiro Yamada
2017-10-09 4:18 GMT+09:00 Julia Lawall : > This semantic patch detects duplicate arrays declared using BQ27XXX_DATA > within a single structure. It is currently specific to the file > drivers/power/supply/bq27xxx_battery.c. Nevertheless, having the script in > the kernel will allow others to chec

Re: [Cocci] [PATCH] Coccinelle: use false positive annotation

2017-11-06 Thread Masahiro Yamada
2017-10-30 12:52 GMT+09:00 Julia Lawall : > > > On Mon, 30 Oct 2017, Masahiro Yamada wrote: > >> Hi Julia, >> >> >> 2017-10-29 8:43 GMT+09:00 Julia Lawall : >> > /// is to describe the semantic patch, while //# indicates reasons >> > for false positives. >> > >> > Signed-off-by: Julia Lawall >> >

Re: [Cocci] [PATCH] coccinelle: fix verbose message about .cocci file being run

2017-11-06 Thread Masahiro Yamada
2017-10-26 16:22 GMT+09:00 Nicolas Palix (LIG) : > Le 26/10/17 à 06:55, Masahiro Yamada a écrit : >> >> If you run coccicheck with V=1 and COCCI=, you will see a strange >> path to the semantic patch file. For example, run the following: >> >> $ make V=1 COCCI=scripts/coccinelle/free/kfree.cocci c

Re: [Cocci] [PATCH] Coccinelle: setup_timer: improve messages from setup_timer

2017-11-06 Thread Masahiro Yamada
2017-08-23 22:11 GMT+09:00 Julia Lawall : > Allow messages about multiple timers. > > Signed-off-by: Julia Lawall > > --- Applied to linux-kbuild/misc. -- Best Regards Masahiro Yamada ___ Cocci mailing list Cocci@systeme.lip6.fr https://systeme.lip6

Re: [Cocci] [PATCH] coccinelle: grep Options and Requires fields more precisely

2017-11-06 Thread Masahiro Yamada
2017-10-26 16:26 GMT+09:00 Nicolas Palix (LIG) : > Le 26/10/17 à 06:59, Julia Lawall a écrit : >> >> >> >> On Thu, 26 Oct 2017, Masahiro Yamada wrote: >> >>> Currently, the required version for badzero.cocci is picked up from >>> its "Comments:" line since it contains the word "Requires". >>> >>> S

Re: [Cocci] Setting the section for a function with SmPL

2017-11-06 Thread SF Markus Elfring
>> @section_specification@ >> type T; >> @@ >> T rcar_pcie_enable_msi(...) >> + __attribute__((section ("my_update"))) > > I don't see any evidence that kernel developers would welcome this change > in this form. There is no welcome needed by them because the shown addition would be nice for tes

Re: [Cocci] Setting the section for a function with SmPL

2017-11-06 Thread Julia Lawall
On Thu, 2 Nov 2017, SF Markus Elfring wrote: > >> @section_specification@ > >> type T; > >> @@ > >> T rcar_pcie_enable_msi(...) > >> + __attribute__((section ("my_update"))) This works now. It should have worked before, but the change was done incompletely. julia