Re: [Cocci] [PATCH v4] coccinelle: fix parallel build with CHECK=scripts/coccicheck

2017-11-23 Thread Masahiro Yamada
2017-11-14 21:35 GMT+09:00 Julia Lawall : > > > On Tue, 14 Nov 2017, Masahiro Yamada wrote: > >> The command "make -j8 C=1 CHECK=scripts/coccicheck COCCI=..." produces >> lots of "coccicheck failed" error messages. >> >> Julia Lawall explained the Coccinelle behavior as follows: >> "The problem on

Re: [Cocci] [PATCH] net: usb: hso.c: remove unneeded DRIVER_LICENSE #define

2017-11-23 Thread Joe Perches
On Wed, 2017-11-22 at 18:12 +0100, Greg Kroah-Hartman wrote: > On Wed, Nov 22, 2017 at 09:05:36AM -0800, Joe Perches wrote: > > On Fri, 2017-11-17 at 15:19 +0100, Greg Kroah-Hartman wrote: > > > There is no need to #define the license of the driver, just put it in > > > the MODULE_LICENSE() line di

Re: [Cocci] [PATCH] net: usb: hso.c: remove unneeded DRIVER_LICENSE #define

2017-11-23 Thread Joe Perches
On Thu, 2017-11-23 at 15:30 -0800, Joe Perches wrote: > --- /dev/null 2017-11-23 06:19:12.943046739 -0800 > +++ single_use_module.pl 2017-11-23 15:23:11.729812156 -0800 > @@ -0,0 +1,15 @@ [] > +$data =~ s~$var~$string~; this needs to be: $data =~ s~\b$var\b~$string~;

Re: [Cocci] [v4] Coccinelle: fix parallel build with CHECK=scripts/coccicheck

2017-11-23 Thread SF Markus Elfring
> Setting NPROC=1 is a reasonable solution; It can be sufficient for the usual purposes of the shell script “scripts/coccicheck”. > spatch does not create the subdirectory. I would like to point out that further development efforts will be needed if such a special directory handling should be

Re: [Cocci] Coccinelle: fix parallel build with CHECK=scripts/coccicheck

2017-11-23 Thread SF Markus Elfring
> The goal is that the user can easily find the stdou and stderr information > while the semantic patch is running. It matters when the tool “spatch” tries to apply its own parallelisation strategy. > This is useful for long running semantic patches to see > if things are going well or not. Ye