Re: [Cocci] Checking for a null pointer with SmPL

2019-06-17 Thread Markus Elfring
> As I already told you, the isomorphisms are applied before matching > against the C code. At that time, this information is not available. Can the software situation be clarified also by omitting Coccinelle's isomorphisms? (Can this functionality be temporarily switched off for a specific SmPL

Re: [Cocci] drivers: Inline code in devm_platform_ioremap_resource() from two functions

2019-06-17 Thread Markus Elfring
>> Two function calls were combined in this function implementation. >> Inline corresponding code so that extra error checks can be avoided here. > > What exactly is the purpose of this ? I suggest to take another look at the need and relevance of involved error checks in the discussed function co

Re: [PATCH] drivers: Inline code in devm_platform_ioremap_resource() from two functions

2019-06-17 Thread Enrico Weigelt, metux IT consult
On 14.06.19 11:22, Markus Elfring wrote: > From: Markus Elfring > Date: Fri, 14 Jun 2019 11:05:33 +0200 > > Two function calls were combined in this function implementation. > Inline corresponding code so that extra error checks can be avoided here. What exactly is the purpose of this ? Looks l

Re: [Cocci] Checking for a null pointer with SmPL

2019-06-17 Thread Markus Elfring
>> Example: >> struct setkey_parm *psetkeyparm; > > As I already told you, the isomorphisms are applied before matching > against the C code. At that time, this information is not available. Under which circumstances will the Coccinelle software become able to take available data type inform