Re: [PATCH] coccicheck: Configuring COCCI parameter for supporting a directory search

2019-10-23 Thread Markus Elfring
> What is the relation between the last two if branches? A small addition is proposed for this bash script. > If the first one fails, does that mean that $COCCI has no definition? No. - It was checked if an empty sting was passed. A file system check is tried then to determine if a valid

Re: [PATCH] coccicheck: Configuring COCCI parameter for supporting a directory search

2019-10-23 Thread Markus Elfring
> This patch puts a modification in scripts/coccicheck which supports users > in configuring COCCI parameter as a directory to traverse files in directory. * I suggest to improve this change description according to a recommended “imperative mood”.

Re: [PATCH] Configuring COCCI parameter as a directory is supportted

2019-10-23 Thread Julia Lawall
On Wed, 23 Oct 2019, zhongshiqi wrote: > This patch puts a modification in scripts/coccicheck which supports users > in configuring COCCI parameter as a directory to traverse files in > directory. > > Signed-off-by: zhongshiqi > --- > scripts/coccicheck | 4 > 1 file changed, 4

[PATCH] Configuring COCCI parameter as a directory is supportted

2019-10-23 Thread zhongshiqi
This patch puts a modification in scripts/coccicheck which supports users in configuring COCCI parameter as a directory to traverse files in directory. Signed-off-by: zhongshiqi --- scripts/coccicheck | 4 1 file changed, 4 insertions(+) diff --git a/scripts/coccicheck