[Cocci] linux: bad logic in repetitive tests

2020-03-30 Thread Joe Perches
There is a block of if tests against the same variable in include/linux/mtd/pfow.h that likely is defective if (prog_status & 0x3) ... else if (prog_status & 0x2) ... else (prog_status & 0x1) ... If the first test is true

Re: [Cocci] [v3 05/10] mmap locking API: Improving the Coccinelle software

2020-03-30 Thread Markus Elfring
>> How will the support evolve for data processing around the application >> of similar macros? > > Not at all. Will such feedback trigger any collateral evolution? Regards, Markus ___ Cocci mailing list Cocci@systeme.lip6.fr

Re: [Cocci] [v3 05/10] mmap locking API: Improving the Coccinelle software

2020-03-30 Thread Julia Lawall
On Mon, 30 Mar 2020, Markus Elfring wrote: > >> … > >> (ONCE) CPP-MACRO: found known macro = FNAME > >> … > >> parse error > … > >> How would you like to improve the affected software areas? > > > > This can be addressed by adding a macro definition to standard.h. > > A corresponding

Re: [Cocci] [v3 05/10] mmap locking API: Improving the Coccinelle software

2020-03-30 Thread Markus Elfring
>> … >> (ONCE) CPP-MACRO: found known macro = FNAME >> … >> parse error … >> How would you like to improve the affected software areas? > > This can be addressed by adding a macro definition to standard.h. A corresponding specification is used already.

Re: [Cocci] [v3 05/10] mmap locking API: Improving the Coccinelle software

2020-03-30 Thread Julia Lawall
On Mon, 30 Mar 2020, Markus Elfring wrote: > >> How will corresponding software development resources evolve? > > > > I don't think I understand the question, or, actually, are you asking > > me or the coccinelle developers ? > > I hope that more development challenges will be picked up. > >

Re: [Cocci] [v3 05/10] mmap locking API: Improving the Coccinelle software

2020-03-30 Thread Markus Elfring
>> How will corresponding software development resources evolve? > > I don't think I understand the question, or, actually, are you asking > me or the coccinelle developers ? I hope that more development challenges will be picked up. The code from a mentioned source file can be reduced to the