On Sat, Feb 24, 2018 at 11:45:16AM +0300, Dan Carpenter wrote:
> On Sat, Feb 24, 2018 at 02:59:41AM +0000, Luis R. Rodriguez wrote:
> > On Mon, Jan 22, 2018 at 01:27:54PM +0300, Dan Carpenter wrote:
> > > The main problem is that the parentheses are in the wrong place and the
>
On Mon, Jan 22, 2018 at 01:27:54PM +0300, Dan Carpenter wrote:
> The main problem is that the parentheses are in the wrong place and the
> unlikely() call returns either 0 or 1 so it's never less than zero.
Doh, thanks, yes. Seems worth considering a grammar rule for it.
> The other problem is th
On Wed, Nov 29, 2017 at 10:28:43PM +0100, Julia Lawall wrote:
> Anohter option is to create a file with lists of file names that should be
> considered together. So you could have:
>
> a/foo.c
> a/xyz.c
>
> b/bar.c
> b/mno.c
> b/zzz.c
>
> Then use --file-groups with the name of this file.
Ah,
On Wed, Nov 29, 2017 at 10:21:00PM +0100, Michael Stefaniuc wrote:
> On 11/29/2017 09:58 PM, Luis R. Rodriguez wrote:
> > I've recently implemented support for a functionality which would allow us
> > to remove freezing calls on kthreads on filesystems *iff* the filesystem
&g
I've recently implemented support for a functionality which would allow us
to remove freezing calls on kthreads on filesystems *iff* the filesystem
implements support for filesystem freezing, this can be determined if
the filesystem implements the fs_freeze superblock callback. So the below
rule lo
On Tue, Nov 14, 2017 at 06:04:49PM +0900, Masahiro Yamada wrote:
> diff --git a/scripts/coccicheck b/scripts/coccicheck
> index 040a8b1..7da82a1 100755
> --- a/scripts/coccicheck
> +++ b/scripts/coccicheck
> @@ -70,6 +64,13 @@ if [ "$C" = "1" -o "$C" = "2" ]; then
> # Take only the last argume
On Thu, Feb 02, 2017 at 12:06:28AM +0100, Julia Lawall wrote:
> > > Do you require that there is exactly one element in the arrays?
> >
> > Well my eventual hunt is for all array users. So I'm starting off by
> > first looking for all simple setups with non-array cases, and then
> > giving context
On Wed, Feb 1, 2017 at 4:34 PM, Julia Lawall wrote:
> On Wed, 1 Feb 2017, Luis R. Rodriguez wrote:
>> Ah you are right, but it then goes ahead and uses it directly:
>>
>> ret = proc_dointvec_minmax(&tmp, write, buffer, lenp, ppos);
>>
>> So I would need to ca
On Wed, Feb 01, 2017 at 11:14:56PM +0100, Julia Lawall wrote:
>
>
> On Wed, 1 Feb 2017, Luis R. Rodriguez wrote:
>
> > On Wed, Feb 01, 2017 at 10:59:29PM +0100, Julia Lawall wrote:
> > >
> > >
> > > On Wed, 1 Feb 2017, Luis R. Rodriguez wrote:
>
On Wed, Feb 01, 2017 at 10:59:29PM +0100, Julia Lawall wrote:
>
>
> On Wed, 1 Feb 2017, Luis R. Rodriguez wrote:
>
> > I'm trying to hunt for users of the proc_dointvec() handler in
> > setups where more than one value is expected to be used. The way
> >
I'm trying to hunt for users of the proc_dointvec() handler in
setups where more than one value is expected to be used. The way
this old API works is it lets you specifiy in a structure the
variables and the size of the variables. In the singular case the
size will be maxlen = sizeof(int). If an ar
2016/7/17/37
Thanks more reading.. :)
> On Thu, Aug 25, 2016 at 9:41 PM, Luis R. Rodriguez wrote:
> >> > So .. I agree, let's avoid the hacks. Patches welcomed.
> >>
> >> Hm, this is a definite change of tack - back when I discussed this
> >> with Gre
Summoning Felix for the embedded aspect on initramfs below.
Jörg might be interested in the async facilities you speak of as well.
On Thu, Aug 25, 2016 at 01:05:44PM +0200, Daniel Vetter wrote:
> On Wed, Aug 24, 2016 at 10:39 PM, Luis R. Rodriguez wrote:
> > On Wed, Aug 24, 2016 at 0
On Wed, Aug 24, 2016 at 08:55:55AM +0200, Daniel Vetter wrote:
> On Fri, Jun 17, 2016 at 12:54 AM, Luis R. Rodriguez wrote:
> > Thou shalt not make firmware calls early on init or probe.
<-- snip -->
> > There are 4 offenders at this time:
> >
> > mcgrof@
On Wed, Jun 29, 2016 at 03:14:50PM -0700, Luis R. Rodriguez wrote:
> There were quite a bit of comments from the v3 series [0], since there
> was quite a bit of review needed for some other changes I've had discussions
> with Nicolas and Julia privately over these changes and collec
This has no functional changes. This is being done
to enable us to later use spatch binary for some
flag checking for certain features early on.
Signed-off-by: Luis R. Rodriguez
Acked-by: Nicolas Palix
---
scripts/coccicheck | 10 +-
1 file changed, 5 insertions(+), 5 deletions
Make use of the new Requires: tag to be able to specify coccinelle binary
version requirements. The cocci file device_node_continue.cocci requires at
least coccinelle 1.0.4.
Signed-off-by: Luis R. Rodriguez
Acked-by: Julia Lawall
Acked-by: Nicolas Palix
---
scripts/coccinelle/iterators
go through the new branches, so the old complex multithreaded process
is skipped as well.
v3:
o move USE_JOBS to avoid being overriden
v2:
o redirect coccinelle stderr to /dev/null by default and
only if DEBUG_FILE is used do we pass it to a file
o fix typo of paramap/parmap
Signed-off-by: Lui
* check, this doesn't work for
disjunctions.
Signed-off-by: Luis R. Rodriguez
Acked-by: Julia Lawall
---
Documentation/coccinelle.txt | 12
scripts/coccicheck | 21 +
2 files changed, 33 insertions(+)
diff --git a/Documentation/coccinelle.txt b
Documentation/coccinelle.txt.
Signed-off-by: Luis R. Rodriguez
Acked-by: Nicolas Palix
---
Documentation/coccinelle.txt | 9 +
scripts/coccicheck | 5 +++--
2 files changed, 12 insertions(+), 2 deletions(-)
diff --git a/Documentation/coccinelle.txt b/Documentation/coccinelle.txt
index
Make use of the new Requires: tag to be able to specify coccinelle binary
version requirements. The cocci file device_node_continue.cocci requires at
least coccinelle 1.0.4.
Acked-by: Julia Lawall
Acked-by: Nicolas Palix
Signed-off-by: Luis R. Rodriguez
---
scripts/coccinelle/iterators
* check, this doesn't work for
disjunctions.
Signed-off-by: Luis R. Rodriguez
---
Documentation/coccinelle.txt | 12
scripts/coccicheck | 23 +++
2 files changed, 35 insertions(+)
diff --git a/Documentation/coccinelle.txt b/Documentation/coccinelle.t
using coccicheck, and how to
properly override these if needed.
o Expand Documentation/coccinelle.txt
v3: Expand commit log a bit more
Signed-off-by: Luis R. Rodriguez
Acked-by: Julia Lawall
---
.cocciconfig | 3 ++
.gitignore | 1 +
Documentation/coccinel
Documentation/coccinelle.txt.
Signed-off-by: Luis R. Rodriguez
---
Documentation/coccinelle.txt | 9 +
scripts/coccicheck | 5 +++--
2 files changed, 12 insertions(+), 2 deletions(-)
diff --git a/Documentation/coccinelle.txt b/Documentation/coccinelle.txt
index b90aa0bc8d6c
added in the v3 series
v4: Update Documentation/coccinelle.txt explaining how
SPFLAGS works as well.
Signed-off-by: Luis R. Rodriguez
Acked-by: Nicolas Palix
---
Documentation/coccinelle.txt | 3 ++-
scripts/coccicheck | 5 -
2 files changed, 6 insertions(+), 2 deletions
ux-next.git/log/?h=20160629-coccicheck-v4
Luis R. Rodriguez (9):
coccicheck: move spatch binary check up
coccicheck: make SPFLAGS more useful
coccicheck: enable parmap support
coccicheck: add support for DEBUG_FILE
coccicheck: replace --very-quiet with --quiet when debugging
scr
things which would go into stderr, such as
profiling. That will be done separately in another
commit.
Expand Documentation/coccinelle.txt with details.
Signed-off-by: Luis R. Rodriguez
Acked-by: Nicolas Palix
---
Documentation/coccinelle.txt | 20
scripts/coccicheck
ow to
properly override these if needed.
o Expand Documentation/coccinelle.txt
v3: Expand commit log a bit more
Signed-off-by: Luis R. Rodriguez
---
.cocciconfig | 3 +++
.gitignore | 1 +
Documentation/coccinelle.txt | 47 ++
On Wed, Jun 29, 2016 at 03:10:17PM -0700, Luis R. Rodriguez wrote:
> Here's a v4 RFC, sending it privately to avoid bikeshedding in public.
> These are rebased on top of linux-next tag next-20160623.
Whoops.. so much for that. Ignore please. Will send the fixed set next
This has no functional changes. This is being done
to enable us to later use spatch binary for some
flag checking for certain features early on.
Signed-off-by: Luis R. Rodriguez
Acked-by: Nicolas Palix
---
scripts/coccicheck | 10 +-
1 file changed, 5 insertions(+), 5 deletions
added in the v3 series
v4: Update Documentation/coccinelle.txt explaining how
SPFLAGS works as well.
Signed-off-by: Luis R. Rodriguez
Acked-by: Nicolas Palix
---
Documentation/coccinelle.txt | 3 ++-
scripts/coccicheck | 5 -
2 files changed, 6 insertions(+), 2 deletions
Here's a v4 RFC, sending it privately to avoid bikeshedding in public.
These are rebased on top of linux-next tag next-20160623.
Luis R. Rodriguez (9):
coccicheck: move spatch binary check up
coccicheck: make SPFLAGS more useful
coccicheck: enable parmap support
coccicheck: add su
things which would go into stderr, such as
profiling. That will be done separately in another
commit.
Expand Documentation/coccinelle.txt with details.
Signed-off-by: Luis R. Rodriguez
---
Documentation/coccinelle.txt | 20
scripts/coccicheck | 10 +-
2 files
go through the new branches, so the old complex multithreaded process
is skipped as well.
v3:
o move USE_JOBS to avoid being overriden
v2:
o redirect coccinelle stderr to /dev/null by default and
only if DEBUG_FILE is used do we pass it to a file
o fix typo of paramap/parmap
Signed-off-by: Lui
: Document // Options and // Requires as well on
Documentation/coccinelle.txt.
Signed-off-by: Luis R. Rodriguez
Acked-by: Nicolas Palix
---
Documentation/coccinelle.txt | 19 +++
scripts/coccicheck | 14 ++
2 files changed, 33 insertions(+)
diff --git a
: Document // Options and // Requires as well on
Documentation/coccinelle.txt.
Signed-off-by: Luis R. Rodriguez
Acked-by: Nicolas Palix
---
Documentation/coccinelle.txt | 19 +++
scripts/coccicheck | 14 ++
2 files changed, 33 insertions(+)
diff --git a
On Sat, Jun 25, 2016 at 02:54:46PM +0200, SF Markus Elfring wrote:
> > bundles/menhirLib/Makefile | 1 +
> > bundles/parmap/Makefile| 1 +
> > bundles/pcre/Makefile | 1 +
> > bundles/pycaml/Makefile| 1 +
>
> How do you think about to
[...]
I'm dropping this patch in favor of some
On Wed, Jun 22, 2016 at 07:25:11AM +0200, Julia Lawall wrote:
>
>
> On Wed, 22 Jun 2016, Luis R. Rodriguez wrote:
>
> > On Tue, Jun 21, 2016 at 11:44:09PM +0200, Julia Lawall wrote:
> > >
> > >
> > > On Tue, 21 Jun 2016, Luis R. Rodriguez wrote:
On Tue, Jun 21, 2016 at 11:12:54PM +0200, Julia Lawall wrote:
> On Tue, 21 Jun 2016, Nicolas Palix (LIG) wrote:
>
> > Le 21/06/16 à 21:21, Luis R. Rodriguez a écrit :
> > > Help Coccinelle when used against Linux with a set of sensible defaults
> > > options for L
On Tue, Jun 21, 2016 at 10:29:53PM +0200, Julia Lawall wrote:
[...]
> mkid -i C --output .id-utils.index
>
> [...] Coccinelle searches for the index in the directory
> on which it is working
Can you clarify if this is $PWD from which we spawn spatch or
the --dir, or the current directory that s
On Tue, Jun 21, 2016 at 11:44:09PM +0200, Julia Lawall wrote:
>
>
> On Tue, 21 Jun 2016, Luis R. Rodriguez wrote:
>
> > On Tue, Jun 21, 2016 at 11:32:11PM +0200, Julia Lawall wrote:
> > >
> > >
> > > On Tue, 21 Jun 2016, Luis R. Rodriguez wrote:
On Tue, Jun 21, 2016 at 11:18:41PM +0200, Julia Lawall wrote:
>
>
> On Tue, 21 Jun 2016, Nicolas Palix (LIG) wrote:
>
> > Hi,
> >
> > Le 21/06/16 à 21:21, Luis R. Rodriguez a écrit :
> > > Sprinkling *tons* of documentation on the script is not a good
On Tue, Jun 21, 2016 at 11:32:11PM +0200, Julia Lawall wrote:
>
>
> On Tue, 21 Jun 2016, Luis R. Rodriguez wrote:
>
> > On Tue, Jun 21, 2016 at 11:00:53PM +0200, Nicolas Palix (LIG) wrote:
> > > Hi,
> > >
> > > Le 21/06/16 à 22:43, Julia Lawall a
On Tue, Jun 21, 2016 at 11:00:53PM +0200, Nicolas Palix (LIG) wrote:
> Hi,
>
> Le 21/06/16 à 22:43, Julia Lawall a écrit :
> >
> >
> >On Tue, 21 Jun 2016, Luis R. Rodriguez wrote:
> >
> >>On Tue, Jun 21, 2016 at 10:17:38PM +0200, Julia Lawall wrote:
&g
On Tue, Jun 21, 2016 at 11:30:03PM +0200, Julia Lawall wrote:
>
>
> On Tue, 21 Jun 2016, Luis R. Rodriguez wrote:
>
> > On Tue, Jun 21, 2016 at 11:02:49PM +0200, Julia Lawall wrote:
> > > On Tue, 21 Jun 2016, Luis R. Rodriguez wrote:
> >
On Tue, Jun 21, 2016 at 11:10:00PM +0200, Julia Lawall wrote:
>
>
> On Tue, 21 Jun 2016, Luis R. Rodriguez wrote:
>
> > On Tue, Jun 21, 2016 at 10:43:04PM +0200, Julia Lawall wrote:
> > >
> > >
> > > On Tue, 21 Jun 2016, Luis R. Rodriguez wrote:
On Tue, Jun 21, 2016 at 11:02:49PM +0200, Julia Lawall wrote:
> On Tue, 21 Jun 2016, Luis R. Rodriguez wrote:
> > That is sanitized as follows:
> >
> > # spatch only allows include directories with the syntax "-I include"
> >
> > # whil
On Tue, Jun 21, 2016 at 10:43:04PM +0200, Julia Lawall wrote:
>
>
> On Tue, 21 Jun 2016, Luis R. Rodriguez wrote:
>
> > On Tue, Jun 21, 2016 at 10:17:38PM +0200, Julia Lawall wrote:
> > >
> > >
> > > On Tue, 21 Jun 2016, Luis R. Rodriguez wr
On Tue, Jun 21, 2016 at 10:13:31PM +0200, Julia Lawall wrote:
>
>
> On Tue, 21 Jun 2016, Luis R. Rodriguez wrote:
>
> > This v3 series addresses the feedback from the last v2 series
> > on the coccicheck enhancements [0], namely:
> >
> > o it drops th
On Tue, Jun 21, 2016 at 10:17:38PM +0200, Julia Lawall wrote:
>
>
> On Tue, 21 Jun 2016, Luis R. Rodriguez wrote:
>
> > Coccinelle has had parmap support since 1.0.2, this means
> > it supports --jobs, enabling built-in multithreaded functionality,
> > instead o
On Tue, Jun 21, 2016 at 07:54:42PM +0200, SF Markus Elfring wrote:
> I suggest therefore to consider additional possibilities.
Patches welcomed.
Luis
___
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci
This has no functional changes. This is being done
to enable us to later use spatch binary for some
flag checking for certain features early on.
Signed-off-by: Luis R. Rodriguez
---
scripts/coccicheck | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/scripts
overriden
v2:
o redirect coccinelle stderr to /dev/null by default and
only if DEBUG_FILE is used do we pass it to a file
o fix typo of paramap/parmap
Signed-off-by: Luis R. Rodriguez
---
scripts/coccicheck | 41 ++---
1 file changed, 38 insertions(+), 3
cessed last, if used
Signed-off-by: Luis R. Rodriguez
---
.cocciconfig | 3 +++
.gitignore | 1 +
2 files changed, 4 insertions(+)
create mode 100644 .cocciconfig
diff --git a/.cocciconfig b/.cocciconfig
new file mode 100644
index ..43967c6b2015
--- /dev/null
+++ b/.c
the rest.
This uses the simple kernel scripts/ld-version.sh to create a weight
on the version provided by spatch. The -dirty attribute is ignored if
supplied, the benefit of scripts/ld-version.sh is it has a long history
and well tested.
Signed-off-by: Luis R. Rodriguez
---
scripts/coccicheck
://git.kernel.org/cgit/linux/kernel/git/mcgrof/linux-next.git/log/?h=20160621-cocciconfig-v3
Luis R. Rodriguez (8):
coccicheck: move spatch binary check up
coccicheck: make SPFLAGS more useful
coccicheck: enable parmap support
coccicheck: replace --very-quiet with --quit when debugging
ODE=report SPFLAGS="--profile
--show-trying" M=./drivers/mfd/arizona-irq.c
v3: rebased, resolve conflicts
v2: use egrep instead of the *"=--option"* check, this doesn't work for
disjunctions.
Signed-off-by: Luis R. Rodriguez
---
scripts/coccicheck | 23
Make use of the new Requires: tag to be able to specify coccinelle binary
version requirements. The cocci file device_node_continue.cocci requires at
least coccinelle 1.0.4.
Signed-off-by: Luis R. Rodriguez
---
scripts/coccinelle/iterators/device_node_continue.cocci | 3 +++
1 file changed, 3
Sprinkling *tons* of documentation on the script is not a good
idea, instead refer to a wiki for further coccicheck documentation:
https://bottest.wiki.kernel.org/coccicheck
This page shall always refer to the linux-next iteration of
scripts/coccicheck.
Signed-off-by: Luis R. Rodriguez
R. Rodriguez
---
scripts/coccicheck | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/scripts/coccicheck b/scripts/coccicheck
index f137b04dfdd3..5319fae910b4 100755
--- a/scripts/coccicheck
+++ b/scripts/coccicheck
@@ -30,7 +30,7 @@ else
NPROC="$J"
f
On Tue, Jun 21, 2016 at 9:22 AM, SF Markus Elfring
wrote:
>> …, the only consistent fix seems to be to use
>> .NOTPARALLEL on all bundles.
>
> How do you think about a bit more fine-tuning for this setting?
>
> Would you really like to switch parallelisation off for the affected make
> scripts co
On Sat, Jun 18, 2016 at 09:12:16AM +0200, SF Markus Elfring wrote:
> > +.ONESHELL:
This ended causing some loop on some system, the only consistent
fix seems to be to use .NOTPARALLEL on all bundles.
Luis
___
Cocci mailing list
Cocci@systeme.lip6.fr
h
#x27;
Makefile:143: recipe for target 'all-release' failed
make[1]: *** [all-release] Error 2
make[1]: Leaving directory '/home/mcgrof/coccinelle'
Makefile:121: recipe for target 'all' failed
make: *** [all] Error 2
Signed-off-by: Luis R. Rodriguez
---
bundles/menhirL
This perhaps is not the best demo for use of ++ but it
should suffice. This adds some basic documentation for it
and a demo.
Signed-off-by: Luis R. Rodriguez
---
demos/plusplus1.c| 4 ++
demos/plusplus1.cocci| 17
demos/plusplus1.res | 5 +++
demos
Signed-off-by: Luis R. Rodriguez
---
docs/manual/cocci_syntax.tex | 51 ++--
1 file changed, 40 insertions(+), 11 deletions(-)
diff --git a/docs/manual/cocci_syntax.tex b/docs/manual/cocci_syntax.tex
index 49602ef1d732..5adfc95b0ce1 100644
--- a/docs
This v2 modifies the ++ demo and documentation to something
a bit more safe for its use, and while at it decided to extend
the iteration documentation and document support for .cocciconfig.
Luis R. Rodriguez (3):
docs/demos: add a few ++ documentation and demos
docs/manual/cocci_syntax.tex
Add documentation and example to manual and man page.
Signed-off-by: Luis R. Rodriguez
---
docs/manual/cocci_syntax.tex | 23 +++
docs/spatch.1.in | 32 +++-
2 files changed, 54 insertions(+), 1 deletion(-)
diff --git a/docs/manual
On Sat, Jun 18, 2016 at 07:51:55AM +0200, Julia Lawall wrote:
>
>
> On Sat, 18 Jun 2016, Luis R. Rodriguez wrote:
>
> > On Fri, Jun 17, 2016 at 05:35:26PM +0200, Julia Lawall wrote:
> > > On Fri, 17 Jun 2016, Luis R. Rodriguez wrote:
> > >
> > &g
On Fri, Jun 17, 2016 at 05:35:26PM +0200, Julia Lawall wrote:
> On Fri, 17 Jun 2016, Luis R. Rodriguez wrote:
>
> > On Fri, Jun 17, 2016 at 11:44:26AM +0200, Julia Lawall wrote:
> > > I'm not sure that this is worth it. It adds a dependency on a tool that
> > &
On Fri, Jun 17, 2016 at 08:47:24PM +0200, Luis R. Rodriguez wrote:
> On Fri, Jun 17, 2016 at 08:10:14PM +0200, Julia Lawall wrote:
> >
> >
> > On Fri, 17 Jun 2016, Luis R. Rodriguez wrote:
> >
> > > This fixes parallel compilation when using 32 threads on a 3
On Fri, Jun 17, 2016 at 08:10:14PM +0200, Julia Lawall wrote:
>
>
> On Fri, 17 Jun 2016, Luis R. Rodriguez wrote:
>
> > This fixes parallel compilation when using 32 threads on a 32-core
> > system:
> >
> > The error:
> >
> > make[6]: Entering d
-release] Error 2
make[1]: Leaving directory '/home/mcgrof/coccinelle'
Makefile:121: recipe for target 'all' failed
make: *** [all] Error 2
Signed-off-by: Luis R. Rodriguez
---
bundles/pycaml/Makefile | 2 ++
1 file changed, 2 insertions(+)
diff --git a/bundles/pycaml/Makefil
On Fri, Jun 17, 2016 at 05:28:58PM +0200, Julia Lawall wrote:
> On Fri, 17 Jun 2016, Luis R. Rodriguez wrote:
>
> > Building coccinelle on a 4 core system using 4 threads works well, on
> > a 32-core system however it fails. Building serially works well on the
> > system.
On Fri, Jun 17, 2016 at 06:05:38PM +0200, SF Markus Elfring wrote:
> > To me what we can best do is see what we can take out of agrep,
> > and port it to proper GNU grep, then see if git can also enable
> > complex queries as Julia notes.
>
> How do you think about to improve such tools together w
On Fri, Jun 17, 2016 at 11:44:26AM +0200, Julia Lawall wrote:
> I'm not sure that this is worth it. It adds a dependency on a tool that
> seems not to be well maintained. In terms of Coccinelle, I'm not sure
> that it gives a big benefit.
>
> Attached is a graph showing the file selection time f
On Fri, Jun 17, 2016 at 11:47:25AM +0200, Julia Lawall wrote:
>
>
> On Thu, 16 Jun 2016, Luis R. Rodriguez wrote:
>
> > Coccinelle has support to make use of its own enhanced "grep"
> > mechanisms instead of using regular grep for searching code,
> > i
Building coccinelle on a 4 core system using 4 threads works well, on
a 32-core system however it fails. Building serially works well on the
system. After autogen, configure, and then make -j 32 I get:
make[6]: Entering directory '/home/mcgrof/coccinelle/bundles/pycaml'
/usr/bin/ocamlopt.opt -I ch
ODE=report SPFLAGS="--profile
--show-trying" M=./drivers/mfd/arizona-irq.c
v2: use egrep instead of the *"=--option"* check, this doesn't work for
disjunctions.
Signed-off-by: Luis R. Rodriguez
---
scripts/coccicheck | 20 +++-
1 file changed, 19 inser
the rest.
This uses the simple kernel scripts/ld-version.sh to create a weight
on the version provided by spatch. The -dirty attribute is ignored if
supplied, the benefit of scripts/ld-version.sh is it has a long history
and well tested.
Signed-off-by: Luis R. Rodriguez
---
scripts/coccicheck
This has no functional changes. This is being done
to enable us to later use spatch binary for some
flag checking for certain features early on.
Signed-off-by: Luis R. Rodriguez
---
scripts/coccicheck | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/scripts
Make use of the new Requires: tag to be able to specify coccinelle binary
version requirements. The cocci file device_node_continue.cocci requires at
least coccinelle 1.0.4.
Signed-off-by: Luis R. Rodriguez
---
scripts/coccinelle/iterators/device_node_continue.cocci | 3 +++
1 file changed, 3
handle some errors in coccinelle cocci files and if
they bail out we should inspect the errors. This will be more
useful later to help annotate coccinelle version dependency
requirements. This will let you run only SmPL files that your
system supports.
Signed-off-by: Luis R. Rodriguez
As a small
Cc: Jiri Slaby
Cc: linux-ser...@vger.kernel.org
Cc: linux-...@vger.kernel.org
Cc: linux-ser...@vger.kernel.org
Cc: linuxppc-...@lists.ozlabs.org
Signed-off-by: Luis R. Rodriguez
---
Documentation/firmware_class/README| 20
drivers/base/Kconfig
help speed up some of the new Coccinelle API checks and
transformations implemented in later series on the request firmware API.
Luis R. Rodriguez (8):
coccicheck: move spatch binary check up
coccicheck: enable parmap support
coccicheck: add indexing enhancement options
scripts: add glimpse.sh
$ make coccicheck V=1 MODE=report COCCI_INDEX="--use-glimpse"
$ make coccicheck V=1 MODE=report COCCI_INDEX="--use-gitgrep"
Signed-off-by: Luis R. Rodriguez
---
scripts/coccicheck | 150 +
1 file changed, 150 insert
Sprinkling *tons* of documentation on the script is not a good
idea, instead refer to a wiki for further coccicheck documentation:
https://bottest.wiki.kernel.org/coccicheck
This page shall always refer to the linux-next iteration of
scripts/coccicheck.
Signed-off-by: Luis R. Rodriguez
and add verbose release information
to commit log about the open sourcing of glimpse and its
current status.
o add index files to .gitignore
[0] http://webglimpse.net/
[1] https://github.com/gvelez17/glimpse/
[2] https://github.com/mcgrof/glimpse.git
Signed-off-by: Luis R. Rodriguez
On Thu, Sep 03, 2015 at 07:56:33AM +0200, Julia Lawall wrote:
>
>
> On Thu, 3 Sep 2015, Luis R. Rodriguez wrote:
>
> > On Sat, Aug 29, 2015 at 06:18:20PM +0200, Julia Lawall wrote:
> > > > +@ defines_module_init exists @
> > > > +declarer
On Wed, Jun 15, 2016 at 09:11:45PM +0200, Michal Marek wrote:
> Dne 15.6.2016 v 18:02 Luis R. Rodriguez napsal(a):
> > On Wed, Jun 15, 2016 at 09:50:11AM +0200, Michal Marek wrote:
> >> On 2016-06-15 00:10, Luis R. Rodriguez wrote:
> >>> +weight = (int(
On Wed, Jun 15, 2016 at 01:20:19PM +0200, SF Markus Elfring wrote:
> > +DIR=$(dirname $(readlink -f $0))
> > +DIR="${DIR}/../"
>
> How do you think about to merge these variable assignments also into one?
>
> +DIR="$(dirname $(readlink -f $0))/../"
Sure.
Luis
_
On Wed, Jun 15, 2016 at 06:52:27PM +0200, Julia Lawall wrote:
>
>
> On Wed, 15 Jun 2016, Luis R. Rodriguez wrote:
>
> > On Wed, Jun 15, 2016 at 06:11:57PM +0200, Julia Lawall wrote:
> > >
> > >
> > > On Wed, 15 Jun 2016, Luis R. Rodriguez wrote:
>
On Wed, Jun 15, 2016 at 08:24:03PM +0200, SF Markus Elfring wrote:
> > http://webglimpse.net/
> > Its vaguely mentioned there. That's as good as it gets...
>
> How do you think about to insert the date "2014-09-26" into your commit
> message?
Sure.
> >> https://github.com/gvelez17/glimpse/
> > S
On Wed, Jun 15, 2016 at 12:26:19PM +0200, SF Markus Elfring wrote:
> > Glimpse is a tool you can use to index the kernel.
> > The tool was recently open sourced under the ISC license
> > and can be obtained at:
>
> Do you find any official announcement for this software evolution?
I had reached o
On Wed, Jun 15, 2016 at 05:44:01PM +0200, Julia Lawall wrote:
>
>
> On Wed, 15 Jun 2016, Luis R. Rodriguez wrote:
> > OK thanks. I remove --very-quiet now if --profile is used within SPFLAGS,
> > I'll extend
> > this to also avoid --very-quiet if --show-trying is
On Wed, Jun 15, 2016 at 06:11:57PM +0200, Julia Lawall wrote:
>
>
> On Wed, 15 Jun 2016, Luis R. Rodriguez wrote:
>
> > On Wed, Jun 15, 2016 at 05:55:34PM +0200, Julia Lawall wrote:
> > >
> > >
> > > On Wed, 15 Jun 2016, Luis R. Rodriguez wrote:
>
On Wed, Jun 15, 2016 at 05:55:34PM +0200, Julia Lawall wrote:
>
>
> On Wed, 15 Jun 2016, Luis R. Rodriguez wrote:
>
> > On Wed, Jun 15, 2016 at 10:43:30AM +0200, Julia Lawall wrote:
> > > How about the following, since Coccinelle knows what its version is?
&g
On Wed, Jun 15, 2016 at 08:06:33AM +0200, Julia Lawall wrote:
>
>
> On Tue, 14 Jun 2016, Luis R. Rodriguez wrote:
>
> > This library can be used in other python scripts to require
> > specific binary version requirements. It will be used first
> > with coccinel
On Wed, Jun 15, 2016 at 09:50:11AM +0200, Michal Marek wrote:
> On 2016-06-15 00:10, Luis R. Rodriguez wrote:
> > +weight = (int(rel_specs['VERSION'])<< 32) + \
> > + (int(rel_specs['PATCHLEVEL']) << 16) + \
> > +
On Wed, Jun 15, 2016 at 02:01:37PM +0200, SF Markus Elfring wrote:
> > +"To be used for verifying binay package dependencies on Python code"
>
> Would you like to fix a typo here?
>
> ... binary ...
Fixed.
Luis
___
Cocci mailing list
Cocci@syste
On Wed, Jun 15, 2016 at 10:43:30AM +0200, Julia Lawall wrote:
> How about the following, since Coccinelle knows what its version is?
> This could of course be implemented in python as well.
>
> julia
>
> diff --git a/docs/Coccilib.3cocci b/docs/Coccilib.3cocci
> index 0e4fbb8..ca5b061 100644
> --
1 - 100 of 421 matches
Mail list logo
