> > Changes in v7:
> > 1:adjust coccinelle.rst documentation
>
> Thanks for your contribution.
>
> Now I am curious if other contributors will add corresponding review comments.
>
>
> > 2:fix a repo of "default"
Sorry...it s
> I suggest to improve the case distinction for the make (and environment)
> variable “COCCI” also by adjusting the document outline.
> * Empty string
> * Directory selection
> * File name specification
>
> See also:
> https://docutils.readthedocs.io/en/sphinx-docs/user/rst/quickstart.html#section
> I got the impression that you are struggling with difficulties (for unknown
> reasons)
> around adding space characters at some places.
> How would you like to improve this situation?
Thanks for your concern,but i haven't struggled with anything.I think i'm used
to
adding space characters.
>
> > Would you like to update the provided software documentation together with
> > the small extension of this bash script?
> >
> > Update candidates:
>
> Please reconsider also the section “Using Coccinelle with a single semantic
> patch”:
> https://git.kernel.org/pub/scm/linux/kernel/git/torva
Sorry for the late reply!
I would say yes.
> Would you like to update the provided software documentation together with
> the small extension of this bash script?
I'd like to but i don't have rights to update.
Thansk,
zhong.shiqi
> Update candidates:
> *
>
Allow defining the environment variable “COCCI” as a directory
> to search SmPL scripts.
>
> * Start a corresponding file determination if it contains an acceptable
> path.
Thanks,i think it would be better!
Best Regards,
zhong.shiqi
> Regards,
> Markus_
Allow defining the environment variable “COCCI” as a directory
> to search SmPL scripts.
>
> * Start a corresponding file determination if it contains an acceptable
> path.
Thanks,i think it would be better!
Best Regards,
zhong.shiqi
> Regards,
> Markus_
> >> How do you think about to use the subject “[PATCH] coccicheck:
> >> Support search for SmPL scripts within selected directory hierarchy”?
> >
> > I would like to use subject as you said.
>
> Thanks for your positive feedback.
>
>
> > But it seems a little bit long,
>
> I hope that this suggest
> I find that the commit message should still be considerably improved.
> How do you think about to use the subject “[PATCH] coccicheck:
> Support search for SmPL scripts within selected directory hierarchy”?
I would like to use subject as you said.
But it seems a little bit long, does it matter?
a directory that contains .cocci files.
>
> In general, at least in simple cases, it is not necessary to mention the
> name of the file you are modifying in the comit log, because one can see
> that just below from looking at the diffstat and the patch.
>
> thanks,
> julia
>
directory(based on "-d"
option).
If it is a directory, the next statement is executed. If it is not a
directory or if it is just a file with a a suffix of cocci, the statement after
the final else branch is executed.
Thanks for you reply，
zhong.shiqi
E: zhong.sh...@
11 matches
Mail list logo
