Re: [3/5] Coccinelle: put_device: Merge four SmPL when constraints into one

2019-05-13 Thread Markus Elfring
>> I try to stress SmPL functionality in this use case. > > That's not the goal of the semantic patches in the kernel. > > The rule is fine as it is. I am curious under which circumstances other software aspects can become more relevant (as suggested). Regards, Markus

Re: [Cocci] [3/5] Coccinelle: put_device: Merge four SmPL when constraints into one

2019-05-13 Thread Julia Lawall
On Mon, 13 May 2019, Markus Elfring wrote: > >> An assignment target was repeated in four SmPL when constraints. > >> Combine the exclusion specifications into disjunctions for the semantic > >> patch language so that this target is referenced only once there. > > > > NACK. > > I find this

Re: [Cocci] [3/5] Coccinelle: put_device: Merge four SmPL when constraints into one

2019-05-13 Thread Markus Elfring
>> An assignment target was repeated in four SmPL when constraints. >> Combine the exclusion specifications into disjunctions for the semantic >> patch language so that this target is referenced only once there. > > NACK. I find this rejection questionable. > This exceeds 80 characters The

Re: [PATCH 3/5] Coccinelle: put_device: Merge four SmPL when constraints into one

2019-05-13 Thread Julia Lawall
On Mon, 13 May 2019, Markus Elfring wrote: > From: Markus Elfring > Date: Sun, 12 May 2019 18:32:46 +0200 > > An assignment target was repeated in four SmPL when constraints. > Combine the exclusion specifications into disjunctions for the semantic > patch language so that this target is