Re: [Cocci] [4/5] Coccinelle: put_device: Extend when constraints for two SmPL ellipses

2019-05-13 Thread Markus Elfring
>> A SmPL ellipsis was specified for a search approach so that additional >> source code would be tolerated between an assignment to a local variable >> and the corresponding null pointer check. >> >> But such code should be restricted. >> * The local variable must not be reassigned there. >> * It

Re: [Cocci] [4/5] Coccinelle: put_device: Extend when constraints for two SmPL ellipses

2019-05-13 Thread Markus Elfring
>> Take additional casts for these code exclusion specifications into account >> together with optional parentheses. > > NACK. I find this rejection surprising. > You don't need so many type metavariables. I got an other software development opinion for this aspect. Yesterday we started to