Re: [Cocci] [PATCH v2 4/8] scripts: add glimpse.sh for indexing the kernel

2016-06-20 Thread Luis R. Rodriguez
On Sat, Jun 18, 2016 at 07:51:55AM +0200, Julia Lawall wrote: > > > On Sat, 18 Jun 2016, Luis R. Rodriguez wrote: > > > On Fri, Jun 17, 2016 at 05:35:26PM +0200, Julia Lawall wrote: > > > On Fri, 17 Jun 2016, Luis R. Rodriguez wrote: > > > > > > > On Fri, Jun 17, 2016 at 11:44:26AM +0200,

Re: [Cocci] [PATCH v2 4/8] scripts: add glimpse.sh for indexing the kernel

2016-06-18 Thread Julia Lawall
On Sat, 18 Jun 2016, Julia Lawall wrote: > Overall, idutils seems to be a good choice. As compared to a grep based > solution, it knows what is code, so it doesn't report on files where the > words of interest only occur in comments. As compared to glimpse, it > knows that foo_bar is a

Re: [Cocci] [PATCH v2 4/8] scripts: add glimpse.sh for indexing the kernel

2016-06-17 Thread Luis R. Rodriguez
On Fri, Jun 17, 2016 at 05:35:26PM +0200, Julia Lawall wrote: > On Fri, 17 Jun 2016, Luis R. Rodriguez wrote: > > > On Fri, Jun 17, 2016 at 11:44:26AM +0200, Julia Lawall wrote: > > > I'm not sure that this is worth it. It adds a dependency on a tool that > > > seems not to be well maintained.

Re: [Cocci] [PATCH v2 4/8] scripts: add glimpse.sh for indexing the kernel

2016-06-17 Thread Julia Lawall
> Under which circumstances will the indexing efforts pay off? Indexing is beneficial when a semantic patch uses in an essential way some words that appear rarely in the code base. For example, the following semantic patch will only do something useful on code that contains xyz: - x =

Re: [Cocci] [PATCH v2 4/8] scripts: add glimpse.sh for indexing the kernel

2016-06-17 Thread SF Markus Elfring
> I'm not sure that this is worth it. It adds a dependency on a tool > that seems not to be well maintained. Would any developers like to achieve further software improvements by additional means? How are the chances for corresponding progress from an approach like in a repository by Luis?

Re: [Cocci] [PATCH v2 4/8] scripts: add glimpse.sh for indexing the kernel

2016-06-17 Thread Luis R. Rodriguez
On Fri, Jun 17, 2016 at 11:44:26AM +0200, Julia Lawall wrote: > I'm not sure that this is worth it. It adds a dependency on a tool that > seems not to be well maintained. In terms of Coccinelle, I'm not sure > that it gives a big benefit. > > Attached is a graph showing the file selection time

[Cocci] [PATCH v2 4/8] scripts: add glimpse.sh for indexing the kernel

2016-06-16 Thread Luis R. Rodriguez
Glimpse is a tool you can use to index the kernel. The tool was open sourced on 2014-09-26 [0] under the ISC license however the original release still [1] does not compile. A fix for this and a release that does compile is provided in a temporary tree [2]. v2 changesl: o simplify DIR in one line