Re: NSUndoManager grouping somewhat broken?

2008-04-08 Thread Graham Cox
Hi, thanks for that. The current version of Sketch doesn't have this code, which is why I couldn't find it ;-) It does confirm the problem I'm having though so that's useful to know - it means I'm not doing something stupid with the undo manager. Interesting that they removed this from Sk

Re: NSUndoManager grouping somewhat broken?

2008-04-08 Thread Graham Cox
Thanks, but unfortunately you're mistaken as far as I and my exhaustive "project find" command can see - Sketch does not use undo grouping at all (seems there is no real need for Sketch to deal with the possibility of multiple undoable operations being grouped because it's so simple and onl

Re: NSUndoManager grouping somewhat broken?

2008-04-08 Thread Quincey Morris
On Apr 7, 2008, at 23:14, Graham Cox wrote: Can someone confirm that undo groups are broken in this way, or if they are not broken, explain what the hell the logic is here? Better still, has anyone written an NSUndoManager subclass that fixes this? The Sketch sample project has code to d

Re: NSUndoManager grouping somewhat broken?

2008-04-08 Thread Florent Pillet
Graham Cox wrote: I am getting funny results using grouping in NSUndoManager. If I begin a group on mouse down, and end the group on mouse up, even if I do nothing in between, it seems to record an undo task, with the plain name "Undo" in the menu, dirtying the document. The "task" is null - i

NSUndoManager grouping somewhat broken?

2008-04-07 Thread Graham Cox
I am getting funny results using grouping in NSUndoManager. If I begin a group on mouse down, and end the group on mouse up, even if I do nothing in between, it seems to record an undo task, with the plain name "Undo" in the menu, dirtying the document. The "task" is null - it doesn't actua