Re: Nullability annotation "best practice"

2015-08-18 Thread Seth Willits
On Aug 16, 2015, at 11:13 AM, Kevin Meaney wrote: > I’ve annotated the public methods of the API of a framework and though I > haven’t yet I will annotate internal methods and functions as well. > > I found a small number of issues where my thinking had not been clear, and > that having to sto

Re: Nullability annotation "best practice"

2015-08-17 Thread David Duncan
> On Aug 8, 2015, at 1:15 PM, Seth Willits wrote: > > Let's stipulate that _Nullable and _Nonnull are great to have because they > can catch bugs and express API intent better than before, so we want them. > The question is where to put them? > > > _Nullable and _Nonnull make perfect sense t

Re: Nullability annotation "best practice"

2015-08-16 Thread Kevin Meaney
I’ve annotated the public methods of the API of a framework and though I haven’t yet I will annotate internal methods and functions as well. I found a small number of issues where my thinking had not been clear, and that having to stop and consider what was intended when annotating the public AP

Re: Nullability annotation "best practice"

2015-08-16 Thread Quincey Morris
On Aug 16, 2015, at 09:10 , Seth Willits wrote: > > Really? This list has no opinions? That's hard to imagine :-) Well, I do, but I didn’t post it because I didn’t think you’d like it. I don’t think it’s worth annotating private methods at all (in general — I’m sure there are specific cases wh

Re: Nullability annotation "best practice"

2015-08-16 Thread Seth Willits
Really? This list has no opinions? That's hard to imagine :-) -- Seth Willits > On Aug 8, 2015, at 1:15 PM, Seth Willits wrote: > > Let's stipulate that _Nullable and _Nonnull are great to have because they > can catch bugs and express API intent better than before, so we want them. > The

Nullability annotation "best practice"

2015-08-08 Thread Seth Willits
Let's stipulate that _Nullable and _Nonnull are great to have because they can catch bugs and express API intent better than before, so we want them. The question is where to put them? _Nullable and _Nonnull make perfect sense to specify in the @interface. Since those annotations existing in t