[GitHub] trafodion pull request #1747: [TRAFODION-3235] add div and trim function for...

2018-11-19 Thread SuJinpei
Github user SuJinpei commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1747#discussion_r234884122 --- Diff: core/conn/odb/src/odb.c --- @@ -14685,6 +14743,56 @@ static void addGlobalPointer(void *ptr) globalPointers[nGlobalPointers++] = ptr

[GitHub] trafodion pull request #1747: [TRAFODION-3235] add div and trim function for...

2018-11-19 Thread SuJinpei
Github user SuJinpei commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1747#discussion_r234883979 --- Diff: core/conn/odb/src/odb.c --- @@ -10076,6 +10114,7 @@ static int Oloadbuff(int eid) clock_gettime(CLOCK_MONOTONIC, &

[GitHub] trafodion pull request #1747: [TRAFODION-3235] add div and trim function for...

2018-11-19 Thread SuJinpei
Github user SuJinpei commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1747#discussion_r234883931 --- Diff: core/conn/odb/src/odb.c --- @@ -6246,7 +6248,8 @@ static void Oload(int eid) trt[16]; /* translit to array

[GitHub] trafodion pull request #1747: [TRAFODION-3235] add div and trim function for...

2018-11-14 Thread SuJinpei
GitHub user SuJinpei opened a pull request: https://github.com/apache/trafodion/pull/1747 [TRAFODION-3235] add div and trim function for map feature, improve bad file print function. Some customer asks for this feature and these feature has been tested. You can merge this pull

[GitHub] trafodion pull request #1745: [TRAFODION-3233] odb rows option not work when...

2018-11-14 Thread SuJinpei
GitHub user SuJinpei opened a pull request: https://github.com/apache/trafodion/pull/1745 [TRAFODION-3233] odb rows option not work when copying data in parallel the cause is : You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] trafodion pull request #1671: [TRAFODION-3710] odb don't report error messag...

2018-07-31 Thread SuJinpei
Github user SuJinpei commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1671#discussion_r206455613 --- Diff: core/conn/odb/src/odb.c --- @@ -40,6 +40,7 @@ char *odbauth = "Trafodion Dev "; #define MAX_ARGS11 /* Max arg

[GitHub] trafodion pull request #1671: [TRAFODION-3710] odb don't report error messag...

2018-07-31 Thread SuJinpei
GitHub user SuJinpei opened a pull request: https://github.com/apache/trafodion/pull/1671 [TRAFODION-3710] odb don't report error message. **root cause:** SQLGetDiagRec expected an error message buffer length parameter which type is signed short, but odb defined a macro LINE_

[GitHub] trafodion pull request #1338: [Trafodion-2841] Windows ODBC supports buildin...

2018-07-29 Thread SuJinpei
Github user SuJinpei closed the pull request at: https://github.com/apache/trafodion/pull/1338 ---

[GitHub] trafodion pull request #1425: [Trafodion-2937] the actual copied data is les...

2018-02-06 Thread SuJinpei
Github user SuJinpei commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1425#discussion_r166286068 --- Diff: core/conn/odb/src/odb.c --- @@ -10867,7 +10874,7 @@ static int Ocopy(int eid) } /* Build Extract Command

[GitHub] trafodion pull request #1425: [Trafodion-2937] the actual copied data is les...

2018-02-06 Thread SuJinpei
Github user SuJinpei commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1425#discussion_r166265982 --- Diff: core/conn/odb/src/odb.c --- @@ -10867,7 +10874,7 @@ static int Ocopy(int eid) } /* Build Extract Command

[GitHub] trafodion pull request #1442: [TRAFODION-2955] odb crash when executing sql ...

2018-02-05 Thread SuJinpei
GitHub user SuJinpei opened a pull request: https://github.com/apache/trafodion/pull/1442 [TRAFODION-2955] odb crash when executing sql statements in a file and the file contains space only line. **root cause:** original odb didn't consider blank line. **fixed by:** deal

[GitHub] trafodion pull request #1433: [TRAFODION-2939] odb copied data exceeds the m...

2018-01-31 Thread SuJinpei
GitHub user SuJinpei opened a pull request: https://github.com/apache/trafodion/pull/1433 [TRAFODION-2939] odb copied data exceeds the max size specified by max option when copying data from oracle to Trafodion **root cause:** max rows were divided into each thread may cause etab

[GitHub] trafodion pull request #1425: [Trafodion-2937] the actual copied data is les...

2018-01-30 Thread SuJinpei
GitHub user SuJinpei opened a pull request: https://github.com/apache/trafodion/pull/1425 [Trafodion-2937] the actual copied data is less than expected when copying data from MySQL to Trafodion **root cause:** During building extract command, odb tool will try to split the task

[GitHub] trafodion pull request #1404: Trafodion 2916

2018-01-21 Thread SuJinpei
Github user SuJinpei commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1404#discussion_r162845411 --- Diff: core/conn/odb/src/odb.c --- @@ -7080,7 +7080,7 @@ static void Oload(int eid) mfl = (size_t) etab[eid].td[i].Osize

[GitHub] trafodion pull request #1404: Trafodion 2916

2018-01-18 Thread SuJinpei
GitHub user SuJinpei opened a pull request: https://github.com/apache/trafodion/pull/1404 Trafodion 2916 **the root cause**: the allocating size of str is determined by max field length + 128(here is 1500+128), but during loading, str will be filled with actual field data