Github user xiaozhongwang commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/1353#discussion_r158179961
--- Diff: install/traf_checkset_env.sh ---
@@ -0,0 +1,243 @@
+#!/bin/bash
+#
+# @@@ START COPYRIGHT
Github user xiaozhongwang commented on the pull request:
https://github.com/apache/trafodion/commit/13443f698dd4de8d47c9dc0c323352f32b8fa355#commitcomment-26701156
looks good for me
---
GitHub user xiaozhongwang opened a pull request:
https://github.com/apache/trafodion/pull/1379
remove code about SP_EXPORT_LIB
Because the SP_EXPORT_LIB is empty.
make a build error, as:
mkdir -p##(SEAMONSTER)
mkdir: 缺å°æä½æ° ##(SEAMONSTER)
请å
GitHub user xiaozhongwang opened a pull request:
https://github.com/apache/trafodion/pull/1380
[TRAFODION-2886] fix the nullpointer error scanned by TScanCode
I scanned code of Trafodion by TScanCode, found many nullpointer error, and
I fixed them here.
You can merge this pull
GitHub user xiaozhongwang opened a pull request:
https://github.com/apache/trafodion/pull/1382
[TRAFODION-2893] fix the logic Critical error checked by TScanCode.
The count of parameters mismatches the format string in sprintf
You can merge this pull request into a Git repository
Github user xiaozhongwang commented on a diff in the pull request:
https://github.com/apache/trafodion/pull/1380#discussion_r160868578
--- Diff: core/sql/executor/cluster.cpp ---
@@ -2395,7 +2395,7 @@ NABoolean Cluster::checkAndSplit(ExeErrorCode * rc
Github user xiaozhongwang commented on a diff in the pull request:
https://github.com/apache/trafodion/pull/1380#discussion_r160870920
--- Diff: core/sql/executor/cluster.cpp ---
@@ -2395,7 +2395,7 @@ NABoolean Cluster::checkAndSplit(ExeErrorCode * rc
GitHub user xiaozhongwang opened a pull request:
https://github.com/apache/trafodion/pull/1394
[TRAFODION-2891] fix the bufoverrun Critical error checked by TScanCode
fix the bufoverrun Critical error checked by TScanCode
You can merge this pull request into a Git repository by
Github user xiaozhongwang commented on a diff in the pull request:
https://github.com/apache/trafodion/pull/1380#discussion_r161255440
--- Diff: core/sql/executor/cluster.cpp ---
@@ -2395,7 +2395,7 @@ NABoolean Cluster::checkAndSplit(ExeErrorCode * rc
Github user xiaozhongwang commented on a diff in the pull request:
https://github.com/apache/trafodion/pull/1380#discussion_r161273985
--- Diff: core/sql/executor/cluster.cpp ---
@@ -2395,7 +2395,7 @@ NABoolean Cluster::checkAndSplit(ExeErrorCode * rc
Github user xiaozhongwang commented on the pull request:
https://github.com/apache/trafodion/commit/5dbc2508f8537e9a5fe5fd6d285ae8a0bf419237#commitcomment-26849230
looks good for me!
---
Github user xiaozhongwang commented on a diff in the pull request:
https://github.com/apache/trafodion/pull/1394#discussion_r161910390
--- Diff: core/conn/odb/src/odb.c ---
@@ -5313,7 +5313,7 @@ static void etabadd(char type, char *run, int id
Github user xiaozhongwang commented on a diff in the pull request:
https://github.com/apache/trafodion/pull/1394#discussion_r161911063
--- Diff: core/sqf/src/seatrans/tm/hbasetmlib2/hbasetm.h ---
@@ -139,9 +139,9 @@ class CHbaseTM : public JavaObjectInterfaceTM
GitHub user xiaozhongwang opened a pull request:
https://github.com/apache/trafodion/pull/1409
[TRAFODION-2919] fixed a negligible error when compile without setting
QT_TOOLKIT
make sure the QT_TOOLKIT set and execute the command as following:
cp -f ../$(basename $(CMPGUI_OBJ
GitHub user xiaozhongwang opened a pull request:
https://github.com/apache/trafodion/pull/1413
[TRAFODION-2802 ] source the .bashrc before access JAVA_HOME
modify for running on a new server
You can merge this pull request into a Git repository by running:
$ git pull https
Github user xiaozhongwang commented on a diff in the pull request:
https://github.com/apache/trafodion/pull/1413#discussion_r164020994
--- Diff: install/traf_checkset_env.sh ---
@@ -244,11 +244,14 @@ if [ ! -d ${javapath} ]; then
exit 1
fi
+source $HOME
GitHub user xiaozhongwang opened a pull request:
https://github.com/apache/trafodion/pull/1421
[TRAFODION-2936] nullpointer error where server return without value
we met a bug, when the server return without value, will make a null point
error.
You can merge this pull request
GitHub user xiaozhongwang opened a pull request:
https://github.com/apache/trafodion/pull/1440
[TRAFODION-2893] make this error when fixed the error checked by TScanCode
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
Github user xiaozhongwang commented on a diff in the pull request:
https://github.com/apache/trafodion/pull/1501#discussion_r177751339
--- Diff: win-odbc64/odbcclient/drvr35/cstmt.cpp ---
@@ -1063,7 +1063,20 @@ SQLRETURN CStmt::SendSQLCommand(BOOL SkipProcess,
SQLCHAR
Github user xiaozhongwang commented on a diff in the pull request:
https://github.com/apache/trafodion/pull/1499#discussion_r177487560
--- Diff:
core/conn/odbc/src/odbc/nsksrvr/Interface/linux/Listener_srvr_ps.cpp ---
@@ -263,7 +263,11 @@ void* CNSKListenerSrvr::OpenTCPIPSession
Github user xiaozhongwang commented on a diff in the pull request:
https://github.com/apache/trafodion/pull/1499#discussion_r177489126
--- Diff: dcs/src/main/java/org/trafodion/dcs/Constants.java ---
@@ -112,6 +112,29 @@
/** Default value for DCS server user program exit
Github user xiaozhongwang commented on a diff in the pull request:
https://github.com/apache/trafodion/pull/1499#discussion_r177485881
--- Diff: core/conn/odbc/src/odbc/Common/Global.h ---
@@ -139,10 +139,16 @@ class ODBCMXTraceMsg;
#define DEFAULT_REFRESH_RATE_SECS
Github user xiaozhongwang commented on a diff in the pull request:
https://github.com/apache/trafodion/pull/1499#discussion_r177483293
--- Diff: core/conn/odbc/src/odbc/Common/Global.h ---
@@ -935,7 +941,10 @@ typedef struct _SRVR_GLOBAL_Def
bzero(m_ProcName,sizeof
Github user xiaozhongwang commented on the pull request:
https://github.com/apache/trafodion/commit/a3971a2365d23f66303c0a33d36b70cb47fb6c21#commitcomment-28689713
+1 looks good for me
---
GitHub user xiaozhongwang opened a pull request:
https://github.com/apache/trafodion/pull/1534
[TRAFODION-3039] SendEventMsg is used in a wrong way
SendEventMsg use dynamic parameter.
And there is a parameter control the total, all of dynamic parameters are
string data type
Github user xiaozhongwang commented on a diff in the pull request:
https://github.com/apache/trafodion/pull/1562#discussion_r187753748
--- Diff: core/sqf/src/tm/tmlib.cpp ---
@@ -2817,35 +2833,44 @@ void TMLIB::initialize()
// This call has been changed so that the node
Github user xiaozhongwang commented on a diff in the pull request:
https://github.com/apache/trafodion/pull/1562#discussion_r187754295
--- Diff: core/sqf/src/tm/tmtransaction.cpp ---
@@ -797,7 +797,7 @@ short TM_Transaction::status(short *pp_status)
return
Github user xiaozhongwang commented on a diff in the pull request:
https://github.com/apache/trafodion/pull/1562#discussion_r187753028
--- Diff: core/sqf/src/tm/tmlib.cpp ---
@@ -2817,35 +2833,44 @@ void TMLIB::initialize()
// This call has been changed so that the node
Github user xiaozhongwang commented on a diff in the pull request:
https://github.com/apache/trafodion/pull/1562#discussion_r187752369
--- Diff: core/sqf/src/tm/tmlib.cpp ---
@@ -2470,7 +2482,7 @@ int16 TMWAIT()
TMlibTrace(("TMLIB_TRACE : TMWAIT ENTRY\n
Github user xiaozhongwang commented on a diff in the pull request:
https://github.com/apache/trafodion/pull/1562#discussion_r187841031
--- Diff: core/sqf/src/tm/tmtransaction.cpp ---
@@ -797,7 +797,7 @@ short TM_Transaction::status(short *pp_status)
return
Github user xiaozhongwang commented on a diff in the pull request:
https://github.com/apache/trafodion/pull/1534#discussion_r186468687
--- Diff: core/conn/odbc/src/odbc/nsksrvrcore/srvrothers.cpp ---
@@ -6533,6 +6533,8 @@ odbc_SQLSrvr_ExtractLob_sme_(
if (retcode
Github user xiaozhongwang commented on a diff in the pull request:
https://github.com/apache/trafodion/pull/1534#discussion_r191289403
--- Diff: core/conn/odbc/src/odbc/nsksrvrcore/srvrothers.cpp ---
@@ -6533,6 +6533,8 @@ odbc_SQLSrvr_ExtractLob_sme_(
if (retcode
GitHub user xiaozhongwang opened a pull request:
https://github.com/apache/trafodion/pull/1582
[TRAFODION-3039] SendEventMsg is used in a wrong way
SendEventMsg use dynamic parameter.
And there is a parameter control the total, all of dynamic parameters are
string data type
Github user xiaozhongwang closed the pull request at:
https://github.com/apache/trafodion/pull/1534
---
Github user xiaozhongwang commented on a diff in the pull request:
https://github.com/apache/trafodion/pull/1582#discussion_r191290915
--- Diff: core/conn/odbc/src/odbc/nsksrvrcore/srvrothers.cpp ---
@@ -6533,6 +6535,8 @@ odbc_SQLSrvr_ExtractLob_sme_(
if (retcode
Github user xiaozhongwang commented on a diff in the pull request:
https://github.com/apache/trafodion/pull/1671#discussion_r206444234
--- Diff: core/conn/odb/src/odb.c ---
@@ -40,6 +40,7 @@ char *odbauth = "Trafodion Dev
";
#define MAX_ARGS11 /* Max
Github user xiaozhongwang commented on a diff in the pull request:
https://github.com/apache/trafodion/pull/1671#discussion_r206460404
--- Diff: core/conn/odb/src/odb.c ---
@@ -40,6 +40,7 @@ char *odbauth = "Trafodion Dev
";
#define MAX_ARGS11 /* Max
37 matches
Mail list logo