[collectd] [PATCH] Fix strtok_r check in configure.in

2010-04-30 Thread collectd
From: Aurélien Reynaud The need for -D_REENTRANT was not correctly detected, because the warnings about undeclared functions do not cause the test program compilation to fail by default. The patch mainly adds -Werror to the CFLAGS during compilation of the test program to force the check to fail

Re: [collectd] [PATCH] Fix strtok_r check in configure.in

2010-04-30 Thread Peter Bray
Hi, On 30/04/10 07:16 PM, colle...@wattapower.net wrote: > +CFLAGS=$CFLAGS" -Werror" Surely there should be a "if" compiler is from the GNU Compiler Collection or you may break the Sun or Intel or ... Compilers. Regards, Peter ___ collectd mailing l

Re: [collectd] [PATCH] Fix strtok_r check in configure.in

2010-05-01 Thread Aurélien Reynaud
Le samedi 01 mai 2010 à 10:01 +0200, Florian Forster a écrit : > Hi, > > sorry for re-doing your work, but I felt it'd be best to mimic the > behavior of src/Makefile.am as closely as possible. I've therefore added > a check for GCC before the block and set "-Wall -Werror" if the compiler > is GCC

Re: [collectd] [PATCH] Fix strtok_r check in configure.in

2010-05-01 Thread Florian Forster
Hi, sorry for re-doing your work, but I felt it'd be best to mimic the behavior of src/Makefile.am as closely as possible. I've therefore added a check for GCC before the block and set "-Wall -Werror" if the compiler is GCC. Hope this works as intended.. Regards, —octo -- Florian octo Forster Ha