Script 'mail_helper' called by obssrc Hello community, here is the log from the commit of package udns for openSUSE:Factory checked in at 2024-05-15 21:28:41 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/udns (Old) and /work/SRC/openSUSE:Factory/.udns.new.1880 (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "udns" Wed May 15 21:28:41 2024 rev:4 rq:1174147 version:0.5 Changes: -------- --- /work/SRC/openSUSE:Factory/udns/udns.changes 2024-02-21 17:59:25.653836428 +0100 +++ /work/SRC/openSUSE:Factory/.udns.new.1880/udns.changes 2024-05-15 21:29:08.143105979 +0200 @@ -1,0 +2,16 @@ +Sun Mar 24 08:05:13 UTC 2024 - Luigi Baldoni <aloi...@gmx.com> + +- Update to version 0.5 (yes, this is a 10 years gap) + * bugfix: wrong init in dns_add_srch() resulting repeating + queries twice for non-existing domains. + * bugfix: typo: LDLAGS=>LDFLAGS. + * portability: include <sys/socket.h> before probing for + socket() et al, so modern compilers don't fail on + -Werror=missing-declarations + * remove a few compiler warnings + * remove debian/ dir from the release tarball + * multiple typo fixes +- Drop Fix-dns_add_srch-initialization-problem.patch (merged + upstream) + +------------------------------------------------------------------- Old: ---- Fix-dns_add_srch-initialization-problem.patch udns-0.4.tar.gz New: ---- udns-0.5.tar.gz BETA DEBUG BEGIN: Old: * multiple typo fixes - Drop Fix-dns_add_srch-initialization-problem.patch (merged upstream) BETA DEBUG END: ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ udns.spec ++++++ --- /var/tmp/diff_new_pack.dnW7MG/_old 2024-05-15 21:29:09.055138990 +0200 +++ /var/tmp/diff_new_pack.dnW7MG/_new 2024-05-15 21:29:09.059139135 +0200 @@ -1,7 +1,7 @@ # # spec file for package udns # -# Copyright (c) 2019 SUSE LINUX GmbH, Nuernberg, Germany. +# Copyright (c) 2024 SUSE LLC # # All modifications and additions to the file contributed by third parties # remain the property of their copyright owners, unless otherwise agreed @@ -17,15 +17,13 @@ Name: udns -Version: 0.4 +Version: 0.5 Release: 0 Summary: DNS resolver tools License: LGPL-2.1-or-later Group: Productivity/Networking/DNS/Utilities -URL: http://www.corpit.ru/mjt/udns.html -Source: http://www.corpit.ru/mjt/udns/udns-%{version}.tar.gz -# PATCH-FIX-UPSTREAM -- http://www.corpit.ru/pipermail/udns/2018q2/000186.html -Patch0: Fix-dns_add_srch-initialization-problem.patch +URL: https://www.corpit.ru/mjt/udns.html +Source: https://www.corpit.ru/mjt/udns/udns-%{version}.tar.gz %description UDNS is a stub DNS resolver library with ability to perform both ++++++ udns-0.4.tar.gz -> udns-0.5.tar.gz ++++++ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/udns-0.4/Makefile.in new/udns-0.5/Makefile.in --- old/udns-0.4/Makefile.in 2014-01-23 11:45:31.000000000 +0100 +++ new/udns-0.5/Makefile.in 2024-03-09 15:37:53.000000000 +0100 @@ -21,7 +21,7 @@ # Suite 330, Boston, MA 02111-1307 USA NAME = udns -VERS = 0.4 +VERS = 0.5 SOVER = 0 SRCS = udns_dn.c udns_dntosp.c udns_parse.c udns_resolver.c udns_init.c \ @@ -153,7 +153,7 @@ done >> Makefile.tmp; \ for f in $(USRCS:.c=.o); do \ echo "$${f%.?}: $$f \$$(LIB)"; \ - echo " \$$(LD) \$$(LDLAGS) -o \$$@ $$f \$$(LIBFL) \$$(LIBS)"; \ + echo " \$$(LD) \$$(LDFLAGS) -o \$$@ $$f \$$(LIBFL) \$$(LIBS)"; \ echo "$${f%.?}_s: $$f \$$(SOLIB)"; \ echo " \$$(LD) \$$(LDFLAGS) -o \$$@ $$f \$$(SOLIBFL)"; \ done >> Makefile.tmp ; \ @@ -184,14 +184,14 @@ rblcheck.o rblcheck.lo: rblcheck.c config.h udns.h getopt.c ex-rdns.o ex-rdns.lo: ex-rdns.c udns.h dnsget: dnsget.o $(LIB) - $(LD) $(LDLAGS) -o $@ dnsget.o $(LIBFL) $(LIBS) + $(LD) $(LDFLAGS) -o $@ dnsget.o $(LIBFL) $(LIBS) dnsget_s: dnsget.o $(SOLIB) $(LD) $(LDFLAGS) -o $@ dnsget.o $(SOLIBFL) rblcheck: rblcheck.o $(LIB) - $(LD) $(LDLAGS) -o $@ rblcheck.o $(LIBFL) $(LIBS) + $(LD) $(LDFLAGS) -o $@ rblcheck.o $(LIBFL) $(LIBS) rblcheck_s: rblcheck.o $(SOLIB) $(LD) $(LDFLAGS) -o $@ rblcheck.o $(SOLIBFL) ex-rdns: ex-rdns.o $(LIB) - $(LD) $(LDLAGS) -o $@ ex-rdns.o $(LIBFL) $(LIBS) + $(LD) $(LDFLAGS) -o $@ ex-rdns.o $(LIBFL) $(LIBS) ex-rdns_s: ex-rdns.o $(SOLIB) $(LD) $(LDFLAGS) -o $@ ex-rdns.o $(SOLIBFL) diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/udns-0.4/NEWS new/udns-0.5/NEWS --- old/udns-0.4/NEWS 2014-01-23 11:45:02.000000000 +0100 +++ new/udns-0.5/NEWS 2024-03-09 15:40:06.000000000 +0100 @@ -1,6 +1,22 @@ NEWS User-visible changes in udns library. Recent changes on top. +0.5 (Mar 2024) (yes this is a 10 years gap) + + - bugfix: wrong init in dns_add_srch() resulting repeating queries twice + for non-existing domains. Report and solution from Lennert Buytenhek + + - bugfix: typo: LDLAGS=>LDFLAGS. Report and solution from Christian Hesse + + - portability: include <sys/socket.h> before probing for socket() et al, + so modern compilers don't fail on -Werror=missing-declarations + + - remove a few compiler warnings + + - remove debian/ dir from the release tarball + + - multiple typo fixes + 0.4 (Jan 2014) - bugfix: fix a bug in new list code introduced in 0.3 diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/udns-0.4/configure new/udns-0.5/configure --- old/udns-0.4/configure 2014-01-18 13:34:00.000000000 +0100 +++ new/udns-0.5/configure 2024-03-03 10:26:10.000000000 +0100 @@ -75,7 +75,9 @@ EOF if ac_library_find_v 'socket and connect' "" "-lsocket -lnsl" <<EOF -int main() { socket(); connect(); return 0; } +#include <sys/types.h> +#include <sys/socket.h> +int main() { socket(0,0,0); connect(0,0,0); return 0; } EOF then : else diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/udns-0.4/dnsget.1 new/udns-0.5/dnsget.1 --- old/udns-0.4/dnsget.1 2014-01-18 13:34:00.000000000 +0100 +++ new/udns-0.5/dnsget.1 2024-03-09 15:35:57.000000000 +0100 @@ -182,7 +182,7 @@ .B dnsget exits with zero exit status. If at least one name was not found, .B dnsget -will exit with return code 100. If some other error occured during +will exit with return code 100. If some other error occurred during name resolution, it will exit with code 99. In case of usage or initialization error, .B dnsget diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/udns-0.4/dnsget.c new/udns-0.5/dnsget.c --- old/udns-0.4/dnsget.c 2011-12-29 13:58:40.000000000 +0100 +++ new/udns-0.5/dnsget.c 2024-03-04 08:22:12.000000000 +0100 @@ -414,6 +414,7 @@ struct dns_parse p; const unsigned char *cur, *end; int numqd; + (void)unused_q; (void)unused_data; /* avoid compiler warning */ if (code > 0) { printf(";; trying %s.\n", dns_dntosp(dns_payload(pkt))); @@ -492,7 +493,8 @@ p.dnsp_cur = p.dnsp_ans = cur; p.dnsp_end = end; p.dnsp_qdn = NULL; - p.dnsp_qcls = p.dnsp_qtyp = 0; + p.dnsp_qcls = 0; + p.dnsp_qtyp = 0; p.dnsp_ttl = 0xffffffffu; p.dnsp_nrr = 0; @@ -519,7 +521,8 @@ pkt = result; end = pkt + r; cur = dns_payload(pkt); dns_getdn(pkt, &cur, end, dn, sizeof(dn)); dns_initparse(&p, NULL, pkt, cur, end); - p.dnsp_qcls = p.dnsp_qtyp = 0; + p.dnsp_qcls = 0; + p.dnsp_qtyp = 0; nrr = 0; while((r = dns_nextrr(&p, &rr)) > 0) { if (!dns_dnequal(dn, rr.dnsrr_dn)) continue; diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/udns-0.4/rblcheck.1 new/udns-0.5/rblcheck.1 --- old/udns-0.4/rblcheck.1 2011-07-05 16:15:10.000000000 +0200 +++ new/udns-0.5/rblcheck.1 2024-03-09 15:35:57.000000000 +0100 @@ -45,7 +45,7 @@ .B \-s or .B \-S -options, optionally obtains text assotiated with the listing (usually it +options, optionally obtains text associated with the listing (usually it is either some description about the reason of the listing or an URL referring to such a description), and displays results on standard output. .PP @@ -105,7 +105,7 @@ found, it will exit unsuccessefully. .SH "RETURN VALUE" -When no addresses given are listed and no errors occured, +When no addresses given are listed and no errors occurred, .B rblcheck exits with code 0. If at least one address is listed, .B rblcheck diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/udns-0.4/rblcheck.c new/udns-0.5/rblcheck.c --- old/udns-0.4/rblcheck.c 2014-01-23 11:41:54.000000000 +0100 +++ new/udns-0.5/rblcheck.c 2024-03-04 08:22:18.000000000 +0100 @@ -44,7 +44,7 @@ # include "getopt.c" #endif -static const char *version = "udns-rblcheck 0.4"; +static const char *version = "udns-rblcheck " UDNS_VERSION; static char *progname; static void error(int die, const char *fmt, ...) { @@ -296,6 +296,7 @@ ++zgiven; if (addzonefile(optarg)) break; error(1, "unable to read zonefile `%s'", optarg); + break; /* avoid warning */ case 'c': ++zgiven; nzones = 0; break; case 'q': --verbose; break; case 'v': ++verbose; break; diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/udns-0.4/udns.3 new/udns-0.5/udns.3 --- old/udns-0.4/udns.3 2014-01-23 11:42:09.000000000 +0100 +++ new/udns-0.5/udns.3 2024-03-09 15:37:53.000000000 +0100 @@ -46,8 +46,8 @@ .PP The DNS library, \fBudns\fR, implements thread-safe stub DNS resolver -functionality, which may be used both traditional, syncronous way -and asyncronously, with application-supplied event loop. +functionality, which may be used both traditional, synchronous way +and asynchronously, with application-supplied event loop. .PP While DNS works with both TCP and UDP, performing UDP query first and @@ -58,7 +58,7 @@ .PP The library uses single UDP socket to perform all operations even when asking multiple nameservers. This way, it is very simple to use the -library in asyncronous event-loop applications: an application should +library in asynchronous event-loop applications: an application should add only single socket to the set of filedescriptors it monitors for I/O. .PP @@ -70,10 +70,10 @@ Query objects holds information about a single DNS query in progress and are allocated/processed/freed by the library. Pointer to query structure may be treated as an identifier of an in-progress query and may be used -to cancel the asyncronous query or to wait for it to complete. +to cancel the asynchronous query or to wait for it to complete. .PP -Asyncronous interface works as follows. An application initializes +Asynchronous interface works as follows. An application initializes resolver context, submits any number of queries for it using one of supplied \fBdns_submit_\fIXXX\fR() routines (each return the query identifier as pointer to query structure), waits for input on the @@ -90,31 +90,31 @@ routine\fR of type \fBdns_parse_fn\fR to perform conversion of on-wire format into easy to use data structure (the library provides parsing routines for several commonly used resource record types, as well as -type-safe higher-level inteface that requests parsing automatically). +type-safe higher-level interface that requests parsing automatically). The I/O monitoring and timeout handling may be either traditional select() or poll() based, or any callback-driven technique may be used. .PP -Additionally, the library provides traditional syncronous interface, -which may be intermixed with asyncronous calls (during syncronous -query processing, other asyncronous queries for the same resolver +Additionally, the library provides traditional synchronous interface, +which may be intermixed with asynchronous calls (during synchronous +query processing, other asynchronous queries for the same resolver context continued to be processed as usual). An application uses one of numerous \fBdns_resolve_\fIXXX\fR() routines provided by the -library to perform a query. As with asyncronous interface, an +library to perform a query. As with asynchronous interface, an application may either request to return raw DNS packet or type-specific data structure by providing the parsing routine to handle the reply. Every routine from \fBdns_resolve_\fIXXX\fR() series return pointer to result or NULL in case of any error. Query completion status (or length of the raw DNS packet) is available from the resolver context using \fBdns_status\fR() routine, the same way as for the -asyncronous interface. +asynchronous interface. .PP Internally, library uses on-wire format of domain names, referred to as \fIDN format\fR in this manual page. This is a series of domain -\fIlabels\fR whith preceeding length byte, terminated by zero-length -label wich is integral part of the DN format. There are several routines +\fIlabels\fR with preceding length byte, terminated by zero-length +label which is integral part of the DN format. There are several routines provided to convert from traditional asciiz string to DN and back. Higher-level type-specific query interface hides the DN format from an application. @@ -220,9 +220,9 @@ being copied should be initialized. \fBdns_new\fR() may fail if there's no memory available to make a copy of \fIcopy\fR, in which case the routine will return NULL pointer. -\fBdns_free\fR() is used to close assotiated socket and free resolver +\fBdns_free\fR() is used to close associated socket and free resolver context resources and cancelling (abandoming) all active queries -assotiated with it. It's an error to free \fBdns_defctx\fR, only +associated with it. It's an error to free \fBdns_defctx\fR, only dynamically allocated contexts returned by \fBdns_new\fR() are allowed to be freed by \fBdns_free\fR(). .RE @@ -280,7 +280,7 @@ .fi .RS \fBdns_open\fR() opens the UDP socket used for queries if not already -open, and return assotiated filedescriptor (or negative value in case +open, and return associated filedescriptor (or negative value in case of error). Before any query can be submitted, the context should be opened using this routine. And before opening, the context should be initialized. @@ -303,9 +303,9 @@ int \fBdns_status\fR(const \fIctx\fR) .fi .RS -return status code from last operation. When using syncronous +return status code from last operation. When using synchronous interface, this is the query completion status of the last query. -With asyncronous interface, from within the callback routine, +With asynchronous interface, from within the callback routine, this is the query completion status of the query for which the callback is being called. When query submission fails, this is the error code indicating failure reason. All error codes @@ -389,24 +389,24 @@ .SH "QUERY INTERFACE" .PP -There are two ways to perform DNS queries: traditional syncronous +There are two ways to perform DNS queries: traditional synchronous way, when udns performs all the necessary processing and return control to the application only when the query completes, and -asyncronous way, when an application submits one or more queries +asynchronous way, when an application submits one or more queries to the library using given resolver context, and waits for completion by monitoring filedescriptor used by library and calling library -routines to process input on that filedescriptor. Asyncronous mode +routines to process input on that filedescriptor. Asynchronous mode works with callback routines: an application supplies an address of a routine to execute when the query completes, and a data pointer, which is passed to the callback routine. .PP Queries are submitted to the library in a form of \fBstruct\ dns_query\fR. -To perform asyncronous query, an application calls one of the +To perform asynchronous query, an application calls one of the \fBdns_submit_\fIXXX\fR() rounines, and provides necessary information for a callback, together with all the query parameters. When the query completes, library will call application-supplied callback -routine, giving it the resolver context (wich holds query completion status), +routine, giving it the resolver context (which holds query completion status), dynamically allocated result (which will be either raw DNS packet or, if applicatin requested parsing the result by specifying non-NULL parse routine, ready-to-use type-specific structure), and a data pointer provided by an @@ -449,7 +449,7 @@ original query, by matching query DN, query class and query type. .PP -Type-specific query inteface supplies necessary parsing routines +Type-specific query interface supplies necessary parsing routines automatically. .PP @@ -477,11 +477,11 @@ .PP Library provides two series of routines which uses similar interface -- -one for asyncronous queries and another for syncronous queries. There -are two general low-level routines in each series to submit (asyncronous -interface) and resolve (syncronous interface) queries, as well as several +one for asynchronous queries and another for synchronous queries. There +are two general low-level routines in each series to submit (asynchronous +interface) and resolve (synchronous interface) queries, as well as several type-specific routines with more easy-to-use interfaces. To submit -an asyncronous query, use one of \fBdns_submit_\fIXXX\fR() routine, each +an asynchronous query, use one of \fBdns_submit_\fIXXX\fR() routine, each of which accepts query parameters, pointers to callback routine and to callback data, and optional current time hint. Note type-specific \fBdns_submit_\fIXXX\fR() routines expects specific type of the callback @@ -491,11 +491,11 @@ used as an identifier for the given query. .PP -To resolve a query syncronously, use one of \fBdns_resolve_\fIXXX\fR() +To resolve a query synchronously, use one of \fBdns_resolve_\fIXXX\fR() routines, which accepts the same query parameters (but not the callback pointers) as corresponding \fBdns_submit_\fIXXX\fR(), and return the query result, which is the same as passed to the callback -routine in case of asyncronous interface. +routine in case of asynchronous interface. .PP In either case, the result memory (if the query completed successefully) @@ -537,7 +537,7 @@ will be set to corresponding error code, which in this case may be DNS_E_BADQUERY if the \fIname\fR of \fIdn\fR is invalid, DNS_E_NOMEM if there's no memory available to allocate query structure, or DNS_E_TEMPFAIL -if an internal error occured. +if an internal error occurred. .RE .PP @@ -552,7 +552,7 @@ dns_parse_fn *\fIparse\fR; .fi .RS -syncronous interface. The routines perform all the steps necessary to resolve +synchronous interface. The routines perform all the steps necessary to resolve the given query and return the result. If there's no positive result for any reason, all the routines return NULL, and set context error status (available using \fBdns_status\fR() routine) to indicate the error code. If the query @@ -1144,7 +1144,7 @@ return various parts from the DNS packet header \fIpkt\fR: query identifier (qid), recursion desired (rd) flag, -truncation occured (tc) flag, +truncation occurred (tc) flag, authoritative answer (aa) flag, query response (qr) flag, recursion available (ra) flag, @@ -1201,7 +1201,7 @@ struct \fBdns_parse\fR { const unsigned char *\fBdnsp_pkt\fR; /* pointer to the packet being parsed */ const unsigned char *\fBdnsp_end\fR; /* end of the packet pointer */ - const unsigned char *\fBdnsp_cur\fR; /* current packet positionn */ + const unsigned char *\fBdnsp_cur\fR; /* current packet position */ const unsigned char *\fBdnsp_ans\fR; /* pointer to the answer section */ int \fBdnsp_rrl\fR; /* number of RRs left */ int \fBdnsp_nrr\fR; /* number of relevant RRs seen so far */ @@ -1349,4 +1349,4 @@ .SH VERSION .PP -This manual page corresponds to udns version 0.4, released Jan-2014. +This manual page corresponds to udns version 0.5, released Mar-2024. diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/udns-0.4/udns.h new/udns-0.5/udns.h --- old/udns-0.4/udns.h 2014-01-23 11:41:16.000000000 +0100 +++ new/udns-0.5/udns.h 2024-03-09 15:37:53.000000000 +0100 @@ -23,7 +23,7 @@ #ifndef UDNS_VERSION /* include guard */ -#define UDNS_VERSION "0.4" +#define UDNS_VERSION "0.5" #ifdef WINDOWS # ifdef UDNS_DYNAMIC_LIBRARY diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/udns-0.4/udns_init.c new/udns-0.5/udns_init.c --- old/udns-0.4/udns_init.c 2011-07-05 16:15:54.000000000 +0200 +++ new/udns-0.5/udns_init.c 2024-03-03 10:26:10.000000000 +0100 @@ -201,7 +201,7 @@ dns_set_opts(ctx, v); /* if still no search list, use local domain name */ - if (has_srch && + if (!has_srch && gethostname(buf, sizeof(buf) - 1) == 0 && (v = strchr(buf, '.')) != NULL && *++v != '\0') diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/udns-0.4/udns_resolver.c new/udns-0.5/udns_resolver.c --- old/udns-0.4/udns_resolver.c 2014-01-23 09:52:55.000000000 +0100 +++ new/udns-0.5/udns_resolver.c 2024-03-09 15:28:42.000000000 +0100 @@ -865,9 +865,10 @@ dns_send_this(ctx, q, q->dnsq_servi++, now); } -static void dns_dummy_cb(struct dns_ctx *ctx, void *result, void *data) { +static void +dns_dummy_cb(struct dns_ctx *unused_ctx, void *result, void *unused_data) { if (result) free(result); - data = ctx = 0; /* used */ + (void)unused_ctx; (void)unused_data; /* avoid warning */ } /* The (only, main, real) query submission routine. @@ -1258,8 +1259,8 @@ assert(ctx == q->dnsq_ctx); dns_assert_ctx(ctx); - /* do not allow re-resolving syncronous queries */ - assert(q->dnsq_cbck != dns_resolve_cb && "can't resolve syncronous query"); + /* do not allow re-resolving synchronous queries */ + assert(q->dnsq_cbck != dns_resolve_cb && "can't resolve synchronous query"); if (q->dnsq_cbck == dns_resolve_cb) { ctx->dnsc_qstatus = DNS_E_BADQUERY; return NULL; @@ -1311,8 +1312,8 @@ SETCTX(ctx); dns_assert_ctx(ctx); assert(q->dnsq_ctx == ctx); - /* do not allow cancelling syncronous queries */ - assert(q->dnsq_cbck != dns_resolve_cb && "can't cancel syncronous query"); + /* do not allow cancelling synchronous queries */ + assert(q->dnsq_cbck != dns_resolve_cb && "can't cancel synchronous query"); if (q->dnsq_cbck == dns_resolve_cb) return (ctx->dnsc_qstatus = DNS_E_BADQUERY); qlist_remove(&ctx->dnsc_qactive, q);
