Repository: activemq-artemis Updated Branches: refs/heads/master 3a3f678e5 -> 9b3a76630
Use sevntu-checkstyle check for required annotation parameters RequiredParameterForAnnotation available on Sevntu since https://github.com/sevntu-checkstyle/sevntu.checkstyle/issues/321 Project: http://git-wip-us.apache.org/repos/asf/activemq-artemis/repo Commit: http://git-wip-us.apache.org/repos/asf/activemq-artemis/commit/b3ed6fbd Tree: http://git-wip-us.apache.org/repos/asf/activemq-artemis/tree/b3ed6fbd Diff: http://git-wip-us.apache.org/repos/asf/activemq-artemis/diff/b3ed6fbd Branch: refs/heads/master Commit: b3ed6fbd431bed5e3b1a75feee0c749868a08075 Parents: 33a5122 Author: Ville Skyttä <ville.sky...@iki.fi> Authored: Tue Jun 14 00:34:55 2016 +0300 Committer: Clebert Suconic <clebertsuco...@apache.org> Committed: Tue Jun 14 20:50:21 2016 -0400 ---------------------------------------------------------------------- etc/checkstyle.xml | 11 ++++------- pom.xml | 8 -------- 2 files changed, 4 insertions(+), 15 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/b3ed6fbd/etc/checkstyle.xml ---------------------------------------------------------------------- diff --git a/etc/checkstyle.xml b/etc/checkstyle.xml index 0196e2a..bb266c5 100644 --- a/etc/checkstyle.xml +++ b/etc/checkstyle.xml @@ -94,13 +94,6 @@ under the License. <property name="illegalPkgs" value="junit.framework"/> </module> - <!-- TODO: Where to place this now? --> - <!-- developed at https://github.com/hornetq/hornetq-checkstyle-checks --> - <module name="org.hornetq.checks.annotation.RequiredAnnotation"> - <property name="annotationName" value="Parameters"/> - <property name="requiredParameters" value="name"/> - </module> - <module name="WriteTag"> <property name="tag" value="@author"/> <property name="tagSeverity" value="error"/> @@ -109,6 +102,10 @@ under the License. <!-- Sevntu checks, http://sevntu-checkstyle.github.io/sevntu.checkstyle/ --> <module name="DiamondOperatorForVariableDefinition"/> + <module name="RequiredParameterForAnnotation"> + <property name="annotationName" value="Parameterized.Parameters"/> + <property name="requiredParameters" value="name"/> + </module> </module> </module> http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/b3ed6fbd/pom.xml ---------------------------------------------------------------------- diff --git a/pom.xml b/pom.xml index 7254f20..f09b538 100644 --- a/pom.xml +++ b/pom.xml @@ -1067,14 +1067,6 @@ <artifactId>sevntu-checkstyle-maven-plugin</artifactId> <version>1.21.0</version> </dependency> - <!-- This was initially done to enforce name on Parameter annotation - I've developed a customized check and I needed this jar to deploy the specialized checkstyle --> - <dependency> - <!-- TODO Find a better home --> - <groupId>org.hornetq</groupId> - <artifactId>hornetq-checkstyle-checks</artifactId> - <version>0.2</version> - </dependency> </dependencies> <configuration> <skip>${skipStyleCheck}</skip>
