[GitHub] BasPH commented on issue #4383: [AIRFLOW-3475] Move ImportError out of models.py

2019-01-03 Thread GitBox
BasPH commented on issue #4383: [AIRFLOW-3475] Move ImportError out of models.py URL: https://github.com/apache/incubator-airflow/pull/4383#issuecomment-451226235 Good point. I'll rename to `errors.py`. @mik-laj There's one other error-class in models.py -> InvalidFernetToken. I

[GitHub] holdenk commented on a change in pull request #4383: [AIRFLOW-3475] Move ImportError out of models.py

2019-01-03 Thread GitBox
holdenk commented on a change in pull request #4383: [AIRFLOW-3475] Move ImportError out of models.py URL: https://github.com/apache/incubator-airflow/pull/4383#discussion_r245079483 ## File path: airflow/models/importerror.py ## @@ -0,0 +1,31 @@ +# -*- coding: utf-8 -*-

[GitHub] holdenk commented on a change in pull request #4315: [AIRFLOW-1381] Specify host temporary directory

2019-01-03 Thread GitBox
holdenk commented on a change in pull request #4315: [AIRFLOW-1381] Specify host temporary directory URL: https://github.com/apache/incubator-airflow/pull/4315#discussion_r245078479 ## File path: tests/operators/test_docker_operator.py ## @@ -57,6 +57,7 @@ def

[GitHub] potiuk commented on issue #4350: [AIRFLOW-3527] Cloud SQL Proxy has shorter path for UNIX socket

2019-01-03 Thread GitBox
potiuk commented on issue #4350: [AIRFLOW-3527] Cloud SQL Proxy has shorter path for UNIX socket URL: https://github.com/apache/incubator-airflow/pull/4350#issuecomment-451221439 @kaxil - fixed and rebased. This is an

[GitHub] codecov-io edited a comment on issue #4354: [AIRFLOW-3446] Add Google Cloud BigTable operators

2019-01-03 Thread GitBox
codecov-io edited a comment on issue #4354: [AIRFLOW-3446] Add Google Cloud BigTable operators URL: https://github.com/apache/incubator-airflow/pull/4354#issuecomment-450030796 # [Codecov](https://codecov.io/gh/apache/incubator-airflow/pull/4354?src=pr=h1) Report > Merging

[GitHub] potiuk commented on issue #4353: [AIRFLOW-3480] Add Database Deploy/Update/Delete operators

2019-01-03 Thread GitBox
potiuk commented on issue #4353: [AIRFLOW-3480] Add Database Deploy/Update/Delete operators URL: https://github.com/apache/incubator-airflow/pull/4353#issuecomment-451207010 @kaxil -> implemented most of it. I again proposed to make project_id optional as separate change (we have some

[jira] [Commented] (AIRFLOW-3622) Add ability to pass hive_conf to HiveToMySqlTransfer

2019-01-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16733224#comment-16733224 ] ASF GitHub Bot commented on AIRFLOW-3622: - aliceabe commented on pull request #4432:

[GitHub] aliceabe opened a new pull request #4432: [AIRFLOW-3622] Add ability to pass hive_conf to HiveToMysqlTransfer

2019-01-03 Thread GitBox
aliceabe opened a new pull request #4432: [AIRFLOW-3622] Add ability to pass hive_conf to HiveToMysqlTransfer URL: https://github.com/apache/incubator-airflow/pull/4432 ### Jira - [x] My PR addresses the following Airflow Jira issues and references them in the PR title. -

[GitHub] potiuk commented on a change in pull request #4353: [AIRFLOW-3480] Add Database Deploy/Update/Delete operators

2019-01-03 Thread GitBox
potiuk commented on a change in pull request #4353: [AIRFLOW-3480] Add Database Deploy/Update/Delete operators URL: https://github.com/apache/incubator-airflow/pull/4353#discussion_r245064704 ## File path: docs/integration.rst ## @@ -687,11 +687,40 @@ Cloud Spanner Cloud

[GitHub] potiuk commented on a change in pull request #4353: [AIRFLOW-3480] Add Database Deploy/Update/Delete operators

2019-01-03 Thread GitBox
potiuk commented on a change in pull request #4353: [AIRFLOW-3480] Add Database Deploy/Update/Delete operators URL: https://github.com/apache/incubator-airflow/pull/4353#discussion_r245064308 ## File path: airflow/contrib/operators/gcp_spanner_operator.py ## @@ -197,3

[GitHub] potiuk commented on a change in pull request #4353: [AIRFLOW-3480] Add Database Deploy/Update/Delete operators

2019-01-03 Thread GitBox
potiuk commented on a change in pull request #4353: [AIRFLOW-3480] Add Database Deploy/Update/Delete operators URL: https://github.com/apache/incubator-airflow/pull/4353#discussion_r245064252 ## File path: airflow/contrib/operators/gcp_spanner_operator.py ## @@ -197,3

[GitHub] potiuk commented on a change in pull request #4353: [AIRFLOW-3480] Add Database Deploy/Update/Delete operators

2019-01-03 Thread GitBox
potiuk commented on a change in pull request #4353: [AIRFLOW-3480] Add Database Deploy/Update/Delete operators URL: https://github.com/apache/incubator-airflow/pull/4353#discussion_r245064016 ## File path: airflow/contrib/operators/gcp_spanner_operator.py ## @@ -197,3

[GitHub] potiuk commented on a change in pull request #4353: [AIRFLOW-3480] Add Database Deploy/Update/Delete operators

2019-01-03 Thread GitBox
potiuk commented on a change in pull request #4353: [AIRFLOW-3480] Add Database Deploy/Update/Delete operators URL: https://github.com/apache/incubator-airflow/pull/4353#discussion_r245063993 ## File path: airflow/contrib/operators/gcp_spanner_operator.py ## @@ -197,3

[GitHub] potiuk commented on a change in pull request #4353: [AIRFLOW-3480] Add Database Deploy/Update/Delete operators

2019-01-03 Thread GitBox
potiuk commented on a change in pull request #4353: [AIRFLOW-3480] Add Database Deploy/Update/Delete operators URL: https://github.com/apache/incubator-airflow/pull/4353#discussion_r245063552 ## File path: airflow/contrib/operators/gcp_spanner_operator.py ## @@ -197,3

[GitHub] potiuk commented on a change in pull request #4353: [AIRFLOW-3480] Add Database Deploy/Update/Delete operators

2019-01-03 Thread GitBox
potiuk commented on a change in pull request #4353: [AIRFLOW-3480] Add Database Deploy/Update/Delete operators URL: https://github.com/apache/incubator-airflow/pull/4353#discussion_r245062825 ## File path: airflow/contrib/operators/gcp_spanner_operator.py ## @@ -197,3

[GitHub] potiuk commented on a change in pull request #4353: [AIRFLOW-3480] Add Database Deploy/Update/Delete operators

2019-01-03 Thread GitBox
potiuk commented on a change in pull request #4353: [AIRFLOW-3480] Add Database Deploy/Update/Delete operators URL: https://github.com/apache/incubator-airflow/pull/4353#discussion_r245062261 ## File path: airflow/contrib/operators/gcp_spanner_operator.py ## @@ -197,3

[GitHub] potiuk commented on a change in pull request #4353: [AIRFLOW-3480] Add Database Deploy/Update/Delete operators

2019-01-03 Thread GitBox
potiuk commented on a change in pull request #4353: [AIRFLOW-3480] Add Database Deploy/Update/Delete operators URL: https://github.com/apache/incubator-airflow/pull/4353#discussion_r245062137 ## File path: airflow/contrib/hooks/gcp_spanner_hook.py ## @@ -168,39 +168,175

[jira] [Commented] (AIRFLOW-3622) Add ability to pass hive_conf to HiveToMySqlTransfer

2019-01-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16733213#comment-16733213 ] ASF GitHub Bot commented on AIRFLOW-3622: - aliceabe commented on pull request #4424:

[GitHub] potiuk commented on issue #4354: [AIRFLOW-3446] Add Google Cloud BigTable operators

2019-01-03 Thread GitBox
potiuk commented on issue #4354: [AIRFLOW-3446] Add Google Cloud BigTable operators URL: https://github.com/apache/incubator-airflow/pull/4354#issuecomment-451197461 I fixed most of the changes @kaxil and propose to defer some of the proposed changes to later commit - covering more

[GitHub] potiuk commented on a change in pull request #4354: [AIRFLOW-3446] Add Google Cloud BigTable operators

2019-01-03 Thread GitBox
potiuk commented on a change in pull request #4354: [AIRFLOW-3446] Add Google Cloud BigTable operators URL: https://github.com/apache/incubator-airflow/pull/4354#discussion_r245054566 ## File path: docs/integration.rst ## @@ -814,6 +815,69 @@ Cloud SQL Hooks

[GitHub] potiuk commented on a change in pull request #4354: [AIRFLOW-3446] Add Google Cloud BigTable operators

2019-01-03 Thread GitBox
potiuk commented on a change in pull request #4354: [AIRFLOW-3446] Add Google Cloud BigTable operators URL: https://github.com/apache/incubator-airflow/pull/4354#discussion_r245054220 ## File path: docs/howto/operator.rst ## @@ -361,6 +361,135 @@ More information See

[GitHub] potiuk commented on a change in pull request #4354: [AIRFLOW-3446] Add Google Cloud BigTable operators

2019-01-03 Thread GitBox
potiuk commented on a change in pull request #4354: [AIRFLOW-3446] Add Google Cloud BigTable operators URL: https://github.com/apache/incubator-airflow/pull/4354#discussion_r245054313 ## File path: docs/howto/operator.rst ## @@ -361,6 +361,135 @@ More information See

[GitHub] potiuk commented on a change in pull request #4354: [AIRFLOW-3446] Add Google Cloud BigTable operators

2019-01-03 Thread GitBox
potiuk commented on a change in pull request #4354: [AIRFLOW-3446] Add Google Cloud BigTable operators URL: https://github.com/apache/incubator-airflow/pull/4354#discussion_r245054254 ## File path: docs/howto/operator.rst ## @@ -361,6 +361,135 @@ More information See

[GitHub] potiuk commented on a change in pull request #4354: [AIRFLOW-3446] Add Google Cloud BigTable operators

2019-01-03 Thread GitBox
potiuk commented on a change in pull request #4354: [AIRFLOW-3446] Add Google Cloud BigTable operators URL: https://github.com/apache/incubator-airflow/pull/4354#discussion_r245054132 ## File path: docs/howto/operator.rst ## @@ -361,6 +361,135 @@ More information See

[GitHub] potiuk commented on a change in pull request #4354: [AIRFLOW-3446] Add Google Cloud BigTable operators

2019-01-03 Thread GitBox
potiuk commented on a change in pull request #4354: [AIRFLOW-3446] Add Google Cloud BigTable operators URL: https://github.com/apache/incubator-airflow/pull/4354#discussion_r245053584 ## File path: airflow/contrib/operators/gcp_bigtable_operator.py ## @@ -0,0 +1,424 @@ +#

[GitHub] potiuk commented on a change in pull request #4354: [AIRFLOW-3446] Add Google Cloud BigTable operators

2019-01-03 Thread GitBox
potiuk commented on a change in pull request #4354: [AIRFLOW-3446] Add Google Cloud BigTable operators URL: https://github.com/apache/incubator-airflow/pull/4354#discussion_r245053453 ## File path: airflow/contrib/operators/gcp_bigtable_operator.py ## @@ -0,0 +1,424 @@ +#

[GitHub] potiuk commented on a change in pull request #4354: [AIRFLOW-3446] Add Google Cloud BigTable operators

2019-01-03 Thread GitBox
potiuk commented on a change in pull request #4354: [AIRFLOW-3446] Add Google Cloud BigTable operators URL: https://github.com/apache/incubator-airflow/pull/4354#discussion_r245053375 ## File path: airflow/contrib/operators/gcp_bigtable_operator.py ## @@ -0,0 +1,424 @@ +#

[GitHub] potiuk commented on a change in pull request #4354: [AIRFLOW-3446] Add Google Cloud BigTable operators

2019-01-03 Thread GitBox
potiuk commented on a change in pull request #4354: [AIRFLOW-3446] Add Google Cloud BigTable operators URL: https://github.com/apache/incubator-airflow/pull/4354#discussion_r245052764 ## File path: airflow/contrib/hooks/gcp_bigtable_hook.py ## @@ -0,0 +1,232 @@ +# -*-

[GitHub] potiuk commented on a change in pull request #4354: [AIRFLOW-3446] Add Google Cloud BigTable operators

2019-01-03 Thread GitBox
potiuk commented on a change in pull request #4354: [AIRFLOW-3446] Add Google Cloud BigTable operators URL: https://github.com/apache/incubator-airflow/pull/4354#discussion_r245052802 ## File path: airflow/contrib/hooks/gcp_bigtable_hook.py ## @@ -0,0 +1,232 @@ +# -*-

[GitHub] potiuk commented on a change in pull request #4354: [AIRFLOW-3446] Add Google Cloud BigTable operators

2019-01-03 Thread GitBox
potiuk commented on a change in pull request #4354: [AIRFLOW-3446] Add Google Cloud BigTable operators URL: https://github.com/apache/incubator-airflow/pull/4354#discussion_r245052727 ## File path: airflow/contrib/hooks/gcp_bigtable_hook.py ## @@ -0,0 +1,232 @@ +# -*-

[GitHub] potiuk commented on a change in pull request #4354: [AIRFLOW-3446] Add Google Cloud BigTable operators

2019-01-03 Thread GitBox
potiuk commented on a change in pull request #4354: [AIRFLOW-3446] Add Google Cloud BigTable operators URL: https://github.com/apache/incubator-airflow/pull/4354#discussion_r245051859 ## File path: airflow/contrib/hooks/gcp_bigtable_hook.py ## @@ -0,0 +1,232 @@ +# -*-

[GitHub] potiuk commented on a change in pull request #4354: [AIRFLOW-3446] Add Google Cloud BigTable operators

2019-01-03 Thread GitBox
potiuk commented on a change in pull request #4354: [AIRFLOW-3446] Add Google Cloud BigTable operators URL: https://github.com/apache/incubator-airflow/pull/4354#discussion_r245048542 ## File path: airflow/contrib/example_dags/example_gcp_bigtable_operators.py ## @@ -0,0

[GitHub] yohei1126 commented on issue #4409: WIP [AIRFLOW-3601] add location support to BigQuery operators

2019-01-03 Thread GitBox
yohei1126 commented on issue #4409: WIP [AIRFLOW-3601] add location support to BigQuery operators URL: https://github.com/apache/incubator-airflow/pull/4409#issuecomment-451161146 @ron819 Thanks! This is an automated

[GitHub] ron819 commented on issue #4409: WIP [AIRFLOW-3601] add location support to BigQuery operators

2019-01-03 Thread GitBox
ron819 commented on issue #4409: WIP [AIRFLOW-3601] add location support to BigQuery operators URL: https://github.com/apache/incubator-airflow/pull/4409#issuecomment-451156015 @yohei1126 Yep https://github.com/apache/incubator-airflow/blob/master/CONTRIBUTING.md#running-unit-tests

[GitHub] yohei1126 commented on issue #4409: WIP [AIRFLOW-3601] add location support to BigQuery operators

2019-01-03 Thread GitBox
yohei1126 commented on issue #4409: WIP [AIRFLOW-3601] add location support to BigQuery operators URL: https://github.com/apache/incubator-airflow/pull/4409#issuecomment-451154605 @kaxil Is there any instruction to run specific test locally? I want to debug the following error.

[GitHub] XD-DENG commented on a change in pull request #4429: [AIRFLOW-3625] Add Redis Cluster support

2019-01-03 Thread GitBox
XD-DENG commented on a change in pull request #4429: [AIRFLOW-3625] Add Redis Cluster support URL: https://github.com/apache/incubator-airflow/pull/4429#discussion_r244997560 ## File path: airflow/contrib/hooks/redis_cluster_hook.py ## @@ -0,0 +1,86 @@ +# -*- coding:

[GitHub] XD-DENG commented on a change in pull request #4429: [AIRFLOW-3625] Add Redis Cluster support

2019-01-03 Thread GitBox
XD-DENG commented on a change in pull request #4429: [AIRFLOW-3625] Add Redis Cluster support URL: https://github.com/apache/incubator-airflow/pull/4429#discussion_r244998237 ## File path: airflow/contrib/sensors/redis_cluster_key_sensor.py ## @@ -0,0 +1,39 @@ +# -*-

[GitHub] XD-DENG commented on a change in pull request #4429: [AIRFLOW-3625] Add Redis Cluster support

2019-01-03 Thread GitBox
XD-DENG commented on a change in pull request #4429: [AIRFLOW-3625] Add Redis Cluster support URL: https://github.com/apache/incubator-airflow/pull/4429#discussion_r244998030 ## File path: airflow/contrib/hooks/redis_cluster_hook.py ## @@ -0,0 +1,86 @@ +# -*- coding:

[GitHub] XD-DENG commented on a change in pull request #4429: [AIRFLOW-3625] Add Redis Cluster support

2019-01-03 Thread GitBox
XD-DENG commented on a change in pull request #4429: [AIRFLOW-3625] Add Redis Cluster support URL: https://github.com/apache/incubator-airflow/pull/4429#discussion_r244997391 ## File path: airflow/contrib/hooks/redis_cluster_hook.py ## @@ -0,0 +1,86 @@ +# -*- coding:

[GitHub] XD-DENG commented on a change in pull request #4429: [AIRFLOW-3625] Add Redis Cluster support

2019-01-03 Thread GitBox
XD-DENG commented on a change in pull request #4429: [AIRFLOW-3625] Add Redis Cluster support URL: https://github.com/apache/incubator-airflow/pull/4429#discussion_r244997944 ## File path: airflow/contrib/hooks/redis_cluster_hook.py ## @@ -0,0 +1,86 @@ +# -*- coding:

[GitHub] XD-DENG commented on a change in pull request #4429: [AIRFLOW-3625] Add Redis Cluster support

2019-01-03 Thread GitBox
XD-DENG commented on a change in pull request #4429: [AIRFLOW-3625] Add Redis Cluster support URL: https://github.com/apache/incubator-airflow/pull/4429#discussion_r244996936 ## File path: airflow/contrib/hooks/redis_cluster_hook.py ## @@ -0,0 +1,86 @@ +# -*- coding:

[GitHub] XD-DENG commented on a change in pull request #4429: [AIRFLOW-3625] Add Redis Cluster support

2019-01-03 Thread GitBox
XD-DENG commented on a change in pull request #4429: [AIRFLOW-3625] Add Redis Cluster support URL: https://github.com/apache/incubator-airflow/pull/4429#discussion_r244997369 ## File path: airflow/contrib/hooks/redis_cluster_hook.py ## @@ -0,0 +1,86 @@ +# -*- coding:

[GitHub] ron819 commented on issue #2052: [AIRFLOW-833] Add an `airflow default_config` sub-command

2019-01-03 Thread GitBox
ron819 commented on issue #2052: [AIRFLOW-833] Add an `airflow default_config` sub-command URL: https://github.com/apache/incubator-airflow/pull/2052#issuecomment-451140136 @gsakkis note that your code apply changes to the old UI which will be deprecated once

[jira] [Updated] (AIRFLOW-3626) Unable to Trigger Zipped Dags through API

2019-01-03 Thread Shubham Parekh (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3626?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shubham Parekh updated AIRFLOW-3626: Priority: Minor (was: Major) > Unable to Trigger Zipped Dags through API >

[GitHub] ron819 edited a comment on issue #2256: [AIRFLOW-1153] Fix issue ' params ' don't pass to HiveOperator execution context

2019-01-03 Thread GitBox
ron819 edited a comment on issue #2256: [AIRFLOW-1153] Fix issue ' params ' don't pass to HiveOperator execution context URL: https://github.com/apache/incubator-airflow/pull/2256#issuecomment-451130937 @xianping Please resolve the conflicts and squash the commits. Once done it will

[GitHub] ron819 commented on issue #2256: [AIRFLOW-1153] Fix issue ' params ' don't pass to HiveOperator execution context

2019-01-03 Thread GitBox
ron819 commented on issue #2256: [AIRFLOW-1153] Fix issue ' params ' don't pass to HiveOperator execution context URL: https://github.com/apache/incubator-airflow/pull/2256#issuecomment-451130937 @xianping Please resolve the conflicts and squash the commits. Once done it can be

[GitHub] canyousayyes commented on issue #4429: [AIRFLOW-3625] Add Redis Cluster support

2019-01-03 Thread GitBox
canyousayyes commented on issue #4429: [AIRFLOW-3625] Add Redis Cluster support URL: https://github.com/apache/incubator-airflow/pull/4429#issuecomment-451128118 I found that Travis build failed due to this: ``` 5.6: Pulling from library/mysql ERROR: error pulling image

[jira] [Updated] (AIRFLOW-3626) Unable to Trigger Zipped Dags through API

2019-01-03 Thread Shubham Parekh (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3626?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shubham Parekh updated AIRFLOW-3626: Summary: Unable to Trigger Zipped Dags through API (was: Unable to Trigger Zipped Dags)

[jira] [Created] (AIRFLOW-3626) Unable to Trigger Zipped Dags

2019-01-03 Thread Shubham Parekh (JIRA)
Shubham Parekh created AIRFLOW-3626: --- Summary: Unable to Trigger Zipped Dags Key: AIRFLOW-3626 URL: https://issues.apache.org/jira/browse/AIRFLOW-3626 Project: Apache Airflow Issue Type:

[GitHub] codecov-io edited a comment on issue #4339: [AIRFLOW-3303] Deprecate old UI in favor of FAB

2019-01-03 Thread GitBox
codecov-io edited a comment on issue #4339: [AIRFLOW-3303] Deprecate old UI in favor of FAB URL: https://github.com/apache/incubator-airflow/pull/4339#issuecomment-448180107 # [Codecov](https://codecov.io/gh/apache/incubator-airflow/pull/4339?src=pr=h1) Report > Merging

[GitHub] codecov-io edited a comment on issue #4339: [AIRFLOW-3303] Deprecate old UI in favor of FAB

2019-01-03 Thread GitBox
codecov-io edited a comment on issue #4339: [AIRFLOW-3303] Deprecate old UI in favor of FAB URL: https://github.com/apache/incubator-airflow/pull/4339#issuecomment-448180107 # [Codecov](https://codecov.io/gh/apache/incubator-airflow/pull/4339?src=pr=h1) Report > Merging

[GitHub] codecov-io edited a comment on issue #4430: AIRFLOW-3316 be sure to initialize schema_fields variable

2019-01-03 Thread GitBox
codecov-io edited a comment on issue #4430: AIRFLOW-3316 be sure to initialize schema_fields variable URL: https://github.com/apache/incubator-airflow/pull/4430#issuecomment-45215 # [Codecov](https://codecov.io/gh/apache/incubator-airflow/pull/4430?src=pr=h1) Report > Merging

[GitHub] codecov-io commented on issue #4430: AIRFLOW-3316 be sure to initialize schema_fields variable

2019-01-03 Thread GitBox
codecov-io commented on issue #4430: AIRFLOW-3316 be sure to initialize schema_fields variable URL: https://github.com/apache/incubator-airflow/pull/4430#issuecomment-45215 # [Codecov](https://codecov.io/gh/apache/incubator-airflow/pull/4430?src=pr=h1) Report > Merging

[GitHub] kaxil closed pull request #4431: [AIRFLOW-XXX] Fix WeekDay Sensor Example

2019-01-03 Thread GitBox
kaxil closed pull request #4431: [AIRFLOW-XXX] Fix WeekDay Sensor Example URL: https://github.com/apache/incubator-airflow/pull/4431 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] kaxil opened a new pull request #4431: [AIRFLOW-XXX] Fix WeekDay Sensor Example

2019-01-03 Thread GitBox
kaxil opened a new pull request #4431: [AIRFLOW-XXX] Fix WeekDay Sensor Example URL: https://github.com/apache/incubator-airflow/pull/4431 Make sure you have checked _all_ steps below. ### Jira - [x] My PR addresses the following [Airflow

[GitHub] XD-DENG commented on a change in pull request #4421: [AIRFLOW-3468] Remove KnownEvent(Event)?

2019-01-03 Thread GitBox
XD-DENG commented on a change in pull request #4421: [AIRFLOW-3468] Remove KnownEvent(Event)? URL: https://github.com/apache/incubator-airflow/pull/4421#discussion_r244964036 ## File path: airflow/models/__init__.py ## @@ -4376,37 +4376,6 @@ def __repr__(self):

[GitHub] shubhparekh commented on issue #3590: [AIRFLOW-2614] in trigger_dag API making the DagBag to load specific DAG instead of loading all the dags

2019-01-03 Thread GitBox
shubhparekh commented on issue #3590: [AIRFLOW-2614] in trigger_dag API making the DagBag to load specific DAG instead of loading all the dags URL: https://github.com/apache/incubator-airflow/pull/3590#issuecomment-451107850 This commit breaks for Zipped dags. Since dag_model.fileloc is

[GitHub] verdan commented on a change in pull request #4339: [AIRFLOW-3303] Deprecate old UI in favor of FAB

2019-01-03 Thread GitBox
verdan commented on a change in pull request #4339: [AIRFLOW-3303] Deprecate old UI in favor of FAB URL: https://github.com/apache/incubator-airflow/pull/4339#discussion_r244955249 ## File path: airflow/bin/cli.py ## @@ -888,7 +882,7 @@ def webserver(args):

[jira] [Commented] (AIRFLOW-3316) GCS to BQ operator leaves schema_fields operator unset when autodetect=True

2019-01-03 Thread Conrad Lee (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16732848#comment-16732848 ] Conrad Lee commented on AIRFLOW-3316: - Hi [~jackjack10].  I think the conditions in the if

[GitHub] conradlee opened a new pull request #4430: AIRFLOW-3316 be sure to initialize schema_fields variable

2019-01-03 Thread GitBox
conradlee opened a new pull request #4430: AIRFLOW-3316 be sure to initialize schema_fields variable URL: https://github.com/apache/incubator-airflow/pull/4430 Make sure you have checked _all_ steps below. ### Jira - [X] My PR addresses the following [Airflow

[jira] [Commented] (AIRFLOW-3316) GCS to BQ operator leaves schema_fields operator unset when autodetect=True

2019-01-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16732845#comment-16732845 ] ASF GitHub Bot commented on AIRFLOW-3316: - conradlee commented on pull request #4430:

[jira] [Assigned] (AIRFLOW-3607) Decreasing scheduler delay between tasks

2019-01-03 Thread Anonymous (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3607?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anonymous reassigned AIRFLOW-3607: -- Assignee: Amichai Horvitz (was: Dan Davydov) > Decreasing scheduler delay between tasks >

[GitHub] canyousayyes opened a new pull request #4429: [AIRFLOW-3625] Add Redis Cluster support

2019-01-03 Thread GitBox
canyousayyes opened a new pull request #4429: [AIRFLOW-3625] Add Redis Cluster support URL: https://github.com/apache/incubator-airflow/pull/4429 Make sure you have checked _all_ steps below. ### Jira - [x] My PR addresses the following [Airflow

[jira] [Comment Edited] (AIRFLOW-3316) GCS to BQ operator leaves schema_fields operator unset when autodetect=True

2019-01-03 Thread jack (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16732810#comment-16732810 ] jack edited comment on AIRFLOW-3316 at 1/3/19 9:42 AM: --- I think I see the

[jira] [Commented] (AIRFLOW-3625) Support for Redis Cluster

2019-01-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16732821#comment-16732821 ] ASF GitHub Bot commented on AIRFLOW-3625: - canyousayyes commented on pull request #4429:

[jira] [Commented] (AIRFLOW-3316) GCS to BQ operator leaves schema_fields operator unset when autodetect=True

2019-01-03 Thread jack (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16732810#comment-16732810 ] jack commented on AIRFLOW-3316: --- I think I see the problem. self.schema_fields will be set to None in

[jira] [Comment Edited] (AIRFLOW-3316) GCS to BQ operator leaves schema_fields operator unset when autodetect=True

2019-01-03 Thread jack (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16732810#comment-16732810 ] jack edited comment on AIRFLOW-3316 at 1/3/19 9:41 AM: --- I think I see the

[jira] [Commented] (AIRFLOW-3316) GCS to BQ operator leaves schema_fields operator unset when autodetect=True

2019-01-03 Thread Conrad Lee (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16732793#comment-16732793 ] Conrad Lee commented on AIRFLOW-3316: - [~jackjack10] here is the source code in my dag for the task

[GitHub] Fokko closed pull request #4363: [AIRFLOW-3560] Add DayOfWeek Sensor

2019-01-03 Thread GitBox
Fokko closed pull request #4363: [AIRFLOW-3560] Add DayOfWeek Sensor URL: https://github.com/apache/incubator-airflow/pull/4363 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign

[jira] [Commented] (AIRFLOW-3560) Add Sensor that polls until a day of the week

2019-01-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16732807#comment-16732807 ] ASF GitHub Bot commented on AIRFLOW-3560: - Fokko commented on pull request #4363:

[jira] [Updated] (AIRFLOW-3560) Add Sensor that polls until a day of the week

2019-01-03 Thread Fokko Driesprong (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3560?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fokko Driesprong updated AIRFLOW-3560: -- Fix Version/s: 2.0.0 > Add Sensor that polls until a day of the week >

[jira] [Resolved] (AIRFLOW-3560) Add Sensor that polls until a day of the week

2019-01-03 Thread Fokko Driesprong (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3560?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fokko Driesprong resolved AIRFLOW-3560. --- Resolution: Fixed > Add Sensor that polls until a day of the week >

[GitHub] Fokko commented on issue #4339: [AIRFLOW-3303] Deprecate old UI in favor of FAB

2019-01-03 Thread GitBox
Fokko commented on issue #4339: [AIRFLOW-3303] Deprecate old UI in favor of FAB URL: https://github.com/apache/incubator-airflow/pull/4339#issuecomment-451092649 @ashb Are you okay with merging this on a short term? Otherwise, we'll end up with merge conflicts again.

[GitHub] Fokko commented on a change in pull request #4339: [AIRFLOW-3303] Deprecate old UI in favor of FAB

2019-01-03 Thread GitBox
Fokko commented on a change in pull request #4339: [AIRFLOW-3303] Deprecate old UI in favor of FAB URL: https://github.com/apache/incubator-airflow/pull/4339#discussion_r244944884 ## File path: airflow/bin/cli.py ## @@ -888,7 +882,7 @@ def webserver(args):

[jira] [Created] (AIRFLOW-3625) Support for Redis Cluster

2019-01-03 Thread Gene Ng (JIRA)
Gene Ng created AIRFLOW-3625: Summary: Support for Redis Cluster Key: AIRFLOW-3625 URL: https://issues.apache.org/jira/browse/AIRFLOW-3625 Project: Apache Airflow Issue Type: Improvement

[GitHub] jgao54 commented on issue #4423: [AIRFLOW-3618] - Fix models.connection.Connection get_hook function

2019-01-03 Thread GitBox
jgao54 commented on issue #4423: [AIRFLOW-3618] - Fix models.connection.Connection get_hook function URL: https://github.com/apache/incubator-airflow/pull/4423#issuecomment-451090738 All the conn type are defined

[jira] [Comment Edited] (AIRFLOW-3316) GCS to BQ operator leaves schema_fields operator unset when autodetect=True

2019-01-03 Thread Conrad Lee (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16732794#comment-16732794 ] Conrad Lee edited comment on AIRFLOW-3316 at 1/3/19 9:22 AM: - [~jackjack10]

[jira] [Commented] (AIRFLOW-3316) GCS to BQ operator leaves schema_fields operator unset when autodetect=True

2019-01-03 Thread Conrad Lee (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16732794#comment-16732794 ] Conrad Lee commented on AIRFLOW-3316: - [~jackjack10] here is the source code in my dag for the task

[jira] [Updated] (AIRFLOW-3624) Add masterType parameter to MLEngineTrainingOperator

2019-01-03 Thread K.K. POON (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3624?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] K.K. POON updated AIRFLOW-3624: --- Labels: pull-request-available (was: ) > Add masterType parameter to MLEngineTrainingOperator >

[jira] [Assigned] (AIRFLOW-3615) Connection parsed from URI - case-insensitive UNIX socket paths in python 2.7 -> 3.5 (but not in 3.6)

2019-01-03 Thread Jarek Potiuk (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3615?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jarek Potiuk reassigned AIRFLOW-3615: - Assignee: Jarek Potiuk > Connection parsed from URI - case-insensitive UNIX socket

[jira] [Commented] (AIRFLOW-3624) Add masterType parameter to MLEngineTrainingOperator

2019-01-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16732784#comment-16732784 ] ASF GitHub Bot commented on AIRFLOW-3624: - kkpoon commented on pull request #4428:

[GitHub] kkpoon opened a new pull request #4428: [AIRFLOW-3624] Add masterType parameter to MLEngineTrainingOperator

2019-01-03 Thread GitBox
kkpoon opened a new pull request #4428: [AIRFLOW-3624] Add masterType parameter to MLEngineTrainingOperator URL: https://github.com/apache/incubator-airflow/pull/4428 Make sure you have checked _all_ steps below. ### Jira - [x] My PR addresses the following [Airflow

[jira] [Created] (AIRFLOW-3624) Add masterType parameter to MLEngineTrainingOperator

2019-01-03 Thread K.K. POON (JIRA)
K.K. POON created AIRFLOW-3624: -- Summary: Add masterType parameter to MLEngineTrainingOperator Key: AIRFLOW-3624 URL: https://issues.apache.org/jira/browse/AIRFLOW-3624 Project: Apache Airflow

[GitHub] jgao54 commented on a change in pull request #4426: [AIRFLOW-XXX] Add a doc on how to add a new role in RBAC UI

2019-01-03 Thread GitBox
jgao54 commented on a change in pull request #4426: [AIRFLOW-XXX] Add a doc on how to add a new role in RBAC UI URL: https://github.com/apache/incubator-airflow/pull/4426#discussion_r244936461 ## File path: docs/howto/add-new-role.rst ## @@ -0,0 +1,33 @@ +.. Licensed to

[GitHub] jgao54 commented on issue #4389: [AIRFLOW-3583] Fix AirflowException import

2019-01-03 Thread GitBox
jgao54 commented on issue #4389: [AIRFLOW-3583] Fix AirflowException import URL: https://github.com/apache/incubator-airflow/pull/4389#issuecomment-451082522 Restarted build, will merge if all tests pass. This is an

[GitHub] codecov-io edited a comment on issue #4427: [AIRFLOW-XXX] Update committer list based on latest TLP discussion

2019-01-03 Thread GitBox
codecov-io edited a comment on issue #4427: [AIRFLOW-XXX] Update committer list based on latest TLP discussion URL: https://github.com/apache/incubator-airflow/pull/4427#issuecomment-451079883 # [Codecov](https://codecov.io/gh/apache/incubator-airflow/pull/4427?src=pr=h1) Report >

[GitHub] codecov-io commented on issue #4427: [AIRFLOW-XXX] Update committer list based on latest TLP discussion

2019-01-03 Thread GitBox
codecov-io commented on issue #4427: [AIRFLOW-XXX] Update committer list based on latest TLP discussion URL: https://github.com/apache/incubator-airflow/pull/4427#issuecomment-451079883 # [Codecov](https://codecov.io/gh/apache/incubator-airflow/pull/4427?src=pr=h1) Report > Merging

[GitHub] codecov-io commented on issue #4426: [AIRFLOW-XXX] Add a doc on how to add a new role in RBAC UI

2019-01-03 Thread GitBox
codecov-io commented on issue #4426: [AIRFLOW-XXX] Add a doc on how to add a new role in RBAC UI URL: https://github.com/apache/incubator-airflow/pull/4426#issuecomment-451078091 # [Codecov](https://codecov.io/gh/apache/incubator-airflow/pull/4426?src=pr=h1) Report > Merging

[GitHub] codecov-io edited a comment on issue #4426: [AIRFLOW-XXX] Add a doc on how to add a new role in RBAC UI

2019-01-03 Thread GitBox
codecov-io edited a comment on issue #4426: [AIRFLOW-XXX] Add a doc on how to add a new role in RBAC UI URL: https://github.com/apache/incubator-airflow/pull/4426#issuecomment-451078091 # [Codecov](https://codecov.io/gh/apache/incubator-airflow/pull/4426?src=pr=h1) Report > Merging

[GitHub] codecov-io edited a comment on issue #4426: [AIRFLOW-XXX] Add a doc on how to add a new role in RBAC UI

2019-01-03 Thread GitBox
codecov-io edited a comment on issue #4426: [AIRFLOW-XXX] Add a doc on how to add a new role in RBAC UI URL: https://github.com/apache/incubator-airflow/pull/4426#issuecomment-451078091 # [Codecov](https://codecov.io/gh/apache/incubator-airflow/pull/4426?src=pr=h1) Report > Merging

<    1   2