[GitHub] bjoernpollex-sc commented on issue #4531: [WIP] Add dag source plugin hooks

2019-01-14 Thread GitBox
bjoernpollex-sc commented on issue #4531: [WIP] Add dag source plugin hooks URL: https://github.com/apache/airflow/pull/4531#issuecomment-454296944 It feels like creating a plugin to deploy DAGs is an unnecessary extra step. Also, DAGs aren't really plugins, right? Wouldn't it be easier to

[GitHub] drewsonne opened a new pull request #4531: [WIP] Add dag source plugin hooks

2019-01-14 Thread GitBox
drewsonne opened a new pull request #4531: [WIP] Add dag source plugin hooks URL: https://github.com/apache/airflow/pull/4531 Make sure you have checked _all_ steps below. ### Jira - [ ] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW

[GitHub] dongli commented on issue #4507: [AIRFLOW-3391] Upgrade Pendulum to latest version

2019-01-14 Thread GitBox
dongli commented on issue #4507: [AIRFLOW-3391] Upgrade Pendulum to latest version URL: https://github.com/apache/airflow/pull/4507#issuecomment-454276187 Looking forward this PR! This is an automated message from the Apache

[GitHub] ramandumcs commented on issue #4434: [AIRFLOW-3516] Support to create k8 worker pods in batches

2019-01-14 Thread GitBox
ramandumcs commented on issue #4434: [AIRFLOW-3516] Support to create k8 worker pods in batches URL: https://github.com/apache/airflow/pull/4434#issuecomment-454262283 Thanks @dimberman for looking in to this PR. As per current implementation K8 Executor submits/creates one k8 worker

[GitHub] mik-laj commented on a change in pull request #4530: [AIRFLOW-3282] Implement Azure Kubernetes Service Operator

2019-01-14 Thread GitBox
mik-laj commented on a change in pull request #4530: [AIRFLOW-3282] Implement Azure Kubernetes Service Operator URL: https://github.com/apache/airflow/pull/4530#discussion_r247741171 ## File path: airflow/models/connection.py ## @@ -84,6 +84,7 @@ class Connection(Base, Log

[GitHub] mik-laj commented on a change in pull request #4530: [AIRFLOW-3282] Implement Azure Kubernetes Service Operator

2019-01-14 Thread GitBox
mik-laj commented on a change in pull request #4530: [AIRFLOW-3282] Implement Azure Kubernetes Service Operator URL: https://github.com/apache/airflow/pull/4530#discussion_r247739678 ## File path: airflow/models/connection.py ## @@ -84,6 +84,7 @@ class Connection(Base, Log

[GitHub] mik-laj commented on a change in pull request #4530: [AIRFLOW-3282] Implement Azure Kubernetes Service Operator

2019-01-14 Thread GitBox
mik-laj commented on a change in pull request #4530: [AIRFLOW-3282] Implement Azure Kubernetes Service Operator URL: https://github.com/apache/airflow/pull/4530#discussion_r247739678 ## File path: airflow/models/connection.py ## @@ -84,6 +84,7 @@ class Connection(Base, Log

[GitHub] mik-laj commented on a change in pull request #4530: [AIRFLOW-3282] Implement Azure Kubernetes Service Operator

2019-01-14 Thread GitBox
mik-laj commented on a change in pull request #4530: [AIRFLOW-3282] Implement Azure Kubernetes Service Operator URL: https://github.com/apache/airflow/pull/4530#discussion_r247738173 ## File path: airflow/contrib/operators/aks_operator.py ## @@ -0,0 +1,200 @@ +# -*- coding

[GitHub] mik-laj commented on a change in pull request #4530: [AIRFLOW-3282] Implement Azure Kubernetes Service Operator

2019-01-14 Thread GitBox
mik-laj commented on a change in pull request #4530: [AIRFLOW-3282] Implement Azure Kubernetes Service Operator URL: https://github.com/apache/airflow/pull/4530#discussion_r247738075 ## File path: airflow/contrib/operators/aks_operator.py ## @@ -0,0 +1,200 @@ +# -*- coding

[GitHub] mik-laj commented on a change in pull request #4530: [AIRFLOW-3282] Implement Azure Kubernetes Service Operator

2019-01-14 Thread GitBox
mik-laj commented on a change in pull request #4530: [AIRFLOW-3282] Implement Azure Kubernetes Service Operator URL: https://github.com/apache/airflow/pull/4530#discussion_r247738075 ## File path: airflow/contrib/operators/aks_operator.py ## @@ -0,0 +1,200 @@ +# -*- coding

[GitHub] codecov-io edited a comment on issue #4321: incubator-airflow/scripts/ launchctl

2019-01-14 Thread GitBox
codecov-io edited a comment on issue #4321: incubator-airflow/scripts/ launchctl URL: https://github.com/apache/airflow/pull/4321#issuecomment-453847975 # [Codecov](https://codecov.io/gh/apache/airflow/pull/4321?src=pr&el=h1) Report > Merging [#4321](https://codecov.io/gh/apache/airflow

[GitHub] XD-DENG commented on a change in pull request #4528: [AIRFLOW XXX] adding exception catch to trigger_dag api

2019-01-14 Thread GitBox
XD-DENG commented on a change in pull request #4528: [AIRFLOW XXX] adding exception catch to trigger_dag api URL: https://github.com/apache/airflow/pull/4528#discussion_r247733364 ## File path: airflow/exceptions.py ## @@ -79,6 +79,12 @@ class DagNotFound(AirflowNotFoundEx

[GitHub] Nipica closed pull request #4528: [AIRFLOW XXX] adding exception catch to trigger_dag api

2019-01-14 Thread GitBox
Nipica closed pull request #4528: [AIRFLOW XXX] adding exception catch to trigger_dag api URL: https://github.com/apache/airflow/pull/4528 As this is a foreign pull request (from a fork), the diff has been sent to your commit mailing list, None ---

[GitHub] Nipica commented on a change in pull request #4528: [AIRFLOW XXX] adding exception catch to trigger_dag api

2019-01-14 Thread GitBox
Nipica commented on a change in pull request #4528: [AIRFLOW XXX] adding exception catch to trigger_dag api URL: https://github.com/apache/airflow/pull/4528#discussion_r247732184 ## File path: airflow/exceptions.py ## @@ -79,6 +79,12 @@ class DagNotFound(AirflowNotFoundExc

[GitHub] XD-DENG commented on a change in pull request #4528: [AIRFLOW XXX] adding exception catch to trigger_dag api

2019-01-14 Thread GitBox
XD-DENG commented on a change in pull request #4528: [AIRFLOW XXX] adding exception catch to trigger_dag api URL: https://github.com/apache/airflow/pull/4528#discussion_r247730608 ## File path: airflow/exceptions.py ## @@ -79,6 +79,12 @@ class DagNotFound(AirflowNotFoundEx

[GitHub] Nipica commented on a change in pull request #4528: [AIRFLOW XXX] test coverage

2019-01-14 Thread GitBox
Nipica commented on a change in pull request #4528: [AIRFLOW XXX] test coverage URL: https://github.com/apache/airflow/pull/4528#discussion_r247729697 ## File path: airflow/exceptions.py ## @@ -79,6 +79,12 @@ class DagNotFound(AirflowNotFoundException): pass +class

[GitHub] Nipica commented on a change in pull request #4528: [AIRFLOW XXX] test coverage

2019-01-14 Thread GitBox
Nipica commented on a change in pull request #4528: [AIRFLOW XXX] test coverage URL: https://github.com/apache/airflow/pull/4528#discussion_r247729583 ## File path: airflow/exceptions.py ## @@ -79,6 +79,12 @@ class DagNotFound(AirflowNotFoundException): pass +class

[jira] [Commented] (AIRFLOW-3681) Project id should be optional in all GCP operators

2019-01-14 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16742634#comment-16742634 ] ASF subversion and git services commented on AIRFLOW-3681: -- Co

[jira] [Resolved] (AIRFLOW-3681) Project id should be optional in all GCP operators

2019-01-14 Thread Kaxil Naik (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3681?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kaxil Naik resolved AIRFLOW-3681. - Resolution: Fixed Fix Version/s: 1.10.2 > Project id should be optional in all GCP opera

[GitHub] kaxil commented on issue #4500: [AIRFLOW-3681] All GCP operators have now optional GCP Project ID

2019-01-14 Thread GitBox
kaxil commented on issue #4500: [AIRFLOW-3681] All GCP operators have now optional GCP Project ID URL: https://github.com/apache/airflow/pull/4500#issuecomment-454224817 Thanks @potiuk This is an automated message from the A

[jira] [Commented] (AIRFLOW-3681) Project id should be optional in all GCP operators

2019-01-14 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16742636#comment-16742636 ] ASF subversion and git services commented on AIRFLOW-3681: -- Co

[jira] [Commented] (AIRFLOW-3704) Support SSL Protection for CeleryExecutor When Redis is Used as Broker

2019-01-14 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16742635#comment-16742635 ] ASF subversion and git services commented on AIRFLOW-3704: -- Co

[GitHub] XD-DENG commented on a change in pull request #4528: [AIRFLOW XXX] test coverage

2019-01-14 Thread GitBox
XD-DENG commented on a change in pull request #4528: [AIRFLOW XXX] test coverage URL: https://github.com/apache/airflow/pull/4528#discussion_r247727131 ## File path: airflow/exceptions.py ## @@ -79,6 +79,12 @@ class DagNotFound(AirflowNotFoundException): pass +clas

[jira] [Commented] (AIRFLOW-3681) Project id should be optional in all GCP operators

2019-01-14 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16742630#comment-16742630 ] ASF subversion and git services commented on AIRFLOW-3681: -- Co

[GitHub] kaxil merged pull request #4500: [AIRFLOW-3681] All GCP operators have now optional GCP Project ID

2019-01-14 Thread GitBox
kaxil merged pull request #4500: [AIRFLOW-3681] All GCP operators have now optional GCP Project ID URL: https://github.com/apache/airflow/pull/4500 As this is a foreign pull request (from a fork), the diff has been sent to your commit mailing list, None --

[GitHub] apraovjr commented on issue #4288: [AIRFLOW-3282] Implement an Azure Kubernetes Service Operator

2019-01-14 Thread GitBox
apraovjr commented on issue #4288: [AIRFLOW-3282] Implement an Azure Kubernetes Service Operator URL: https://github.com/apache/airflow/pull/4288#issuecomment-454222421 @mik-laj can you please comment here i have opened a new one https://github.com/apache/airflow/pull/4530

[GitHub] mik-laj commented on a change in pull request #4288: [AIRFLOW-3282] Implement an Azure Kubernetes Service Operator

2019-01-14 Thread GitBox
mik-laj commented on a change in pull request #4288: [AIRFLOW-3282] Implement an Azure Kubernetes Service Operator URL: https://github.com/apache/airflow/pull/4288#discussion_r247725653 ## File path: tests/contrib/hooks/test_azure_kubernetes_hook.py ## @@ -0,0 +1,84 @@ +#

[jira] [Commented] (AIRFLOW-3282) Implement a Azure Kubernetes Service Operator

2019-01-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16742625#comment-16742625 ] ASF GitHub Bot commented on AIRFLOW-3282: - apraovjr commented on pull request #

[GitHub] apraovjr opened a new pull request #4530: [AIRFLOW-3282] Implement Azure Kubernetes Service Operator

2019-01-14 Thread GitBox
apraovjr opened a new pull request #4530: [AIRFLOW-3282] Implement Azure Kubernetes Service Operator URL: https://github.com/apache/airflow/pull/4530 Add an operator to spin up azure kubernetes service. Azure Kubernetes Service is use to deploy a managed kubernetes cluster in Azure.

[jira] [Resolved] (AIRFLOW-3704) Support SSL Protection for CeleryExecutor When Redis is Used as Broker

2019-01-14 Thread Kaxil Naik (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3704?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kaxil Naik resolved AIRFLOW-3704. - Resolution: Fixed Fix Version/s: 1.10.2 > Support SSL Protection for CeleryExecutor When

[GitHub] mik-laj commented on a change in pull request #4288: [AIRFLOW-3282] Implement an Azure Kubernetes Service Operator

2019-01-14 Thread GitBox
mik-laj commented on a change in pull request #4288: [AIRFLOW-3282] Implement an Azure Kubernetes Service Operator URL: https://github.com/apache/airflow/pull/4288#discussion_r247725350 ## File path: airflow/contrib/operators/aks_operator.py ## @@ -0,0 +1,200 @@ +# -*- co

[GitHub] apraovjr closed pull request #4529: [AIRFLOW-3282] Azure Kubernetes Service Operator

2019-01-14 Thread GitBox
apraovjr closed pull request #4529: [AIRFLOW-3282] Azure Kubernetes Service Operator URL: https://github.com/apache/airflow/pull/4529 As this is a foreign pull request (from a fork), the diff has been sent to your commit mailing list, None

[jira] [Reopened] (AIRFLOW-3704) Support SSL Protection for CeleryExecutor When Redis is Used as Broker

2019-01-14 Thread Kaxil Naik (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3704?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kaxil Naik reopened AIRFLOW-3704: - > Support SSL Protection for CeleryExecutor When Redis is Used as Broker >

[jira] [Commented] (AIRFLOW-3704) Support SSL Protection for CeleryExecutor When Redis is Used as Broker

2019-01-14 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16742621#comment-16742621 ] ASF subversion and git services commented on AIRFLOW-3704: -- Co

[jira] [Commented] (AIRFLOW-3704) Support SSL Protection for CeleryExecutor When Redis is Used as Broker

2019-01-14 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16742622#comment-16742622 ] ASF subversion and git services commented on AIRFLOW-3704: -- Co

[jira] [Commented] (AIRFLOW-3282) Implement a Azure Kubernetes Service Operator

2019-01-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16742619#comment-16742619 ] ASF GitHub Bot commented on AIRFLOW-3282: - apraovjr commented on pull request #

[GitHub] apraovjr opened a new pull request #4529: [AIRFLOW-3282] Azure Kubernetes Service Operator (#12) (#19)

2019-01-14 Thread GitBox
apraovjr opened a new pull request #4529: [AIRFLOW-3282] Azure Kubernetes Service Operator (#12) (#19) URL: https://github.com/apache/airflow/pull/4529 Add an operator to spin up azure kubernetes service. Azure Kubernetes Service is use to deploy a managed kubernetes cluster in Azure.

[GitHub] apraovjr closed pull request #4290: [AIRFLOW-3282] Implement Azure Kubernetes Service Operator

2019-01-14 Thread GitBox
apraovjr closed pull request #4290: [AIRFLOW-3282] Implement Azure Kubernetes Service Operator URL: https://github.com/apache/airflow/pull/4290 As this is a foreign pull request (from a fork), the diff has been sent to your commit mailing list, None -

[GitHub] Nipica opened a new pull request #4528: [AIRFLOW XXX] test coverage

2019-01-14 Thread GitBox
Nipica opened a new pull request #4528: [AIRFLOW XXX] test coverage URL: https://github.com/apache/airflow/pull/4528 Make sure you have checked _all_ steps below. ### Jira - [ ] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues

[GitHub] mik-laj commented on a change in pull request #4524: [AIRFLOW-3707] Group subpackages by cloud providers

2019-01-14 Thread GitBox
mik-laj commented on a change in pull request #4524: [AIRFLOW-3707] Group subpackages by cloud providers URL: https://github.com/apache/airflow/pull/4524#discussion_r247713468 ## File path: airflow/utils/log/s3_task_handler.py ## @@ -45,7 +45,7 @@ def _build_hook(self):

[GitHub] mik-laj commented on a change in pull request #4524: [AIRFLOW-3707] Group subpackages by cloud providers

2019-01-14 Thread GitBox
mik-laj commented on a change in pull request #4524: [AIRFLOW-3707] Group subpackages by cloud providers URL: https://github.com/apache/airflow/pull/4524#discussion_r247708692 ## File path: airflow/utils/log/s3_task_handler.py ## @@ -45,7 +45,7 @@ def _build_hook(self):

[GitHub] mik-laj edited a comment on issue #4524: [AIRFLOW-3707] Group subpackages by cloud providers

2019-01-14 Thread GitBox
mik-laj edited a comment on issue #4524: [AIRFLOW-3707] Group subpackages by cloud providers URL: https://github.com/apache/airflow/pull/4524#issuecomment-454203668 > This needs a note in updating, otherwise someone might try to install apache-airflow[s3] and be confused by it not working.

[GitHub] mik-laj commented on issue #4524: [AIRFLOW-3707] Group subpackages by cloud providers

2019-01-14 Thread GitBox
mik-laj commented on issue #4524: [AIRFLOW-3707] Group subpackages by cloud providers URL: https://github.com/apache/airflow/pull/4524#issuecomment-454203668 > This needs a note in updating, otherwise someone might try to install apache-airflow[s3] and be confused by it not working. Tha

[GitHub] mik-laj edited a comment on issue #4524: [AIRFLOW-3707] Group subpackages by cloud providers

2019-01-14 Thread GitBox
mik-laj edited a comment on issue #4524: [AIRFLOW-3707] Group subpackages by cloud providers URL: https://github.com/apache/airflow/pull/4524#issuecomment-454203668 > This needs a note in updating, otherwise someone might try to install apache-airflow[s3] and be confused by it not working.

[GitHub] r39132 merged pull request #4526: [AIRFLOW-XXX] Include Los Angeles Times as a contributor in the Readme

2019-01-14 Thread GitBox
r39132 merged pull request #4526: [AIRFLOW-XXX] Include Los Angeles Times as a contributor in the Readme URL: https://github.com/apache/airflow/pull/4526 As this is a foreign pull request (from a fork), the diff has been sent to your commit mailing list, None

[GitHub] r39132 merged pull request #4527: [AIRFLOW-XXX] Adding to CAVA & PXYData

2019-01-14 Thread GitBox
r39132 merged pull request #4527: [AIRFLOW-XXX] Adding to CAVA & PXYData URL: https://github.com/apache/airflow/pull/4527 As this is a foreign pull request (from a fork), the diff has been sent to your commit mailing list, None -

[jira] [Assigned] (AIRFLOW-1515) Airflow 1.8.1 tasks not being marked as upstream_failed when one of the parents fails

2019-01-14 Thread Faryz Eysz7x (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-1515?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Faryz Eysz7x reassigned AIRFLOW-1515: - Assignee: Faryz Eysz7x > Airflow 1.8.1 tasks not being marked as upstream_failed when

[GitHub] danabananarama commented on issue #4514: [AIRFLOW-3698] Add region param for EMR jobflow sensor

2019-01-14 Thread GitBox
danabananarama commented on issue #4514: [AIRFLOW-3698] Add region param for EMR jobflow sensor URL: https://github.com/apache/airflow/pull/4514#issuecomment-454198797 Thanks for looking @ashb! And thanks for the tip, it does the trick. Did I miss this in the documentation? (or if not, whe

[GitHub] Patchus opened a new pull request #4527: Adding to CAVA & PXYData

2019-01-14 Thread GitBox
Patchus opened a new pull request #4527: Adding to CAVA & PXYData URL: https://github.com/apache/airflow/pull/4527 Make sure you have checked _all_ steps below. ### Jira - [ ] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues a

[GitHub] mik-laj commented on a change in pull request #4524: [AIRFLOW-3707] Group subpackages by cloud providers

2019-01-14 Thread GitBox
mik-laj commented on a change in pull request #4524: [AIRFLOW-3707] Group subpackages by cloud providers URL: https://github.com/apache/airflow/pull/4524#discussion_r247695503 ## File path: setup.py ## @@ -157,30 +160,30 @@ def write_version(filename=os.path.join(*['airflo

[jira] [Closed] (AIRFLOW-3708) CLONE - Airflow 1.8.1 tasks not being marked as upstream_failed when one of the parents fails

2019-01-14 Thread Ash Berlin-Taylor (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3708?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ash Berlin-Taylor closed AIRFLOW-3708. -- Resolution: Duplicate Dup of your own ticket AIRFLOW-1515 - please don't report twice

[jira] [Created] (AIRFLOW-3708) CLONE - Airflow 1.8.1 tasks not being marked as upstream_failed when one of the parents fails

2019-01-14 Thread Faryz Eysz7x (JIRA)
Faryz Eysz7x created AIRFLOW-3708: - Summary: CLONE - Airflow 1.8.1 tasks not being marked as upstream_failed when one of the parents fails Key: AIRFLOW-3708 URL: https://issues.apache.org/jira/browse/AIRFLOW-3708

[GitHub] mik-laj commented on a change in pull request #4316: [AIRFLOW-3511] Create GCP Memorystore Redis Hook

2019-01-14 Thread GitBox
mik-laj commented on a change in pull request #4316: [AIRFLOW-3511] Create GCP Memorystore Redis Hook URL: https://github.com/apache/airflow/pull/4316#discussion_r247686747 ## File path: airflow/contrib/hooks/gcp_memorystore_hook.py ## @@ -0,0 +1,283 @@ +# -*- coding: utf

[GitHub] ashb commented on issue #4483: [AIRFLOW-3673] Add official dockerfile

2019-01-14 Thread GitBox
ashb commented on issue #4483: [AIRFLOW-3673] Add official dockerfile URL: https://github.com/apache/airflow/pull/4483#issuecomment-454188371 > separate images for different versions of python is probably the way to go for Travis I think we use the "other" version of python in the te

[GitHub] ashb commented on a change in pull request #4524: [AIRFLOW-3707] Group subpackages by cloud providers

2019-01-14 Thread GitBox
ashb commented on a change in pull request #4524: [AIRFLOW-3707] Group subpackages by cloud providers URL: https://github.com/apache/airflow/pull/4524#discussion_r247686136 ## File path: setup.py ## @@ -157,30 +160,30 @@ def write_version(filename=os.path.join(*['airflow',

[GitHub] ashb commented on a change in pull request #4524: [AIRFLOW-3707] Group subpackages by cloud providers

2019-01-14 Thread GitBox
ashb commented on a change in pull request #4524: [AIRFLOW-3707] Group subpackages by cloud providers URL: https://github.com/apache/airflow/pull/4524#discussion_r247685582 ## File path: airflow/utils/log/s3_task_handler.py ## @@ -45,7 +45,7 @@ def _build_hook(self):

[GitHub] ashb commented on issue #4516: [AIRFLOW-2524] Handle StopIteration in CloudWatch logs retrieval

2019-01-14 Thread GitBox
ashb commented on issue #4516: [AIRFLOW-2524] Handle StopIteration in CloudWatch logs retrieval URL: https://github.com/apache/airflow/pull/4516#issuecomment-454186622 Is it easy to add a test for this? The log code is a bit complex and capturing why this is needed would be good. Ad

[GitHub] mik-laj commented on a change in pull request #4523: [AIRFLOW-3616] Add aliases for schema with underscore

2019-01-14 Thread GitBox
mik-laj commented on a change in pull request #4523: [AIRFLOW-3616] Add aliases for schema with underscore URL: https://github.com/apache/airflow/pull/4523#discussion_r247684793 ## File path: docs/concepts.rst ## @@ -369,8 +369,7 @@ for some basic load balancing and fault

[GitHub] ashb commented on a change in pull request #4516: [AIRFLOW-2524] Handle StopIteration in CloudWatch logs retrieval

2019-01-14 Thread GitBox
ashb commented on a change in pull request #4516: [AIRFLOW-2524] Handle StopIteration in CloudWatch logs retrieval URL: https://github.com/apache/airflow/pull/4516#discussion_r247683359 ## File path: airflow/contrib/hooks/sagemaker_hook.py ## @@ -304,7 +304,15 @@ def multi

[GitHub] codecov-io edited a comment on issue #4321: incubator-airflow/scripts/ launchctl

2019-01-14 Thread GitBox
codecov-io edited a comment on issue #4321: incubator-airflow/scripts/ launchctl URL: https://github.com/apache/airflow/pull/4321#issuecomment-453847975 # [Codecov](https://codecov.io/gh/apache/airflow/pull/4321?src=pr&el=h1) Report > Merging [#4321](https://codecov.io/gh/apache/airflow

[GitHub] codecov-io edited a comment on issue #4321: incubator-airflow/scripts/ launchctl

2019-01-14 Thread GitBox
codecov-io edited a comment on issue #4321: incubator-airflow/scripts/ launchctl URL: https://github.com/apache/airflow/pull/4321#issuecomment-453847975 # [Codecov](https://codecov.io/gh/apache/airflow/pull/4321?src=pr&el=h1) Report > Merging [#4321](https://codecov.io/gh/apache/airflow

[GitHub] potiuk commented on issue #4500: [AIRFLOW-3681] All GCP operators have now optional GCP Project ID

2019-01-14 Thread GitBox
potiuk commented on issue #4500: [AIRFLOW-3681] All GCP operators have now optional GCP Project ID URL: https://github.com/apache/airflow/pull/4500#issuecomment-454184803 @jmcarp -> you might take a look as well. This one is vastly improved version of optional project_id - now in hooks al

[GitHub] potiuk commented on issue #4500: [AIRFLOW-3681] All GCP operators have now optional GCP Project ID

2019-01-14 Thread GitBox
potiuk commented on issue #4500: [AIRFLOW-3681] All GCP operators have now optional GCP Project ID URL: https://github.com/apache/airflow/pull/4500#issuecomment-454184266 All is done now @kaxil : This is a monster change, but it's mostly in tests. The change includes changing the project_i

[GitHub] codecov-io edited a comment on issue #4500: [AIRFLOW-3681] All GCP operators have now optional GCP Project ID

2019-01-14 Thread GitBox
codecov-io edited a comment on issue #4500: [AIRFLOW-3681] All GCP operators have now optional GCP Project ID URL: https://github.com/apache/airflow/pull/4500#issuecomment-453777063 # [Codecov](https://codecov.io/gh/apache/airflow/pull/4500?src=pr&el=h1) Report > Merging [#4500](https:

[GitHub] ashb commented on a change in pull request #4523: [AIRFLOW-3616] Add aliases for schema with underscore

2019-01-14 Thread GitBox
ashb commented on a change in pull request #4523: [AIRFLOW-3616] Add aliases for schema with underscore URL: https://github.com/apache/airflow/pull/4523#discussion_r247677177 ## File path: docs/concepts.rst ## @@ -369,8 +369,7 @@ for some basic load balancing and fault tol

[GitHub] standyro opened a new pull request #4526: Update README.md to include Los Angeles Times as contributor

2019-01-14 Thread GitBox
standyro opened a new pull request #4526: Update README.md to include Los Angeles Times as contributor URL: https://github.com/apache/airflow/pull/4526 Make sure you have checked _all_ steps below. ### Jira - [ ] My PR addresses the following [Airflow Jira](https://issues.apa

[GitHub] codecov-io commented on issue #4524: [AIRFLOW-3707] Group subpackages by cloud providers

2019-01-14 Thread GitBox
codecov-io commented on issue #4524: [AIRFLOW-3707] Group subpackages by cloud providers URL: https://github.com/apache/airflow/pull/4524#issuecomment-454171796 # [Codecov](https://codecov.io/gh/apache/airflow/pull/4524?src=pr&el=h1) Report > Merging [#4524](https://codecov.io/gh/apach

[GitHub] feluelle commented on issue #4475: [AIRFLOW-3602] Changes ImapHook to raise an exception on no attachments

2019-01-14 Thread GitBox
feluelle commented on issue #4475: [AIRFLOW-3602] Changes ImapHook to raise an exception on no attachments URL: https://github.com/apache/airflow/pull/4475#issuecomment-454168121 It is similar to the S3Hook if you want to download a file from s3 you get an exception when there isn't a file

[GitHub] codecov-io commented on issue #4525: [AIRFLOW-3108] Define get_autocommit method for MsSqlHook

2019-01-14 Thread GitBox
codecov-io commented on issue #4525: [AIRFLOW-3108] Define get_autocommit method for MsSqlHook URL: https://github.com/apache/airflow/pull/4525#issuecomment-454165789 # [Codecov](https://codecov.io/gh/apache/airflow/pull/4525?src=pr&el=h1) Report > Merging [#4525](https://codecov.io/gh

[jira] [Commented] (AIRFLOW-3108) MsSqlHook.run fails to commit if autocommit=False (Default config)

2019-01-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16742484#comment-16742484 ] ASF GitHub Bot commented on AIRFLOW-3108: - thalesmello commented on pull reques

[GitHub] potiuk commented on issue #4483: [AIRFLOW-3673] Add official dockerfile

2019-01-14 Thread GitBox
potiuk commented on issue #4483: [AIRFLOW-3673] Add official dockerfile URL: https://github.com/apache/airflow/pull/4483#issuecomment-454155148 I think we can have some basee image with minimal apt-get dependencies and then build both Dockers "forking" from that - maybe we can use multi-sta

[GitHub] thalesmello opened a new pull request #4525: [AIRFLOW-3108] Define get_autocommit method for MsSqlHook

2019-01-14 Thread GitBox
thalesmello opened a new pull request #4525: [AIRFLOW-3108] Define get_autocommit method for MsSqlHook URL: https://github.com/apache/airflow/pull/4525 Make sure you have checked _all_ steps below. ### Jira - https://issues.apache.org/jira/browse/AIRFLOW-3108 ###

[GitHub] mik-laj commented on issue #4524: [AIRFLOW-3707] Group subpackages by cloud providers

2019-01-14 Thread GitBox
mik-laj commented on issue #4524: [AIRFLOW-3707] Group subpackages by cloud providers URL: https://github.com/apache/airflow/pull/4524#issuecomment-454150188 @ashb Recently, you gave me a thumb up on a comment that pointed to this problem. -

[jira] [Commented] (AIRFLOW-3707) Too many subpackages - group by cloud providers

2019-01-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16742477#comment-16742477 ] ASF GitHub Bot commented on AIRFLOW-3707: - mik-laj commented on pull request #4

[GitHub] mik-laj opened a new pull request #4524: [AIRFLOW-3707] Group subpackages by cloud providers

2019-01-14 Thread GitBox
mik-laj opened a new pull request #4524: [AIRFLOW-3707] Group subpackages by cloud providers URL: https://github.com/apache/airflow/pull/4524 Make sure you have checked _all_ steps below. ### Jira - https://issues.apache.org/jira/browse/AIRFLOW-3707 ### Description

[jira] [Updated] (AIRFLOW-3707) Too many subpackages - group by cloud providers

2019-01-14 Thread Kamil Bregula (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3707?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kamil Bregula updated AIRFLOW-3707: --- Summary: Too many subpackages - group by cloud providers (was: Too many subpackages - grup

[jira] [Created] (AIRFLOW-3707) Too many subpackages - grup by cloud providers

2019-01-14 Thread Kamil Bregula (JIRA)
Kamil Bregula created AIRFLOW-3707: -- Summary: Too many subpackages - grup by cloud providers Key: AIRFLOW-3707 URL: https://issues.apache.org/jira/browse/AIRFLOW-3707 Project: Apache Airflow

[GitHub] tedmiston commented on issue #3656: [AIRFLOW-2803] Fix all ESLint issues

2019-01-14 Thread GitBox
tedmiston commented on issue #3656: [AIRFLOW-2803] Fix all ESLint issues URL: https://github.com/apache/airflow/pull/3656#issuecomment-454143234 Hey all - sorry I dropped off on this one over the holidays. Yes, I can bring this back in and see what's required. It looks like I'll hav

[GitHub] yangaws commented on a change in pull request #4516: [AIRFLOW-2524] Handle StopIteration in CloudWatch logs retrieval

2019-01-14 Thread GitBox
yangaws commented on a change in pull request #4516: [AIRFLOW-2524] Handle StopIteration in CloudWatch logs retrieval URL: https://github.com/apache/airflow/pull/4516#discussion_r247632982 ## File path: airflow/contrib/hooks/sagemaker_hook.py ## @@ -304,7 +304,15 @@ def mu

[GitHub] yangaws commented on a change in pull request #4516: [AIRFLOW-2524] Handle StopIteration in CloudWatch logs retrieval

2019-01-14 Thread GitBox
yangaws commented on a change in pull request #4516: [AIRFLOW-2524] Handle StopIteration in CloudWatch logs retrieval URL: https://github.com/apache/airflow/pull/4516#discussion_r247632982 ## File path: airflow/contrib/hooks/sagemaker_hook.py ## @@ -304,7 +304,15 @@ def mu

[GitHub] yangaws commented on a change in pull request #4516: [AIRFLOW-2524] Handle StopIteration in CloudWatch logs retrieval

2019-01-14 Thread GitBox
yangaws commented on a change in pull request #4516: [AIRFLOW-2524] Handle StopIteration in CloudWatch logs retrieval URL: https://github.com/apache/airflow/pull/4516#discussion_r247632982 ## File path: airflow/contrib/hooks/sagemaker_hook.py ## @@ -304,7 +304,15 @@ def mu

[jira] [Commented] (AIRFLOW-3655) Links on model view columns not escaped

2019-01-14 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16742440#comment-16742440 ] ASF subversion and git services commented on AIRFLOW-3655: -- Co

[jira] [Commented] (AIRFLOW-3319) Kubernetes Executor attempts to get the "try_number" from labels but fails

2019-01-14 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16742441#comment-16742441 ] ASF subversion and git services commented on AIRFLOW-3319: -- Co

[jira] [Commented] (AIRFLOW-3319) Kubernetes Executor attempts to get the "try_number" from labels but fails

2019-01-14 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16742446#comment-16742446 ] ASF subversion and git services commented on AIRFLOW-3319: -- Co

[GitHub] yangaws commented on a change in pull request #4516: [AIRFLOW-2524] Handle StopIteration in CloudWatch logs retrieval

2019-01-14 Thread GitBox
yangaws commented on a change in pull request #4516: [AIRFLOW-2524] Handle StopIteration in CloudWatch logs retrieval URL: https://github.com/apache/airflow/pull/4516#discussion_r247632982 ## File path: airflow/contrib/hooks/sagemaker_hook.py ## @@ -304,7 +304,15 @@ def mu

[jira] [Commented] (AIRFLOW-3700) Change the lowest allowed version of "requests" to address security vulnerabilities

2019-01-14 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16742444#comment-16742444 ] ASF subversion and git services commented on AIRFLOW-3700: -- Co

[jira] [Commented] (AIRFLOW-3655) Links on model view columns not escaped

2019-01-14 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16742445#comment-16742445 ] ASF subversion and git services commented on AIRFLOW-3655: -- Co

[GitHub] codecov-io edited a comment on issue #4523: [AIRFLOW-3616] Add aliases for schema with underscore

2019-01-14 Thread GitBox
codecov-io edited a comment on issue #4523: [AIRFLOW-3616] Add aliases for schema with underscore URL: https://github.com/apache/airflow/pull/4523#issuecomment-454115923 # [Codecov](https://codecov.io/gh/apache/airflow/pull/4523?src=pr&el=h1) Report > Merging [#4523](https://codecov.io

[GitHub] codecov-io edited a comment on issue #4523: [AIRFLOW-3616] Add aliases for schema with underscore

2019-01-14 Thread GitBox
codecov-io edited a comment on issue #4523: [AIRFLOW-3616] Add aliases for schema with underscore URL: https://github.com/apache/airflow/pull/4523#issuecomment-454115923 # [Codecov](https://codecov.io/gh/apache/airflow/pull/4523?src=pr&el=h1) Report > Merging [#4523](https://codecov.io

[GitHub] codecov-io edited a comment on issue #4523: [AIRFLOW-3616] Add aliases for schema with underscore

2019-01-14 Thread GitBox
codecov-io edited a comment on issue #4523: [AIRFLOW-3616] Add aliases for schema with underscore URL: https://github.com/apache/airflow/pull/4523#issuecomment-454115923 # [Codecov](https://codecov.io/gh/apache/airflow/pull/4523?src=pr&el=h1) Report > Merging [#4523](https://codecov.io

[GitHub] codecov-io edited a comment on issue #4523: [AIRFLOW-3616] Add aliases for schema with underscore

2019-01-14 Thread GitBox
codecov-io edited a comment on issue #4523: [AIRFLOW-3616] Add aliases for schema with underscore URL: https://github.com/apache/airflow/pull/4523#issuecomment-454115923 # [Codecov](https://codecov.io/gh/apache/airflow/pull/4523?src=pr&el=h1) Report > Merging [#4523](https://codecov.io

[GitHub] codecov-io edited a comment on issue #4523: [AIRFLOW-3616] Add aliases for schema with underscore

2019-01-14 Thread GitBox
codecov-io edited a comment on issue #4523: [AIRFLOW-3616] Add aliases for schema with underscore URL: https://github.com/apache/airflow/pull/4523#issuecomment-454115923 # [Codecov](https://codecov.io/gh/apache/airflow/pull/4523?src=pr&el=h1) Report > Merging [#4523](https://codecov.io

[GitHub] codecov-io edited a comment on issue #4523: [AIRFLOW-3616] Add aliases for schema with underscore

2019-01-14 Thread GitBox
codecov-io edited a comment on issue #4523: [AIRFLOW-3616] Add aliases for schema with underscore URL: https://github.com/apache/airflow/pull/4523#issuecomment-454115923 # [Codecov](https://codecov.io/gh/apache/airflow/pull/4523?src=pr&el=h1) Report > Merging [#4523](https://codecov.io

[GitHub] codecov-io edited a comment on issue #4523: [AIRFLOW-3616] Add aliases for schema with underscore

2019-01-14 Thread GitBox
codecov-io edited a comment on issue #4523: [AIRFLOW-3616] Add aliases for schema with underscore URL: https://github.com/apache/airflow/pull/4523#issuecomment-454115923 # [Codecov](https://codecov.io/gh/apache/airflow/pull/4523?src=pr&el=h1) Report > Merging [#4523](https://codecov.io

[jira] [Assigned] (AIRFLOW-3705) PostgresHook's get_conn method calls incorrect attribute by default

2019-01-14 Thread Cooper Gillan (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3705?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Cooper Gillan reassigned AIRFLOW-3705: -- Assignee: Cooper Gillan > PostgresHook's get_conn method calls incorrect attribute b

[GitHub] codecov-io edited a comment on issue #4523: [AIRFLOW-3616] Add aliases for schema with underscore

2019-01-14 Thread GitBox
codecov-io edited a comment on issue #4523: [AIRFLOW-3616] Add aliases for schema with underscore URL: https://github.com/apache/airflow/pull/4523#issuecomment-454115923 # [Codecov](https://codecov.io/gh/apache/airflow/pull/4523?src=pr&el=h1) Report > Merging [#4523](https://codecov.io

[GitHub] codecov-io commented on issue #4523: [AIRFLOW-3616] Add aliases for schema with underscore

2019-01-14 Thread GitBox
codecov-io commented on issue #4523: [AIRFLOW-3616] Add aliases for schema with underscore URL: https://github.com/apache/airflow/pull/4523#issuecomment-454115923 # [Codecov](https://codecov.io/gh/apache/airflow/pull/4523?src=pr&el=h1) Report > Merging [#4523](https://codecov.io/gh/apa

[jira] [Comment Edited] (AIRFLOW-3706) Tooltip Display Issue for a Task Instance

2019-01-14 Thread Felix Uellendall (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16742335#comment-16742335 ] Felix Uellendall edited comment on AIRFLOW-3706 at 1/14/19 6:20 PM: -

[GitHub] morgendave commented on issue #4101: [AIRFLOW-3272] Add base grpc hook

2019-01-14 Thread GitBox
morgendave commented on issue #4101: [AIRFLOW-3272] Add base grpc hook URL: https://github.com/apache/airflow/pull/4101#issuecomment-454112596 > @morgendave Please do the testing on your own fork of Travis. ASF is paying for the Travis time. Sure although the test failure are random,

[jira] [Commented] (AIRFLOW-3616) Connection parsed from URI - unacceptable underscore in schema part

2019-01-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16742392#comment-16742392 ] ASF GitHub Bot commented on AIRFLOW-3616: - mik-laj commented on pull request #4

  1   2   3   >