[GitHub] ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database

2019-02-14 Thread GitBox
ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#discussion_r257134031 ## File path: airflow/models/__init__.py ## @@ -4050,8 +4164,14 @@ def sync_to_db(self, owner=None, sync_time=N

[GitHub] ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database

2019-02-14 Thread GitBox
ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#discussion_r257133602 ## File path: airflow/models/__init__.py ## @@ -4012,17 +4088,55 @@ def create_dagrun(self, conf=c

[GitHub] ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database

2019-02-14 Thread GitBox
ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#discussion_r257133588 ## File path: airflow/models/__init__.py ## @@ -4012,17 +4088,55 @@ def create_dagrun(self, conf=c

[GitHub] ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database

2019-02-14 Thread GitBox
ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#discussion_r257133366 ## File path: airflow/models/__init__.py ## @@ -4012,17 +4088,55 @@ def create_dagrun(self, conf=c

[GitHub] ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database

2019-02-14 Thread GitBox
ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#discussion_r257133187 ## File path: airflow/models/__init__.py ## @@ -4012,17 +4088,55 @@ def create_dagrun(self, conf=c

[GitHub] BasPH commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database

2019-02-14 Thread GitBox
BasPH commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#discussion_r257133039 ## File path: airflow/www/views.py ## @@ -1349,21 +1357,26 @@ class GraphForm(DateTimeWithNumRunsWithDagRunsForm

[GitHub] ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database

2019-02-14 Thread GitBox
ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#discussion_r257132913 ## File path: airflow/models/__init__.py ## @@ -3238,9 +3314,10 @@ def normalize_schedule(self, dttm):

[GitHub] drewsonne commented on a change in pull request #4640: [RFC] [WIP] Feature/flask restful

2019-02-14 Thread GitBox
drewsonne commented on a change in pull request #4640: [RFC] [WIP] Feature/flask restful URL: https://github.com/apache/airflow/pull/4640#discussion_r257132644 ## File path: airflow/plugins_manager.py ## @@ -84,12 +84,16 @@ def load_entrypoint_plugins(entry_points, airflow

[GitHub] ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database

2019-02-14 Thread GitBox
ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#discussion_r257132348 ## File path: airflow/models/__init__.py ## @@ -2812,16 +2821,39 @@ def get_default_view(self): re

[GitHub] BasPH commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database

2019-02-14 Thread GitBox
BasPH commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#discussion_r257132000 ## File path: airflow/www/views.py ## @@ -1293,24 +1303,28 @@ def set_duration(tid): def graph(self, sessio

[GitHub] ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database

2019-02-14 Thread GitBox
ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#discussion_r257131721 ## File path: airflow/models/__init__.py ## @@ -688,6 +632,57 @@ def __init__(self, task, execution_date, state

[GitHub] BasPH commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database

2019-02-14 Thread GitBox
BasPH commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#discussion_r257131310 ## File path: airflow/models/dag_edge.py ## @@ -0,0 +1,60 @@ +# -*- coding: utf-8 -*- +# +# Licensed to the Apac

[GitHub] BasPH commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database

2019-02-14 Thread GitBox
BasPH commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#discussion_r257130988 ## File path: airflow/models/dag_edge.py ## @@ -0,0 +1,60 @@ +# -*- coding: utf-8 -*- +# +# Licensed to the Apac

[GitHub] ffinfo commented on issue #4396: [AIRFLOW-3585] - Add edges to database

2019-02-14 Thread GitBox
ffinfo commented on issue #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#issuecomment-463929201 @astahlman I have seen the same thing. This happens when you generated a dagrun on master and try to view this on this branch. This is because some

[GitHub] ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database

2019-02-14 Thread GitBox
ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#discussion_r257120300 ## File path: tests/sensors/test_base_sensor.py ## @@ -60,12 +61,12 @@ def setUp(self): 'start_dat

[GitHub] ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database

2019-02-14 Thread GitBox
ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#discussion_r257120183 ## File path: tests/core.py ## @@ -2878,13 +2903,6 @@ def test_get_connections_env_var(self): assert c

[GitHub] ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database

2019-02-14 Thread GitBox
ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#discussion_r257119817 ## File path: airflow/models/__init__.py ## @@ -679,6 +620,9 @@ def __init__(self, task, execution_date, state=

[jira] [Resolved] (AIRFLOW-3770) Automatic validation of documentation

2019-02-14 Thread Tao Feng (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3770?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tao Feng resolved AIRFLOW-3770. --- Resolution: Fixed > Automatic validation of documentation > - >

[GitHub] ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database

2019-02-14 Thread GitBox
ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#discussion_r257117183 ## File path: airflow/models/__init__.py ## @@ -96,7 +97,7 @@ from airflow.utils import timezone from airflow

[GitHub] ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database

2019-02-14 Thread GitBox
ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#discussion_r257116801 ## File path: airflow/jobs.py ## @@ -1869,7 +1869,7 @@ def __init__( start_date=None,

[GitHub] ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database

2019-02-14 Thread GitBox
ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#discussion_r257115977 ## File path: airflow/www/views.py ## @@ -1319,24 +1335,20 @@ def graph(self, session=None):

[GitHub] ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database

2019-02-14 Thread GitBox
ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#discussion_r257115832 ## File path: airflow/www/views.py ## @@ -1293,24 +1303,30 @@ def set_duration(tid): def graph(self, sessi

[GitHub] ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database

2019-02-14 Thread GitBox
ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#discussion_r257115465 ## File path: airflow/www/views.py ## @@ -1293,24 +1303,30 @@ def set_duration(tid): def graph(self, sessi

[GitHub] ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database

2019-02-14 Thread GitBox
ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#discussion_r257115006 ## File path: airflow/www/views.py ## @@ -1293,24 +1303,30 @@ def set_duration(tid): def graph(self, sessi

[GitHub] ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database

2019-02-14 Thread GitBox
ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#discussion_r257114786 ## File path: airflow/www/views.py ## @@ -1293,24 +1303,30 @@ def set_duration(tid): def graph(self, sessi

[jira] [Resolved] (AIRFLOW-3598) Add tests for MsSqlToHiveTransfer

2019-02-14 Thread Tao Feng (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3598?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tao Feng resolved AIRFLOW-3598. --- Resolution: Fixed > Add tests for MsSqlToHiveTransfer > - > >

[GitHub] ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database

2019-02-14 Thread GitBox
ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#discussion_r257114230 ## File path: airflow/www/views.py ## @@ -1293,24 +1303,30 @@ def set_duration(tid): def graph(self, sessi

[GitHub] ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database

2019-02-14 Thread GitBox
ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#discussion_r257113954 ## File path: airflow/models/__init__.py ## @@ -2812,16 +2821,39 @@ def get_default_view(self): re

[GitHub] feng-tao commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database

2019-02-14 Thread GitBox
feng-tao commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#discussion_r256946287 ## File path: airflow/models/__init__.py ## @@ -519,7 +459,6 @@ def bag_dag(self, dag, parent_dag, root_dag):

[GitHub] ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database

2019-02-14 Thread GitBox
ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#discussion_r257113428 ## File path: airflow/migrations/versions/10aab8d908d0_adding_dag_edges.py ## @@ -0,0 +1,63 @@ +# +# Licensed t

[GitHub] ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database

2019-02-14 Thread GitBox
ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#discussion_r257113381 ## File path: airflow/models/__init__.py ## @@ -356,6 +293,9 @@ def process_file(self, filepath, only_if_update

[jira] [Closed] (AIRFLOW-2629) Rename a.h.hive_hooks to a.h.hive_hook

2019-02-14 Thread Tao Feng (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-2629?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tao Feng closed AIRFLOW-2629. - Resolution: Won't Fix > Rename a.h.hive_hooks to a.h.hive_hook > --

[jira] [Closed] (AIRFLOW-3641) Fix DagModel edit icons in the DAGs page to work

2019-02-14 Thread Tao Feng (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3641?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tao Feng closed AIRFLOW-3641. - Resolution: Won't Fix Given we removed non-RBAC code, I don't think we need this jira. > Fix DagModel

[GitHub] ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database

2019-02-14 Thread GitBox
ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#discussion_r257112910 ## File path: airflow/migrations/versions/10aab8d908d0_adding_dag_edges.py ## @@ -0,0 +1,63 @@ +# +# Licensed t

[jira] [Closed] (AIRFLOW-1406) ignore_depends_on_past property ignored by backfill

2019-02-14 Thread Tao Feng (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-1406?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tao Feng closed AIRFLOW-1406. - Resolution: Not A Problem > ignore_depends_on_past property ignored by backfill > -

[jira] [Assigned] (AIRFLOW-3883) Support DAG level access for API

2019-02-14 Thread Tao Feng (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3883?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tao Feng reassigned AIRFLOW-3883: - Assignee: Andrew Stahlman (was: Tao Feng) > Support DAG level access for API > --

[jira] [Commented] (AIRFLOW-3887) Dagre D3 Version 0.6.3 raises merge is not a function error

2019-02-14 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16768957#comment-16768957 ] ASF subversion and git services commented on AIRFLOW-3887: -- Co

[jira] [Closed] (AIRFLOW-3445) MariaDB explicit_defaults_for_timestamp = 1 Does not work.

2019-02-14 Thread Tao Feng (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3445?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tao Feng closed AIRFLOW-3445. - Resolution: Not A Problem > MariaDB explicit_defaults_for_timestamp = 1 Does not work. > --

[jira] [Assigned] (AIRFLOW-3887) Dagre D3 Version 0.6.3 raises merge is not a function error

2019-02-14 Thread Tao Feng (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3887?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tao Feng reassigned AIRFLOW-3887: - Assignee: Andrew Stahlman > Dagre D3 Version 0.6.3 raises merge is not a function error >

[GitHub] feng-tao merged pull request #4713: [AIRFLOW-3887] Downgrade dagre-d3 to 0.4.18

2019-02-14 Thread GitBox
feng-tao merged pull request #4713: [AIRFLOW-3887] Downgrade dagre-d3 to 0.4.18 URL: https://github.com/apache/airflow/pull/4713 This is an automated message from the Apache Git Service. To respond to the message, please log

[jira] [Resolved] (AIRFLOW-3887) Dagre D3 Version 0.6.3 raises merge is not a function error

2019-02-14 Thread Tao Feng (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3887?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tao Feng resolved AIRFLOW-3887. --- Resolution: Fixed > Dagre D3 Version 0.6.3 raises merge is not a function error > -

[jira] [Commented] (AIRFLOW-3887) Dagre D3 Version 0.6.3 raises merge is not a function error

2019-02-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16768956#comment-16768956 ] ASF GitHub Bot commented on AIRFLOW-3887: - feng-tao commented on pull request #

[GitHub] feng-tao commented on issue #4713: [AIRFLOW-3887] Downgrade dagre-d3 to 0.4.18

2019-02-14 Thread GitBox
feng-tao commented on issue #4713: [AIRFLOW-3887] Downgrade dagre-d3 to 0.4.18 URL: https://github.com/apache/airflow/pull/4713#issuecomment-463912496 LGTM This is an automated message from the Apache Git Service. To respond t

[jira] [Commented] (AIRFLOW-3887) Dagre D3 Version 0.6.3 raises merge is not a function error

2019-02-14 Thread Andrew Stahlman (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16768946#comment-16768946 ] Andrew Stahlman commented on AIRFLOW-3887: -- Submitted a PR to temporarily down

[GitHub] astahlman commented on issue #4713: [AIRFLOW-3887] Downgrade dagre-d3 to 0.4.18

2019-02-14 Thread GitBox
astahlman commented on issue #4713: [AIRFLOW-3887] Downgrade dagre-d3 to 0.4.18 URL: https://github.com/apache/airflow/pull/4713#issuecomment-463907708 cc @feng-tao This is an automated message from the Apache Git Service. To

[GitHub] astahlman commented on issue #4713: [AIRFLOW-3887] Downgrade dagre-d3 to 0.4.18

2019-02-14 Thread GitBox
astahlman commented on issue #4713: [AIRFLOW-3887] Downgrade dagre-d3 to 0.4.18 URL: https://github.com/apache/airflow/pull/4713#issuecomment-463907414 # Before ![screen shot 2019-02-14 at 8 56 37 pm](https://user-images.githubusercontent.com/1173394/52835467-5f648c80-309b-11e9-98c4-4cb1

[jira] [Commented] (AIRFLOW-3887) Dagre D3 Version 0.6.3 raises merge is not a function error

2019-02-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16768938#comment-16768938 ] ASF GitHub Bot commented on AIRFLOW-3887: - astahlman commented on pull request

[GitHub] astahlman opened a new pull request #4713: [AIRFLOW-3887] Downgrade dagre-d3 to 0.4.18

2019-02-14 Thread GitBox
astahlman opened a new pull request #4713: [AIRFLOW-3887] Downgrade dagre-d3 to 0.4.18 URL: https://github.com/apache/airflow/pull/4713 Make sure you have checked _all_ steps below. ### Jira - [ X ] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/b

[GitHub] mik-laj commented on issue #4667: [AIRFLOW-3826] Group SageMaker sensors and operators into 2 files

2019-02-14 Thread GitBox
mik-laj commented on issue #4667: [AIRFLOW-3826] Group SageMaker sensors and operators into 2 files URL: https://github.com/apache/airflow/pull/4667#issuecomment-463905335 @ashb SageMaker is a service from Amazon Web Services. I think that we should emphasize this. ---

[GitHub] astahlman commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database

2019-02-14 Thread GitBox
astahlman commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#discussion_r257097558 ## File path: tests/test_models.py ## @@ -2811,7 +2889,7 @@ def test_email_alert(self, mock_send_email):

[GitHub] astahlman commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database

2019-02-14 Thread GitBox
astahlman commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#discussion_r257101516 ## File path: tests/core.py ## @@ -166,6 +176,7 @@ def test_schedule_dag_relativedelta(self): t

[GitHub] astahlman commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database

2019-02-14 Thread GitBox
astahlman commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#discussion_r257084944 ## File path: airflow/models/__init__.py ## @@ -4012,17 +4088,55 @@ def create_dagrun(self, con

[GitHub] astahlman commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database

2019-02-14 Thread GitBox
astahlman commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#discussion_r257091744 ## File path: airflow/www/views.py ## @@ -920,10 +924,16 @@ def clear(self): dag_id = request.args.

[GitHub] astahlman commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database

2019-02-14 Thread GitBox
astahlman commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#discussion_r257098566 ## File path: airflow/models/__init__.py ## @@ -1856,6 +1851,13 @@ def init_run_context(self, raw=False):

[GitHub] astahlman commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database

2019-02-14 Thread GitBox
astahlman commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#discussion_r257092061 ## File path: airflow/www/views.py ## @@ -1293,24 +1303,30 @@ def set_duration(tid): def graph(self, se

[GitHub] astahlman commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database

2019-02-14 Thread GitBox
astahlman commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#discussion_r257099513 ## File path: airflow/models/__init__.py ## @@ -2812,16 +2821,39 @@ def get_default_view(self):

[GitHub] astahlman commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database

2019-02-14 Thread GitBox
astahlman commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#discussion_r257091521 ## File path: airflow/www/views.py ## @@ -920,10 +924,16 @@ def clear(self): dag_id = request.args.

[GitHub] astahlman commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database

2019-02-14 Thread GitBox
astahlman commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#discussion_r257082752 ## File path: airflow/models/__init__.py ## @@ -2812,16 +2821,39 @@ def get_default_view(self):

[GitHub] astahlman commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database

2019-02-14 Thread GitBox
astahlman commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#discussion_r257100875 ## File path: airflow/models/__init__.py ## @@ -3118,6 +3150,50 @@ def date_range(self, start_date, num=None

[GitHub] astahlman commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database

2019-02-14 Thread GitBox
astahlman commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#discussion_r257101039 ## File path: airflow/models/__init__.py ## @@ -3118,6 +3150,50 @@ def date_range(self, start_date, num=None

[GitHub] astahlman commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database

2019-02-14 Thread GitBox
astahlman commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#discussion_r257098437 ## File path: airflow/models/__init__.py ## @@ -193,70 +194,6 @@ def get_fernet(): _CONTEXT_MANAGER_DAG = N

[GitHub] astahlman commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database

2019-02-14 Thread GitBox
astahlman commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#discussion_r257096012 ## File path: airflow/www/views.py ## @@ -1293,24 +1303,30 @@ def set_duration(tid): def graph(self, se

[GitHub] astahlman commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database

2019-02-14 Thread GitBox
astahlman commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#discussion_r257100914 ## File path: airflow/models/__init__.py ## @@ -3118,6 +3150,50 @@ def date_range(self, start_date, num=None

[GitHub] zhongjiajie commented on a change in pull request #4712: [AIRFLOW-3892] Create Redis pub sub sensor

2019-02-14 Thread GitBox
zhongjiajie commented on a change in pull request #4712: [AIRFLOW-3892] Create Redis pub sub sensor URL: https://github.com/apache/airflow/pull/4712#discussion_r257077359 ## File path: airflow/contrib/sensors/redis_pub_sub_sensor.py ## @@ -0,0 +1,72 @@ +# -*- coding: utf-8

[GitHub] zhongjiajie commented on a change in pull request #4712: [AIRFLOW-3892] Create Redis pub sub sensor

2019-02-14 Thread GitBox
zhongjiajie commented on a change in pull request #4712: [AIRFLOW-3892] Create Redis pub sub sensor URL: https://github.com/apache/airflow/pull/4712#discussion_r257077747 ## File path: tests/contrib/sensors/test_redis_pub_sub_sensor.py ## @@ -0,0 +1,90 @@ +# -*- coding: ut

[GitHub] zhongjiajie commented on a change in pull request #4712: [AIRFLOW-3892] Create Redis pub sub sensor

2019-02-14 Thread GitBox
zhongjiajie commented on a change in pull request #4712: [AIRFLOW-3892] Create Redis pub sub sensor URL: https://github.com/apache/airflow/pull/4712#discussion_r257074811 ## File path: tests/contrib/sensors/test_redis_pub_sub_sensor.py ## @@ -0,0 +1,90 @@ +# -*- coding: ut

[GitHub] zhongjiajie commented on a change in pull request #4712: [AIRFLOW-3892] Create Redis pub sub sensor

2019-02-14 Thread GitBox
zhongjiajie commented on a change in pull request #4712: [AIRFLOW-3892] Create Redis pub sub sensor URL: https://github.com/apache/airflow/pull/4712#discussion_r257075532 ## File path: airflow/contrib/sensors/redis_pub_sub_sensor.py ## @@ -0,0 +1,72 @@ +# -*- coding: utf-8

[jira] [Work started] (AIRFLOW-3892) Create RedisPubSubSensor

2019-02-14 Thread Mans Singh (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3892?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on AIRFLOW-3892 started by Mans Singh. --- > Create RedisPubSubSensor > > > Key: A

[jira] [Commented] (AIRFLOW-3892) Create RedisPubSubSensor

2019-02-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16768770#comment-16768770 ] ASF GitHub Bot commented on AIRFLOW-3892: - mans2singh commented on pull request

[GitHub] mans2singh opened a new pull request #4712: [AIRFLOW-3892] Create Redis pub sub sensor

2019-02-14 Thread GitBox
mans2singh opened a new pull request #4712: [AIRFLOW-3892] Create Redis pub sub sensor URL: https://github.com/apache/airflow/pull/4712 Make sure you have checked _all_ steps below. ### Jira - [x] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/bro

[jira] [Created] (AIRFLOW-3892) Create RedisPubSubSensor

2019-02-14 Thread Mans Singh (JIRA)
Mans Singh created AIRFLOW-3892: --- Summary: Create RedisPubSubSensor Key: AIRFLOW-3892 URL: https://issues.apache.org/jira/browse/AIRFLOW-3892 Project: Apache Airflow Issue Type: New Feature

[jira] [Commented] (AIRFLOW-351) Failed to clear downstream tasks

2019-02-14 Thread Tao Feng (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16768750#comment-16768750 ] Tao Feng commented on AIRFLOW-351: -- we do this in python_operator:  https://github.com/

[GitHub] chang removed a comment on issue #4711: [AIRFLOW-XXX] Add Asana to companies list

2019-02-14 Thread GitBox
chang removed a comment on issue #4711: [AIRFLOW-XXX] Add Asana to companies list URL: https://github.com/apache/airflow/pull/4711#issuecomment-463781605 Thanks for the great work, and hello from down the street! This is an a

[jira] [Commented] (AIRFLOW-351) Failed to clear downstream tasks

2019-02-14 Thread Vijay Thakorlal (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16768721#comment-16768721 ] Vijay Thakorlal commented on AIRFLOW-351: - In my case it's the RemoteSparkSubmit

[GitHub] feng-tao merged pull request #4711: [AIRFLOW-XXX] Add Asana to companies list

2019-02-14 Thread GitBox
feng-tao merged pull request #4711: [AIRFLOW-XXX] Add Asana to companies list URL: https://github.com/apache/airflow/pull/4711 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] chang commented on issue #4711: [AIRFLOW-XXX] Add Asana to companies list

2019-02-14 Thread GitBox
chang commented on issue #4711: [AIRFLOW-XXX] Add Asana to companies list URL: https://github.com/apache/airflow/pull/4711#issuecomment-463781605 Thanks for the great work, and hello from down the street! This is an automated

[jira] [Commented] (AIRFLOW-351) Failed to clear downstream tasks

2019-02-14 Thread Tao Feng (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16768684#comment-16768684 ] Tao Feng commented on AIRFLOW-351: -- [~eronarn] , which operator do you encounter the is

[GitHub] chang opened a new pull request #4711: Add Asana to companies list

2019-02-14 Thread GitBox
chang opened a new pull request #4711: Add Asana to companies list URL: https://github.com/apache/airflow/pull/4711 Make sure you have checked _all_ steps below. ### Jira - [ ] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues

[GitHub] mik-laj commented on a change in pull request #4665: [AIRFLOW-3701] Google Cloud Vision Product Search operators

2019-02-14 Thread GitBox
mik-laj commented on a change in pull request #4665: [AIRFLOW-3701] Google Cloud Vision Product Search operators URL: https://github.com/apache/airflow/pull/4665#discussion_r256979924 ## File path: airflow/contrib/hooks/gcp_vision_hook.py ## @@ -0,0 +1,253 @@ +# -*- coding

[GitHub] mik-laj commented on a change in pull request #4665: [AIRFLOW-3701] Google Cloud Vision Product Search operators

2019-02-14 Thread GitBox
mik-laj commented on a change in pull request #4665: [AIRFLOW-3701] Google Cloud Vision Product Search operators URL: https://github.com/apache/airflow/pull/4665#discussion_r256975229 ## File path: airflow/contrib/hooks/gcp_vision_hook.py ## @@ -0,0 +1,253 @@ +# -*- coding

[GitHub] mik-laj commented on a change in pull request #4665: [AIRFLOW-3701] Google Cloud Vision Product Search operators

2019-02-14 Thread GitBox
mik-laj commented on a change in pull request #4665: [AIRFLOW-3701] Google Cloud Vision Product Search operators URL: https://github.com/apache/airflow/pull/4665#discussion_r256975229 ## File path: airflow/contrib/hooks/gcp_vision_hook.py ## @@ -0,0 +1,253 @@ +# -*- coding

[GitHub] drewsonne commented on issue #4707: [AIRFLOW-3891] Disable SQL Alchemy tracking

2019-02-14 Thread GitBox
drewsonne commented on issue #4707: [AIRFLOW-3891] Disable SQL Alchemy tracking URL: https://github.com/apache/airflow/pull/4707#issuecomment-463748246 I created this PR before work, and came back and now I feel like I didn’t take part in most of it, but it’s got my name on it anyway. Good

[GitHub] feng-tao commented on issue #4396: [AIRFLOW-3585] - Add edges to database

2019-02-14 Thread GitBox
feng-tao commented on issue #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#issuecomment-463743368 Any increased scheduler latency with this change? This is an automated message f

[GitHub] feng-tao commented on issue #4396: [AIRFLOW-3585] - Add edges to database

2019-02-14 Thread GitBox
feng-tao commented on issue #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#issuecomment-463741543 given it is such a big change, it would be good to get more pairs of eyes for this pr: cc @mistercrunch , @bolkedebruin , @astahlman ---

[GitHub] feng-tao commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database

2019-02-14 Thread GitBox
feng-tao commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#discussion_r256952832 ## File path: airflow/models/dag_edge.py ## @@ -0,0 +1,60 @@ +# -*- coding: utf-8 -*- +# +# Licensed to the A

[GitHub] feng-tao commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database

2019-02-14 Thread GitBox
feng-tao commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#discussion_r256946641 ## File path: airflow/models/__init__.py ## @@ -679,6 +620,9 @@ def __init__(self, task, execution_date, stat

[GitHub] feng-tao commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database

2019-02-14 Thread GitBox
feng-tao commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#discussion_r256957133 ## File path: airflow/www/views.py ## @@ -1319,24 +1335,20 @@ def graph(self, session=None):

[GitHub] feng-tao commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database

2019-02-14 Thread GitBox
feng-tao commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#discussion_r256950610 ## File path: airflow/models/__init__.py ## @@ -4012,17 +4088,55 @@ def create_dagrun(self, conf

[GitHub] feng-tao commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database

2019-02-14 Thread GitBox
feng-tao commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#discussion_r256957942 ## File path: tests/core.py ## @@ -2878,13 +2903,6 @@ def test_get_connections_env_var(self): assert

[GitHub] feng-tao commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database

2019-02-14 Thread GitBox
feng-tao commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#discussion_r256945081 ## File path: airflow/migrations/versions/10aab8d908d0_adding_dag_edges.py ## @@ -0,0 +1,63 @@ +# +# Licensed

[GitHub] feng-tao commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database

2019-02-14 Thread GitBox
feng-tao commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#discussion_r256958070 ## File path: tests/sensors/test_base_sensor.py ## @@ -60,12 +61,12 @@ def setUp(self): 'start_d

[GitHub] feng-tao commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database

2019-02-14 Thread GitBox
feng-tao commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#discussion_r256951023 ## File path: airflow/models/__init__.py ## @@ -4012,17 +4088,55 @@ def create_dagrun(self, conf

[GitHub] feng-tao commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database

2019-02-14 Thread GitBox
feng-tao commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#discussion_r256945433 ## File path: airflow/models/__init__.py ## @@ -96,7 +97,7 @@ from airflow.utils import timezone from airfl

[GitHub] feng-tao commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database

2019-02-14 Thread GitBox
feng-tao commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#discussion_r256948569 ## File path: airflow/models/__init__.py ## @@ -2812,16 +2821,39 @@ def get_default_view(self):

[GitHub] feng-tao commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database

2019-02-14 Thread GitBox
feng-tao commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#discussion_r256954379 ## File path: airflow/operators/subdag_operator.py ## @@ -91,6 +91,8 @@ def __init__( )

[GitHub] feng-tao commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database

2019-02-14 Thread GitBox
feng-tao commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#discussion_r256945759 ## File path: airflow/models/__init__.py ## @@ -356,6 +293,9 @@ def process_file(self, filepath, only_if_upda

[GitHub] feng-tao commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database

2019-02-14 Thread GitBox
feng-tao commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#discussion_r256948963 ## File path: airflow/models/__init__.py ## @@ -2812,16 +2821,39 @@ def get_default_view(self):

[GitHub] feng-tao commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database

2019-02-14 Thread GitBox
feng-tao commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#discussion_r256944362 ## File path: airflow/jobs.py ## @@ -1869,7 +1869,7 @@ def __init__( start_date=None,

[GitHub] feng-tao commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database

2019-02-14 Thread GitBox
feng-tao commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#discussion_r256954139 ## File path: airflow/models/dag_edge.py ## @@ -0,0 +1,60 @@ +# -*- coding: utf-8 -*- +# +# Licensed to the A

[GitHub] feng-tao commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database

2019-02-14 Thread GitBox
feng-tao commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#discussion_r256951924 ## File path: airflow/models/__init__.py ## @@ -4050,8 +4164,14 @@ def sync_to_db(self, owner=None, sync_time

  1   2   3   >