[GitHub] ffinfo commented on issue #4396: [AIRFLOW-3585] - Add edges to database

2019-02-15 Thread GitBox
ffinfo commented on issue #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#issuecomment-464308526 Small comment on the screenshots. As you can see the edges itself are not visible but this also happens on master. Can take a look at this but let'

[GitHub] ffinfo edited a comment on issue #4396: [AIRFLOW-3585] - Add edges to database

2019-02-15 Thread GitBox
ffinfo edited a comment on issue #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#issuecomment-464307752 @feng-tao and @astahlman I think I have the a solution. I created a fall back on the graph view on the last known graph in de database. With

[GitHub] ffinfo commented on issue #4396: [AIRFLOW-3585] - Add edges to database

2019-02-15 Thread GitBox
ffinfo commented on issue #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#issuecomment-464307752 @feng-tao and @astahlman I think I have the a solution. I created a fall back on the graph view on the last known graph in de database. With this a

[GitHub] ffinfo commented on issue #4396: [AIRFLOW-3585] - Add edges to database

2019-02-15 Thread GitBox
ffinfo commented on issue #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#issuecomment-464302726 @feng-tao option 2 is already implemented. Maybe it's better to keep is like this. The problem here is that this changes makes historical graphs

[GitHub] BasPH commented on a change in pull request #4716: [AIRFLOW-3896] Add running command logging back to SSHOperator

2019-02-15 Thread GitBox
BasPH commented on a change in pull request #4716: [AIRFLOW-3896] Add running command logging back to SSHOperator URL: https://github.com/apache/airflow/pull/4716#discussion_r257449904 ## File path: airflow/contrib/operators/ssh_operator.py ## @@ -99,6 +99,8 @@ def execute

[GitHub] BasPH commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database

2019-02-15 Thread GitBox
BasPH commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#discussion_r257449604 ## File path: airflow/www/views.py ## @@ -1349,21 +1357,26 @@ class GraphForm(DateTimeWithNumRunsWithDagRunsForm

[GitHub] ramandumcs commented on a change in pull request #4687: [AIRFLOW-3865] Added api to get python code of a given Dag id

2019-02-15 Thread GitBox
ramandumcs commented on a change in pull request #4687: [AIRFLOW-3865] Added api to get python code of a given Dag id URL: https://github.com/apache/airflow/pull/4687#discussion_r257447343 ## File path: airflow/api/common/experimental/get_code.py ## @@ -0,0 +1,42 @@ +# -*-

[GitHub] jmcarp commented on issue #4685: [AIRFLOW-3862] Check types with mypy.

2019-02-15 Thread GitBox
jmcarp commented on issue #4685: [AIRFLOW-3862] Check types with mypy. URL: https://github.com/apache/airflow/pull/4685#issuecomment-464293281 Thanks @mik-laj. Looks like travis was using the same install steps for all pre-test stages. I updated those stages to just install their requiremen

[GitHub] feng-tao commented on issue #4646: AIRFLOW-3543: Fix deletion of DAG with rescheduled tasks

2019-02-15 Thread GitBox
feng-tao commented on issue #4646: AIRFLOW-3543: Fix deletion of DAG with rescheduled tasks URL: https://github.com/apache/airflow/pull/4646#issuecomment-464291435 @seelmann , any update? This is an automated message from the

[jira] [Commented] (AIRFLOW-3900) Prevent undefined variables in templates

2019-02-15 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16770013#comment-16770013 ] ASF subversion and git services commented on AIRFLOW-3900: -- Co

[jira] [Commented] (AIRFLOW-3900) Prevent undefined variables in templates

2019-02-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16770012#comment-16770012 ] ASF GitHub Bot commented on AIRFLOW-3900: - feng-tao commented on pull request #

[GitHub] feng-tao merged pull request #4719: [AIRFLOW-3900] Error on undefined template variables in unit tests.

2019-02-15 Thread GitBox
feng-tao merged pull request #4719: [AIRFLOW-3900] Error on undefined template variables in unit tests. URL: https://github.com/apache/airflow/pull/4719 This is an automated message from the Apache Git Service. To respond to

[jira] [Resolved] (AIRFLOW-3900) Prevent undefined variables in templates

2019-02-15 Thread Tao Feng (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3900?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tao Feng resolved AIRFLOW-3900. --- Resolution: Fixed > Prevent undefined variables in templates >

[GitHub] mik-laj commented on issue #4685: [AIRFLOW-3862] Check types with mypy.

2019-02-15 Thread GitBox
mik-laj commented on issue #4685: [AIRFLOW-3862] Check types with mypy. URL: https://github.com/apache/airflow/pull/4685#issuecomment-464285412 Why is this process taking over 4 minutes? i because of this line? `Docker-compose -f scripts/ci/docker-compose.yml pull --quiet --parallel` m

[GitHub] codecov-io commented on issue #4717: [AIRFLOW-3895] GoogleCloudStorageHook create_bucket with optional request body

2019-02-15 Thread GitBox
codecov-io commented on issue #4717: [AIRFLOW-3895] GoogleCloudStorageHook create_bucket with optional request body URL: https://github.com/apache/airflow/pull/4717#issuecomment-464284571 # [Codecov](https://codecov.io/gh/apache/airflow/pull/4717?src=pr&el=h1) Report > Merging [#4717](

[GitHub] codecov-io edited a comment on issue #4719: [AIRFLOW-3900] Error on undefined template variables in unit tests.

2019-02-15 Thread GitBox
codecov-io edited a comment on issue #4719: [AIRFLOW-3900] Error on undefined template variables in unit tests. URL: https://github.com/apache/airflow/pull/4719#issuecomment-464284310 # [Codecov](https://codecov.io/gh/apache/airflow/pull/4719?src=pr&el=h1) Report > Merging [#4719](http

[GitHub] codecov-io commented on issue #4719: [AIRFLOW-3900] Error on undefined template variables in unit tests.

2019-02-15 Thread GitBox
codecov-io commented on issue #4719: [AIRFLOW-3900] Error on undefined template variables in unit tests. URL: https://github.com/apache/airflow/pull/4719#issuecomment-464284310 # [Codecov](https://codecov.io/gh/apache/airflow/pull/4719?src=pr&el=h1) Report > Merging [#4719](https://cod

[GitHub] mik-laj commented on issue #4523: [AIRFLOW-3616][AIRFLOW-1215] Add aliases for schema with underscore

2019-02-15 Thread GitBox
mik-laj commented on issue #4523: [AIRFLOW-3616][AIRFLOW-1215] Add aliases for schema with underscore URL: https://github.com/apache/airflow/pull/4523#issuecomment-464283627 @ashb rebased. People are waiting for this PR.yesterday They were discussing on the slack.

[GitHub] jmcarp commented on issue #4685: [AIRFLOW-3862] Check types with mypy.

2019-02-15 Thread GitBox
jmcarp commented on issue #4685: [AIRFLOW-3862] Check types with mypy. URL: https://github.com/apache/airflow/pull/4685#issuecomment-464282257 @ashb: thanks for reviewing! I think I addressed your comments--sorry if I missed anything. Have time to take another look? ---

[GitHub] jmcarp commented on a change in pull request #4685: [AIRFLOW-3862] Check types with mypy.

2019-02-15 Thread GitBox
jmcarp commented on a change in pull request #4685: [AIRFLOW-3862] Check types with mypy. URL: https://github.com/apache/airflow/pull/4685#discussion_r257444670 ## File path: setup.py ## @@ -319,6 +318,7 @@ def do_setup(): 'sqlalchemy>=1.1.15, <1.3.0',

[GitHub] mik-laj commented on issue #4708: [AIRFLOW-3888] HA for metastore connection

2019-02-15 Thread GitBox
mik-laj commented on issue #4708: [AIRFLOW-3888] HA for metastore connection URL: https://github.com/apache/airflow/pull/4708#issuecomment-464281363 I prepared a PR with my other idea: https://github.com/GuzikJakub/airflow/pull/1 Uses AA mechanisms to store multiple connections rath

[GitHub] zhongjiajie commented on a change in pull request #4712: [AIRFLOW-3892] Create Redis pub sub sensor

2019-02-15 Thread GitBox
zhongjiajie commented on a change in pull request #4712: [AIRFLOW-3892] Create Redis pub sub sensor URL: https://github.com/apache/airflow/pull/4712#discussion_r257443974 ## File path: airflow/contrib/sensors/redis_pub_sub_sensor.py ## @@ -0,0 +1,72 @@ +# -*- coding: utf-8

[GitHub] galak75 commented on issue #4691: [AIRFLOW-1814] : templatize PythonOperator op_args and op_kwargs fields

2019-02-15 Thread GitBox
galak75 commented on issue #4691: [AIRFLOW-1814] : templatize PythonOperator op_args and op_kwargs fields URL: https://github.com/apache/airflow/pull/4691#issuecomment-464279041 I checked, and it actually fails with a `TypeError: Object of type Mock is not JSON serializable` see https:/

[GitHub] mans2singh commented on a change in pull request #4712: [AIRFLOW-3892] Create Redis pub sub sensor

2019-02-15 Thread GitBox
mans2singh commented on a change in pull request #4712: [AIRFLOW-3892] Create Redis pub sub sensor URL: https://github.com/apache/airflow/pull/4712#discussion_r257443114 ## File path: airflow/contrib/sensors/redis_pub_sub_sensor.py ## @@ -0,0 +1,72 @@ +# -*- coding: utf-8

[jira] [Commented] (AIRFLOW-161) Redirection to external url

2019-02-15 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16769981#comment-16769981 ] ASF subversion and git services commented on AIRFLOW-161: - Commi

[jira] [Reopened] (AIRFLOW-161) Redirection to external url

2019-02-15 Thread Tao Feng (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-161?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tao Feng reopened AIRFLOW-161: -- > Redirection to external url > --- > > Key: AIRFLOW-161 >

[jira] [Commented] (AIRFLOW-161) Redirection to external url

2019-02-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16769982#comment-16769982 ] ASF GitHub Bot commented on AIRFLOW-161: feng-tao commented on pull request #472

[GitHub] feng-tao merged pull request #4720: Revert "[AIRFLOW-161] New redirect route and extra links"

2019-02-15 Thread GitBox
feng-tao merged pull request #4720: Revert "[AIRFLOW-161] New redirect route and extra links" URL: https://github.com/apache/airflow/pull/4720 This is an automated message from the Apache Git Service. To respond to the messa

[jira] [Commented] (AIRFLOW-161) Redirection to external url

2019-02-15 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16769983#comment-16769983 ] ASF subversion and git services commented on AIRFLOW-161: - Commi

[jira] [Commented] (AIRFLOW-161) Redirection to external url

2019-02-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16769975#comment-16769975 ] ASF GitHub Bot commented on AIRFLOW-161: feng-tao commented on pull request #472

[GitHub] feng-tao commented on issue #4720: Revert "[AIRFLOW-161] New redirect route and extra links"

2019-02-15 Thread GitBox
feng-tao commented on issue #4720: Revert "[AIRFLOW-161] New redirect route and extra links" URL: https://github.com/apache/airflow/pull/4720#issuecomment-464274659 cc @ArgentFalcon @msumit @kaxil This is an automated messag

[GitHub] feng-tao opened a new pull request #4720: Revert "[AIRFLOW-161] New redirect route and extra links"

2019-02-15 Thread GitBox
feng-tao opened a new pull request #4720: Revert "[AIRFLOW-161] New redirect route and extra links" URL: https://github.com/apache/airflow/pull/4720 Reverts apache/airflow#3533 The pr passes pr tests, but fails at master branch. --

[GitHub] feng-tao commented on issue #3533: [AIRFLOW-161] New redirect route and extra links

2019-02-15 Thread GitBox
feng-tao commented on issue #3533: [AIRFLOW-161] New redirect route and extra links URL: https://github.com/apache/airflow/pull/3533#issuecomment-464274582 @ArgentFalcon , somehow the test is consistently failing in master branch. I am going to revert it for now. Please investigate and res

[jira] [Created] (AIRFLOW-3900) Prevent undefined variables in templates

2019-02-15 Thread Josh Carp (JIRA)
Josh Carp created AIRFLOW-3900: -- Summary: Prevent undefined variables in templates Key: AIRFLOW-3900 URL: https://issues.apache.org/jira/browse/AIRFLOW-3900 Project: Apache Airflow Issue Type: I

[jira] [Commented] (AIRFLOW-3900) Prevent undefined variables in templates

2019-02-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16769972#comment-16769972 ] ASF GitHub Bot commented on AIRFLOW-3900: - jmcarp commented on pull request #47

[GitHub] jmcarp opened a new pull request #4719: [AIRFLOW-3900] Error on undefined template variables in unit tests.

2019-02-15 Thread GitBox
jmcarp opened a new pull request #4719: [AIRFLOW-3900] Error on undefined template variables in unit tests. URL: https://github.com/apache/airflow/pull/4719 Make sure you have checked _all_ steps below. ### Jira - [x] My PR addresses the following [Airflow Jira](https://issue

[GitHub] ryanyuan commented on a change in pull request #4717: [AIRFLOW-3895] GoogleCloudStorageHook create_bucket with optional request body

2019-02-15 Thread GitBox
ryanyuan commented on a change in pull request #4717: [AIRFLOW-3895] GoogleCloudStorageHook create_bucket with optional request body URL: https://github.com/apache/airflow/pull/4717#discussion_r257425180 ## File path: airflow/contrib/hooks/gcs_hook.py ## @@ -543,11 +549,12

[GitHub] ryanyuan commented on a change in pull request #4717: [AIRFLOW-3895] GoogleCloudStorageHook create_bucket with optional request body

2019-02-15 Thread GitBox
ryanyuan commented on a change in pull request #4717: [AIRFLOW-3895] GoogleCloudStorageHook create_bucket with optional request body URL: https://github.com/apache/airflow/pull/4717#discussion_r257430921 ## File path: tests/contrib/operators/test_gcs_operator.py ## @@ -42,

[GitHub] ryanyuan commented on a change in pull request #4717: [AIRFLOW-3895] GoogleCloudStorageHook create_bucket with optional request body

2019-02-15 Thread GitBox
ryanyuan commented on a change in pull request #4717: [AIRFLOW-3895] GoogleCloudStorageHook create_bucket with optional request body URL: https://github.com/apache/airflow/pull/4717#discussion_r257429922 ## File path: airflow/contrib/hooks/gcs_hook.py ## @@ -543,11 +549,12

[GitHub] feluelle edited a comment on issue #4490: [AIRFLOW-3683] Fix formatting of error message for invalid TriggerRule

2019-02-15 Thread GitBox
feluelle edited a comment on issue #4490: [AIRFLOW-3683] Fix formatting of error message for invalid TriggerRule URL: https://github.com/apache/airflow/pull/4490#issuecomment-464256431 @ashb a trivial change. [all_triggers](https://github.com/apache/airflow/blob/master/airflow/utils/trigge

[GitHub] feluelle commented on issue #4490: [AIRFLOW-3683] Fix formatting of error message for invalid TriggerRule

2019-02-15 Thread GitBox
feluelle commented on issue #4490: [AIRFLOW-3683] Fix formatting of error message for invalid TriggerRule URL: https://github.com/apache/airflow/pull/4490#issuecomment-464256431 @ashb a trivial change. [all_triggers](https://github.com/apache/airflow/blob/master/airflow/utils/trigger_rule.

[GitHub] ybendana commented on a change in pull request #4291: [AIRFLOW-1488] Add the DagRunSensor operator

2019-02-15 Thread GitBox
ybendana commented on a change in pull request #4291: [AIRFLOW-1488] Add the DagRunSensor operator URL: https://github.com/apache/airflow/pull/4291#discussion_r257427723 ## File path: airflow/contrib/sensors/dagrun_sensor.py ## @@ -0,0 +1,76 @@ +# -*- coding: utf-8 -*- +#

[GitHub] ybendana commented on a change in pull request #4291: [AIRFLOW-1488] Add the DagRunSensor operator

2019-02-15 Thread GitBox
ybendana commented on a change in pull request #4291: [AIRFLOW-1488] Add the DagRunSensor operator URL: https://github.com/apache/airflow/pull/4291#discussion_r257427806 ## File path: airflow/contrib/sensors/dagrun_sensor.py ## @@ -0,0 +1,76 @@ +# -*- coding: utf-8 -*- +#

[GitHub] ybendana commented on a change in pull request #4291: [AIRFLOW-1488] Add the DagRunSensor operator

2019-02-15 Thread GitBox
ybendana commented on a change in pull request #4291: [AIRFLOW-1488] Add the DagRunSensor operator URL: https://github.com/apache/airflow/pull/4291#discussion_r257427665 ## File path: airflow/contrib/sensors/dagrun_sensor.py ## @@ -0,0 +1,76 @@ +# -*- coding: utf-8 -*- +#

[GitHub] ybendana commented on a change in pull request #4291: [AIRFLOW-1488] Add the DagRunSensor operator

2019-02-15 Thread GitBox
ybendana commented on a change in pull request #4291: [AIRFLOW-1488] Add the DagRunSensor operator URL: https://github.com/apache/airflow/pull/4291#discussion_r257427609 ## File path: airflow/contrib/sensors/dagrun_sensor.py ## @@ -0,0 +1,76 @@ +# -*- coding: utf-8 -*- +#

[GitHub] ffinfo commented on issue #4396: [AIRFLOW-3585] - Add edges to database

2019-02-15 Thread GitBox
ffinfo commented on issue #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#issuecomment-464247441 @feng-tao I will add this to the migration. Only bad thing is that this migration step then requires to parse all dag files. But I can see this is

[GitHub] ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database

2019-02-15 Thread GitBox
ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#discussion_r257424502 ## File path: airflow/models/__init__.py ## @@ -193,70 +194,6 @@ def get_fernet(): _CONTEXT_MANAGER_DAG = None

[jira] [Resolved] (AIRFLOW-3898) Doc: show example connection string when using Psycopg2

2019-02-15 Thread Tao Feng (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3898?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tao Feng resolved AIRFLOW-3898. --- Resolution: Fixed > Doc: show example connection string when using Psycopg2 > -

[jira] [Commented] (AIRFLOW-3898) Doc: show example connection string when using Psycopg2

2019-02-15 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16769857#comment-16769857 ] ASF subversion and git services commented on AIRFLOW-3898: -- Co

[jira] [Commented] (AIRFLOW-3898) Doc: show example connection string when using Psycopg2

2019-02-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16769855#comment-16769855 ] ASF GitHub Bot commented on AIRFLOW-3898: - feng-tao commented on pull request #

[GitHub] feng-tao merged pull request #4718: [AIRFLOW-3898] Show example connection string when using Psycopg2

2019-02-15 Thread GitBox
feng-tao merged pull request #4718: [AIRFLOW-3898] Show example connection string when using Psycopg2 URL: https://github.com/apache/airflow/pull/4718 This is an automated message from the Apache Git Service. To respond to t

[GitHub] ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database

2019-02-15 Thread GitBox
ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#discussion_r257423876 ## File path: airflow/www/views.py ## @@ -1293,24 +1303,30 @@ def set_duration(tid): def graph(self, sessi

[jira] [Commented] (AIRFLOW-3853) Duplicate Logs appearing in S3

2019-02-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16769850#comment-16769850 ] ASF GitHub Bot commented on AIRFLOW-3853: - samuelwbock commented on pull reques

[GitHub] samuelwbock opened a new pull request #4675: [AIRFLOW-3853] Default to delete local logs after remote upload

2019-02-15 Thread GitBox
samuelwbock opened a new pull request #4675: [AIRFLOW-3853] Default to delete local logs after remote upload URL: https://github.com/apache/airflow/pull/4675 Make sure you have checked _all_ steps below. ### Jira - [X] My PR addresses the following [Airflow Jira](https://issu

[GitHub] ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database

2019-02-15 Thread GitBox
ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#discussion_r257423430 ## File path: airflow/models/dag_edge.py ## @@ -0,0 +1,60 @@ +# -*- coding: utf-8 -*- +# +# Licensed to the Apa

[GitHub] codecov-io edited a comment on issue #3533: [AIRFLOW-161] New redirect route and extra links

2019-02-15 Thread GitBox
codecov-io edited a comment on issue #3533: [AIRFLOW-161] New redirect route and extra links URL: https://github.com/apache/airflow/pull/3533#issuecomment-400106002 # [Codecov](https://codecov.io/gh/apache/airflow/pull/3533?src=pr&el=h1) Report > Merging [#3533](https://codecov.io/gh/a

[GitHub] codecov-io edited a comment on issue #3533: [AIRFLOW-161] New redirect route and extra links

2019-02-15 Thread GitBox
codecov-io edited a comment on issue #3533: [AIRFLOW-161] New redirect route and extra links URL: https://github.com/apache/airflow/pull/3533#issuecomment-400106002 # [Codecov](https://codecov.io/gh/apache/airflow/pull/3533?src=pr&el=h1) Report > Merging [#3533](https://codecov.io/gh/a

[GitHub] ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database

2019-02-15 Thread GitBox
ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#discussion_r257422882 ## File path: tests/core.py ## @@ -166,6 +176,7 @@ def test_schedule_dag_relativedelta(self): task

[jira] [Commented] (AIRFLOW-3853) Duplicate Logs appearing in S3

2019-02-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16769844#comment-16769844 ] ASF GitHub Bot commented on AIRFLOW-3853: - samuelwbock commented on pull reques

[jira] [Resolved] (AIRFLOW-161) Redirection to external url

2019-02-15 Thread Tao Feng (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-161?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tao Feng resolved AIRFLOW-161. -- Resolution: Fixed Assignee: Max Payton (was: Sumit Maheshwari) > Redirection to external url >

[GitHub] samuelwbock closed pull request #4675: [AIRFLOW-3853] Default to delete local logs after remote upload

2019-02-15 Thread GitBox
samuelwbock closed pull request #4675: [AIRFLOW-3853] Default to delete local logs after remote upload URL: https://github.com/apache/airflow/pull/4675 This is an automated message from the Apache Git Service. To respond to

[GitHub] ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database

2019-02-15 Thread GitBox
ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#discussion_r257422195 ## File path: airflow/models/__init__.py ## @@ -1856,6 +1851,13 @@ def init_run_context(self, raw=False):

[GitHub] ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database

2019-02-15 Thread GitBox
ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#discussion_r257421945 ## File path: tests/test_models.py ## @@ -2811,7 +2889,7 @@ def test_email_alert(self, mock_send_email):

[jira] [Commented] (AIRFLOW-161) Redirection to external url

2019-02-15 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16769840#comment-16769840 ] ASF subversion and git services commented on AIRFLOW-161: - Commi

[GitHub] feng-tao merged pull request #3533: [AIRFLOW-161] New redirect route and extra links

2019-02-15 Thread GitBox
feng-tao merged pull request #3533: [AIRFLOW-161] New redirect route and extra links URL: https://github.com/apache/airflow/pull/3533 This is an automated message from the Apache Git Service. To respond to the message, pleas

[jira] [Commented] (AIRFLOW-161) Redirection to external url

2019-02-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16769839#comment-16769839 ] ASF GitHub Bot commented on AIRFLOW-161: feng-tao commented on pull request #353

[GitHub] ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database

2019-02-15 Thread GitBox
ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#discussion_r257421397 ## File path: airflow/models/__init__.py ## @@ -2812,16 +2821,39 @@ def get_default_view(self): re

[GitHub] feng-tao commented on issue #3533: [AIRFLOW-161] New redirect route and extra links

2019-02-15 Thread GitBox
feng-tao commented on issue #3533: [AIRFLOW-161] New redirect route and extra links URL: https://github.com/apache/airflow/pull/3533#issuecomment-464241907 thanks @ArgentFalcon , lgtm This is an automated message from the Apa

[GitHub] ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database

2019-02-15 Thread GitBox
ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#discussion_r257421017 ## File path: airflow/www/views.py ## @@ -1293,24 +1303,30 @@ def set_duration(tid): def graph(self, sessi

[GitHub] ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database

2019-02-15 Thread GitBox
ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#discussion_r257420675 ## File path: airflow/www/views.py ## @@ -920,10 +924,16 @@ def clear(self): dag_id = request.args.get

[GitHub] ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database

2019-02-15 Thread GitBox
ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#discussion_r257420364 ## File path: airflow/models/__init__.py ## @@ -3118,6 +3150,50 @@ def date_range(self, start_date, num=None,

[GitHub] ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database

2019-02-15 Thread GitBox
ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#discussion_r257420386 ## File path: airflow/models/__init__.py ## @@ -3118,6 +3150,50 @@ def date_range(self, start_date, num=None,

[GitHub] ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database

2019-02-15 Thread GitBox
ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#discussion_r257419474 ## File path: airflow/models/__init__.py ## @@ -3118,6 +3150,50 @@ def date_range(self, start_date, num=None,

[GitHub] ffinfo commented on issue #4396: [AIRFLOW-3585] - Add edges to database

2019-02-15 Thread GitBox
ffinfo commented on issue #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#issuecomment-464238403 @feng-tao I think the scheduler does not have a lot to do with this. Only place where the scheduler does something more is on create_dagrun. -

[GitHub] ArgentFalcon edited a comment on issue #3533: [AIRFLOW-161] New redirect route and extra links

2019-02-15 Thread GitBox
ArgentFalcon edited a comment on issue #3533: [AIRFLOW-161] New redirect route and extra links URL: https://github.com/apache/airflow/pull/3533#issuecomment-464233872 nevermind as soon as I typed that a failure showed up :( ---

[GitHub] ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database

2019-02-15 Thread GitBox
ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#discussion_r257418251 ## File path: airflow/models/dag_edge.py ## @@ -0,0 +1,60 @@ +# -*- coding: utf-8 -*- +# +# Licensed to the Apa

[GitHub] ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database

2019-02-15 Thread GitBox
ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#discussion_r257418066 ## File path: airflow/models/__init__.py ## @@ -4050,8 +4164,14 @@ def sync_to_db(self, owner=None, sync_time=N

[GitHub] ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database

2019-02-15 Thread GitBox
ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#discussion_r257417466 ## File path: airflow/models/__init__.py ## @@ -4012,17 +4088,55 @@ def create_dagrun(self, conf=c

[GitHub] ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database

2019-02-15 Thread GitBox
ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#discussion_r257417594 ## File path: airflow/www/views.py ## @@ -920,10 +924,16 @@ def clear(self): dag_id = request.args.get

[GitHub] ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database

2019-02-15 Thread GitBox
ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#discussion_r257416396 ## File path: airflow/www/views.py ## @@ -1349,21 +1357,26 @@ class GraphForm(DateTimeWithNumRunsWithDagRunsFor

[GitHub] ArgentFalcon commented on issue #3533: [AIRFLOW-161] New redirect route and extra links

2019-02-15 Thread GitBox
ArgentFalcon commented on issue #3533: [AIRFLOW-161] New redirect route and extra links URL: https://github.com/apache/airflow/pull/3533#issuecomment-464233872 nevermind as soon as I typed that a failur showed up :( This i

[GitHub] ArgentFalcon commented on issue #3533: [AIRFLOW-161] New redirect route and extra links

2019-02-15 Thread GitBox
ArgentFalcon commented on issue #3533: [AIRFLOW-161] New redirect route and extra links URL: https://github.com/apache/airflow/pull/3533#issuecomment-464233750 @feng-tao I did it. The tests pass This is an automated messa

[GitHub] galak75 edited a comment on issue #4691: [AIRFLOW-1814] : templatize PythonOperator op_args and op_kwargs fields

2019-02-15 Thread GitBox
galak75 edited a comment on issue #4691: [AIRFLOW-1814] : templatize PythonOperator op_args and op_kwargs fields URL: https://github.com/apache/airflow/pull/4691#issuecomment-464194845 > @galak75 I created a PR with suggestion: [VilledeMontreal#4](https://github.com/VilledeMontreal/incubat

[jira] [Comment Edited] (AIRFLOW-3494) Dask executor has dependency conflict

2019-02-15 Thread Davor Cubranic (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16769748#comment-16769748 ] Davor Cubranic edited comment on AIRFLOW-3494 at 2/15/19 9:19 PM: ---

[jira] [Commented] (AIRFLOW-3494) Dask executor has dependency conflict

2019-02-15 Thread Davor Cubranic (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16769748#comment-16769748 ] Davor Cubranic commented on AIRFLOW-3494: - psutil version restriction was raise

[GitHub] mik-laj commented on issue #4691: [AIRFLOW-1814] : templatize PythonOperator op_args and op_kwargs fields

2019-02-15 Thread GitBox
mik-laj commented on issue #4691: [AIRFLOW-1814] : templatize PythonOperator op_args and op_kwargs fields URL: https://github.com/apache/airflow/pull/4691#issuecomment-464199751 Oh. You're right. It may not work. I did not check it thoroughly. This construction seemed surprising to me at f

[GitHub] techalchemy commented on a change in pull request #4685: [AIRFLOW-3862] Check types with mypy.

2019-02-15 Thread GitBox
techalchemy commented on a change in pull request #4685: [AIRFLOW-3862] Check types with mypy. URL: https://github.com/apache/airflow/pull/4685#discussion_r257390078 ## File path: setup.py ## @@ -319,6 +318,7 @@ def do_setup(): 'sqlalchemy>=1.1.15, <1.3.0',

[GitHub] techalchemy commented on a change in pull request #4685: [AIRFLOW-3862] Check types with mypy.

2019-02-15 Thread GitBox
techalchemy commented on a change in pull request #4685: [AIRFLOW-3862] Check types with mypy. URL: https://github.com/apache/airflow/pull/4685#discussion_r257390078 ## File path: setup.py ## @@ -319,6 +318,7 @@ def do_setup(): 'sqlalchemy>=1.1.15, <1.3.0',

[GitHub] feng-tao commented on issue #4718: [AIRFLOW-3898] Show example connection string when using Psycopg2

2019-02-15 Thread GitBox
feng-tao commented on issue #4718: [AIRFLOW-3898] Show example connection string when using Psycopg2 URL: https://github.com/apache/airflow/pull/4718#issuecomment-464197125 lgtm This is an automated message from the Apache Gi

[jira] [Created] (AIRFLOW-3899) Backfill command failing with picke exception

2019-02-15 Thread Ellison Leao (JIRA)
Ellison Leao created AIRFLOW-3899: - Summary: Backfill command failing with picke exception Key: AIRFLOW-3899 URL: https://issues.apache.org/jira/browse/AIRFLOW-3899 Project: Apache Airflow Is

[GitHub] galak75 edited a comment on issue #4691: [AIRFLOW-1814] : templatize PythonOperator op_args and op_kwargs fields

2019-02-15 Thread GitBox
galak75 edited a comment on issue #4691: [AIRFLOW-1814] : templatize PythonOperator op_args and op_kwargs fields URL: https://github.com/apache/airflow/pull/4691#issuecomment-464194845 > @galak75 I created a PR with suggestion: [VilledeMontreal#4](https://github.com/VilledeMontreal/incubat

[GitHub] galak75 commented on issue #4691: [AIRFLOW-1814] : templatize PythonOperator op_args and op_kwargs fields

2019-02-15 Thread GitBox
galak75 commented on issue #4691: [AIRFLOW-1814] : templatize PythonOperator op_args and op_kwargs fields URL: https://github.com/apache/airflow/pull/4691#issuecomment-464194845 > @galak75 I created a PR with suggestion: [VilledeMontreal#4](https://github.com/VilledeMontreal/incubator-airf

[jira] [Updated] (AIRFLOW-3899) Backfill command failing with pickle exception

2019-02-15 Thread Ellison Leao (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3899?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ellison Leao updated AIRFLOW-3899: -- Summary: Backfill command failing with pickle exception (was: Backfill command failing with

[GitHub] mik-laj commented on issue #4691: [AIRFLOW-1814] : templatize PythonOperator op_args and op_kwargs fields

2019-02-15 Thread GitBox
mik-laj commented on issue #4691: [AIRFLOW-1814] : templatize PythonOperator op_args and op_kwargs fields URL: https://github.com/apache/airflow/pull/4691#issuecomment-464191751 @galak75 I created a PR with suggestion: https://github.com/VilledeMontreal/incubator-airflow/pull/4 --

[jira] [Commented] (AIRFLOW-3898) Doc: show example connection string when using Psycopg2

2019-02-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16769673#comment-16769673 ] ASF GitHub Bot commented on AIRFLOW-3898: - cubranic commented on pull request #

[GitHub] cubranic opened a new pull request #4718: [AIRFLOW-3898] Show example connection string when using Psycopg2

2019-02-15 Thread GitBox
cubranic opened a new pull request #4718: [AIRFLOW-3898] Show example connection string when using Psycopg2 URL: https://github.com/apache/airflow/pull/4718 Make sure you have checked _all_ steps below. ### Jira - [x] My PR addresses the following [Airflow Jira](https://issue

[jira] [Created] (AIRFLOW-3898) Doc: show example connection string when using Psycopg2

2019-02-15 Thread Davor Cubranic (JIRA)
Davor Cubranic created AIRFLOW-3898: --- Summary: Doc: show example connection string when using Psycopg2 Key: AIRFLOW-3898 URL: https://issues.apache.org/jira/browse/AIRFLOW-3898 Project: Apache Airflo

[GitHub] BasPH commented on a change in pull request #4715: [AIRFLOW-3894] unstructured connection to webhdfs

2019-02-15 Thread GitBox
BasPH commented on a change in pull request #4715: [AIRFLOW-3894] unstructured connection to webhdfs URL: https://github.com/apache/airflow/pull/4715#discussion_r257370054 ## File path: airflow/hooks/webhdfs_hook.py ## @@ -55,7 +63,9 @@ def get_conn(self): for nn

[GitHub] BasPH commented on a change in pull request #4715: [AIRFLOW-3894] unstructured connection to webhdfs

2019-02-15 Thread GitBox
BasPH commented on a change in pull request #4715: [AIRFLOW-3894] unstructured connection to webhdfs URL: https://github.com/apache/airflow/pull/4715#discussion_r257368406 ## File path: airflow/hooks/base_hook.py ## @@ -88,6 +88,20 @@ def get_hook(cls, conn_id): c

[GitHub] BasPH commented on a change in pull request #4715: [AIRFLOW-3894] unstructured connection to webhdfs

2019-02-15 Thread GitBox
BasPH commented on a change in pull request #4715: [AIRFLOW-3894] unstructured connection to webhdfs URL: https://github.com/apache/airflow/pull/4715#discussion_r257371112 ## File path: airflow/hooks/webhdfs_hook.py ## @@ -67,9 +77,10 @@ def get_conn(self): ex

  1   2   >