[GitHub] [airflow] ffinfo commented on issue #4831: [AIRFLOW-3830] Remove DagBag from /dag_details

2019-03-05 Thread GitBox
ffinfo commented on issue #4831: [AIRFLOW-3830] Remove DagBag from /dag_details URL: https://github.com/apache/airflow/pull/4831#issuecomment-469578505 Yes indeed, this makes the webserver stateless because it does not depend on a periodical scan of the DagBag anymore. We going to co

[GitHub] [airflow] codecov-io commented on issue #4831: [AIRFLOW-3830] Remove DagBag from /dag_details

2019-03-05 Thread GitBox
codecov-io commented on issue #4831: [AIRFLOW-3830] Remove DagBag from /dag_details URL: https://github.com/apache/airflow/pull/4831#issuecomment-469579486 # [Codecov](https://codecov.io/gh/apache/airflow/pull/4831?src=pr&el=h1) Report > Merging [#4831](https://codecov.io/gh/apache/air

[jira] [Assigned] (AIRFLOW-3871) Allow Jinja templating recursively on object attributes

2019-03-05 Thread JIRA
[ https://issues.apache.org/jira/browse/AIRFLOW-3871?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Björn Pollex reassigned AIRFLOW-3871: - Assignee: Björn Pollex > Allow Jinja templating recursively on object attributes > ---

[jira] [Commented] (AIRFLOW-3871) Allow Jinja templating recursively on object attributes

2019-03-05 Thread JIRA
[ https://issues.apache.org/jira/browse/AIRFLOW-3871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16784208#comment-16784208 ] Björn Pollex commented on AIRFLOW-3871: --- Hi, thanks for taking the initiative on

[GitHub] [airflow] bjoernpollex-sc commented on a change in pull request #4743: [AIRFLOW-3871] render Operators template fields recursively

2019-03-05 Thread GitBox
bjoernpollex-sc commented on a change in pull request #4743: [AIRFLOW-3871] render Operators template fields recursively URL: https://github.com/apache/airflow/pull/4743#discussion_r262390862 ## File path: airflow/models/__init__.py ## @@ -2452,9 +2454,35 @@ def render_tem

[GitHub] [airflow] ryanyuan commented on a change in pull request #4836: [AIRFLOW-4009] Fix docstring issue in GCSToBQOperator

2019-03-05 Thread GitBox
ryanyuan commented on a change in pull request #4836: [AIRFLOW-4009] Fix docstring issue in GCSToBQOperator URL: https://github.com/apache/airflow/pull/4836#discussion_r262396441 ## File path: airflow/contrib/operators/gcs_to_bq.py ## @@ -43,9 +43,10 @@ class GoogleCloudSt

[GitHub] [airflow] codecov-io commented on issue #4836: [AIRFLOW-4009] Fix docstring issue in GCSToBQOperator

2019-03-05 Thread GitBox
codecov-io commented on issue #4836: [AIRFLOW-4009] Fix docstring issue in GCSToBQOperator URL: https://github.com/apache/airflow/pull/4836#issuecomment-469597416 # [Codecov](https://codecov.io/gh/apache/airflow/pull/4836?src=pr&el=h1) Report > Merging [#4836](https://codecov.io/gh/apa

[GitHub] [airflow] OmerJog commented on issue #4303: [AIRFLOW-3370] Elasticsearch log task handler additional features

2019-03-05 Thread GitBox
OmerJog commented on issue #4303: [AIRFLOW-3370] Elasticsearch log task handler additional features URL: https://github.com/apache/airflow/pull/4303#issuecomment-469597828 @rhwang10 Still needs fixing: ``` ./airflow/config/log_config.py:214:9: E117 over-indented ./airflow/confi

[jira] [Commented] (AIRFLOW-3353) redis-py 3.0.0 dependency breaks celery executor

2019-03-05 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16784258#comment-16784258 ] ASF subversion and git services commented on AIRFLOW-3353: -- Co

[jira] [Commented] (AIRFLOW-2988) GCP Dataflow hook should specifically run python2

2019-03-05 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-2988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16784252#comment-16784252 ] ASF subversion and git services commented on AIRFLOW-2988: -- Co

[jira] [Commented] (AIRFLOW-2190) base_url with a subpath generates TypeError

2019-03-05 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-2190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16784251#comment-16784251 ] ASF subversion and git services commented on AIRFLOW-2190: -- Co

[jira] [Commented] (AIRFLOW-2928) Use uuid.uuid4 to create unique job name

2019-03-05 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-2928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16784253#comment-16784253 ] ASF subversion and git services commented on AIRFLOW-2928: -- Co

[jira] [Commented] (AIRFLOW-2876) Bump version of Tenacity

2019-03-05 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-2876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16784250#comment-16784250 ] ASF subversion and git services commented on AIRFLOW-2876: -- Co

[jira] [Commented] (AIRFLOW-3044) Dataflow operators accept templated job_name param

2019-03-05 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16784255#comment-16784255 ] ASF subversion and git services commented on AIRFLOW-3044: -- Co

[jira] [Commented] (AIRFLOW-2009) DataFlowHook does not use correct service account

2019-03-05 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-2009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16784256#comment-16784256 ] ASF subversion and git services commented on AIRFLOW-2009: -- Co

[jira] [Commented] (AIRFLOW-3250) Fix for Redis Hook for not authorised connection calls.

2019-03-05 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16784257#comment-16784257 ] ASF subversion and git services commented on AIRFLOW-3250: -- Co

[jira] [Created] (AIRFLOW-4012) Upgrade upper bound of tabulate to 0.8.3

2019-03-05 Thread omerjog (JIRA)
omerjog created AIRFLOW-4012: Summary: Upgrade upper bound of tabulate to 0.8.3 Key: AIRFLOW-4012 URL: https://issues.apache.org/jira/browse/AIRFLOW-4012 Project: Apache Airflow Issue Type: Impro

[GitHub] [airflow] OmerJog opened a new pull request #4838: [AIRFLOW-4012] - Upgrade tabulate to 0.8.3

2019-03-05 Thread GitBox
OmerJog opened a new pull request #4838: [AIRFLOW-4012] - Upgrade tabulate to 0.8.3 URL: https://github.com/apache/airflow/pull/4838 Make sure you have checked _all_ steps below. ### Jira - [ ] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/brows

[jira] [Commented] (AIRFLOW-3023) Incorrect types in docstrings

2019-03-05 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16784254#comment-16784254 ] ASF subversion and git services commented on AIRFLOW-3023: -- Co

[jira] [Commented] (AIRFLOW-4012) Upgrade upper bound of tabulate to 0.8.3

2019-03-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16784267#comment-16784267 ] ASF GitHub Bot commented on AIRFLOW-4012: - OmerJog commented on pull request #4

[jira] [Created] (AIRFLOW-4013) Mark success/failed is picking all execution date

2019-03-05 Thread Kang Yu (JIRA)
Kang Yu created AIRFLOW-4013: Summary: Mark success/failed is picking all execution date Key: AIRFLOW-4013 URL: https://issues.apache.org/jira/browse/AIRFLOW-4013 Project: Apache Airflow Issue Ty

[jira] [Commented] (AIRFLOW-4013) Mark success/failed is picking all execution date

2019-03-05 Thread Kang Yu (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16784273#comment-16784273 ] Kang Yu commented on AIRFLOW-4013: -- May relate to AIRFLOW-1049 > Mark success/failed

[jira] [Updated] (AIRFLOW-4013) Mark success/failed is picking all execution date

2019-03-05 Thread Kang Yu (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4013?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kang Yu updated AIRFLOW-4013: - Attachment: screenshot-1.png > Mark success/failed is picking all execution date >

[jira] [Updated] (AIRFLOW-4013) Mark success/failed is picking all execution date

2019-03-05 Thread Kang Yu (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4013?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kang Yu updated AIRFLOW-4013: - Attachment: screenshot-2.png > Mark success/failed is picking all execution date >

[jira] [Updated] (AIRFLOW-4013) Mark success/failed is picking all execution date

2019-03-05 Thread Kang Yu (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4013?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kang Yu updated AIRFLOW-4013: - Description: page: graph view with latest task instance action: click a task then click "Mark Failed"

[jira] [Updated] (AIRFLOW-3602) Change ImapHook to raise an Exception when no attachments have been found

2019-03-05 Thread Ash Berlin-Taylor (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3602?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ash Berlin-Taylor updated AIRFLOW-3602: --- Fix Version/s: (was: 2.0.0) > Change ImapHook to raise an Exception when no att

[jira] [Updated] (AIRFLOW-1215) Add Airflow Connections via command line for schemes with underscore fail to be added successfully

2019-03-05 Thread Ash Berlin-Taylor (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-1215?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ash Berlin-Taylor updated AIRFLOW-1215: --- Fix Version/s: (was: 2.0.0) 1.10.3 > Add Airflow Connections

[jira] [Updated] (AIRFLOW-2988) GCP Dataflow hook should specifically run python2

2019-03-05 Thread Ash Berlin-Taylor (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-2988?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ash Berlin-Taylor updated AIRFLOW-2988: --- Fix Version/s: (was: 2.0.0) 1.10.3 > GCP Dataflow hook shoul

[jira] [Updated] (AIRFLOW-2928) Use uuid.uuid4 to create unique job name

2019-03-05 Thread Ash Berlin-Taylor (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-2928?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ash Berlin-Taylor updated AIRFLOW-2928: --- Fix Version/s: (was: 2.0.0) 1.10.3 > Use uuid.uuid4 to creat

[GitHub] [airflow] codecov-io edited a comment on issue #4838: [AIRFLOW-4012] - Upgrade tabulate to 0.8.3

2019-03-05 Thread GitBox
codecov-io edited a comment on issue #4838: [AIRFLOW-4012] - Upgrade tabulate to 0.8.3 URL: https://github.com/apache/airflow/pull/4838#issuecomment-469630748 # [Codecov](https://codecov.io/gh/apache/airflow/pull/4838?src=pr&el=h1) Report > Merging [#4838](https://codecov.io/gh/apache

[GitHub] [airflow] codecov-io commented on issue #4838: [AIRFLOW-4012] - Upgrade tabulate to 0.8.3

2019-03-05 Thread GitBox
codecov-io commented on issue #4838: [AIRFLOW-4012] - Upgrade tabulate to 0.8.3 URL: https://github.com/apache/airflow/pull/4838#issuecomment-469630748 # [Codecov](https://codecov.io/gh/apache/airflow/pull/4838?src=pr&el=h1) Report > Merging [#4838](https://codecov.io/gh/apache/airflow

[jira] [Updated] (AIRFLOW-3692) Remove GPL dependency check as it is not required anymore

2019-03-05 Thread Ash Berlin-Taylor (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3692?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ash Berlin-Taylor updated AIRFLOW-3692: --- Fix Version/s: (was: 2.0.0) 1.10.3 > Remove GPL dependency c

[jira] [Reopened] (AIRFLOW-3023) Incorrect types in docstrings

2019-03-05 Thread Ash Berlin-Taylor (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3023?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ash Berlin-Taylor reopened AIRFLOW-3023: Reopening to set fix version > Incorrect types in docstrings >

[jira] [Resolved] (AIRFLOW-3023) Incorrect types in docstrings

2019-03-05 Thread Ash Berlin-Taylor (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3023?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ash Berlin-Taylor resolved AIRFLOW-3023. Resolution: Fixed Fix Version/s: (was: 2.0.0) 1.10.3

[jira] [Updated] (AIRFLOW-3044) Dataflow operators accept templated job_name param

2019-03-05 Thread Ash Berlin-Taylor (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3044?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ash Berlin-Taylor updated AIRFLOW-3044: --- Fix Version/s: (was: 2.0.0) 1.10.3 > Dataflow operators acce

[jira] [Updated] (AIRFLOW-3250) Fix for Redis Hook for not authorised connection calls.

2019-03-05 Thread Ash Berlin-Taylor (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3250?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ash Berlin-Taylor updated AIRFLOW-3250: --- Fix Version/s: (was: 2.0.0) 1.10.3 > Fix for Redis Hook for

[jira] [Updated] (AIRFLOW-2009) DataFlowHook does not use correct service account

2019-03-05 Thread Ash Berlin-Taylor (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-2009?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ash Berlin-Taylor updated AIRFLOW-2009: --- Fix Version/s: (was: 2.0.0) > DataFlowHook does not use correct service account

[jira] [Updated] (AIRFLOW-3353) redis-py 3.0.0 dependency breaks celery executor

2019-03-05 Thread Ash Berlin-Taylor (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3353?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ash Berlin-Taylor updated AIRFLOW-3353: --- Fix Version/s: (was: 2.0.0) > redis-py 3.0.0 dependency breaks celery executor

[GitHub] [airflow] ashb commented on a change in pull request #4543: [AIRFLOW-3718] [WIP] Multi-layered version of the docker image

2019-03-05 Thread GitBox
ashb commented on a change in pull request #4543: [AIRFLOW-3718] [WIP] Multi-layered version of the docker image URL: https://github.com/apache/airflow/pull/4543#discussion_r262449409 ## File path: scripts/ci/kubernetes/docker/build.sh ## @@ -34,7 +34,7 @@ fi echo "Airflo

[GitHub] [airflow] ashb commented on a change in pull request #4543: [AIRFLOW-3718] [WIP] Multi-layered version of the docker image

2019-03-05 Thread GitBox
ashb commented on a change in pull request #4543: [AIRFLOW-3718] [WIP] Multi-layered version of the docker image URL: https://github.com/apache/airflow/pull/4543#discussion_r262450290 ## File path: .travis.yml ## @@ -19,26 +19,30 @@ sudo: true dist: trusty language: pyt

[GitHub] [airflow] feluelle commented on issue #4810: [AIRFLOW-3985] Added unary + operator for easier linear DAG building

2019-03-05 Thread GitBox
feluelle commented on issue #4810: [AIRFLOW-3985] Added unary + operator for easier linear DAG building URL: https://github.com/apache/airflow/pull/4810#issuecomment-469642996 The `+` operator for this kind of dependency chaining looks very strange to me. Otherwise I find your idea great.

[jira] [Commented] (AIRFLOW-2910) models.Connection cannot use https

2019-03-05 Thread siro (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-2910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16784338#comment-16784338 ] siro commented on AIRFLOW-2910: --- [~csconnell] I think you are correct about the name of t

[jira] [Comment Edited] (AIRFLOW-2910) models.Connection cannot use https

2019-03-05 Thread siro (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-2910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16784338#comment-16784338 ] siro edited comment on AIRFLOW-2910 at 3/5/19 11:22 AM: [~cscon

[GitHub] [airflow] mik-laj commented on a change in pull request #3115: [AIRFLOW-2193] Add ROperator for using R

2019-03-05 Thread GitBox
mik-laj commented on a change in pull request #3115: [AIRFLOW-2193] Add ROperator for using R URL: https://github.com/apache/airflow/pull/3115#discussion_r262458401 ## File path: airflow/contrib/operators/r_operator.py ## @@ -0,0 +1,99 @@ +# -*- coding: utf-8 -*- +# +# Lic

[GitHub] [airflow] mik-laj commented on a change in pull request #3115: [AIRFLOW-2193] Add ROperator for using R

2019-03-05 Thread GitBox
mik-laj commented on a change in pull request #3115: [AIRFLOW-2193] Add ROperator for using R URL: https://github.com/apache/airflow/pull/3115#discussion_r262458401 ## File path: airflow/contrib/operators/r_operator.py ## @@ -0,0 +1,99 @@ +# -*- coding: utf-8 -*- +# +# Lic

[jira] [Created] (AIRFLOW-4014) Add tests for DatastoreHook

2019-03-05 Thread Felix Uellendall (JIRA)
Felix Uellendall created AIRFLOW-4014: - Summary: Add tests for DatastoreHook Key: AIRFLOW-4014 URL: https://issues.apache.org/jira/browse/AIRFLOW-4014 Project: Apache Airflow Issue Type:

[jira] [Updated] (AIRFLOW-4011) Add Classmethod as an Airflow user

2019-03-05 Thread Ash Berlin-Taylor (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4011?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ash Berlin-Taylor updated AIRFLOW-4011: --- Fix Version/s: (was: 1.10.3) > Add Classmethod as an Airflow user > ---

[GitHub] [airflow] codecov-io commented on issue #4811: [AIRFLOW-3984] Add tests for WinRMHook

2019-03-05 Thread GitBox
codecov-io commented on issue #4811: [AIRFLOW-3984] Add tests for WinRMHook URL: https://github.com/apache/airflow/pull/4811#issuecomment-469653915 # [Codecov](https://codecov.io/gh/apache/airflow/pull/4811?src=pr&el=h1) Report > Merging [#4811](https://codecov.io/gh/apache/airflow/pull

[GitHub] [airflow] ashb commented on a change in pull request #4810: [AIRFLOW-3985] Added unary + operator for easier linear DAG building

2019-03-05 Thread GitBox
ashb commented on a change in pull request #4810: [AIRFLOW-3985] Added unary + operator for easier linear DAG building URL: https://github.com/apache/airflow/pull/4810#discussion_r262467528 ## File path: docs/concepts.rst ## @@ -263,6 +263,31 @@ and equivalent to: o

[GitHub] [airflow] ttanay commented on a change in pull request #4601: [AIRFLOW-3758] Fix circular import in WasbTaskHandler

2019-03-05 Thread GitBox
ttanay commented on a change in pull request #4601: [AIRFLOW-3758] Fix circular import in WasbTaskHandler URL: https://github.com/apache/airflow/pull/4601#discussion_r262467410 ## File path: tests/test_logging_config.py ## @@ -251,6 +251,14 @@ def test_1_9_config(self):

[GitHub] [airflow] ttanay commented on a change in pull request #4601: [AIRFLOW-3758] Fix circular import in WasbTaskHandler

2019-03-05 Thread GitBox
ttanay commented on a change in pull request #4601: [AIRFLOW-3758] Fix circular import in WasbTaskHandler URL: https://github.com/apache/airflow/pull/4601#discussion_r262467410 ## File path: tests/test_logging_config.py ## @@ -251,6 +251,14 @@ def test_1_9_config(self):

[GitHub] [airflow] ashb commented on issue #2906: [AIRFLOW-1956] Add parameter whether the navbar clock time is UTC

2019-03-05 Thread GitBox
ashb commented on issue #2906: [AIRFLOW-1956] Add parameter whether the navbar clock time is UTC URL: https://github.com/apache/airflow/pull/2906#issuecomment-469655074 Something like this makes sense. I'm just trying to work out if we should add the timezone, possibly as a tooltip, or as

[GitHub] [airflow] ashb commented on a change in pull request #4601: [AIRFLOW-3758] Fix circular import in WasbTaskHandler

2019-03-05 Thread GitBox
ashb commented on a change in pull request #4601: [AIRFLOW-3758] Fix circular import in WasbTaskHandler URL: https://github.com/apache/airflow/pull/4601#discussion_r262473733 ## File path: tests/test_logging_config.py ## @@ -251,6 +251,14 @@ def test_1_9_config(self):

[GitHub] [airflow] ttanay commented on a change in pull request #4601: [AIRFLOW-3758] Fix circular import in WasbTaskHandler

2019-03-05 Thread GitBox
ttanay commented on a change in pull request #4601: [AIRFLOW-3758] Fix circular import in WasbTaskHandler URL: https://github.com/apache/airflow/pull/4601#discussion_r262477187 ## File path: tests/test_logging_config.py ## @@ -251,6 +251,14 @@ def test_1_9_config(self):

[GitHub] [airflow] mik-laj commented on issue #3656: [AIRFLOW-2803] Fix all ESLint issues

2019-03-05 Thread GitBox
mik-laj commented on issue #3656: [AIRFLOW-2803] Fix all ESLint issues URL: https://github.com/apache/airflow/pull/3656#issuecomment-469663477 Hi. I created a related PR: https://github.com/apache/airflow/pull/4787 This also fixes linting of the javascript that is in the HTML code.

[GitHub] [airflow] potiuk commented on a change in pull request #4810: [AIRFLOW-3985] Added unary + operator for easier linear DAG building

2019-03-05 Thread GitBox
potiuk commented on a change in pull request #4810: [AIRFLOW-3985] Added unary + operator for easier linear DAG building URL: https://github.com/apache/airflow/pull/4810#discussion_r262479343 ## File path: docs/concepts.rst ## @@ -263,6 +263,31 @@ and equivalent to:

[GitHub] [airflow] potiuk commented on a change in pull request #4810: [AIRFLOW-3985] Added unary + operator for easier linear DAG building

2019-03-05 Thread GitBox
potiuk commented on a change in pull request #4810: [AIRFLOW-3985] Added unary + operator for easier linear DAG building URL: https://github.com/apache/airflow/pull/4810#discussion_r262479343 ## File path: docs/concepts.rst ## @@ -263,6 +263,31 @@ and equivalent to:

[GitHub] [airflow] feluelle commented on issue #4829: [AIRFLOW-3993] Add tests for salesforce hook

2019-03-05 Thread GitBox
feluelle commented on issue #4829: [AIRFLOW-3993] Add tests for salesforce hook URL: https://github.com/apache/airflow/pull/4829#issuecomment-469666042 I don't understand why `simple_salesforce` can not be imported. See: https://travis-ci.org/apache/airflow/jobs/501970876#L2878 It

[jira] [Created] (AIRFLOW-4015) GET dag_runs endpoint do not work

2019-03-05 Thread Dmytro Kulyk (JIRA)
Dmytro Kulyk created AIRFLOW-4015: - Summary: GET dag_runs endpoint do not work Key: AIRFLOW-4015 URL: https://issues.apache.org/jira/browse/AIRFLOW-4015 Project: Apache Airflow Issue Type: Bu

[jira] [Updated] (AIRFLOW-4015) GET dag_runs endpoint do not work

2019-03-05 Thread Dmytro Kulyk (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4015?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dmytro Kulyk updated AIRFLOW-4015: -- Description: when i try to get dag_runs over experimental api it throws 405 response: http:/

[jira] [Updated] (AIRFLOW-4015) GET dag_runs endpoint do not work

2019-03-05 Thread Dmytro Kulyk (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4015?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dmytro Kulyk updated AIRFLOW-4015: -- Description: when i try to get dag_runs over experimental api it throws 405 response: http:/

[GitHub] [airflow] ssoto commented on issue #4735: [AIRFLOW-3795] provide_context param is now used

2019-03-05 Thread GitBox
ssoto commented on issue #4735: [AIRFLOW-3795] provide_context param is now used URL: https://github.com/apache/airflow/pull/4735#issuecomment-469669377 Thanks for merge @Fokko , How can I know which version of apache-airflow will have this fix?

[jira] [Updated] (AIRFLOW-4015) GET dag_runs endpoint do not work

2019-03-05 Thread Dmytro Kulyk (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4015?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dmytro Kulyk updated AIRFLOW-4015: -- Description: when i try to get dag_runs over experimental api ( dags//dag_runs ) it throws 4

[jira] [Commented] (AIRFLOW-3830) Remove DagBag from /dag_details

2019-03-05 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16784408#comment-16784408 ] ASF subversion and git services commented on AIRFLOW-3830: -- Co

[GitHub] [airflow] Fokko merged pull request #4831: [AIRFLOW-3830] Remove DagBag from /dag_details

2019-03-05 Thread GitBox
Fokko merged pull request #4831: [AIRFLOW-3830] Remove DagBag from /dag_details URL: https://github.com/apache/airflow/pull/4831 This is an automated message from the Apache Git Service. To respond to the message, please log

[jira] [Commented] (AIRFLOW-3830) Remove DagBag from /dag_details

2019-03-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16784407#comment-16784407 ] ASF GitHub Bot commented on AIRFLOW-3830: - Fokko commented on pull request #483

[jira] [Resolved] (AIRFLOW-3830) Remove DagBag from /dag_details

2019-03-05 Thread Fokko Driesprong (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3830?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fokko Driesprong resolved AIRFLOW-3830. --- Resolution: Fixed > Remove DagBag from /dag_details > -

[GitHub] [airflow] mik-laj commented on issue #4829: [AIRFLOW-3993] Add tests for salesforce hook

2019-03-05 Thread GitBox
mik-laj commented on issue #4829: [AIRFLOW-3993] Add tests for salesforce hook URL: https://github.com/apache/airflow/pull/4829#issuecomment-469672654 is it in devel_all? This is an automated message from the Apache Git Servic

[GitHub] [airflow] codecov-io edited a comment on issue #4810: [AIRFLOW-3985] Added unary + operator for easier linear DAG building

2019-03-05 Thread GitBox
codecov-io edited a comment on issue #4810: [AIRFLOW-3985] Added unary + operator for easier linear DAG building URL: https://github.com/apache/airflow/pull/4810#issuecomment-468680866 # [Codecov](https://codecov.io/gh/apache/airflow/pull/4810?src=pr&el=h1) Report > Merging [#4810](htt

[GitHub] [airflow] GuzikJakub commented on issue #4708: [AIRFLOW-3888] HA for metastore connection

2019-03-05 Thread GitBox
GuzikJakub commented on issue #4708: [AIRFLOW-3888] HA for metastore connection URL: https://github.com/apache/airflow/pull/4708#issuecomment-469679589 I have one small question. While I wrote unittest for the wrong port, how can I add a new basic connection in the test base? I need it beca

[jira] [Resolved] (AIRFLOW-1945) Pass --autoscale to celery workers

2019-03-05 Thread Ash Berlin-Taylor (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-1945?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ash Berlin-Taylor resolved AIRFLOW-1945. Resolution: Fixed Fix Version/s: 1.10.3 Config option added for it. > Pas

[jira] [Created] (AIRFLOW-4016) Make job tests more stateless

2019-03-05 Thread Peter van 't Hof (JIRA)
Peter van 't Hof created AIRFLOW-4016: - Summary: Make job tests more stateless Key: AIRFLOW-4016 URL: https://issues.apache.org/jira/browse/AIRFLOW-4016 Project: Apache Airflow Issue Type

[GitHub] [airflow] ffinfo opened a new pull request #4839: [AIRFLOW-4016] Clear runs for BackfillJobTest

2019-03-05 Thread GitBox
ffinfo opened a new pull request #4839: [AIRFLOW-4016] Clear runs for BackfillJobTest URL: https://github.com/apache/airflow/pull/4839 Make sure you have checked _all_ steps below. ### Jira - [ ] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/brow

[jira] [Commented] (AIRFLOW-4016) Make job tests more stateless

2019-03-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16784437#comment-16784437 ] ASF GitHub Bot commented on AIRFLOW-4016: - ffinfo commented on pull request #48

[jira] [Updated] (AIRFLOW-3820) Removing the old UI removed the gunicorn configurations

2019-03-05 Thread Ash Berlin-Taylor (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3820?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ash Berlin-Taylor updated AIRFLOW-3820: --- Fix Version/s: (was: 1.10.3) Leave with no fix for version - it was a bug intro

[GitHub] [airflow] msumit commented on issue #4832: [AIRFLOW-3938] Qubole Operator Fixes

2019-03-05 Thread GitBox
msumit commented on issue #4832: [AIRFLOW-3938] Qubole Operator Fixes URL: https://github.com/apache/airflow/pull/4832#issuecomment-469684201 lgtm This is an automated message from the Apache Git Service. To respond to the mes

[jira] [Commented] (AIRFLOW-3938) Qubole Operator Improvements

2019-03-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16784449#comment-16784449 ] ASF GitHub Bot commented on AIRFLOW-3938: - msumit commented on pull request #48

[GitHub] [airflow] msumit merged pull request #4832: [AIRFLOW-3938] Qubole Operator Fixes

2019-03-05 Thread GitBox
msumit merged pull request #4832: [AIRFLOW-3938] Qubole Operator Fixes URL: https://github.com/apache/airflow/pull/4832 This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[jira] [Commented] (AIRFLOW-3938) Qubole Operator Improvements

2019-03-05 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16784450#comment-16784450 ] ASF subversion and git services commented on AIRFLOW-3938: -- Co

[GitHub] [airflow] potiuk commented on a change in pull request #4543: [AIRFLOW-3718] [WIP] Multi-layered version of the docker image

2019-03-05 Thread GitBox
potiuk commented on a change in pull request #4543: [AIRFLOW-3718] [WIP] Multi-layered version of the docker image URL: https://github.com/apache/airflow/pull/4543#discussion_r262503983 ## File path: .travis.yml ## @@ -19,26 +19,30 @@ sudo: true dist: trusty language: p

[GitHub] [airflow] potiuk commented on a change in pull request #4543: [AIRFLOW-3718] [WIP] Multi-layered version of the docker image

2019-03-05 Thread GitBox
potiuk commented on a change in pull request #4543: [AIRFLOW-3718] [WIP] Multi-layered version of the docker image URL: https://github.com/apache/airflow/pull/4543#discussion_r262503983 ## File path: .travis.yml ## @@ -19,26 +19,30 @@ sudo: true dist: trusty language: p

[GitHub] [airflow] potiuk commented on a change in pull request #4543: [AIRFLOW-3718] [WIP] Multi-layered version of the docker image

2019-03-05 Thread GitBox
potiuk commented on a change in pull request #4543: [AIRFLOW-3718] [WIP] Multi-layered version of the docker image URL: https://github.com/apache/airflow/pull/4543#discussion_r262504995 ## File path: Dockerfile ## @@ -13,45 +13,72 @@ # WITHOUT WARRANTIES OR CONDITIONS OF

[jira] [Closed] (AIRFLOW-3938) Qubole Operator Improvements

2019-03-05 Thread Joy Lal Chattaraj (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3938?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joy Lal Chattaraj closed AIRFLOW-3938. -- Resolution: Fixed > Qubole Operator Improvements > > >

[GitHub] [airflow] potiuk commented on a change in pull request #4543: [AIRFLOW-3718] [WIP] Multi-layered version of the docker image

2019-03-05 Thread GitBox
potiuk commented on a change in pull request #4543: [AIRFLOW-3718] [WIP] Multi-layered version of the docker image URL: https://github.com/apache/airflow/pull/4543#discussion_r262511864 ## File path: scripts/ci/kubernetes/docker/build.sh ## @@ -34,7 +34,7 @@ fi echo "Airf

[GitHub] [airflow] potiuk commented on issue #4543: [AIRFLOW-3718] [WIP] Multi-layered version of the docker image

2019-03-05 Thread GitBox
potiuk commented on issue #4543: [AIRFLOW-3718] [WIP] Multi-layered version of the docker image URL: https://github.com/apache/airflow/pull/4543#issuecomment-469703048 Some comments on the progress and current state @Fokko @ashb. You might take a look at the current implementation if you a

[GitHub] [airflow] potiuk commented on a change in pull request #4543: [AIRFLOW-3718] [WIP] Multi-layered version of the docker image

2019-03-05 Thread GitBox
potiuk commented on a change in pull request #4543: [AIRFLOW-3718] [WIP] Multi-layered version of the docker image URL: https://github.com/apache/airflow/pull/4543#discussion_r262524299 ## File path: Dockerfile ## @@ -13,45 +13,72 @@ # WITHOUT WARRANTIES OR CONDITIONS OF

[GitHub] [airflow] ashb commented on a change in pull request #4601: [AIRFLOW-3758] Fix circular import in WasbTaskHandler

2019-03-05 Thread GitBox
ashb commented on a change in pull request #4601: [AIRFLOW-3758] Fix circular import in WasbTaskHandler URL: https://github.com/apache/airflow/pull/4601#discussion_r262524096 ## File path: tests/test_logging_config.py ## @@ -251,6 +251,14 @@ def test_1_9_config(self):

[GitHub] [airflow] ttanay commented on a change in pull request #4601: [AIRFLOW-3758] Fix circular import in WasbTaskHandler

2019-03-05 Thread GitBox
ttanay commented on a change in pull request #4601: [AIRFLOW-3758] Fix circular import in WasbTaskHandler URL: https://github.com/apache/airflow/pull/4601#discussion_r262527565 ## File path: tests/test_logging_config.py ## @@ -251,6 +251,14 @@ def test_1_9_config(self):

[GitHub] [airflow] ashb commented on a change in pull request #4601: [AIRFLOW-3758] Fix circular import in WasbTaskHandler

2019-03-05 Thread GitBox
ashb commented on a change in pull request #4601: [AIRFLOW-3758] Fix circular import in WasbTaskHandler URL: https://github.com/apache/airflow/pull/4601#discussion_r262529008 ## File path: tests/test_logging_config.py ## @@ -259,6 +259,11 @@ def test_loading_remote_logging

[GitHub] [airflow] potiuk commented on issue #4828: [AIRFLOW-4002] Optionally open debugger on errors in airflow test.

2019-03-05 Thread GitBox
potiuk commented on issue #4828: [AIRFLOW-4002] Optionally open debugger on errors in airflow test. URL: https://github.com/apache/airflow/pull/4828#issuecomment-469707920 Super useful! This is an automated message from the

[GitHub] [airflow] mik-laj commented on issue #4828: [AIRFLOW-4002] Optionally open debugger on errors in airflow test.

2019-03-05 Thread GitBox
mik-laj commented on issue #4828: [AIRFLOW-4002] Optionally open debugger on errors in airflow test. URL: https://github.com/apache/airflow/pull/4828#issuecomment-469712201 I recommend coworkers to cherry-pick this change. This is very helpful in the development of operators.

[GitHub] [airflow] mik-laj commented on issue #4828: [AIRFLOW-4002] Optionally open debugger on errors in airflow test.

2019-03-05 Thread GitBox
mik-laj commented on issue #4828: [AIRFLOW-4002] Optionally open debugger on errors in airflow test. URL: https://github.com/apache/airflow/pull/4828#issuecomment-469715155 Have you thought about ipdb support? Ipdb provides a much more enjoyable experience. It is possible to detect ipdb.

[GitHub] [airflow] ashb opened a new pull request #4840: [AIRFLOW-3761] Fix `DROP TABLE user` migration for upgrades.

2019-03-05 Thread GitBox
ashb opened a new pull request #4840: [AIRFLOW-3761] Fix `DROP TABLE user` migration for upgrades. URL: https://github.com/apache/airflow/pull/4840 If you are upgrading an old install you will likely have rows in the user and known_event tables. We dropped the KnownEvent without a mig

[jira] [Commented] (AIRFLOW-3761) Decommission User & Chart models; Update doc accordingly

2019-03-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16784563#comment-16784563 ] ASF GitHub Bot commented on AIRFLOW-3761: - ashb commented on pull request #4840

[GitHub] [airflow] XD-DENG commented on issue #4840: [AIRFLOW-3761] Fix `DROP TABLE user` migration for upgrades.

2019-03-05 Thread GitBox
XD-DENG commented on issue #4840: [AIRFLOW-3761] Fix `DROP TABLE user` migration for upgrades. URL: https://github.com/apache/airflow/pull/4840#issuecomment-469728978 My understanding is that `KnownEvent` table is kept only to ensure user's data will not be lost, but this table itself will

[GitHub] [airflow] EamonKeane commented on issue #4648: [AIRFLOW-3274] Add run_as_user and fs_group options for Kubernetes

2019-03-05 Thread GitBox
EamonKeane commented on issue #4648: [AIRFLOW-3274] Add run_as_user and fs_group options for Kubernetes URL: https://github.com/apache/airflow/pull/4648#issuecomment-469736288 +1 This adds the functionality needed on non-root pod operators whose entrypoints e.g. copy and chmod secr

[GitHub] [airflow] ashb commented on issue #4642: [AIRFLOW-2694] Declare permissions in DAG definition

2019-03-05 Thread GitBox
ashb commented on issue #4642: [AIRFLOW-2694] Declare permissions in DAG definition URL: https://github.com/apache/airflow/pull/4642#issuecomment-469736358 Is there a reason we don't (additionally) sync the DAG parms at webserver start up? I had to dig in to the code to find why my dag per

[GitHub] [airflow] XD-DENG edited a comment on issue #4840: [AIRFLOW-3761] Fix `DROP TABLE user` migration for upgrades.

2019-03-05 Thread GitBox
XD-DENG edited a comment on issue #4840: [AIRFLOW-3761] Fix `DROP TABLE user` migration for upgrades. URL: https://github.com/apache/airflow/pull/4840#issuecomment-469728978 My understanding is that `KnownEvent` table is kept only to ensure user's data will not be lost, but this table itse

[GitHub] [airflow] ashb commented on issue #4642: [AIRFLOW-2694] Declare permissions in DAG definition

2019-03-05 Thread GitBox
ashb commented on issue #4642: [AIRFLOW-2694] Declare permissions in DAG definition URL: https://github.com/apache/airflow/pull/4642#issuecomment-469739918 Also (not sure it relates to this PR or another one) but what happens if I specify a `dag_id="all_dags"` and run sync_perms :D --

[GitHub] [airflow] ashb commented on issue #4569: [AIRFLOW-3745] Fix viewer not able to view dag details

2019-03-05 Thread GitBox
ashb commented on issue #4569: [AIRFLOW-3745] Fix viewer not able to view dag details URL: https://github.com/apache/airflow/pull/4569#issuecomment-469743622 Am I reading this right - does it give Viewer role the ability to edit dags. That seems incorrect?

  1   2   3   >