[
https://issues.apache.org/jira/browse/AIRFLOW-4020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16784904#comment-16784904
]
ASF GitHub Bot commented on AIRFLOW-4020:
-
feng-tao commented on pull request #4845:
ashb commented on a change in pull request #4819: [AIRFLOW-3997] Add accessor
for optional variables
URL: https://github.com/apache/airflow/pull/4819#discussion_r262691620
##
File path: airflow/models/__init__.py
##
@@ -4263,6 +4263,14 @@ def setdefault(cls, key, default,
ashb commented on a change in pull request #4819: [AIRFLOW-3997] Add accessor
for optional variables
URL: https://github.com/apache/airflow/pull/4819#discussion_r262691620
##
File path: airflow/models/__init__.py
##
@@ -4263,6 +4263,14 @@ def setdefault(cls, key, default,
feng-tao commented on issue #4569: [AIRFLOW-3745] Fix viewer not able to view
dag details
URL: https://github.com/apache/airflow/pull/4569#issuecomment-469857557
correct, we shouldn't rely on UI for the operations...
This is
feng-tao commented on issue #4569: [AIRFLOW-3745] Fix viewer not able to view
dag details
URL: https://github.com/apache/airflow/pull/4569#issuecomment-469857250
@ashb , https://github.com/apache/airflow/pull/4845 for removing viewer edit
permissions.
feng-tao opened a new pull request #4845: [AIRFLOW-4020] Remove viewer DAG edit
permissions
URL: https://github.com/apache/airflow/pull/4845
Make sure you have checked _all_ steps below.
### Jira
- [x] My PR addresses the following [Airflow
ashb commented on issue #4569: [AIRFLOW-3745] Fix viewer not able to view dag
details
URL: https://github.com/apache/airflow/pull/4569#issuecomment-469856650
Correct, yeah I've been testing the v1-10-stable branch to prepare 1.10.3 -
though the problem would also apply to any upgraded
Tao Feng created AIRFLOW-4020:
-
Summary: remove viewer DAG edit permission
Key: AIRFLOW-4020
URL: https://issues.apache.org/jira/browse/AIRFLOW-4020
Project: Apache Airflow
Issue Type:
[
https://issues.apache.org/jira/browse/AIRFLOW-2910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16784882#comment-16784882
]
Craig S. Connell commented on AIRFLOW-2910:
---
[~siro], that makes sense to me. I think that
[
https://issues.apache.org/jira/browse/AIRFLOW-4019?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Work on AIRFLOW-4019 started by Mariko Wakabayashi.
---
> AWS Athena Sensor's object has no attribute 'mode'
>
feng-tao edited a comment on issue #4569: [AIRFLOW-3745] Fix viewer not able to
view dag details
URL: https://github.com/apache/airflow/pull/4569#issuecomment-469834959
@ashb , I see. Your deploy is based on 1.10.2 not on master? I think I fail
to get this pr into 1.10.2 as the release
feng-tao commented on issue #4569: [AIRFLOW-3745] Fix viewer not able to view
dag details
URL: https://github.com/apache/airflow/pull/4569#issuecomment-469834959
@ashb , I see your issue. Your deploy is based on 1.10.2 not on master? I
think I fail to get this pr into 1.10.2 as the
codecov-io commented on issue #4843: [AIRFLOW-XXX] Add note about backwards
incompatible changes
URL: https://github.com/apache/airflow/pull/4843#issuecomment-469835078
# [Codecov](https://codecov.io/gh/apache/airflow/pull/4843?src=pr=h1)
Report
> Merging
schnie commented on issue #4303: [AIRFLOW-3370] Elasticsearch log task handler
additional features
URL: https://github.com/apache/airflow/pull/4303#issuecomment-469833600
Hey @OmerJog, I talked with @rhwang10 and I'm going to create a new PR for
this. I was able to get something working
ttanay commented on issue #4601: [AIRFLOW-3758] Fix circular import in
WasbTaskHandler
URL: https://github.com/apache/airflow/pull/4601#issuecomment-469830733
Thanks for your help @ashb :metal:
This is an automated
[
https://issues.apache.org/jira/browse/AIRFLOW-3758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16784823#comment-16784823
]
ASF GitHub Bot commented on AIRFLOW-3758:
-
ashb commented on pull request #4601: [AIRFLOW-3758]
[
https://issues.apache.org/jira/browse/AIRFLOW-3758?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ash Berlin-Taylor resolved AIRFLOW-3758.
Resolution: Fixed
> Airflow command fails when remote logging enabled to azure
[
https://issues.apache.org/jira/browse/AIRFLOW-3758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16784824#comment-16784824
]
ASF subversion and git services commented on AIRFLOW-3758:
--
Commit
ashb merged pull request #4601: [AIRFLOW-3758] Fix circular import in
WasbTaskHandler
URL: https://github.com/apache/airflow/pull/4601
This is an automated message from the Apache Git Service.
To respond to the message,
ashb commented on issue #4601: [AIRFLOW-3758] Fix circular import in
WasbTaskHandler
URL: https://github.com/apache/airflow/pull/4601#issuecomment-469829984
Thanks @ttanay!
This is an automated message from the Apache Git
[
https://issues.apache.org/jira/browse/AIRFLOW-3758?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ash Berlin-Taylor updated AIRFLOW-3758:
---
Fix Version/s: 1.10.3
> Airflow command fails when remote logging enabled to azure
ashb commented on issue #4569: [AIRFLOW-3745] Fix viewer not able to view dag
details
URL: https://github.com/apache/airflow/pull/4569#issuecomment-469828759
1. It never gets to L1657, `@has_dag_access` issues a 302 before the view fn
is ever run.
2. I'll cherry-pick this PR (which
feng-tao edited a comment on issue #4784: [AIRFLOW-XXX][WIP]Enforce order in
imports
URL: https://github.com/apache/airflow/pull/4784#issuecomment-469825269
@mik-laj , anything else we need to update from this pr?
This is an
[
https://issues.apache.org/jira/browse/AIRFLOW-4019?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ash Berlin-Taylor updated AIRFLOW-4019:
---
Fix Version/s: 1.10.3
> AWS Athena Sensor's object has no attribute 'mode'
>
feng-tao commented on issue #4784: [AIRFLOW-XXX][WIP]Enforce order in imports
URL: https://github.com/apache/airflow/pull/4784#issuecomment-469825269
@mik-laj , anything else we need from this pr?
This is an automated message
ashb commented on issue #4844: [AIRFLOW-4019] Fix AWS Athena Sensor object has
no attribute 'mode'
URL: https://github.com/apache/airflow/pull/4844#issuecomment-469824299
Doh, good catch
This is an automated message from the
[
https://issues.apache.org/jira/browse/AIRFLOW-4019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16784809#comment-16784809
]
ASF GitHub Bot commented on AIRFLOW-4019:
-
mwakaba2 commented on pull request #4844:
mwakaba2 opened a new pull request #4844: [AIRFLOW-4019] Fix AWS Athena Sensor
object has no attribute 'mode'
URL: https://github.com/apache/airflow/pull/4844
### Jira
- [x] My PR addresses this jira ticket
[AIRFLOW-4019](https://issues.apache.org/jira/browse/AIRFLOW-4019) .
codecov-io edited a comment on issue #4601: [AIRFLOW-3758] Fix circular import
in WasbTaskHandler
URL: https://github.com/apache/airflow/pull/4601#issuecomment-457931939
# [Codecov](https://codecov.io/gh/apache/airflow/pull/4601?src=pr=h1)
Report
> Merging
[
https://issues.apache.org/jira/browse/AIRFLOW-3720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16784801#comment-16784801
]
jack commented on AIRFLOW-3720:
---
[~yohei] didnt you encounter a similar issue? i remember you fixed it
[
https://issues.apache.org/jira/browse/AIRFLOW-4019?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mariko Wakabayashi updated AIRFLOW-4019:
Description:
*Bug*
{code:java}
[2019-03-05 18:52:32,317] {models.py:1788} ERROR
Mariko Wakabayashi created AIRFLOW-4019:
---
Summary: AWS Athena Sensor's object has no attribute 'mode'
Key: AIRFLOW-4019
URL: https://issues.apache.org/jira/browse/AIRFLOW-4019
Project: Apache
feng-tao commented on issue #4569: [AIRFLOW-3745] Fix viewer not able to view
dag details
URL: https://github.com/apache/airflow/pull/4569#issuecomment-469817956
@ashb , let's consolidate all the discussion in one place. And I could do
some investigations in my night time(PST time zone).
kristiany edited a comment on issue #4819: [AIRFLOW-3997] Add accessor for
optional variables
URL: https://github.com/apache/airflow/pull/4819#issuecomment-469813538
@OmerJog Sorry, fixed now.
Struggling a bit with running the tests locally...
OmerJog commented on a change in pull request #4838: [AIRFLOW-4012] - Upgrade
tabulate to 0.8.3
URL: https://github.com/apache/airflow/pull/4838#discussion_r262643711
##
File path: setup.py
##
@@ -317,7 +317,7 @@ def do_setup():
'requests>=2.20.0, <3',
kristiany commented on issue #4819: [AIRFLOW-3997] Add accessor for optional
variables
URL: https://github.com/apache/airflow/pull/4819#issuecomment-469813538
@OmerJog Sorry, fixed now.
Struggling a bit with running the tests...
feluelle opened a new pull request #4843: [AIRFLOW-XXX] Add note about
backwards incompatible changes
URL: https://github.com/apache/airflow/pull/4843
Make sure you have checked _all_ steps below.
### Jira
- [x] My PR addresses the following [Airflow
feluelle commented on issue #4829: [AIRFLOW-3993] Add tests for salesforce hook
URL: https://github.com/apache/airflow/pull/4829#issuecomment-469809875
Ah okay, I missed this line: [devel_ci =
devel_all](https://github.com/apache/airflow/blob/master/setup.py#L273). Thank
you @mik-laj I
ashb edited a comment on issue #4118: [AIRFLOW-3271] Airflow RBAC Permissions
modification via UI do not persist
URL: https://github.com/apache/airflow/pull/4118#issuecomment-469801650
@feng-tao to continue the discussion from
ashb commented on issue #4118: [AIRFLOW-3271] Airflow RBAC Permissions
modification via UI do not persist
URL: https://github.com/apache/airflow/pull/4118#issuecomment-469801650
@feng-tao to continue the discussion from
https://github.com/apache/airflow/pull/4569#issuecomment-469796095 as
feluelle edited a comment on issue #4829: [AIRFLOW-3993] Add tests for
salesforce hook
URL: https://github.com/apache/airflow/pull/4829#issuecomment-469666042
I don't understand why `simple_salesforce` can not be imported.
See: https://travis-ci.org/apache/airflow/jobs/501970876#L2878
ttanay commented on issue #4601: [AIRFLOW-3758] Fix circular import in
WasbTaskHandler
URL: https://github.com/apache/airflow/pull/4601#issuecomment-469799890
> Test Job#8 failed because `No output has been received in the last 10m0s`.
> Test Job#11 failed because of `Connection Error;
ashb commented on issue #4569: [AIRFLOW-3745] Fix viewer not able to view dag
details
URL: https://github.com/apache/airflow/pull/4569#issuecomment-469798406
A possibly simpler use case: Start with a fresh install on 1.10.2, add a
user in the "Op" role and try to pause a DAG :)
ashb edited a comment on issue #4569: [AIRFLOW-3745] Fix viewer not able to
view dag details
URL: https://github.com/apache/airflow/pull/4569#issuecomment-469796095
@feng-tao Okay I've got a reproduction case, I'm not sure which PR it
applies to:
1. Start with airflow 1.10.1 in a
jyothsnapk17 commented on a change in pull request #4835: [AIRFLOW-]
Improvements to formatted content in documentation
URL: https://github.com/apache/airflow/pull/4835#discussion_r262627573
##
File path: docs/howto/check-health.rst
##
@@ -33,15 +33,17 @@ To check the
ashb commented on issue #4569: [AIRFLOW-3745] Fix viewer not able to view dag
details
URL: https://github.com/apache/airflow/pull/4569#issuecomment-469796095
@feng-tao Okay I've got a reproduction case, I'm not sure which PR it
applies to:
1. Start with airflow 1.10.1 in a fresh
[
https://issues.apache.org/jira/browse/AIRFLOW-1557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16784737#comment-16784737
]
Chao-Han Tsai commented on AIRFLOW-1557:
I can take a look
> backfill ignores configured
[
https://issues.apache.org/jira/browse/AIRFLOW-1557?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chao-Han Tsai reassigned AIRFLOW-1557:
--
Assignee: Chao-Han Tsai
> backfill ignores configured number of slots in a pool
>
feng-tao edited a comment on issue #4642: [AIRFLOW-2694] Declare permissions in
DAG definition
URL: https://github.com/apache/airflow/pull/4642#issuecomment-469784933
@ashb , we do sync perms in
https://github.com/apache/airflow/blob/master/airflow/www/app.py#L181 .Which
roles with what
ttanay commented on issue #4601: [AIRFLOW-3758] Fix circular import in
WasbTaskHandler
URL: https://github.com/apache/airflow/pull/4601#issuecomment-469786166
> That happens somtimes :( I'll restart that one.
Cool :metal: Thanks!
feng-tao edited a comment on issue #4642: [AIRFLOW-2694] Declare permissions in
DAG definition
URL: https://github.com/apache/airflow/pull/4642#issuecomment-469784933
@ashb , we do sync perms in
https://github.com/apache/airflow/blob/master/airflow/www/app.py#L181 .Which
roles with what
feng-tao commented on issue #4642: [AIRFLOW-2694] Declare permissions in DAG
definition
URL: https://github.com/apache/airflow/pull/4642#issuecomment-469784933
@ashb , we do sync perms in
https://github.com/apache/airflow/blob/master/airflow/www/app.py#L181 .Which
roles with what
ashb commented on issue #4601: [AIRFLOW-3758] Fix circular import in
WasbTaskHandler
URL: https://github.com/apache/airflow/pull/4601#issuecomment-469784431
That happens somtimes :( I'll restart that one.
This is an
ttanay commented on issue #4601: [AIRFLOW-3758] Fix circular import in
WasbTaskHandler
URL: https://github.com/apache/airflow/pull/4601#issuecomment-469783080
Test Job#8 failed because `No output has been received in the last 10m0s`.
Test Job#11 failed because of `Connection Error;
ashb commented on issue #4118: [AIRFLOW-3271] Airflow RBAC Permissions
modification via UI do not persist
URL: https://github.com/apache/airflow/pull/4118#issuecomment-469781673
@feng-tao Not over-writing user changes does sound like a thing we want.
I'll have to pin something down
[
https://issues.apache.org/jira/browse/AIRFLOW-3937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16784708#comment-16784708
]
Kamil Gałuszka commented on AIRFLOW-3937:
-
PR for this issue is ready for review here
feng-tao commented on issue #4569: [AIRFLOW-3745] Fix viewer not able to view
dag details
URL: https://github.com/apache/airflow/pull/4569#issuecomment-469781261
@ashb , I will submit a pr to address the viewer edit issue today.
[
https://issues.apache.org/jira/browse/AIRFLOW-4014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16784703#comment-16784703
]
ASF GitHub Bot commented on AIRFLOW-4014:
-
feluelle commented on pull request #4842:
ashb commented on issue #4569: [AIRFLOW-3745] Fix viewer not able to view dag
details
URL: https://github.com/apache/airflow/pull/4569#issuecomment-469779758
I'm trying to debug something - I've gone from a 1.10.2 RBAC install to
master, and I'm no longer able to pause DAGs
Viewer
galuszkak commented on issue #4772: [AIRFLOW-3937] KubernetesPodOperator
support for envFrom configMapRef…
URL: https://github.com/apache/airflow/pull/4772#issuecomment-469779659
@feng-tao @ashb @pgagnon this PR is ready for review, I've incorporated most
of the requested changes here.
feluelle opened a new pull request #4842: [AIRFLOW-4014] Change DatastoreHook
and add tests
URL: https://github.com/apache/airflow/pull/4842
Make sure you have checked _all_ steps below.
### Jira
- [x] My PR addresses the following [Airflow
feng-tao edited a comment on issue #4118: [AIRFLOW-3271] Airflow RBAC
Permissions modification via UI do not persist
URL: https://github.com/apache/airflow/pull/4118#issuecomment-469778880
@ashb , not sure if I got what you mean. Those existing roles will stay with
all-dag permissions
feng-tao edited a comment on issue #4118: [AIRFLOW-3271] Airflow RBAC
Permissions modification via UI do not persist
URL: https://github.com/apache/airflow/pull/4118#issuecomment-469778880
@ashb , not sure if I got what you mean. Those existing roles will still
exist with all-dag
feng-tao commented on issue #4118: [AIRFLOW-3271] Airflow RBAC Permissions
modification via UI do not persist
URL: https://github.com/apache/airflow/pull/4118#issuecomment-469778880
@ashb , not sure if I got what you mean. Those existing roles will stay with
all-dag permissions meaning
galuszkak commented on a change in pull request #4772: [AIRFLOW-3937]
KubernetesPodOperator support for envFrom configMapRef…
URL: https://github.com/apache/airflow/pull/4772#discussion_r262606548
##
File path: airflow/contrib/kubernetes/configmap.py
##
@@ -0,0 +1,23 @@
galuszkak commented on a change in pull request #4772: [AIRFLOW-3937]
KubernetesPodOperator support for envFrom configMapRef…
URL: https://github.com/apache/airflow/pull/4772#discussion_r262606670
##
File path: airflow/contrib/kubernetes/secret.py
##
@@ -39,3 +39,10 @@
galuszkak commented on a change in pull request #4772: [AIRFLOW-3937]
KubernetesPodOperator support for envFrom configMapRef…
URL: https://github.com/apache/airflow/pull/4772#discussion_r262606321
##
File path:
feng-tao commented on issue #4569: [AIRFLOW-3745] Fix viewer not able to view
dag details
URL: https://github.com/apache/airflow/pull/4569#issuecomment-469777142
@ashb , it came from someone(maybe XD) reporting in the dev alias that
viewer could no longer view the same details as in
ashb commented on issue #4841: [AIRFLOW-3834] Remove dagbag from /log
URL: https://github.com/apache/airflow/pull/4841#issuecomment-469775977
You can probably have one Jira ticket for all views if you like (to save you
creating N jira tickets) - just add a comment somewhere so we know not
ashb commented on issue #4735: [AIRFLOW-3795] provide_context param is now used
URL: https://github.com/apache/airflow/pull/4735#issuecomment-469774187
@ssoto That said: provide context might have a few quirks/edge cases for the
venv operator:
[
https://issues.apache.org/jira/browse/AIRFLOW-3795?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ash Berlin-Taylor updated AIRFLOW-3795:
---
Fix Version/s: (was: 2.0.0)
1.10.3
> provide_context is not
ashb commented on issue #4735: [AIRFLOW-3795] provide_context param is now used
URL: https://github.com/apache/airflow/pull/4735#issuecomment-469773845
@ssoto I've marked it for inclusion in 1.10.3 which I'm hopeful will be out
by the end of next week. But I can't promise that timeline.
Diederik van Liere created AIRFLOW-4018:
---
Summary: Status of task documentation is unclear
Key: AIRFLOW-4018
URL: https://issues.apache.org/jira/browse/AIRFLOW-4018
Project: Apache Airflow
ashb commented on a change in pull request #4838: [AIRFLOW-4012] - Upgrade
tabulate to 0.8.3
URL: https://github.com/apache/airflow/pull/4838#discussion_r262599568
##
File path: setup.py
##
@@ -317,7 +317,7 @@ def do_setup():
'requests>=2.20.0, <3',
ashb edited a comment on issue #4569: [AIRFLOW-3745] Fix viewer not able to
view dag details
URL: https://github.com/apache/airflow/pull/4569#issuecomment-469743622
Am I reading this right - does it give Viewer role the ability to edit dags.
That seems incorrect? ~Likewise for User which
ashb removed a comment on issue #4569: [AIRFLOW-3745] Fix viewer not able to
view dag details
URL: https://github.com/apache/airflow/pull/4569#issuecomment-469754091
Am I reading this right - does it give Viewer role the ability to edit dags.
That seems ... incorrect?
ashb edited a comment on issue #4569: [AIRFLOW-3745] Fix viewer not able to
view dag details
URL: https://github.com/apache/airflow/pull/4569#issuecomment-469743622
Am I reading this right - does it give Viewer role the ability to edit dags.
That seems incorrect? Likewise for User which
codecov-io commented on issue #4840: [AIRFLOW-3761] Fix `DROP TABLE user`
migration for upgrades.
URL: https://github.com/apache/airflow/pull/4840#issuecomment-469766780
# [Codecov](https://codecov.io/gh/apache/airflow/pull/4840?src=pr=h1)
Report
> Merging
NEHAL created AIRFLOW-4017:
--
Summary: query_params unable to pass value to SQL statement
Key: AIRFLOW-4017
URL: https://issues.apache.org/jira/browse/AIRFLOW-4017
Project: Apache Airflow
Issue
codecov-io commented on issue #4839: [AIRFLOW-4016] Clear runs for
BackfillJobTest
URL: https://github.com/apache/airflow/pull/4839#issuecomment-469763166
# [Codecov](https://codecov.io/gh/apache/airflow/pull/4839?src=pr=h1)
Report
> Merging
ashb commented on issue #4118: [AIRFLOW-3271] Airflow RBAC Permissions
modification via UI do not persist
URL: https://github.com/apache/airflow/pull/4118#issuecomment-469753996
Does this change mean that as we add new permissions to Airflow (for example
the Per-DAG) permissions that we
ashb commented on issue #4569: [AIRFLOW-3745] Fix viewer not able to view dag
details
URL: https://github.com/apache/airflow/pull/4569#issuecomment-469754091
Am I reading this right - does it give Viewer role the ability to edit dags.
That seems ... incorrect?
ashb commented on issue #2740: [AIRFLOW-1768] add if to show trigger only if
not paused
URL: https://github.com/apache/airflow/pull/2740#issuecomment-469751619
Rather than removing the trigger button entirely we should have it there,
but make it disabled (with a tooltip saying why it's
potiuk commented on a change in pull request #4788: [AIRFLOW-3811][3/3] Add
automatic generation of API Reference
URL: https://github.com/apache/airflow/pull/4788#discussion_r262573344
##
File path: .gitignore
##
@@ -83,6 +83,7 @@ instance/
Review comment:
Please
potiuk commented on a change in pull request #4788: [AIRFLOW-3811][3/3] Add
automatic generation of API Reference
URL: https://github.com/apache/airflow/pull/4788#discussion_r262572990
##
File path: .gitignore
##
@@ -83,6 +83,7 @@ instance/
# Sphinx documentation
[
https://issues.apache.org/jira/browse/AIRFLOW-3834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16784620#comment-16784620
]
ASF GitHub Bot commented on AIRFLOW-3834:
-
ffinfo commented on pull request #4841:
ffinfo opened a new pull request #4841: [AIRFLOW-3834] Remove dagbag from /log
URL: https://github.com/apache/airflow/pull/4841
Make sure you have checked _all_ steps below.
### Jira
- [ ] My PR addresses the following [Airflow
mik-laj commented on issue #4708: [AIRFLOW-3888] HA for metastore connection
URL: https://github.com/apache/airflow/pull/4708#issuecomment-469746486
@GuzikJakub You must mock the method to return the expected value.
Look at:
ashb commented on issue #4569: [AIRFLOW-3745] Fix viewer not able to view dag
details
URL: https://github.com/apache/airflow/pull/4569#issuecomment-469743622
Am I reading this right - does it give Viewer role the ability to edit dags.
That seems incorrect?
ashb commented on issue #4642: [AIRFLOW-2694] Declare permissions in DAG
definition
URL: https://github.com/apache/airflow/pull/4642#issuecomment-469739918
Also (not sure it relates to this PR or another one) but what happens if I
specify a `dag_id="all_dags"` and run sync_perms :D
XD-DENG edited a comment on issue #4840: [AIRFLOW-3761] Fix `DROP TABLE user`
migration for upgrades.
URL: https://github.com/apache/airflow/pull/4840#issuecomment-469728978
My understanding is that `KnownEvent` table is kept only to ensure user's
data will not be lost, but this table
ashb commented on issue #4642: [AIRFLOW-2694] Declare permissions in DAG
definition
URL: https://github.com/apache/airflow/pull/4642#issuecomment-469736358
Is there a reason we don't (additionally) sync the DAG parms at webserver
start up? I had to dig in to the code to find why my dag
EamonKeane commented on issue #4648: [AIRFLOW-3274] Add run_as_user and
fs_group options for Kubernetes
URL: https://github.com/apache/airflow/pull/4648#issuecomment-469736288
+1
This adds the functionality needed on non-root pod operators whose
entrypoints e.g. copy and chmod
XD-DENG commented on issue #4840: [AIRFLOW-3761] Fix `DROP TABLE user`
migration for upgrades.
URL: https://github.com/apache/airflow/pull/4840#issuecomment-469728978
My understanding is that `KnownEvent` table is kept only to ensure user's
data will not be lost, but this table itself
[
https://issues.apache.org/jira/browse/AIRFLOW-3761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16784563#comment-16784563
]
ASF GitHub Bot commented on AIRFLOW-3761:
-
ashb commented on pull request #4840: [AIRFLOW-3761]
ashb opened a new pull request #4840: [AIRFLOW-3761] Fix `DROP TABLE user`
migration for upgrades.
URL: https://github.com/apache/airflow/pull/4840
If you are upgrading an old install you will likely have rows in the
user and known_event tables. We dropped the KnownEvent without a
mik-laj commented on issue #4828: [AIRFLOW-4002] Optionally open debugger on
errors in airflow test.
URL: https://github.com/apache/airflow/pull/4828#issuecomment-469715155
Have you thought about ipdb support? Ipdb provides a much more enjoyable
experience. It is possible to detect
mik-laj commented on issue #4828: [AIRFLOW-4002] Optionally open debugger on
errors in airflow test.
URL: https://github.com/apache/airflow/pull/4828#issuecomment-469712201
I recommend coworkers to cherry-pick this change. This is very helpful in
the development of operators.
potiuk commented on issue #4828: [AIRFLOW-4002] Optionally open debugger on
errors in airflow test.
URL: https://github.com/apache/airflow/pull/4828#issuecomment-469707920
Super useful!
This is an automated message from the
ashb commented on a change in pull request #4601: [AIRFLOW-3758] Fix circular
import in WasbTaskHandler
URL: https://github.com/apache/airflow/pull/4601#discussion_r262529008
##
File path: tests/test_logging_config.py
##
@@ -259,6 +259,11 @@ def
101 - 200 of 282 matches
Mail list logo
