[GitHub] [airflow] codecov-io edited a comment on issue #4591: [AIRFLOW-3615] Parse hostname using netloc

codecov-io edited a comment on issue #4591: [AIRFLOW-3615] Parse hostname using netloc URL: https://github.com/apache/airflow/pull/4591#issuecomment-467251879 # [Codecov](https://codecov.io/gh/apache/airflow/pull/4591?src=pr=h1) Report > Merging

[GitHub] [airflow] XD-DENG commented on issue #4933: [AIRFLOW-4111] Auto config airflow_db to database in initdb

XD-DENG commented on issue #4933: [AIRFLOW-4111] Auto config airflow_db to database in initdb URL: https://github.com/apache/airflow/pull/4933#issuecomment-474782976 That helps. Thanks :) This is an automated message from

[GitHub] [airflow] zhongjiajie commented on issue #4933: [AIRFLOW-4111] Auto config airflow_db to database in initdb

zhongjiajie commented on issue #4933: [AIRFLOW-4111] Auto config airflow_db to database in initdb URL: https://github.com/apache/airflow/pull/4933#issuecomment-474781219 @XD-DENG Thanks for you review, BTW, I close jira ticket with information that your comment above.

[jira] [Closed] (AIRFLOW-4111) Auto config airflow_db to database in initdb

[ https://issues.apache.org/jira/browse/AIRFLOW-4111?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] zhongjiajie closed AIRFLOW-4111. Resolution: Won't Fix Close by XD-DENG review. reason as below: I think it's changing the

[jira] [Commented] (AIRFLOW-4129) Escape HTML in tooltips

[ https://issues.apache.org/jira/browse/AIRFLOW-4129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16797046#comment-16797046 ] ASF GitHub Bot commented on AIRFLOW-4129: - ashb commented on pull request #4944: [AIRFLOW-4129]

[GitHub] [airflow] ashb closed pull request #4944: [AIRFLOW-4129] Escape HTML in generated tooltips

ashb closed pull request #4944: [AIRFLOW-4129] Escape HTML in generated tooltips URL: https://github.com/apache/airflow/pull/4944 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [airflow] ashb commented on issue #4944: [AIRFLOW-4129] Escape HTML in generated tooltips

ashb commented on issue #4944: [AIRFLOW-4129] Escape HTML in generated tooltips URL: https://github.com/apache/airflow/pull/4944#issuecomment-474779744 Closing in favour of #4950 This is an automated message from the Apache

[GitHub] [airflow] mik-laj commented on a change in pull request #4929: [AIRFLOW-4108] Load autocomplete data asynchronously

mik-laj commented on a change in pull request #4929: [AIRFLOW-4108] Load autocomplete data asynchronously URL: https://github.com/apache/airflow/pull/4929#discussion_r266221357 ## File path: airflow/www/templates/airflow/dags.html ## @@ -215,6 +215,7 @@ DAGs

[GitHub] [airflow] ashb commented on issue #4950: [AIRFLOW-4129] Escape HTML in generated tooltips

ashb commented on issue #4950: [AIRFLOW-4129] Escape HTML in generated tooltips URL: https://github.com/apache/airflow/pull/4950#issuecomment-474779157 Much better, thanks! This is an automated message from the Apache Git

[jira] [Commented] (AIRFLOW-4111) Auto config airflow_db to database in initdb

[ https://issues.apache.org/jira/browse/AIRFLOW-4111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16797043#comment-16797043 ] ASF GitHub Bot commented on AIRFLOW-4111: - zhongjiajie commented on pull request #4933:

[GitHub] [airflow] XD-DENG commented on issue #4933: [AIRFLOW-4111] Auto config airflow_db to database in initdb

XD-DENG commented on issue #4933: [AIRFLOW-4111] Auto config airflow_db to database in initdb URL: https://github.com/apache/airflow/pull/4933#issuecomment-474778684 No worries. Thanks @zhongjiajie This is an automated

[GitHub] [airflow] zhongjiajie commented on issue #4933: [AIRFLOW-4111] Auto config airflow_db to database in initdb

zhongjiajie commented on issue #4933: [AIRFLOW-4111] Auto config airflow_db to database in initdb URL: https://github.com/apache/airflow/pull/4933#issuecomment-474778249 @XD-DENG Sorry XD, I don't know you comment at two days ago. You are right, I don't figure out that all of the

[GitHub] [airflow] zhongjiajie closed pull request #4933: [AIRFLOW-4111] Auto config airflow_db to database in initdb

zhongjiajie closed pull request #4933: [AIRFLOW-4111] Auto config airflow_db to database in initdb URL: https://github.com/apache/airflow/pull/4933 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [airflow] mik-laj commented on issue #4944: [AIRFLOW-4129] Escape HTML in generated tooltips

mik-laj commented on issue #4944: [AIRFLOW-4129] Escape HTML in generated tooltips URL: https://github.com/apache/airflow/pull/4944#issuecomment-474777901 My new PR: https://github.com/apache/airflow/pull/4950 This is an

[jira] [Commented] (AIRFLOW-4129) Escape HTML in tooltips

[ https://issues.apache.org/jira/browse/AIRFLOW-4129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16797041#comment-16797041 ] ASF GitHub Bot commented on AIRFLOW-4129: - mik-laj commented on pull request #4950:

[GitHub] [airflow] mik-laj opened a new pull request #4950: [AIRFLOW-4129] Escape HTML in generated tooltips

mik-laj opened a new pull request #4950: [AIRFLOW-4129] Escape HTML in generated tooltips URL: https://github.com/apache/airflow/pull/4950 Make sure you have checked _all_ steps below. ### Jira - [ ] My PR addresses the following [Airflow

[GitHub] [airflow] mik-laj commented on issue #4944: [AIRFLOW-4129] Escape HTML in generated tooltips

mik-laj commented on issue #4944: [AIRFLOW-4129] Escape HTML in generated tooltips URL: https://github.com/apache/airflow/pull/4944#issuecomment-474775420 I will create a separate PR. You will move my commits to expected branch/PR/etc.

[GitHub] [airflow] ashb commented on issue #4941: [AIRFLOW-4123] Add Exception handling for _change_state method in K8 …

ashb commented on issue #4941: [AIRFLOW-4123] Add Exception handling for _change_state method in K8 … URL: https://github.com/apache/airflow/pull/4941#issuecomment-474774108 @dimberman I've updated your Jira perms - try now.

[GitHub] [airflow] ashb edited a comment on issue #4944: [AIRFLOW-4129] Escape HTML in generated tooltips

ashb edited a comment on issue #4944: [AIRFLOW-4129] Escape HTML in generated tooltips URL: https://github.com/apache/airflow/pull/4944#issuecomment-474773006 Thanks. It was late last night when I was working on this. If you do it on one PR I'll fix up the other. Edit: oh you probably

[GitHub] [airflow] ashb commented on issue #4944: [AIRFLOW-4129] Escape HTML in generated tooltips

ashb commented on issue #4944: [AIRFLOW-4129] Escape HTML in generated tooltips URL: https://github.com/apache/airflow/pull/4944#issuecomment-474773006 Thanks. It was late last night when I was working on this. If you do it on one PR I'll fix up the other

[GitHub] [airflow] mik-laj edited a comment on issue #4944: [AIRFLOW-4129] Escape HTML in generated tooltips

mik-laj edited a comment on issue #4944: [AIRFLOW-4129] Escape HTML in generated tooltips URL: https://github.com/apache/airflow/pull/4944#issuecomment-474771892 It is still possible. You could create a new HTML element, like in my example. I will prepare my PR. Please wait.

[GitHub] [airflow] mik-laj edited a comment on issue #4944: [AIRFLOW-4129] Escape HTML in generated tooltips

mik-laj edited a comment on issue #4944: [AIRFLOW-4129] Escape HTML in generated tooltips URL: https://github.com/apache/airflow/pull/4944#issuecomment-474771892 It is still possible. You could create a new HTML element, as a my example. I will prepare my PR. Please wait.

[GitHub] [airflow] mik-laj commented on issue #4944: [AIRFLOW-4129] Escape HTML in generated tooltips

mik-laj commented on issue #4944: [AIRFLOW-4129] Escape HTML in generated tooltips URL: https://github.com/apache/airflow/pull/4944#issuecomment-474771892 It is still possible. I will prepare my PR. Please wait. This is an

[GitHub] [airflow] ashb commented on issue #4944: [AIRFLOW-4129] Escape HTML in generated tooltips

ashb commented on issue #4944: [AIRFLOW-4129] Escape HTML in generated tooltips URL: https://github.com/apache/airflow/pull/4944#issuecomment-474770683 @mik-laj I agree, and I didn't like doing this, but there is no HTML element to set the property on - as this is setting an attribute

[GitHub] [airflow] ashb commented on a change in pull request #4926: [AIRFLOW-4104] Add type annotations to common classes.

ashb commented on a change in pull request #4926: [AIRFLOW-4104] Add type annotations to common classes. URL: https://github.com/apache/airflow/pull/4926#discussion_r267268730 ## File path: airflow/models/__init__.py ## @@ -4290,7 +4291,13 @@ def setdefault(cls, key,

[GitHub] [airflow] ashb commented on issue #4947: [AIRFLOW-3706] Fix tooltip max-width by correcting ordering of CSS files

ashb commented on issue #4947: [AIRFLOW-3706] Fix tooltip max-width by correcting ordering of CSS files URL: https://github.com/apache/airflow/pull/4947#issuecomment-474761285 Ah, it was "rebroken" by https://github.com/apache/airflow/pull/3719

[GitHub] [airflow] XD-DENG commented on issue #4933: [AIRFLOW-4111] Auto config airflow_db to database in initdb

XD-DENG commented on issue #4933: [AIRFLOW-4111] Auto config airflow_db to database in initdb URL: https://github.com/apache/airflow/pull/4933#issuecomment-474757473 @zhongjiajie may you consider closing this? This is an

[GitHub] [airflow] XD-DENG commented on a change in pull request #4943: [AIRFLOW-XXX] add description of is_delete_operator_pod

XD-DENG commented on a change in pull request #4943: [AIRFLOW-XXX] add description of is_delete_operator_pod URL: https://github.com/apache/airflow/pull/4943#discussion_r267252382 ## File path: airflow/contrib/operators/kubernetes_pod_operator.py ## @@ -80,6 +80,10 @@

[GitHub] [airflow] marengaz commented on a change in pull request #4943: [AIRFLOW-XXX] add description of is_delete_operator_pod

marengaz commented on a change in pull request #4943: [AIRFLOW-XXX] add description of is_delete_operator_pod URL: https://github.com/apache/airflow/pull/4943#discussion_r267248883 ## File path: airflow/contrib/operators/kubernetes_pod_operator.py ## @@ -80,6 +80,10 @@

[GitHub] [airflow] XD-DENG removed a comment on issue #4943: [AIRFLOW-XXX] add description of is_delete_operator_pod

XD-DENG removed a comment on issue #4943: [AIRFLOW-XXX] add description of is_delete_operator_pod URL: https://github.com/apache/airflow/pull/4943#issuecomment-474746169 @marengaz it may be good to mention the default value in the doc.

[GitHub] [airflow] XD-DENG commented on a change in pull request #4943: [AIRFLOW-XXX] add description of is_delete_operator_pod

XD-DENG commented on a change in pull request #4943: [AIRFLOW-XXX] add description of is_delete_operator_pod URL: https://github.com/apache/airflow/pull/4943#discussion_r267242641 ## File path: airflow/contrib/operators/kubernetes_pod_operator.py ## @@ -80,6 +80,10 @@

[GitHub] [airflow] XD-DENG commented on issue #4943: [AIRFLOW-XXX] add description of is_delete_operator_pod

XD-DENG commented on issue #4943: [AIRFLOW-XXX] add description of is_delete_operator_pod URL: https://github.com/apache/airflow/pull/4943#issuecomment-474746169 @marengaz it may be good to mention the default value in the doc.

[jira] [Commented] (AIRFLOW-3706) Tooltip Display Issue for a Task Instance

[ https://issues.apache.org/jira/browse/AIRFLOW-3706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16796900#comment-16796900 ] ASF GitHub Bot commented on AIRFLOW-3706: - XD-DENG commented on pull request #4947:

[jira] [Resolved] (AIRFLOW-3706) Tooltip Display Issue for a Task Instance

[ https://issues.apache.org/jira/browse/AIRFLOW-3706?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xiaodong DENG resolved AIRFLOW-3706. Resolution: Resolved > Tooltip Display Issue for a Task Instance >

[jira] [Commented] (AIRFLOW-3706) Tooltip Display Issue for a Task Instance

[ https://issues.apache.org/jira/browse/AIRFLOW-3706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16796901#comment-16796901 ] ASF subversion and git services commented on AIRFLOW-3706: -- Commit

[GitHub] [airflow] XD-DENG merged pull request #4947: [AIRFLOW-3706] Fix tooltip max-width by correcting ordering of CSS files

XD-DENG merged pull request #4947: [AIRFLOW-3706] Fix tooltip max-width by correcting ordering of CSS files URL: https://github.com/apache/airflow/pull/4947 This is an automated message from the Apache Git Service. To

[GitHub] [airflow] kaxil commented on issue #4947: [AIRFLOW-3706] Fix tooltip max-width by correcting ordering of CSS files

kaxil commented on issue #4947: [AIRFLOW-3706] Fix tooltip max-width by correcting ordering of CSS files URL: https://github.com/apache/airflow/pull/4947#issuecomment-474728731 Yea, no harm in merging this This is an

[GitHub] [airflow] stijndehaes commented on issue #4931: [AIRFLOW-4109] Added support for passing the airflow fernet key to th…

stijndehaes commented on issue #4931: [AIRFLOW-4109] Added support for passing the airflow fernet key to th… URL: https://github.com/apache/airflow/pull/4931#issuecomment-474720078 @XD-DENG I need to pass the fernet key as I am using it in my airflow config to encrypt passwords. This

[GitHub] [airflow] mik-laj commented on a change in pull request #4846: [AIRFLOW-4030] adding start to singularity for airflow

mik-laj commented on a change in pull request #4846: [AIRFLOW-4030] adding start to singularity for airflow URL: https://github.com/apache/airflow/pull/4846#discussion_r267207306 ## File path: tests/contrib/operators/test_singularity_operator.py ## @@ -17,14 +17,13 @@ #

[GitHub] [airflow] mik-laj commented on a change in pull request #4887: [AIRFLOW-4055] Add AWS SQS Sensor

mik-laj commented on a change in pull request #4887: [AIRFLOW-4055] Add AWS SQS Sensor URL: https://github.com/apache/airflow/pull/4887#discussion_r267207002 ## File path: airflow/contrib/sensors/aws_sqs_sensor.py ## @@ -0,0 +1,88 @@ +# -*- coding: utf-8 -*- +# +#

[GitHub] [airflow] mik-laj commented on a change in pull request #4887: [AIRFLOW-4055] Add AWS SQS Sensor

mik-laj commented on a change in pull request #4887: [AIRFLOW-4055] Add AWS SQS Sensor URL: https://github.com/apache/airflow/pull/4887#discussion_r267206780 ## File path: airflow/contrib/sensors/aws_sqs_sensor.py ## @@ -0,0 +1,88 @@ +# -*- coding: utf-8 -*- +# +#

[GitHub] [airflow] XD-DENG commented on issue #4931: [AIRFLOW-4109] Added support for passing the airflow fernet key to th…

XD-DENG commented on issue #4931: [AIRFLOW-4109] Added support for passing the airflow fernet key to th… URL: https://github.com/apache/airflow/pull/4931#issuecomment-474712678 You only need to specify the config items that you want to apply your own values (instead of default values) as

[GitHub] [airflow] stijndehaes edited a comment on issue #4931: [AIRFLOW-4109] Added support for passing the airflow fernet key to th…

stijndehaes edited a comment on issue #4931: [AIRFLOW-4109] Added support for passing the airflow fernet key to th… URL: https://github.com/apache/airflow/pull/4931#issuecomment-474712030 Airflow spawns the kubernetes executors itself, the config put in the scheduler or web pods is not

[GitHub] [airflow] stijndehaes commented on issue #4931: [AIRFLOW-4109] Added support for passing the airflow fernet key to th…

stijndehaes commented on issue #4931: [AIRFLOW-4109] Added support for passing the airflow fernet key to th… URL: https://github.com/apache/airflow/pull/4931#issuecomment-474712030 Airflow spawns the kubernetes executors itself, the config put in the scheduler or web pods is not passed

[GitHub] [airflow] mik-laj commented on a change in pull request #4895: [AIRFLOW-1526] Add dingding hook and operator

mik-laj commented on a change in pull request #4895: [AIRFLOW-1526] Add dingding hook and operator URL: https://github.com/apache/airflow/pull/4895#discussion_r267205912 ## File path: docs/howto/operator/dingding.rst ## @@ -0,0 +1,72 @@ +.. Licensed to the Apache

[jira] [Commented] (AIRFLOW-1557) backfill ignores configured number of slots in a pool

[ https://issues.apache.org/jira/browse/AIRFLOW-1557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16796859#comment-16796859 ] ASF GitHub Bot commented on AIRFLOW-1557: - milton0825 commented on pull request #4949:

[GitHub] [airflow] milton0825 opened a new pull request #4949: [AIRFLOW-1557] Backfill respect pool

milton0825 opened a new pull request #4949: [AIRFLOW-1557] Backfill respect pool URL: https://github.com/apache/airflow/pull/4949 Make sure you have checked _all_ steps below. ### Jira - [ ] My PR addresses the following [Airflow

[GitHub] [airflow] mik-laj commented on a change in pull request #4903: [AIRFLOW-4069] Add Opsgenie Alert Hook and Operator

mik-laj commented on a change in pull request #4903: [AIRFLOW-4069] Add Opsgenie Alert Hook and Operator URL: https://github.com/apache/airflow/pull/4903#discussion_r267204856 ## File path: airflow/contrib/operators/opsgenie_alert_operator.py ## @@ -0,0 +1,142 @@ +# -*-

[GitHub] [airflow] XD-DENG commented on issue #4931: [AIRFLOW-4109] Added support for passing the airflow fernet key to th…

XD-DENG commented on issue #4931: [AIRFLOW-4109] Added support for passing the airflow fernet key to th… URL: https://github.com/apache/airflow/pull/4931#issuecomment-474710542 Nice we have got agreement ;-) May I know why it has to be

[GitHub] [airflow] mik-laj commented on a change in pull request #4903: [AIRFLOW-4069] Add Opsgenie Alert Hook and Operator

mik-laj commented on a change in pull request #4903: [AIRFLOW-4069] Add Opsgenie Alert Hook and Operator URL: https://github.com/apache/airflow/pull/4903#discussion_r267204856 ## File path: airflow/contrib/operators/opsgenie_alert_operator.py ## @@ -0,0 +1,142 @@ +# -*-

[jira] [Commented] (AIRFLOW-4109) Airflow kubernetes executor set the fernet key

[ https://issues.apache.org/jira/browse/AIRFLOW-4109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16796857#comment-16796857 ] ASF GitHub Bot commented on AIRFLOW-4109: - stijndehaes commented on pull request #4931:

[jira] [Closed] (AIRFLOW-4109) Airflow kubernetes executor set the fernet key

[ https://issues.apache.org/jira/browse/AIRFLOW-4109?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stijn De Haes closed AIRFLOW-4109. -- Resolution: Won't Fix > Airflow kubernetes executor set the fernet key >

[GitHub] [airflow] stijndehaes commented on issue #4931: [AIRFLOW-4109] Added support for passing the airflow fernet key to th…

stijndehaes commented on issue #4931: [AIRFLOW-4109] Added support for passing the airflow fernet key to th… URL: https://github.com/apache/airflow/pull/4931#issuecomment-474709840 Ok had some time to think about it. You are right we don't need to add support for this for airflow. But at

[GitHub] [airflow] mik-laj commented on issue #4944: [AIRFLOW-4129] Escape HTML in generated tooltips

mik-laj commented on issue #4944: [AIRFLOW-4129] Escape HTML in generated tooltips URL: https://github.com/apache/airflow/pull/4944#issuecomment-474709801 Hi. You should not implement your own security mechanisms when it is not required. Look how you can achieve a similar effect, but

[GitHub] [airflow] stijndehaes closed pull request #4931: [AIRFLOW-4109] Added support for passing the airflow fernet key to th…

stijndehaes closed pull request #4931: [AIRFLOW-4109] Added support for passing the airflow fernet key to th… URL: https://github.com/apache/airflow/pull/4931 This is an automated message from the Apache Git Service. To

[jira] [Resolved] (AIRFLOW-4123) Add Exception handling for _change_state method in K8 Executor

[ https://issues.apache.org/jira/browse/AIRFLOW-4123?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anand resolved AIRFLOW-4123. Resolution: Fixed > Add Exception handling for _change_state method in K8 Executor >

[GitHub] [airflow] Gaurav589 commented on issue #4338: [AIRFLOW-3172] Fix error creation dag link

Gaurav589 commented on issue #4338: [AIRFLOW-3172] Fix error creation dag link URL: https://github.com/apache/airflow/pull/4338#issuecomment-474697165 File "/usr/lib/python3/dist-packages/jinja2/_compat.py", line 37, in reraise raise value.with_traceback(tb) File

<    1   2