[jira] [Commented] (AIRFLOW-4150) Modify the docker operator implementation

2019-03-25 Thread aaronluo (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16801414#comment-16801414 ] aaronluo commented on AIRFLOW-4150: --- [~ash] For docker container tasks that need to run for a long

[GitHub] [airflow] cooltoast commented on issue #4939: [AIRFLOW-4120] Modify SchedulerJob.manage_slas to respect zero timedelta SLAs

2019-03-25 Thread GitBox
cooltoast commented on issue #4939: [AIRFLOW-4120] Modify SchedulerJob.manage_slas to respect zero timedelta SLAs URL: https://github.com/apache/airflow/pull/4939#issuecomment-476474485 @Fokko I added a couple tests, please take a look. thank you

[GitHub] [airflow] astahlman commented on issue #4974: [AIRFLOW-4057] Fix bug in stat name validation

2019-03-25 Thread GitBox
astahlman commented on issue #4974: [AIRFLOW-4057] Fix bug in stat name validation URL: https://github.com/apache/airflow/pull/4974#issuecomment-476466982 Oops, sorry @ashb. Will keep that in mind for next time This is an

[GitHub] [airflow] codecov-io edited a comment on issue #4939: [AIRFLOW-4120] Modify SchedulerJob.manage_slas to respect zero timedelta SLAs

2019-03-25 Thread GitBox
codecov-io edited a comment on issue #4939: [AIRFLOW-4120] Modify SchedulerJob.manage_slas to respect zero timedelta SLAs URL: https://github.com/apache/airflow/pull/4939#issuecomment-475907566 # [Codecov](https://codecov.io/gh/apache/airflow/pull/4939?src=pr=h1) Report > Merging

[GitHub] [airflow] jmcarp commented on a change in pull request #4926: [AIRFLOW-4104] Add type annotations to common classes.

2019-03-25 Thread GitBox
jmcarp commented on a change in pull request #4926: [AIRFLOW-4104] Add type annotations to common classes. URL: https://github.com/apache/airflow/pull/4926#discussion_r268934073 ## File path: airflow/models/__init__.py ## @@ -4290,7 +4291,13 @@ def setdefault(cls, key,

[GitHub] [airflow] jmcarp commented on issue #4926: [AIRFLOW-4104] Add type annotations to common classes.

2019-03-25 Thread GitBox
jmcarp commented on issue #4926: [AIRFLOW-4104] Add type annotations to common classes. URL: https://github.com/apache/airflow/pull/4926#issuecomment-476463889 Conflicts resolved. This is an automated message from the Apache

[GitHub] [airflow] feng-tao commented on a change in pull request #4973: [AIRFLOW-4155] Allow Public role access to /home

2019-03-25 Thread GitBox
feng-tao commented on a change in pull request #4973: [AIRFLOW-4155] Allow Public role access to /home URL: https://github.com/apache/airflow/pull/4973#discussion_r268930130 ## File path: tests/www/test_security.py ## @@ -308,3 +308,26 @@ def test_override_role_vm(self):

[jira] [Commented] (AIRFLOW-4057) airflow should handle invalid stats name

2019-03-25 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16801332#comment-16801332 ] ASF subversion and git services commented on AIRFLOW-4057: -- Commit

[GitHub] [airflow] feng-tao merged pull request #4974: [AIRFLOW-4057] Fix bug in stat name validation

2019-03-25 Thread GitBox
feng-tao merged pull request #4974: [AIRFLOW-4057] Fix bug in stat name validation URL: https://github.com/apache/airflow/pull/4974 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [airflow] feng-tao commented on issue #4974: [AIRFLOW-4057] Fix bug in stat name validation

2019-03-25 Thread GitBox
feng-tao commented on issue #4974: [AIRFLOW-4057] Fix bug in stat name validation URL: https://github.com/apache/airflow/pull/4974#issuecomment-476458849 cc @ashb FYI, as we have two prs for the same jira ticket. This is an

[jira] [Commented] (AIRFLOW-4057) airflow should handle invalid stats name

2019-03-25 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16801333#comment-16801333 ] ASF subversion and git services commented on AIRFLOW-4057: -- Commit

[jira] [Commented] (AIRFLOW-4057) airflow should handle invalid stats name

2019-03-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16801330#comment-16801330 ] ASF GitHub Bot commented on AIRFLOW-4057: - feng-tao commented on pull request #4974:

[GitHub] [airflow] feng-tao commented on issue #4974: [AIRFLOW-4057] Fix bug in stat name validation

2019-03-25 Thread GitBox
feng-tao commented on issue #4974: [AIRFLOW-4057] Fix bug in stat name validation URL: https://github.com/apache/airflow/pull/4974#issuecomment-476458670 @astahlman , thanks for the fix. I think that unit test is flaky. If you want, we could fix in a different pr. But let's get this one

[GitHub] [airflow] feng-tao commented on a change in pull request #4974: [AIRFLOW-4057] Fix bug in stat name validation

2019-03-25 Thread GitBox
feng-tao commented on a change in pull request #4974: [AIRFLOW-4057] Fix bug in stat name validation URL: https://github.com/apache/airflow/pull/4974#discussion_r268929570 ## File path: docs/plugins.rst ## @@ -212,7 +212,7 @@ definitions in Airflow.

[GitHub] [airflow] feng-tao commented on a change in pull request #4974: [AIRFLOW-4057] Fix bug in stat name validation

2019-03-25 Thread GitBox
feng-tao commented on a change in pull request #4974: [AIRFLOW-4057] Fix bug in stat name validation URL: https://github.com/apache/airflow/pull/4974#discussion_r268929570 ## File path: docs/plugins.rst ## @@ -212,7 +212,7 @@ definitions in Airflow.

[GitHub] [airflow] feng-tao commented on a change in pull request #4974: [AIRFLOW-4057] Fix bug in stat name validation

2019-03-25 Thread GitBox
feng-tao commented on a change in pull request #4974: [AIRFLOW-4057] Fix bug in stat name validation URL: https://github.com/apache/airflow/pull/4974#discussion_r268929613 ## File path: docs/plugins.rst ## @@ -212,7 +212,7 @@ definitions in Airflow.

[GitHub] [airflow] gerardo commented on a change in pull request #4938: [AIRFLOW-4117] Multi-staging Image - Travis CI tests [Step 3/3]

2019-03-25 Thread GitBox
gerardo commented on a change in pull request #4938: [AIRFLOW-4117] Multi-staging Image - Travis CI tests [Step 3/3] URL: https://github.com/apache/airflow/pull/4938#discussion_r268924028 ## File path: scripts/ci/docker-compose.yml ## @@ -18,61 +18,67 @@ version: "2.2"

[GitHub] [airflow] astahlman commented on issue #4974: [AIRFLOW-4057] Fix bug in stat name validation

2019-03-25 Thread GitBox
astahlman commented on issue #4974: [AIRFLOW-4057] Fix bug in stat name validation URL: https://github.com/apache/airflow/pull/4974#issuecomment-476451175 @feng-tao Have you ever seen this failure before? I'm pretty sure it's not related to my changes, but I can dig deeper if you think

[GitHub] [airflow] astahlman commented on issue #4974: [AIRFLOW-4057] Fix bug in stat name validation

2019-03-25 Thread GitBox
astahlman commented on issue #4974: [AIRFLOW-4057] Fix bug in stat name validation URL: https://github.com/apache/airflow/pull/4974#issuecomment-476446514 @feng-tao Fixed - see https://github.com/apache/airflow/pull/4974/files#r268920074 for an explanation. cc @milton0825 I've

[GitHub] [airflow] astahlman commented on a change in pull request #4974: [AIRFLOW-4057] Fix bug in stat name validation

2019-03-25 Thread GitBox
astahlman commented on a change in pull request #4974: [AIRFLOW-4057] Fix bug in stat name validation URL: https://github.com/apache/airflow/pull/4974#discussion_r268920074 ## File path: docs/plugins.rst ## @@ -212,7 +212,7 @@ definitions in Airflow.

[GitHub] [airflow] zhongjiajie commented on a change in pull request #4895: [AIRFLOW-1526] Add dingding hook and operator

2019-03-25 Thread GitBox
zhongjiajie commented on a change in pull request #4895: [AIRFLOW-1526] Add dingding hook and operator URL: https://github.com/apache/airflow/pull/4895#discussion_r268915806 ## File path: airflow/contrib/hooks/dingding_hook.py ## @@ -0,0 +1,133 @@ +# -*- coding: utf-8 -*-

[GitHub] [airflow] zhongjiajie commented on a change in pull request #4903: [AIRFLOW-4069] Add Opsgenie Alert Hook and Operator

2019-03-25 Thread GitBox
zhongjiajie commented on a change in pull request #4903: [AIRFLOW-4069] Add Opsgenie Alert Hook and Operator URL: https://github.com/apache/airflow/pull/4903#discussion_r268914882 ## File path: airflow/contrib/hooks/opsgenie_alert_hook.py ## @@ -0,0 +1,68 @@ +# -*-

[GitHub] [airflow] zhongjiajie commented on a change in pull request #4903: [AIRFLOW-4069] Add Opsgenie Alert Hook and Operator

2019-03-25 Thread GitBox
zhongjiajie commented on a change in pull request #4903: [AIRFLOW-4069] Add Opsgenie Alert Hook and Operator URL: https://github.com/apache/airflow/pull/4903#discussion_r268914120 ## File path: airflow/contrib/operators/opsgenie_alert_operator.py ## @@ -0,0 +1,139 @@ +#

[GitHub] [airflow] zhongjiajie commented on a change in pull request #4903: [AIRFLOW-4069] Add Opsgenie Alert Hook and Operator

2019-03-25 Thread GitBox
zhongjiajie commented on a change in pull request #4903: [AIRFLOW-4069] Add Opsgenie Alert Hook and Operator URL: https://github.com/apache/airflow/pull/4903#discussion_r268913989 ## File path: airflow/contrib/hooks/opsgenie_alert_hook.py ## @@ -0,0 +1,68 @@ +# -*-

[GitHub] [airflow] zhongjiajie commented on a change in pull request #4903: [AIRFLOW-4069] Add Opsgenie Alert Hook and Operator

2019-03-25 Thread GitBox
zhongjiajie commented on a change in pull request #4903: [AIRFLOW-4069] Add Opsgenie Alert Hook and Operator URL: https://github.com/apache/airflow/pull/4903#discussion_r268914994 ## File path: airflow/contrib/hooks/opsgenie_alert_hook.py ## @@ -0,0 +1,68 @@ +# -*-

[GitHub] [airflow] XD-DENG merged pull request #4976: adding Beeswax as a company who uses airflow

2019-03-25 Thread GitBox
XD-DENG merged pull request #4976: adding Beeswax as a company who uses airflow URL: https://github.com/apache/airflow/pull/4976 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [airflow] potiuk commented on a change in pull request #4938: [AIRFLOW-4117] Multi-staging Image - Travis CI tests [Step 3/3]

2019-03-25 Thread GitBox
potiuk commented on a change in pull request #4938: [AIRFLOW-4117] Multi-staging Image - Travis CI tests [Step 3/3] URL: https://github.com/apache/airflow/pull/4938#discussion_r268896300 ## File path: setup.py ## @@ -35,31 +34,34 @@ PY3 = sys.version_info[0] == 3

[GitHub] [airflow] potiuk commented on a change in pull request #4938: [AIRFLOW-4117] Multi-staging Image - Travis CI tests [Step 3/3]

2019-03-25 Thread GitBox
potiuk commented on a change in pull request #4938: [AIRFLOW-4117] Multi-staging Image - Travis CI tests [Step 3/3] URL: https://github.com/apache/airflow/pull/4938#discussion_r268896021 ## File path: scripts/ci/docker-compose.yml ## @@ -18,61 +18,67 @@ version: "2.2"

[GitHub] [airflow] codecov-io commented on issue #4976: adding Beeswax as a company who uses airflow

2019-03-25 Thread GitBox
codecov-io commented on issue #4976: adding Beeswax as a company who uses airflow URL: https://github.com/apache/airflow/pull/4976#issuecomment-476417971 # [Codecov](https://codecov.io/gh/apache/airflow/pull/4976?src=pr=h1) Report > Merging

[GitHub] [airflow] potiuk commented on a change in pull request #4937: [AIRFLOW-4116] Multi-staging includes CI image [Step 2/3]

2019-03-25 Thread GitBox
potiuk commented on a change in pull request #4937: [AIRFLOW-4116] Multi-staging includes CI image [Step 2/3] URL: https://github.com/apache/airflow/pull/4937#discussion_r268895206 ## File path: Dockerfile ## @@ -85,14 +85,134 @@ RUN adduser airflow \ && echo

[GitHub] [airflow] feng-tao commented on issue #4974: [AIRFLOW-4057] Fix bug in stat name validation

2019-03-25 Thread GitBox
feng-tao commented on issue #4974: [AIRFLOW-4057] Fix bug in stat name validation URL: https://github.com/apache/airflow/pull/4974#issuecomment-476414687 @astahlman , fyi, the py27 fails with the followings: ```==

[GitHub] [airflow] mans2singh commented on a change in pull request #4967: [AIRFLOW-4147] Operator to publish event to Redis

2019-03-25 Thread GitBox
mans2singh commented on a change in pull request #4967: [AIRFLOW-4147] Operator to publish event to Redis URL: https://github.com/apache/airflow/pull/4967#discussion_r268892210 ## File path: tests/contrib/operators/test_redis_publish_operator.py ## @@ -0,0 +1,59 @@ +# -*-

[GitHub] [airflow] mans2singh commented on a change in pull request #4967: [AIRFLOW-4147] Operator to publish event to Redis

2019-03-25 Thread GitBox
mans2singh commented on a change in pull request #4967: [AIRFLOW-4147] Operator to publish event to Redis URL: https://github.com/apache/airflow/pull/4967#discussion_r268892174 ## File path: tests/contrib/operators/test_redis_publish_operator.py ## @@ -0,0 +1,59 @@ +# -*-

[GitHub] [airflow] potiuk commented on a change in pull request #4936: [AIRFLOW-4115] Multi-staging Aiflow Docker image [Step 1/3]

2019-03-25 Thread GitBox
potiuk commented on a change in pull request #4936: [AIRFLOW-4115] Multi-staging Aiflow Docker image [Step 1/3] URL: https://github.com/apache/airflow/pull/4936#discussion_r268880220 ## File path: .dockerignore ## @@ -0,0 +1,107 @@ +# +# Licensed to the Apache Software

[GitHub] [airflow] feng-tao commented on issue #4974: [AIRFLOW-4057] Fix bug in stat name validation

2019-03-25 Thread GitBox
feng-tao commented on issue #4974: [AIRFLOW-4057] Fix bug in stat name validation URL: https://github.com/apache/airflow/pull/4974#issuecomment-476399767 why does it fail for all the python27 CI? This is an automated message

[GitHub] [airflow] ashb commented on a change in pull request #4973: [AIRFLOW-4155] Allow Public role access to /home

2019-03-25 Thread GitBox
ashb commented on a change in pull request #4973: [AIRFLOW-4155] Allow Public role access to /home URL: https://github.com/apache/airflow/pull/4973#discussion_r268874265 ## File path: tests/www/test_security.py ## @@ -308,3 +308,26 @@ def test_override_role_vm(self):

[GitHub] [airflow] potiuk commented on a change in pull request #4936: [AIRFLOW-4115] Multi-staging Aiflow Docker image [Step 1/3]

2019-03-25 Thread GitBox
potiuk commented on a change in pull request #4936: [AIRFLOW-4115] Multi-staging Aiflow Docker image [Step 1/3] URL: https://github.com/apache/airflow/pull/4936#discussion_r268874142 ## File path: Dockerfile ## @@ -13,46 +13,179 @@ # WITHOUT WARRANTIES OR CONDITIONS OF

[jira] [Commented] (AIRFLOW-4156) KubernetesPodOperator does not support set security context

2019-03-25 Thread Ash Berlin-Taylor (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16801161#comment-16801161 ] Ash Berlin-Taylor commented on AIRFLOW-4156: Some overlap with AIRFLOW-3274 (though it

[GitHub] [airflow] potiuk commented on a change in pull request #4936: [AIRFLOW-4115] Multi-staging Aiflow Docker image [Step 1/3]

2019-03-25 Thread GitBox
potiuk commented on a change in pull request #4936: [AIRFLOW-4115] Multi-staging Aiflow Docker image [Step 1/3] URL: https://github.com/apache/airflow/pull/4936#discussion_r268871848 ## File path: Dockerfile ## @@ -13,46 +13,179 @@ # WITHOUT WARRANTIES OR CONDITIONS OF

[GitHub] [airflow] ashb commented on a change in pull request #4936: [AIRFLOW-4115] Multi-staging Aiflow Docker image [Step 1/3]

2019-03-25 Thread GitBox
ashb commented on a change in pull request #4936: [AIRFLOW-4115] Multi-staging Aiflow Docker image [Step 1/3] URL: https://github.com/apache/airflow/pull/4936#discussion_r268870799 ## File path: setup.py ## @@ -252,7 +253,7 @@ def

[GitHub] [airflow] mik-laj commented on issue #4894: [AIRFLOW-3996] Add view source link to included fragments

2019-03-25 Thread GitBox
mik-laj commented on issue #4894: [AIRFLOW-3996] Add view source link to included fragments URL: https://github.com/apache/airflow/pull/4894#issuecomment-476393030 @Fokko I updated a PR: http://steadfast-machine.surge.sh/howto/operator/index.html

[GitHub] [airflow] mik-laj removed a comment on issue #4894: [AIRFLOW-3996] Add view source link to included fragments

2019-03-25 Thread GitBox
mik-laj removed a comment on issue #4894: [AIRFLOW-3996] Add view source link to included fragments URL: https://github.com/apache/airflow/pull/4894#issuecomment-475994293 I updated a PR: http://steadfast-machine.surge.sh/howto/operator/index.html

[GitHub] [airflow] mik-laj commented on a change in pull request #4823: [AIRFLOW-3999] Remove all inline style

2019-03-25 Thread GitBox
mik-laj commented on a change in pull request #4823: [AIRFLOW-3999] Remove all inline style URL: https://github.com/apache/airflow/pull/4823#discussion_r268127817 ## File path: airflow/www/static/css/_page_dags.scss ## @@ -0,0 +1,46 @@ +/** +* Licensed to the Apache

[GitHub] [airflow] mans2singh commented on issue #4967: [AIRFLOW-4147] Operator to publish event to Redis

2019-03-25 Thread GitBox
mans2singh commented on issue #4967: [AIRFLOW-4147] Operator to publish event to Redis URL: https://github.com/apache/airflow/pull/4967#issuecomment-476391674 @XD-DENG - I've updated the test based on your feedback. Please let me know if you have any additional advice. Thanks

[GitHub] [airflow] potiuk commented on a change in pull request #4936: [AIRFLOW-4115] Multi-staging Aiflow Docker image [Step 1/3]

2019-03-25 Thread GitBox
potiuk commented on a change in pull request #4936: [AIRFLOW-4115] Multi-staging Aiflow Docker image [Step 1/3] URL: https://github.com/apache/airflow/pull/4936#discussion_r268862273 ## File path: setup.py ## @@ -252,7 +253,7 @@ def

[GitHub] [airflow] potiuk commented on a change in pull request #4936: [AIRFLOW-4115] Multi-staging Aiflow Docker image [Step 1/3]

2019-03-25 Thread GitBox
potiuk commented on a change in pull request #4936: [AIRFLOW-4115] Multi-staging Aiflow Docker image [Step 1/3] URL: https://github.com/apache/airflow/pull/4936#discussion_r268861624 ## File path: setup.py ## @@ -252,7 +253,7 @@ def

[GitHub] [airflow] feng-tao commented on a change in pull request #4973: [AIRFLOW-4155] Allow Public role access to /home

2019-03-25 Thread GitBox
feng-tao commented on a change in pull request #4973: [AIRFLOW-4155] Allow Public role access to /home URL: https://github.com/apache/airflow/pull/4973#discussion_r268853058 ## File path: airflow/www/security.py ## @@ -155,6 +154,11 @@ class

[GitHub] [airflow] feng-tao commented on a change in pull request #4973: [AIRFLOW-4155] Allow Public role access to /home

2019-03-25 Thread GitBox
feng-tao commented on a change in pull request #4973: [AIRFLOW-4155] Allow Public role access to /home URL: https://github.com/apache/airflow/pull/4973#discussion_r268852064 ## File path: tests/www/test_security.py ## @@ -308,3 +308,26 @@ def test_override_role_vm(self):

[GitHub] [airflow] feng-tao commented on a change in pull request #4973: [AIRFLOW-4155] Allow Public role access to /home

2019-03-25 Thread GitBox
feng-tao commented on a change in pull request #4973: [AIRFLOW-4155] Allow Public role access to /home URL: https://github.com/apache/airflow/pull/4973#discussion_r268852064 ## File path: tests/www/test_security.py ## @@ -308,3 +308,26 @@ def test_override_role_vm(self):

[jira] [Created] (AIRFLOW-4156) KubernetesPodOperator does not support set security context

2019-03-25 Thread Magnus Runesson (JIRA)
Magnus Runesson created AIRFLOW-4156: Summary: KubernetesPodOperator does not support set security context Key: AIRFLOW-4156 URL: https://issues.apache.org/jira/browse/AIRFLOW-4156 Project:

[jira] [Commented] (AIRFLOW-4149) gRPC connection should be added to forms

2019-03-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16801006#comment-16801006 ] ASF GitHub Bot commented on AIRFLOW-4149: - morgendave commented on pull request #4975:

[GitHub] [airflow] morgendave opened a new pull request #4975: AIRFLOW-4149 add extra gRPC fields to connections forms

2019-03-25 Thread GitBox
morgendave opened a new pull request #4975: AIRFLOW-4149 add extra gRPC fields to connections forms URL: https://github.com/apache/airflow/pull/4975 Make sure you have checked _all_ steps below. ### Jira - [ ] My PR addresses the following [Airflow

[jira] [Commented] (AIRFLOW-3650) Fix flaky test in TestTriggerDag

2019-03-25 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16800988#comment-16800988 ] ASF subversion and git services commented on AIRFLOW-3650: -- Commit

[GitHub] [airflow] nritholtz commented on issue #4903: [AIRFLOW-4069] Add Opsgenie Alert Hook and Operator

2019-03-25 Thread GitBox
nritholtz commented on issue #4903: [AIRFLOW-4069] Add Opsgenie Alert Hook and Operator URL: https://github.com/apache/airflow/pull/4903#issuecomment-476340038 @ashb @XD-DENG I've made all recommended changes (hopefully). PTAL.

svn commit: r33189 - in /dev/airflow/1.10.3b1: ./ apache-airflow-1.10.3b1-bin.tar.gz apache-airflow-1.10.3b1-source.tar.gz apache_airflow-1.10.3b1-py2.py3-none-any.whl

2019-03-25 Thread ash
Author: ash Date: Mon Mar 25 19:10:56 2019 New Revision: 33189 Log: Non-signed 1.10.3b1 snapshot artefacts Added: dev/airflow/1.10.3b1/ dev/airflow/1.10.3b1/apache-airflow-1.10.3b1-bin.tar.gz (with props) dev/airflow/1.10.3b1/apache-airflow-1.10.3b1-source.tar.gz (with props)

[GitHub] [airflow] ashb commented on a change in pull request #4973: [AIRFLOW-4155] Allow Public role access to /home

2019-03-25 Thread GitBox
ashb commented on a change in pull request #4973: [AIRFLOW-4155] Allow Public role access to /home URL: https://github.com/apache/airflow/pull/4973#discussion_r268804775 ## File path: tests/www/test_security.py ## @@ -308,3 +308,26 @@ def test_override_role_vm(self):

[jira] [Updated] (AIRFLOW-4057) airflow should handle invalid stats name

2019-03-25 Thread Ash Berlin-Taylor (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4057?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ash Berlin-Taylor updated AIRFLOW-4057: --- Fix Version/s: 2.0.0 > airflow should handle invalid stats name >

[GitHub] [airflow] milton0825 commented on issue #4974: [AIRFLOW-4057] Fix bug in stat name validation

2019-03-25 Thread GitBox
milton0825 commented on issue #4974: [AIRFLOW-4057] Fix bug in stat name validation URL: https://github.com/apache/airflow/pull/4974#issuecomment-476318214  thanks for the fix This is an automated message from the Apache

[GitHub] [airflow] astahlman commented on issue #4974: [AIRFLOW-4057] Fix bug in stat name validation

2019-03-25 Thread GitBox
astahlman commented on issue #4974: [AIRFLOW-4057] Fix bug in stat name validation URL: https://github.com/apache/airflow/pull/4974#issuecomment-476317602 cc @feng-tao This is an automated message from the Apache Git

[GitHub] [airflow] astahlman commented on a change in pull request #4973: [AIRFLOW-4155] Allow Public role access to /home

2019-03-25 Thread GitBox
astahlman commented on a change in pull request #4973: [AIRFLOW-4155] Allow Public role access to /home URL: https://github.com/apache/airflow/pull/4973#discussion_r268784234 ## File path: tests/www/test_security.py ## @@ -308,3 +308,26 @@ def test_override_role_vm(self):

[GitHub] [airflow] astahlman commented on a change in pull request #4973: [AIRFLOW-4155] Allow Public role access to /home

2019-03-25 Thread GitBox
astahlman commented on a change in pull request #4973: [AIRFLOW-4155] Allow Public role access to /home URL: https://github.com/apache/airflow/pull/4973#discussion_r268782862 ## File path: airflow/www/templates/airflow/dags.html ## @@ -28,6 +28,17 @@ {% block content %}

[GitHub] [airflow] astahlman commented on issue #4974: [AIRFLOW-4057] Fix bug in stat name validation

2019-03-25 Thread GitBox
astahlman commented on issue #4974: [AIRFLOW-4057] Fix bug in stat name validation URL: https://github.com/apache/airflow/pull/4974#issuecomment-476313372 cc @milton0825 This is an automated message from the Apache Git

[jira] [Reopened] (AIRFLOW-3650) Fix flaky test in TestTriggerDag

2019-03-25 Thread Ash Berlin-Taylor (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3650?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ash Berlin-Taylor reopened AIRFLOW-3650: > Fix flaky test in TestTriggerDag > > >

[jira] [Resolved] (AIRFLOW-3650) Fix flaky test in TestTriggerDag

2019-03-25 Thread Ash Berlin-Taylor (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3650?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ash Berlin-Taylor resolved AIRFLOW-3650. Resolution: Fixed Fix Version/s: (was: 2.0.0)

[jira] [Commented] (AIRFLOW-3650) Fix flaky test in TestTriggerDag

2019-03-25 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16800912#comment-16800912 ] ASF subversion and git services commented on AIRFLOW-3650: -- Commit

[GitHub] [airflow] ashb commented on a change in pull request #4973: [AIRFLOW-4155] Allow Public role access to /home

2019-03-25 Thread GitBox
ashb commented on a change in pull request #4973: [AIRFLOW-4155] Allow Public role access to /home URL: https://github.com/apache/airflow/pull/4973#discussion_r268761916 ## File path: tests/www/test_security.py ## @@ -308,3 +308,26 @@ def test_override_role_vm(self):

[jira] [Commented] (AIRFLOW-4155) Logging in with Public role triggers infinite redirect loop

2019-03-25 Thread Ash Berlin-Taylor (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16800891#comment-16800891 ] Ash Berlin-Taylor commented on AIRFLOW-4155: Sounds like doc/config issue -

[jira] [Commented] (AIRFLOW-4155) Logging in with Public role triggers infinite redirect loop

2019-03-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16800893#comment-16800893 ] ASF GitHub Bot commented on AIRFLOW-4155: - astahlman commented on pull request #4973:

[GitHub] [airflow] astahlman opened a new pull request #4973: [AIRFLOW-4155] Allow Public role access to /home

2019-03-25 Thread GitBox
astahlman opened a new pull request #4973: [AIRFLOW-4155] Allow Public role access to /home URL: https://github.com/apache/airflow/pull/4973 Make sure you have checked _all_ steps below. ### Jira - [ X ] My PR addresses the following [Airflow

[GitHub] [airflow] ashb commented on a change in pull request #4772: [AIRFLOW-3937] KubernetesPodOperator support for envFrom configMapRef…

2019-03-25 Thread GitBox
ashb commented on a change in pull request #4772: [AIRFLOW-3937] KubernetesPodOperator support for envFrom configMapRef… URL: https://github.com/apache/airflow/pull/4772#discussion_r268751356 ## File path:

[jira] [Created] (AIRFLOW-4155) Logging in with Public role triggers infinite redirect loop

2019-03-25 Thread Andrew Stahlman (JIRA)
Andrew Stahlman created AIRFLOW-4155: Summary: Logging in with Public role triggers infinite redirect loop Key: AIRFLOW-4155 URL: https://issues.apache.org/jira/browse/AIRFLOW-4155 Project:

[GitHub] [airflow] dimberman commented on a change in pull request #4772: [AIRFLOW-3937] KubernetesPodOperator support for envFrom configMapRef…

2019-03-25 Thread GitBox
dimberman commented on a change in pull request #4772: [AIRFLOW-3937] KubernetesPodOperator support for envFrom configMapRef… URL: https://github.com/apache/airflow/pull/4772#discussion_r268747033 ## File path: airflow/contrib/kubernetes/secret.py ## @@ -14,28 +14,41 @@

[jira] [Updated] (AIRFLOW-4072) enable GKEPodOperator xcom

2019-03-25 Thread Ben Marengo (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4072?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ben Marengo updated AIRFLOW-4072: - Issue Type: Bug (was: Improvement) > enable GKEPodOperator xcom > --

svn commit: r33185 - in /dev/airflow: 1.10.2beta1/ 1.10.2beta2/ 1.10.2rc1/ 1.10.2rc2/

2019-03-25 Thread ash
Author: ash Date: Mon Mar 25 16:30:56 2019 New Revision: 33185 Log: Remove old Airflow dev/RC releases Removed: dev/airflow/1.10.2beta1/ dev/airflow/1.10.2beta2/ dev/airflow/1.10.2rc1/ dev/airflow/1.10.2rc2/

[jira] [Commented] (AIRFLOW-4072) enable GKEPodOperator xcom

2019-03-25 Thread jack (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16800849#comment-16800849 ] jack commented on AIRFLOW-4072: --- Duplicated ticket of https://issues.apache.org/jira/browse/AIRFLOW-3113

[GitHub] [airflow] OmerJog commented on issue #4855: [AIRFLOW-2421] - HTTPHook set verify True by default

2019-03-25 Thread GitBox
OmerJog commented on issue #4855: [AIRFLOW-2421] - HTTPHook set verify True by default URL: https://github.com/apache/airflow/pull/4855#issuecomment-476262309 @Fokko Done This is an automated message from the Apache Git

[GitHub] [airflow] zhongjiajie commented on issue #4966: [AIRFLOW-4062] Improve docs on install extra package commands

2019-03-25 Thread GitBox
zhongjiajie commented on issue #4966: [AIRFLOW-4062] Improve docs on install extra package commands URL: https://github.com/apache/airflow/pull/4966#issuecomment-476259643 I got it, thanks @ashb This is an automated

[jira] [Commented] (AIRFLOW-1582) Improve logging structure of Airflow

2019-03-25 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-1582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16800820#comment-16800820 ] ASF subversion and git services commented on AIRFLOW-1582: -- Commit

[GitHub] [airflow] feluelle commented on issue #4972: [AIRFLOW-4154] Correct string formatting in jobs.py

2019-03-25 Thread GitBox
feluelle commented on issue #4972: [AIRFLOW-4154] Correct string formatting in jobs.py URL: https://github.com/apache/airflow/pull/4972#issuecomment-476250764 LGTM This is an automated message from the Apache Git Service. To

[jira] [Updated] (AIRFLOW-4154) Correct string formatting in jobs.py

2019-03-25 Thread Xiaodong DENG (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4154?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xiaodong DENG updated AIRFLOW-4154: --- Description: There are improper string formatting, like   * _*["{}".format(x) for x in

[jira] [Updated] (AIRFLOW-4154) Correct string formatting in jobs.py

2019-03-25 Thread Xiaodong DENG (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4154?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xiaodong DENG updated AIRFLOW-4154: --- Description: There are improper string formatting, like   - ["{}".format(x) for x in

[jira] [Updated] (AIRFLOW-4154) Correct string formatting in jobs.py

2019-03-25 Thread Xiaodong DENG (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4154?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xiaodong DENG updated AIRFLOW-4154: --- Description: There are improper string formatting, like   -  ["{}".format(x) for x in

[jira] [Commented] (AIRFLOW-4154) Correct string formatting in jobs.py

2019-03-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16800801#comment-16800801 ] ASF GitHub Bot commented on AIRFLOW-4154: - XD-DENG commented on pull request #4972:

[GitHub] [airflow] XD-DENG opened a new pull request #4972: [AIRFLOW-4154] Correct string formatting in jobs.py

2019-03-25 Thread GitBox
XD-DENG opened a new pull request #4972: [AIRFLOW-4154] Correct string formatting in jobs.py URL: https://github.com/apache/airflow/pull/4972 ### Jira - https://issues.apache.org/jira/browse/AIRFLOW-4154 ### Description Fix improper string formatting, like -

[jira] [Created] (AIRFLOW-4154) Correct string formatting in jobs.py

2019-03-25 Thread Xiaodong DENG (JIRA)
Xiaodong DENG created AIRFLOW-4154: -- Summary: Correct string formatting in jobs.py Key: AIRFLOW-4154 URL: https://issues.apache.org/jira/browse/AIRFLOW-4154 Project: Apache Airflow Issue

[GitHub] [airflow] potiuk commented on issue #4938: [AIRFLOW-4117] Multi-staging Image - Travis CI tests [Step 3/3]

2019-03-25 Thread GitBox
potiuk commented on issue #4938: [AIRFLOW-4117] Multi-staging Image - Travis CI tests [Step 3/3] URL: https://github.com/apache/airflow/pull/4938#issuecomment-476246297 @ashb -> thanks for the thorough review. I will apply all the comments shortly

[GitHub] [airflow] potiuk commented on a change in pull request #4938: [AIRFLOW-4117] Multi-staging Image - Travis CI tests [Step 3/3]

2019-03-25 Thread GitBox
potiuk commented on a change in pull request #4938: [AIRFLOW-4117] Multi-staging Image - Travis CI tests [Step 3/3] URL: https://github.com/apache/airflow/pull/4938#discussion_r268697984 ## File path: setup.py ## @@ -294,6 +308,7 @@ def do_setup():

[GitHub] [airflow] potiuk commented on a change in pull request #4938: [AIRFLOW-4117] Multi-staging Image - Travis CI tests [Step 3/3]

2019-03-25 Thread GitBox
potiuk commented on a change in pull request #4938: [AIRFLOW-4117] Multi-staging Image - Travis CI tests [Step 3/3] URL: https://github.com/apache/airflow/pull/4938#discussion_r268697368 ## File path: setup.py ## @@ -153,6 +166,7 @@ def

[GitHub] [airflow] potiuk commented on a change in pull request #4938: [AIRFLOW-4117] Multi-staging Image - Travis CI tests [Step 3/3]

2019-03-25 Thread GitBox
potiuk commented on a change in pull request #4938: [AIRFLOW-4117] Multi-staging Image - Travis CI tests [Step 3/3] URL: https://github.com/apache/airflow/pull/4938#discussion_r268696917 ## File path: setup.py ## @@ -69,7 +71,18 @@ def finalize_options(self):

[GitHub] [airflow] potiuk commented on a change in pull request #4938: [AIRFLOW-4117] Multi-staging Image - Travis CI tests [Step 3/3]

2019-03-25 Thread GitBox
potiuk commented on a change in pull request #4938: [AIRFLOW-4117] Multi-staging Image - Travis CI tests [Step 3/3] URL: https://github.com/apache/airflow/pull/4938#discussion_r268696718 ## File path: setup.py ## @@ -35,31 +34,34 @@ PY3 = sys.version_info[0] == 3

[GitHub] [airflow] potiuk commented on a change in pull request #4938: [AIRFLOW-4117] Multi-staging Image - Travis CI tests [Step 3/3]

2019-03-25 Thread GitBox
potiuk commented on a change in pull request #4938: [AIRFLOW-4117] Multi-staging Image - Travis CI tests [Step 3/3] URL: https://github.com/apache/airflow/pull/4938#discussion_r268696114 ## File path: scripts/ci/in_container/run_ci_tests.sh ## @@ -0,0 +1,128 @@

[GitHub] [airflow] potiuk commented on a change in pull request #4938: [AIRFLOW-4117] Multi-staging Image - Travis CI tests [Step 3/3]

2019-03-25 Thread GitBox
potiuk commented on a change in pull request #4938: [AIRFLOW-4117] Multi-staging Image - Travis CI tests [Step 3/3] URL: https://github.com/apache/airflow/pull/4938#discussion_r268695621 ## File path: scripts/ci/in_container/run_ci.sh ## @@ -0,0 +1,127 @@ +#!/usr/bin/env

[GitHub] [airflow] potiuk commented on a change in pull request #4938: [AIRFLOW-4117] Multi-staging Image - Travis CI tests [Step 3/3]

2019-03-25 Thread GitBox
potiuk commented on a change in pull request #4938: [AIRFLOW-4117] Multi-staging Image - Travis CI tests [Step 3/3] URL: https://github.com/apache/airflow/pull/4938#discussion_r268695344 ## File path: scripts/ci/in_container/run_ci.sh ## @@ -0,0 +1,127 @@ +#!/usr/bin/env

[GitHub] [airflow] ashb commented on issue #4966: [AIRFLOW-4062] Improve docs on install extra package commands

2019-03-25 Thread GitBox
ashb commented on issue #4966: [AIRFLOW-4062] Improve docs on install extra package commands URL: https://github.com/apache/airflow/pull/4966#issuecomment-476243906 The commiter usually marks the Jira ticket as resolved, but we forget sometimes. If we don't, yes you can mark your own

[GitHub] [airflow] XD-DENG commented on issue #4919: [AIRFLOW-4093] Throw exception if job failed or cancelled or retry too many times

2019-03-25 Thread GitBox
XD-DENG commented on issue #4919: [AIRFLOW-4093] Throw exception if job failed or cancelled or retry too many times URL: https://github.com/apache/airflow/pull/4919#issuecomment-476243247 @bryanyang0528 You're welcome ;-) Thanks for your contribution as well.

[GitHub] [airflow] potiuk commented on a change in pull request #4938: [AIRFLOW-4117] Multi-staging Image - Travis CI tests [Step 3/3]

2019-03-25 Thread GitBox
potiuk commented on a change in pull request #4938: [AIRFLOW-4117] Multi-staging Image - Travis CI tests [Step 3/3] URL: https://github.com/apache/airflow/pull/4938#discussion_r268693677 ## File path: scripts/ci/in_container/run_ci.sh ## @@ -0,0 +1,127 @@ +#!/usr/bin/env

[GitHub] [airflow] zhongjiajie commented on issue #4966: [AIRFLOW-4062] Improve docs on install extra package commands

2019-03-25 Thread GitBox
zhongjiajie commented on issue #4966: [AIRFLOW-4062] Improve docs on install extra package commands URL: https://github.com/apache/airflow/pull/4966#issuecomment-476242244 @ashb I found out you make jira ticket status "RESOLVED", It nessary for me to change jira ticket when PR was merge?

[jira] [Updated] (AIRFLOW-3929) Modal buttons should be links

2019-03-25 Thread Ash Berlin-Taylor (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3929?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ash Berlin-Taylor updated AIRFLOW-3929: --- Fix Version/s: (was: 1.10.3) > Modal buttons should be links >

[GitHub] [airflow] ashb commented on a change in pull request #4830: [AIRFLOW-3929] Use anchor tag for dag filter link.

2019-03-25 Thread GitBox
ashb commented on a change in pull request #4830: [AIRFLOW-3929] Use anchor tag for dag filter link. URL: https://github.com/apache/airflow/pull/4830#discussion_r268690649 ## File path: airflow/www/templates/airflow/dag.html ## @@ -125,12 +125,12 @@

[GitHub] [airflow] ashb commented on a change in pull request #4936: [AIRFLOW-4115] Multi-staging Aiflow Docker image [Step 1/3]

2019-03-25 Thread GitBox
ashb commented on a change in pull request #4936: [AIRFLOW-4115] Multi-staging Aiflow Docker image [Step 1/3] URL: https://github.com/apache/airflow/pull/4936#discussion_r268684148 ## File path: .dockerignore ## @@ -0,0 +1,107 @@ +# +# Licensed to the Apache Software

  1   2   3   >