[GitHub] [airflow] adankro commented on issue #6111: [AIRFLOW-5487]Fix unused warning var

2019-09-15 Thread GitBox
adankro commented on issue #6111: [AIRFLOW-5487]Fix unused warning var URL: https://github.com/apache/airflow/pull/6111#issuecomment-531601991 @jghoman This is an automated message from the Apache Git Service. To respond to t

[jira] [Commented] (AIRFLOW-5487) airflow/utils/strings.py: Fix unused warning variable

2019-09-15 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16930119#comment-16930119 ] ASF GitHub Bot commented on AIRFLOW-5487: - adankro commented on pull request #6

[GitHub] [airflow] jghoman merged pull request #6110: [AIRFLOW-5496] Delete unneeded variable assignment

2019-09-15 Thread GitBox
jghoman merged pull request #6110: [AIRFLOW-5496] Delete unneeded variable assignment URL: https://github.com/apache/airflow/pull/6110 This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] [airflow] jghoman commented on issue #6110: [AIRFLOW-5496] Delete unneeded variable assignment

2019-09-15 Thread GitBox
jghoman commented on issue #6110: [AIRFLOW-5496] Delete unneeded variable assignment URL: https://github.com/apache/airflow/pull/6110#issuecomment-531602023 +1. Looks great. Thanks for the contribution, Daniela! Welcome to Airflow.

[jira] [Commented] (AIRFLOW-5496) hive_stats_operator: Unneeded variable assignment

2019-09-15 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16930122#comment-16930122 ] ASF subversion and git services commented on AIRFLOW-5496: -- Co

[jira] [Commented] (AIRFLOW-5496) hive_stats_operator: Unneeded variable assignment

2019-09-15 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16930121#comment-16930121 ] ASF GitHub Bot commented on AIRFLOW-5496: - jghoman commented on pull request #6

[GitHub] [airflow] jghoman commented on issue #6111: [AIRFLOW-5487]Fix unused warning var

2019-09-15 Thread GitBox
jghoman commented on issue #6111: [AIRFLOW-5487]Fix unused warning var URL: https://github.com/apache/airflow/pull/6111#issuecomment-531602140 +1. Looks great. Thanks, Adan! This is an automated message from the Apache Git Se

[GitHub] [airflow] mik-laj commented on a change in pull request #6109: [AIRFLOW-5490] Fix incorrect None comparison

2019-09-15 Thread GitBox
mik-laj commented on a change in pull request #6109: [AIRFLOW-5490] Fix incorrect None comparison URL: https://github.com/apache/airflow/pull/6109#discussion_r324482337 ## File path: airflow/www/security.py ## @@ -340,8 +340,8 @@ def clean_perms(self): pvms = (

[GitHub] [airflow] aijamalnk merged pull request #6111: [AIRFLOW-5487]Fix unused warning var

2019-09-15 Thread GitBox
aijamalnk merged pull request #6111: [AIRFLOW-5487]Fix unused warning var URL: https://github.com/apache/airflow/pull/6111 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[jira] [Commented] (AIRFLOW-5487) airflow/utils/strings.py: Fix unused warning variable

2019-09-15 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16930123#comment-16930123 ] ASF GitHub Bot commented on AIRFLOW-5487: - aijamalnk commented on pull request

[jira] [Commented] (AIRFLOW-5484) PigCliHook has incorrect named parameter

2019-09-15 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16930127#comment-16930127 ] ASF GitHub Bot commented on AIRFLOW-5484: - yorologo commented on pull request #

[GitHub] [airflow] yorologo opened a new pull request #6112: AIRFLOW-5484: fix PigCliHook incorrectly named parameter

2019-09-15 Thread GitBox
yorologo opened a new pull request #6112: AIRFLOW-5484: fix PigCliHook incorrectly named parameter URL: https://github.com/apache/airflow/pull/6112 Make sure you have checked _all_ steps below. ### Jira - [x] My PR addresses the following [Airflow Jira](https://issues.apache.

[jira] [Commented] (AIRFLOW-5487) airflow/utils/strings.py: Fix unused warning variable

2019-09-15 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16930125#comment-16930125 ] ASF subversion and git services commented on AIRFLOW-5487: -- Co

[GitHub] [airflow] yorologo commented on issue #6112: AIRFLOW-5484: fix PigCliHook incorrectly named parameter

2019-09-15 Thread GitBox
yorologo commented on issue #6112: AIRFLOW-5484: fix PigCliHook incorrectly named parameter URL: https://github.com/apache/airflow/pull/6112#issuecomment-531602674 @jghoman Thanks for this experience This is an automated mess

[GitHub] [airflow] soldraghz opened a new pull request #6113: [AIRFLOW-5493]: fix cli.py unnecessary paren wrapping of scala variable

2019-09-15 Thread GitBox
soldraghz opened a new pull request #6113: [AIRFLOW-5493]: fix cli.py unnecessary paren wrapping of scala variable URL: https://github.com/apache/airflow/pull/6113 Make sure you have checked _all_ steps below. ### Jira - [ ] My PR addresses the following [Airflow Jira](https:

[jira] [Commented] (AIRFLOW-5493) cli.py has unnecessary paren wrapping of scala variable

2019-09-15 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16930130#comment-16930130 ] ASF GitHub Bot commented on AIRFLOW-5493: - soldraghz commented on pull request

[GitHub] [airflow] soldraghz commented on issue #6113: [AIRFLOW-5493]: fix cli.py unnecessary paren wrapping of scala variable

2019-09-15 Thread GitBox
soldraghz commented on issue #6113: [AIRFLOW-5493]: fix cli.py unnecessary paren wrapping of scala variable URL: https://github.com/apache/airflow/pull/6113#issuecomment-531602900 @jghoman hey can you review this? thanks This

[GitHub] [airflow] FernandoMon opened a new pull request #6114: [AIRFLOW-5488]Remove unused variables from tmp_configuration_copy method

2019-09-15 Thread GitBox
FernandoMon opened a new pull request #6114: [AIRFLOW-5488]Remove unused variables from tmp_configuration_copy method URL: https://github.com/apache/airflow/pull/6114 Make sure you have checked _all_ steps below. ### Jira - [ ] My PR addresses the following [Airflow Jira](htt

[jira] [Commented] (AIRFLOW-5488) Remove unused variables from tmp_configuration_copy method

2019-09-15 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16930131#comment-16930131 ] ASF GitHub Bot commented on AIRFLOW-5488: - FernandoMon commented on pull reques

[GitHub] [airflow] jghoman merged pull request #6112: AIRFLOW-5484: fix PigCliHook incorrectly named parameter

2019-09-15 Thread GitBox
jghoman merged pull request #6112: AIRFLOW-5484: fix PigCliHook incorrectly named parameter URL: https://github.com/apache/airflow/pull/6112 This is an automated message from the Apache Git Service. To respond to the message

[GitHub] [airflow] jghoman commented on issue #6112: AIRFLOW-5484: fix PigCliHook incorrectly named parameter

2019-09-15 Thread GitBox
jghoman commented on issue #6112: AIRFLOW-5484: fix PigCliHook incorrectly named parameter URL: https://github.com/apache/airflow/pull/6112#issuecomment-531603141 +1. Looks great, Josue! Thanks for the contribution, welcome to Airflow! -

[jira] [Commented] (AIRFLOW-5484) PigCliHook has incorrect named parameter

2019-09-15 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16930132#comment-16930132 ] ASF GitHub Bot commented on AIRFLOW-5484: - jghoman commented on pull request #6

[jira] [Commented] (AIRFLOW-5484) PigCliHook has incorrect named parameter

2019-09-15 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16930133#comment-16930133 ] ASF subversion and git services commented on AIRFLOW-5484: -- Co

[GitHub] [airflow] FernandoMon commented on issue #6114: [AIRFLOW-5488]Remove unused variables from tmp_configuration_copy method

2019-09-15 Thread GitBox
FernandoMon commented on issue #6114: [AIRFLOW-5488]Remove unused variables from tmp_configuration_copy method URL: https://github.com/apache/airflow/pull/6114#issuecomment-531603239 @jghoman This is an automated message from

[GitHub] [airflow] jghoman merged pull request #6114: [AIRFLOW-5488]Remove unused variables from tmp_configuration_copy method

2019-09-15 Thread GitBox
jghoman merged pull request #6114: [AIRFLOW-5488]Remove unused variables from tmp_configuration_copy method URL: https://github.com/apache/airflow/pull/6114 This is an automated message from the Apache Git Service. To respon

[GitHub] [airflow] jghoman commented on issue #6114: [AIRFLOW-5488]Remove unused variables from tmp_configuration_copy method

2019-09-15 Thread GitBox
jghoman commented on issue #6114: [AIRFLOW-5488]Remove unused variables from tmp_configuration_copy method URL: https://github.com/apache/airflow/pull/6114#issuecomment-531603270 +1. Looks great, Fernando! Thanks for the contribution and welcome to Airflow! --

[jira] [Commented] (AIRFLOW-5488) Remove unused variables from tmp_configuration_copy method

2019-09-15 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16930134#comment-16930134 ] ASF GitHub Bot commented on AIRFLOW-5488: - jghoman commented on pull request #6

[jira] [Commented] (AIRFLOW-5488) Remove unused variables from tmp_configuration_copy method

2019-09-15 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16930135#comment-16930135 ] ASF subversion and git services commented on AIRFLOW-5488: -- Co

[GitHub] [airflow] dstandish commented on a change in pull request #6104: [AIRFLOW-4574] allow providing private_key in SSHHook

2019-09-15 Thread GitBox
dstandish commented on a change in pull request #6104: [AIRFLOW-4574] allow providing private_key in SSHHook URL: https://github.com/apache/airflow/pull/6104#discussion_r324483395 ## File path: airflow/contrib/hooks/ssh_hook.py ## @@ -160,24 +169,27 @@ def get_conn(self):

[GitHub] [airflow] jghoman merged pull request #6113: [AIRFLOW-5493]: fix cli.py unnecessary paren wrapping of scala variable

2019-09-15 Thread GitBox
jghoman merged pull request #6113: [AIRFLOW-5493]: fix cli.py unnecessary paren wrapping of scala variable URL: https://github.com/apache/airflow/pull/6113 This is an automated message from the Apache Git Service. To respond

[GitHub] [airflow] jghoman commented on issue #6113: [AIRFLOW-5493]: fix cli.py unnecessary paren wrapping of scala variable

2019-09-15 Thread GitBox
jghoman commented on issue #6113: [AIRFLOW-5493]: fix cli.py unnecessary paren wrapping of scala variable URL: https://github.com/apache/airflow/pull/6113#issuecomment-531603686 +1. Looks good, Manuel! Thanks for the contribution and welcome to Airflow. ---

[jira] [Commented] (AIRFLOW-5493) cli.py has unnecessary paren wrapping of scala variable

2019-09-15 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16930137#comment-16930137 ] ASF subversion and git services commented on AIRFLOW-5493: -- Co

[jira] [Commented] (AIRFLOW-5493) cli.py has unnecessary paren wrapping of scala variable

2019-09-15 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16930136#comment-16930136 ] ASF GitHub Bot commented on AIRFLOW-5493: - jghoman commented on pull request #6

[GitHub] [airflow] mik-laj merged pull request #6087: [AIRFLOW-XXX][depends on #6086] Display AWS integrations in table

2019-09-15 Thread GitBox
mik-laj merged pull request #6087: [AIRFLOW-XXX][depends on #6086] Display AWS integrations in table URL: https://github.com/apache/airflow/pull/6087 This is an automated message from the Apache Git Service. To respond to th

[jira] [Commented] (AIRFLOW-5479) Normalize get_conn method in GCP Kubernetes hook

2019-09-15 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16930146#comment-16930146 ] ASF subversion and git services commented on AIRFLOW-5479: -- Co

[jira] [Commented] (AIRFLOW-5476) Typo in BREEZE.rst

2019-09-15 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16930143#comment-16930143 ] ASF subversion and git services commented on AIRFLOW-5476: -- Co

[jira] [Commented] (AIRFLOW-5471) Fix docstring in GcpTransferServiceOperationsListOperator

2019-09-15 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16930145#comment-16930145 ] ASF subversion and git services commented on AIRFLOW-5471: -- Co

[jira] [Commented] (AIRFLOW-5480) Fix flaky impersonation test

2019-09-15 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16930144#comment-16930144 ] ASF subversion and git services commented on AIRFLOW-5480: -- Co

[jira] [Commented] (AIRFLOW-5482) Deprecate Schedule Interval on task level

2019-09-15 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16930147#comment-16930147 ] ASF subversion and git services commented on AIRFLOW-5482: -- Co

[jira] [Commented] (AIRFLOW-5465) Fix deprecated imports in examples

2019-09-15 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16930141#comment-16930141 ] ASF subversion and git services commented on AIRFLOW-5465: -- Co

[jira] [Commented] (AIRFLOW-5464) Fix GCP Memorystore example DAG

2019-09-15 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16930142#comment-16930142 ] ASF subversion and git services commented on AIRFLOW-5464: -- Co

[jira] [Commented] (AIRFLOW-5150) Implement POC of GitLab CI + GKE integration

2019-09-15 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16930149#comment-16930149 ] ASF subversion and git services commented on AIRFLOW-5150: -- Co

[jira] [Commented] (AIRFLOW-5482) Deprecate Schedule Interval on task level

2019-09-15 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16930148#comment-16930148 ] ASF subversion and git services commented on AIRFLOW-5482: -- Co

[jira] [Commented] (AIRFLOW-5492) Missing docstring for hive .py

2019-09-15 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16930152#comment-16930152 ] ASF subversion and git services commented on AIRFLOW-5492: -- Co

[jira] [Commented] (AIRFLOW-5490) security.py: Fix incorrect None comparison

2019-09-15 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16930150#comment-16930150 ] ASF subversion and git services commented on AIRFLOW-5490: -- Co

[jira] [Commented] (AIRFLOW-5150) Implement POC of GitLab CI + GKE integration

2019-09-15 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16930158#comment-16930158 ] ASF subversion and git services commented on AIRFLOW-5150: -- Co

[jira] [Commented] (AIRFLOW-5484) PigCliHook has incorrect named parameter

2019-09-15 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16930155#comment-16930155 ] ASF subversion and git services commented on AIRFLOW-5484: -- Co

[jira] [Commented] (AIRFLOW-5487) airflow/utils/strings.py: Fix unused warning variable

2019-09-15 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16930154#comment-16930154 ] ASF subversion and git services commented on AIRFLOW-5487: -- Co

[jira] [Commented] (AIRFLOW-5488) Remove unused variables from tmp_configuration_copy method

2019-09-15 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16930156#comment-16930156 ] ASF subversion and git services commented on AIRFLOW-5488: -- Co

[jira] [Commented] (AIRFLOW-5489) bash_senor: Remove unneeded assignment of variable

2019-09-15 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16930151#comment-16930151 ] ASF subversion and git services commented on AIRFLOW-5489: -- Co

[jira] [Commented] (AIRFLOW-5493) cli.py has unnecessary paren wrapping of scala variable

2019-09-15 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16930157#comment-16930157 ] ASF subversion and git services commented on AIRFLOW-5493: -- Co

[jira] [Commented] (AIRFLOW-5496) hive_stats_operator: Unneeded variable assignment

2019-09-15 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16930153#comment-16930153 ] ASF subversion and git services commented on AIRFLOW-5496: -- Co

[jira] [Resolved] (AIRFLOW-5476) Typo in BREEZE.rst

2019-09-15 Thread Lee Dongjin (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5476?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lee Dongjin resolved AIRFLOW-5476. -- Resolution: Fixed > Typo in BREEZE.rst > -- > > Key: AIRFLOW-

[GitHub] [airflow] potiuk opened a new pull request #6115: [AIRFLOW-5150] Implement POC for GitLab + Kubernetes tests

2019-09-15 Thread GitBox
potiuk opened a new pull request #6115: [AIRFLOW-5150] Implement POC for GitLab + Kubernetes tests URL: https://github.com/apache/airflow/pull/6115 Make sure you have checked _all_ steps below. ### Jira - [ ] My PR addresses the following [Airflow Jira](https://issues.apache.

[jira] [Commented] (AIRFLOW-5150) Implement POC of GitLab CI + GKE integration

2019-09-15 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16930163#comment-16930163 ] ASF GitHub Bot commented on AIRFLOW-5150: - potiuk commented on pull request #61

[GitHub] [airflow] potiuk commented on a change in pull request #5837: [AIRFLOW-5223] Use KinD for Kubernetes in CI

2019-09-15 Thread GitBox
potiuk commented on a change in pull request #5837: [AIRFLOW-5223] Use KinD for Kubernetes in CI URL: https://github.com/apache/airflow/pull/5837#discussion_r324486045 ## File path: scripts/ci/kubernetes/docker/build.sh ## @@ -20,29 +20,14 @@ IMAGE=${IMAGE:-airflow} TAG=$

[GitHub] [airflow] potiuk commented on a change in pull request #5837: [AIRFLOW-5223] Use KinD for Kubernetes in CI

2019-09-15 Thread GitBox
potiuk commented on a change in pull request #5837: [AIRFLOW-5223] Use KinD for Kubernetes in CI URL: https://github.com/apache/airflow/pull/5837#discussion_r324486249 ## File path: Dockerfile ## @@ -372,4 +397,6 @@ EXPOSE 8080 ENTRYPOINT ["/usr/local/bin/dumb-init", "-

[GitHub] [airflow] potiuk commented on a change in pull request #5837: [AIRFLOW-5223] Use KinD for Kubernetes in CI

2019-09-15 Thread GitBox
potiuk commented on a change in pull request #5837: [AIRFLOW-5223] Use KinD for Kubernetes in CI URL: https://github.com/apache/airflow/pull/5837#discussion_r324486346 ## File path: Dockerfile ## @@ -85,6 +92,24 @@ RUN curl -sL https://deb.nodesource.com/setup_10.x | bash

[GitHub] [airflow] potiuk commented on a change in pull request #5837: [AIRFLOW-5223] Use KinD for Kubernetes in CI

2019-09-15 Thread GitBox
potiuk commented on a change in pull request #5837: [AIRFLOW-5223] Use KinD for Kubernetes in CI URL: https://github.com/apache/airflow/pull/5837#discussion_r324486402 ## File path: scripts/ci/pylint_todo.txt ## @@ -462,8 +462,8 @@ ./tests/lineage/backend/test_atlas.py .

[GitHub] [airflow] potiuk commented on a change in pull request #5837: [AIRFLOW-5223] Use KinD for Kubernetes in CI

2019-09-15 Thread GitBox
potiuk commented on a change in pull request #5837: [AIRFLOW-5223] Use KinD for Kubernetes in CI URL: https://github.com/apache/airflow/pull/5837#discussion_r324486431 ## File path: scripts/ci/local_ci_stop_environment.sh ## @@ -45,7 +45,6 @@ export HOST_GROUP_ID docker

[GitHub] [airflow] potiuk commented on issue #5837: [AIRFLOW-5223] Use KinD for Kubernetes in CI

2019-09-15 Thread GitBox
potiuk commented on issue #5837: [AIRFLOW-5223] Use KinD for Kubernetes in CI URL: https://github.com/apache/airflow/pull/5837#issuecomment-531608665 Hey @gerardo -> I think maybe you can take a look at running the dind image separately. It would be simplification and it will make the airfl

[jira] [Commented] (AIRFLOW-5150) Implement POC of GitLab CI + GKE integration

2019-09-15 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16930167#comment-16930167 ] ASF subversion and git services commented on AIRFLOW-5150: -- Co

[jira] [Commented] (AIRFLOW-5150) Implement POC of GitLab CI + GKE integration

2019-09-15 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16930168#comment-16930168 ] ASF subversion and git services commented on AIRFLOW-5150: -- Co

[GitHub] [airflow] potiuk commented on issue #5976: [AIRFLOW-5369] Add interactivity to pre-commits

2019-09-15 Thread GitBox
potiuk commented on issue #5976: [AIRFLOW-5369] Add interactivity to pre-commits URL: https://github.com/apache/airflow/pull/5976#issuecomment-531610072 Hey @dimberman :)? This is an automated message from the Apache Git Serv

[jira] [Commented] (AIRFLOW-5150) Implement POC of GitLab CI + GKE integration

2019-09-15 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16930170#comment-16930170 ] ASF subversion and git services commented on AIRFLOW-5150: -- Co

[GitHub] [airflow] potiuk commented on a change in pull request #5786: [AIRFLOW-5170] [AIRFLOW-5256] Consistent licences for python files and related pylint fixes

2019-09-15 Thread GitBox
potiuk commented on a change in pull request #5786: [AIRFLOW-5170] [AIRFLOW-5256] Consistent licences for python files and related pylint fixes URL: https://github.com/apache/airflow/pull/5786#discussion_r324488944 ## File path: airflow/kubernetes/volume.py ## @@ -25,20 +

[GitHub] [airflow] potiuk commented on a change in pull request #5786: [AIRFLOW-5170] [AIRFLOW-5256] Consistent licences for python files and related pylint fixes

2019-09-15 Thread GitBox
potiuk commented on a change in pull request #5786: [AIRFLOW-5170] [AIRFLOW-5256] Consistent licences for python files and related pylint fixes URL: https://github.com/apache/airflow/pull/5786#discussion_r324488969 ## File path: airflow/kubernetes/volume.py ## @@ -25,20 +

[GitHub] [airflow] potiuk commented on issue #5786: [AIRFLOW-5170] [AIRFLOW-5256] Consistent licences for python files and related pylint fixes

2019-09-15 Thread GitBox
potiuk commented on issue #5786: [AIRFLOW-5170] [AIRFLOW-5256] Consistent licences for python files and related pylint fixes URL: https://github.com/apache/airflow/pull/5786#issuecomment-531613726 @feluelle -> I think it will be green soon:) ---

[jira] [Commented] (AIRFLOW-5150) Implement POC of GitLab CI + GKE integration

2019-09-15 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16930174#comment-16930174 ] ASF subversion and git services commented on AIRFLOW-5150: -- Co

[jira] [Commented] (AIRFLOW-5150) Implement POC of GitLab CI + GKE integration

2019-09-15 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16930177#comment-16930177 ] ASF subversion and git services commented on AIRFLOW-5150: -- Co

[GitHub] [airflow] jasonlin2268 opened a new pull request #6116: Merge pull request #1 from apache/master

2019-09-15 Thread GitBox
jasonlin2268 opened a new pull request #6116: Merge pull request #1 from apache/master URL: https://github.com/apache/airflow/pull/6116 fix Make sure you have checked _all_ steps below. ### Jira - [ ] My PR addresses the following [Airflow Jira](https://issues.apache.o

[jira] [Comment Edited] (AIRFLOW-5447) KubernetesExecutor hangs on task queueing

2019-09-15 Thread Daniel Imberman (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16930224#comment-16930224 ] Daniel Imberman edited comment on AIRFLOW-5447 at 9/16/19 4:21 AM: --

[jira] [Commented] (AIRFLOW-5447) KubernetesExecutor hangs on task queueing

2019-09-15 Thread Daniel Imberman (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16930224#comment-16930224 ] Daniel Imberman commented on AIRFLOW-5447: -- [~Yuval.Itzchakov] [~cwegrzyn]Than

[GitHub] [airflow] dstandish commented on a change in pull request #6104: [AIRFLOW-4574] allow providing private_key in SSHHook

2019-09-15 Thread GitBox
dstandish commented on a change in pull request #6104: [AIRFLOW-4574] allow providing private_key in SSHHook URL: https://github.com/apache/airflow/pull/6104#discussion_r324483395 ## File path: airflow/contrib/hooks/ssh_hook.py ## @@ -160,24 +169,27 @@ def get_conn(self):

[GitHub] [airflow] dstandish commented on a change in pull request #6104: [AIRFLOW-4574] allow providing private_key in SSHHook

2019-09-15 Thread GitBox
dstandish commented on a change in pull request #6104: [AIRFLOW-4574] allow providing private_key in SSHHook URL: https://github.com/apache/airflow/pull/6104#discussion_r324483395 ## File path: airflow/contrib/hooks/ssh_hook.py ## @@ -160,24 +169,27 @@ def get_conn(self):

<    1   2