[GitHub] [airflow] potiuk commented on a change in pull request #6266: [AIRFLOW-2439] Production Docker image support including refactoring of build scripts - depends on [AIRFLOW-5704]

2019-10-21 Thread GitBox
potiuk commented on a change in pull request #6266: [AIRFLOW-2439] Production Docker image support including refactoring of build scripts - depends on [AIRFLOW-5704] URL: https://github.com/apache/airflow/pull/6266#discussion_r33707 ## File path: setup.py ## @@ -287,4

[GitHub] [airflow] potiuk commented on a change in pull request #6266: [AIRFLOW-2439] Production Docker image support including refactoring of build scripts - depends on [AIRFLOW-5704]

2019-10-21 Thread GitBox
potiuk commented on a change in pull request #6266: [AIRFLOW-2439] Production Docker image support including refactoring of build scripts - depends on [AIRFLOW-5704] URL: https://github.com/apache/airflow/pull/6266#discussion_r337071730 ## File path: Dockerfile ## @@ -77,

[GitHub] [airflow] potiuk commented on a change in pull request #6266: [AIRFLOW-2439] Production Docker image support including refactoring of build scripts - depends on [AIRFLOW-5704]

2019-10-21 Thread GitBox
potiuk commented on a change in pull request #6266: [AIRFLOW-2439] Production Docker image support including refactoring of build scripts - depends on [AIRFLOW-5704] URL: https://github.com/apache/airflow/pull/6266#discussion_r337071394 ## File path: Dockerfile ## @@ -334

[GitHub] [airflow] potiuk commented on a change in pull request #6266: [AIRFLOW-2439] Production Docker image support including refactoring of build scripts - depends on [AIRFLOW-5704]

2019-10-21 Thread GitBox
potiuk commented on a change in pull request #6266: [AIRFLOW-2439] Production Docker image support including refactoring of build scripts - depends on [AIRFLOW-5704] URL: https://github.com/apache/airflow/pull/6266#discussion_r337071166 ## File path: Dockerfile ## @@ -334

[GitHub] [airflow] davlum commented on issue #6375: [AIRFLOW-5706] Add KubernetesPodYamlOperator

2019-10-21 Thread GitBox
davlum commented on issue #6375: [AIRFLOW-5706] Add KubernetesPodYamlOperator URL: https://github.com/apache/airflow/pull/6375#issuecomment-544556561 > Do we need a separate operator for this? Might a KubeernetesPodOperator(yaml=...) work? @ashb This is possible in #6230 and was the

[GitHub] [airflow] davlum commented on a change in pull request #6230: [AIRFLOW-5413] Allow K8S worker pod to be configured from JSON/YAML file

2019-10-21 Thread GitBox
davlum commented on a change in pull request #6230: [AIRFLOW-5413] Allow K8S worker pod to be configured from JSON/YAML file URL: https://github.com/apache/airflow/pull/6230#discussion_r337068355 ## File path: airflow/kubernetes/pod_generator.py ## @@ -301,51 +352,151 @@ d

[GitHub] [airflow] potiuk commented on a change in pull request #6266: [AIRFLOW-2439] Production Docker image support including refactoring of build scripts - depends on [AIRFLOW-5704]

2019-10-21 Thread GitBox
potiuk commented on a change in pull request #6266: [AIRFLOW-2439] Production Docker image support including refactoring of build scripts - depends on [AIRFLOW-5704] URL: https://github.com/apache/airflow/pull/6266#discussion_r337067401 ## File path: Dockerfile ## @@ -77,

[GitHub] [airflow] potiuk commented on a change in pull request #6266: [AIRFLOW-2439] Production Docker image support including refactoring of build scripts - depends on [AIRFLOW-5704]

2019-10-21 Thread GitBox
potiuk commented on a change in pull request #6266: [AIRFLOW-2439] Production Docker image support including refactoring of build scripts - depends on [AIRFLOW-5704] URL: https://github.com/apache/airflow/pull/6266#discussion_r337065995 ## File path: Dockerfile ## @@ -77,

[GitHub] [airflow] potiuk commented on a change in pull request #6266: [AIRFLOW-2439] Production Docker image support including refactoring of build scripts - depends on [AIRFLOW-5704]

2019-10-21 Thread GitBox
potiuk commented on a change in pull request #6266: [AIRFLOW-2439] Production Docker image support including refactoring of build scripts - depends on [AIRFLOW-5704] URL: https://github.com/apache/airflow/pull/6266#discussion_r337065283 ## File path: Dockerfile ## @@ -77,

[GitHub] [airflow] potiuk commented on a change in pull request #6266: [AIRFLOW-2439] Production Docker image support including refactoring of build scripts - depends on [AIRFLOW-5704]

2019-10-21 Thread GitBox
potiuk commented on a change in pull request #6266: [AIRFLOW-2439] Production Docker image support including refactoring of build scripts - depends on [AIRFLOW-5704] URL: https://github.com/apache/airflow/pull/6266#discussion_r337057640 ## File path: BREEZE.rst ## @@ -912

[GitHub] [airflow] potiuk commented on a change in pull request #6266: [AIRFLOW-2439] Production Docker image support including refactoring of build scripts - depends on [AIRFLOW-5704]

2019-10-21 Thread GitBox
potiuk commented on a change in pull request #6266: [AIRFLOW-2439] Production Docker image support including refactoring of build scripts - depends on [AIRFLOW-5704] URL: https://github.com/apache/airflow/pull/6266#discussion_r337057579 ## File path: Dockerfile ## @@ -77,

[GitHub] [airflow] potiuk commented on a change in pull request #6266: [AIRFLOW-2439] Production Docker image support including refactoring of build scripts - depends on [AIRFLOW-5704]

2019-10-21 Thread GitBox
potiuk commented on a change in pull request #6266: [AIRFLOW-2439] Production Docker image support including refactoring of build scripts - depends on [AIRFLOW-5704] URL: https://github.com/apache/airflow/pull/6266#discussion_r337057683 ## File path: BREEZE.rst ## @@ -912

[GitHub] [airflow] potiuk commented on a change in pull request #6266: [AIRFLOW-2439] Production Docker image support including refactoring of build scripts - depends on [AIRFLOW-5704]

2019-10-21 Thread GitBox
potiuk commented on a change in pull request #6266: [AIRFLOW-2439] Production Docker image support including refactoring of build scripts - depends on [AIRFLOW-5704] URL: https://github.com/apache/airflow/pull/6266#discussion_r337057538 ## File path: Dockerfile ## @@ -77,

[GitHub] [airflow] mik-laj commented on a change in pull request #6375: [AIRFLOW-5706] Add KubernetesPodYamlOperator

2019-10-21 Thread GitBox
mik-laj commented on a change in pull request #6375: [AIRFLOW-5706] Add KubernetesPodYamlOperator URL: https://github.com/apache/airflow/pull/6375#discussion_r337054780 ## File path: airflow/contrib/example_dags/example_kubernetes_operator.py ## @@ -63,6 +99,24 @@

[GitHub] [airflow] codecov-io edited a comment on issue #6306: [AIRFLOW-5632] Rename ComputeEngine operators

2019-10-21 Thread GitBox
codecov-io edited a comment on issue #6306: [AIRFLOW-5632] Rename ComputeEngine operators URL: https://github.com/apache/airflow/pull/6306#issuecomment-541052532 # [Codecov](https://codecov.io/gh/apache/airflow/pull/6306?src=pr&el=h1) Report > Merging [#6306](https://codecov.io/gh/apac

[GitHub] [airflow] codecov-io edited a comment on issue #6306: [AIRFLOW-5632] Rename ComputeEngine operators

2019-10-21 Thread GitBox
codecov-io edited a comment on issue #6306: [AIRFLOW-5632] Rename ComputeEngine operators URL: https://github.com/apache/airflow/pull/6306#issuecomment-541052532 # [Codecov](https://codecov.io/gh/apache/airflow/pull/6306?src=pr&el=h1) Report > Merging [#6306](https://codecov.io/gh/apac

[GitHub] [airflow] codecov-io edited a comment on issue #6306: [AIRFLOW-5632] Rename ComputeEngine operators

2019-10-21 Thread GitBox
codecov-io edited a comment on issue #6306: [AIRFLOW-5632] Rename ComputeEngine operators URL: https://github.com/apache/airflow/pull/6306#issuecomment-541052532 # [Codecov](https://codecov.io/gh/apache/airflow/pull/6306?src=pr&el=h1) Report > Merging [#6306](https://codecov.io/gh/apac

[GitHub] [airflow] mik-laj commented on a change in pull request #6375: [AIRFLOW-5706] Add KubernetesPodYamlOperator

2019-10-21 Thread GitBox
mik-laj commented on a change in pull request #6375: [AIRFLOW-5706] Add KubernetesPodYamlOperator URL: https://github.com/apache/airflow/pull/6375#discussion_r337054780 ## File path: airflow/contrib/example_dags/example_kubernetes_operator.py ## @@ -63,6 +99,24 @@

[jira] [Commented] (AIRFLOW-3140) Add MongoDBToGoogleStorage Opearator

2019-10-21 Thread Q C (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-3140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16956156#comment-16956156 ] Q C commented on AIRFLOW-3140: -- Hi just wondering if there's any update on this one? Befor

[GitHub] [airflow] mik-laj commented on a change in pull request #6375: [AIRFLOW-5706] Add KubernetesPodYamlOperator

2019-10-21 Thread GitBox
mik-laj commented on a change in pull request #6375: [AIRFLOW-5706] Add KubernetesPodYamlOperator URL: https://github.com/apache/airflow/pull/6375#discussion_r337050245 ## File path: airflow/contrib/example_dags/example_kubernetes_operator.py ## @@ -63,6 +99,24 @@

[GitHub] [airflow] mik-laj commented on a change in pull request #6375: [AIRFLOW-5706] Add KubernetesPodYamlOperator

2019-10-21 Thread GitBox
mik-laj commented on a change in pull request #6375: [AIRFLOW-5706] Add KubernetesPodYamlOperator URL: https://github.com/apache/airflow/pull/6375#discussion_r337050245 ## File path: airflow/contrib/example_dags/example_kubernetes_operator.py ## @@ -63,6 +99,24 @@

[GitHub] [airflow] dimberman commented on a change in pull request #6377: AIRFLOW-5589 monitor pods by labels instead of names

2019-10-21 Thread GitBox
dimberman commented on a change in pull request #6377: AIRFLOW-5589 monitor pods by labels instead of names URL: https://github.com/apache/airflow/pull/6377#discussion_r337026044 ## File path: airflow/contrib/operators/kubernetes_pod_operator.py ## @@ -23,6 +25,28 @@ from

[GitHub] [airflow] dimberman commented on a change in pull request #6377: AIRFLOW-5589 monitor pods by labels instead of names

2019-10-21 Thread GitBox
dimberman commented on a change in pull request #6377: AIRFLOW-5589 monitor pods by labels instead of names URL: https://github.com/apache/airflow/pull/6377#discussion_r337026142 ## File path: airflow/contrib/operators/kubernetes_pod_operator.py ## @@ -23,6 +25,28 @@ from

[GitHub] [airflow] ashb commented on a change in pull request #6377: AIRFLOW-5589 monitor pods by labels instead of names

2019-10-21 Thread GitBox
ashb commented on a change in pull request #6377: AIRFLOW-5589 monitor pods by labels instead of names URL: https://github.com/apache/airflow/pull/6377#discussion_r337022800 ## File path: airflow/contrib/operators/kubernetes_pod_operator.py ## @@ -23,6 +25,28 @@ from airf

[GitHub] [airflow] ashb commented on a change in pull request #6377: AIRFLOW-5589 monitor pods by labels instead of names

2019-10-21 Thread GitBox
ashb commented on a change in pull request #6377: AIRFLOW-5589 monitor pods by labels instead of names URL: https://github.com/apache/airflow/pull/6377#discussion_r337022800 ## File path: airflow/contrib/operators/kubernetes_pod_operator.py ## @@ -23,6 +25,28 @@ from airf

[GitHub] [airflow] ashb commented on a change in pull request #6377: AIRFLOW-5589 monitor pods by labels instead of names

2019-10-21 Thread GitBox
ashb commented on a change in pull request #6377: AIRFLOW-5589 monitor pods by labels instead of names URL: https://github.com/apache/airflow/pull/6377#discussion_r337022202 ## File path: airflow/contrib/operators/kubernetes_pod_operator.py ## @@ -23,6 +25,28 @@ from airf

[GitHub] [airflow] ashb commented on a change in pull request #6377: AIRFLOW-5589 monitor pods by labels instead of names

2019-10-21 Thread GitBox
ashb commented on a change in pull request #6377: AIRFLOW-5589 monitor pods by labels instead of names URL: https://github.com/apache/airflow/pull/6377#discussion_r337021945 ## File path: airflow/contrib/operators/kubernetes_pod_operator.py ## @@ -23,6 +25,28 @@ from airf

[GitHub] [airflow] TobKed opened a new pull request #6378: [AIRFLOW-5707] Add type annotations to SFTPHook

2019-10-21 Thread GitBox
TobKed opened a new pull request #6378: [AIRFLOW-5707] Add type annotations to SFTPHook URL: https://github.com/apache/airflow/pull/6378 Make sure you have checked _all_ steps below. ### Jira - [ ] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/br

[jira] [Commented] (AIRFLOW-5707) Add type annotations to SFTPHook

2019-10-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16956091#comment-16956091 ] ASF GitHub Bot commented on AIRFLOW-5707: - TobKed commented on pull request #63

[GitHub] [airflow] ashb commented on issue #6266: [AIRFLOW-2439] Production Docker image support including refactoring of build scripts - depends on [AIRFLOW-5704]

2019-10-21 Thread GitBox
ashb commented on issue #6266: [AIRFLOW-2439] Production Docker image support including refactoring of build scripts - depends on [AIRFLOW-5704] URL: https://github.com/apache/airflow/pull/6266#issuecomment-544516428 > This is exactly what I can do using --copy-from as described above

[GitHub] [airflow] potiuk commented on a change in pull request #6266: [AIRFLOW-2439] Production Docker image support including refactoring of build scripts - depends on [AIRFLOW-5704]

2019-10-21 Thread GitBox
potiuk commented on a change in pull request #6266: [AIRFLOW-2439] Production Docker image support including refactoring of build scripts - depends on [AIRFLOW-5704] URL: https://github.com/apache/airflow/pull/6266#discussion_r337015240 ## File path: Dockerfile ## @@ -16,

[jira] [Created] (AIRFLOW-5707) Add type annotations to SFTPHook

2019-10-21 Thread Tobiasz Kedzierski (Jira)
Tobiasz Kedzierski created AIRFLOW-5707: --- Summary: Add type annotations to SFTPHook Key: AIRFLOW-5707 URL: https://issues.apache.org/jira/browse/AIRFLOW-5707 Project: Apache Airflow Iss

[GitHub] [airflow] potiuk commented on issue #6266: [AIRFLOW-2439] Production Docker image support including refactoring of build scripts - depends on [AIRFLOW-5704]

2019-10-21 Thread GitBox
potiuk commented on issue #6266: [AIRFLOW-2439] Production Docker image support including refactoring of build scripts - depends on [AIRFLOW-5704] URL: https://github.com/apache/airflow/pull/6266#issuecomment-544511732 > I've left some review comments (see below) but the main thing I want t

[GitHub] [airflow] potiuk commented on a change in pull request #6266: [AIRFLOW-2439] Production Docker image support including refactoring of build scripts - depends on [AIRFLOW-5704]

2019-10-21 Thread GitBox
potiuk commented on a change in pull request #6266: [AIRFLOW-2439] Production Docker image support including refactoring of build scripts - depends on [AIRFLOW-5704] URL: https://github.com/apache/airflow/pull/6266#discussion_r336992424 ## File path: .travis.yml ## @@ -32

[GitHub] [airflow] potiuk commented on a change in pull request #6266: [AIRFLOW-2439] Production Docker image support including refactoring of build scripts - depends on [AIRFLOW-5704]

2019-10-21 Thread GitBox
potiuk commented on a change in pull request #6266: [AIRFLOW-2439] Production Docker image support including refactoring of build scripts - depends on [AIRFLOW-5704] URL: https://github.com/apache/airflow/pull/6266#discussion_r336985423 ## File path: .pre-commit-config.yaml ##

[GitHub] [airflow] potiuk commented on a change in pull request #6373: [AIRFLOW-5704] Optimise KIND kubernetes setup

2019-10-21 Thread GitBox
potiuk commented on a change in pull request #6373: [AIRFLOW-5704] Optimise KIND kubernetes setup URL: https://github.com/apache/airflow/pull/6373#discussion_r336983746 ## File path: Dockerfile ## @@ -174,39 +170,8 @@ RUN if [[ "${APT_DEPS_IMAGE}" == "airflow-apt-deps-ci"

[GitHub] [airflow] potiuk commented on a change in pull request #6373: [AIRFLOW-5704] Optimise KIND kubernetes setup

2019-10-21 Thread GitBox
potiuk commented on a change in pull request #6373: [AIRFLOW-5704] Optimise KIND kubernetes setup URL: https://github.com/apache/airflow/pull/6373#discussion_r336983876 ## File path: .travis.yml ## @@ -63,8 +43,28 @@ jobs: - name: "Build documentation" stage: p

[jira] [Commented] (AIRFLOW-5589) KubernetesPodOperator: Duplicate pods created on worker restart

2019-10-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16955995#comment-16955995 ] ASF GitHub Bot commented on AIRFLOW-5589: - dimberman commented on pull request

[GitHub] [airflow] dimberman opened a new pull request #6377: AIRFLOW-5589 monitor pods by labels instead of names

2019-10-21 Thread GitBox
dimberman opened a new pull request #6377: AIRFLOW-5589 monitor pods by labels instead of names URL: https://github.com/apache/airflow/pull/6377 Make sure you have checked _all_ steps below. ### Jira - [ ] My PR addresses the following [Airflow Jira](https://issues.apache.org

[GitHub] [airflow] KKcorps commented on a change in pull request #6295: [AIRFLOW-XXX] GSoD: Adding Task re-run documentation

2019-10-21 Thread GitBox
KKcorps commented on a change in pull request #6295: [AIRFLOW-XXX] GSoD: Adding Task re-run documentation URL: https://github.com/apache/airflow/pull/6295#discussion_r336966785 ## File path: docs/index.rst ## @@ -84,6 +84,7 @@ Content concepts scheduler exec

[GitHub] [airflow] KKcorps commented on a change in pull request #6348: [AIRFLOW-XXX] GSoD: Adding 'Create a custom operator' doc

2019-10-21 Thread GitBox
KKcorps commented on a change in pull request #6348: [AIRFLOW-XXX] GSoD: Adding 'Create a custom operator' doc URL: https://github.com/apache/airflow/pull/6348#discussion_r336962212 ## File path: docs/howto/custom-operator.rst ## @@ -85,7 +94,7 @@ Let's extend our previous

[GitHub] [airflow] ashb commented on a change in pull request #5731: [AIRFLOW-5117] support refreshing EKS api tokens

2019-10-21 Thread GitBox
ashb commented on a change in pull request #5731: [AIRFLOW-5117] support refreshing EKS api tokens URL: https://github.com/apache/airflow/pull/5731#discussion_r336960921 ## File path: airflow/kubernetes/kube_client.py ## @@ -15,12 +15,48 @@ # specific language governing p

[GitHub] [airflow] ashb commented on a change in pull request #6375: [AIRFLOW-5706] Add KubernetesPodYamlOperator

2019-10-21 Thread GitBox
ashb commented on a change in pull request #6375: [AIRFLOW-5706] Add KubernetesPodYamlOperator URL: https://github.com/apache/airflow/pull/6375#discussion_r336956431 ## File path: airflow/contrib/example_dags/example_kubernetes_operator.py ## @@ -63,6 +99,24 @@

[GitHub] [airflow] ashb commented on a change in pull request #6348: [AIRFLOW-XXX] GSoD: Adding 'Create a custom operator' doc

2019-10-21 Thread GitBox
ashb commented on a change in pull request #6348: [AIRFLOW-XXX] GSoD: Adding 'Create a custom operator' doc URL: https://github.com/apache/airflow/pull/6348#discussion_r336953005 ## File path: docs/howto/custom-operator.rst ## @@ -0,0 +1,192 @@ + .. Licensed to the Apache

[GitHub] [airflow] ashb commented on a change in pull request #6348: [AIRFLOW-XXX] GSoD: Adding 'Create a custom operator' doc

2019-10-21 Thread GitBox
ashb commented on a change in pull request #6348: [AIRFLOW-XXX] GSoD: Adding 'Create a custom operator' doc URL: https://github.com/apache/airflow/pull/6348#discussion_r336952880 ## File path: docs/howto/custom-operator.rst ## @@ -0,0 +1,192 @@ + .. Licensed to the Apache

[GitHub] [airflow] ashb commented on a change in pull request #6348: [AIRFLOW-XXX] GSoD: Adding 'Create a custom operator' doc

2019-10-21 Thread GitBox
ashb commented on a change in pull request #6348: [AIRFLOW-XXX] GSoD: Adding 'Create a custom operator' doc URL: https://github.com/apache/airflow/pull/6348#discussion_r336950814 ## File path: docs/howto/custom-operator.rst ## @@ -0,0 +1,192 @@ + .. Licensed to the Apache

[GitHub] [airflow] ashb commented on a change in pull request #6348: [AIRFLOW-XXX] GSoD: Adding 'Create a custom operator' doc

2019-10-21 Thread GitBox
ashb commented on a change in pull request #6348: [AIRFLOW-XXX] GSoD: Adding 'Create a custom operator' doc URL: https://github.com/apache/airflow/pull/6348#discussion_r336950172 ## File path: docs/howto/custom-operator.rst ## @@ -85,7 +94,7 @@ Let's extend our previous ex

[GitHub] [airflow] ashb commented on a change in pull request #6348: [AIRFLOW-XXX] GSoD: Adding 'Create a custom operator' doc

2019-10-21 Thread GitBox
ashb commented on a change in pull request #6348: [AIRFLOW-XXX] GSoD: Adding 'Create a custom operator' doc URL: https://github.com/apache/airflow/pull/6348#discussion_r336950001 ## File path: docs/howto/custom-operator.rst ## @@ -60,15 +60,24 @@ You can now use the derive

[GitHub] [airflow] ashb commented on a change in pull request #6348: [AIRFLOW-XXX] GSoD: Adding 'Create a custom operator' doc

2019-10-21 Thread GitBox
ashb commented on a change in pull request #6348: [AIRFLOW-XXX] GSoD: Adding 'Create a custom operator' doc URL: https://github.com/apache/airflow/pull/6348#discussion_r336949680 ## File path: docs/howto/custom-operator.rst ## @@ -60,15 +60,24 @@ You can now use the derive

[GitHub] [airflow] codecov-io commented on issue #6366: [AIRFLOW-5696] GoogleCloudStorageToSFTPOperator

2019-10-21 Thread GitBox
codecov-io commented on issue #6366: [AIRFLOW-5696] GoogleCloudStorageToSFTPOperator URL: https://github.com/apache/airflow/pull/6366#issuecomment-544454296 # [Codecov](https://codecov.io/gh/apache/airflow/pull/6366?src=pr&el=h1) Report > Merging [#6366](https://codecov.io/gh/apache/ai

[GitHub] [airflow] codecov-io commented on issue #6371: [AIRFLOW-5691] Rewrite Dataproc operators to use python library

2019-10-21 Thread GitBox
codecov-io commented on issue #6371: [AIRFLOW-5691] Rewrite Dataproc operators to use python library URL: https://github.com/apache/airflow/pull/6371#issuecomment-54999 # [Codecov](https://codecov.io/gh/apache/airflow/pull/6371?src=pr&el=h1) Report > Merging [#6371](https://codecov

[GitHub] [airflow] ashb commented on a change in pull request #6266: [AIRFLOW-2439] Production Docker image support including refactoring of build scripts - depends on [AIRFLOW-5704]

2019-10-21 Thread GitBox
ashb commented on a change in pull request #6266: [AIRFLOW-2439] Production Docker image support including refactoring of build scripts - depends on [AIRFLOW-5704] URL: https://github.com/apache/airflow/pull/6266#discussion_r336913399 ## File path: setup.py ## @@ -287,46

[GitHub] [airflow] ashb commented on a change in pull request #6266: [AIRFLOW-2439] Production Docker image support including refactoring of build scripts - depends on [AIRFLOW-5704]

2019-10-21 Thread GitBox
ashb commented on a change in pull request #6266: [AIRFLOW-2439] Production Docker image support including refactoring of build scripts - depends on [AIRFLOW-5704] URL: https://github.com/apache/airflow/pull/6266#discussion_r336904053 ## File path: Dockerfile ## @@ -334,5

[GitHub] [airflow] ashb commented on a change in pull request #6266: [AIRFLOW-2439] Production Docker image support including refactoring of build scripts - depends on [AIRFLOW-5704]

2019-10-21 Thread GitBox
ashb commented on a change in pull request #6266: [AIRFLOW-2439] Production Docker image support including refactoring of build scripts - depends on [AIRFLOW-5704] URL: https://github.com/apache/airflow/pull/6266#discussion_r336898067 ## File path: Dockerfile ## @@ -16,19

[GitHub] [airflow] ashb commented on a change in pull request #6266: [AIRFLOW-2439] Production Docker image support including refactoring of build scripts - depends on [AIRFLOW-5704]

2019-10-21 Thread GitBox
ashb commented on a change in pull request #6266: [AIRFLOW-2439] Production Docker image support including refactoring of build scripts - depends on [AIRFLOW-5704] URL: https://github.com/apache/airflow/pull/6266#discussion_r336903775 ## File path: Dockerfile ## @@ -77,25

[GitHub] [airflow] ashb commented on a change in pull request #6266: [AIRFLOW-2439] Production Docker image support including refactoring of build scripts - depends on [AIRFLOW-5704]

2019-10-21 Thread GitBox
ashb commented on a change in pull request #6266: [AIRFLOW-2439] Production Docker image support including refactoring of build scripts - depends on [AIRFLOW-5704] URL: https://github.com/apache/airflow/pull/6266#discussion_r336916999 ## File path: Dockerfile ## @@ -334,5

[GitHub] [airflow] ashb commented on a change in pull request #6266: [AIRFLOW-2439] Production Docker image support including refactoring of build scripts - depends on [AIRFLOW-5704]

2019-10-21 Thread GitBox
ashb commented on a change in pull request #6266: [AIRFLOW-2439] Production Docker image support including refactoring of build scripts - depends on [AIRFLOW-5704] URL: https://github.com/apache/airflow/pull/6266#discussion_r336905484 ## File path: Dockerfile ## @@ -77,25

[GitHub] [airflow] ashb commented on a change in pull request #6266: [AIRFLOW-2439] Production Docker image support including refactoring of build scripts - depends on [AIRFLOW-5704]

2019-10-21 Thread GitBox
ashb commented on a change in pull request #6266: [AIRFLOW-2439] Production Docker image support including refactoring of build scripts - depends on [AIRFLOW-5704] URL: https://github.com/apache/airflow/pull/6266#discussion_r336904694 ## File path: Dockerfile ## @@ -334,5

[GitHub] [airflow] ashb commented on a change in pull request #6266: [AIRFLOW-2439] Production Docker image support including refactoring of build scripts - depends on [AIRFLOW-5704]

2019-10-21 Thread GitBox
ashb commented on a change in pull request #6266: [AIRFLOW-2439] Production Docker image support including refactoring of build scripts - depends on [AIRFLOW-5704] URL: https://github.com/apache/airflow/pull/6266#discussion_r336899269 ## File path: Dockerfile ## @@ -77,25

[GitHub] [airflow] ashb commented on a change in pull request #6266: [AIRFLOW-2439] Production Docker image support including refactoring of build scripts - depends on [AIRFLOW-5704]

2019-10-21 Thread GitBox
ashb commented on a change in pull request #6266: [AIRFLOW-2439] Production Docker image support including refactoring of build scripts - depends on [AIRFLOW-5704] URL: https://github.com/apache/airflow/pull/6266#discussion_r336905828 ## File path: airflow/contrib/hooks/winrm_hook.

[GitHub] [airflow] ashb commented on a change in pull request #6266: [AIRFLOW-2439] Production Docker image support including refactoring of build scripts - depends on [AIRFLOW-5704]

2019-10-21 Thread GitBox
ashb commented on a change in pull request #6266: [AIRFLOW-2439] Production Docker image support including refactoring of build scripts - depends on [AIRFLOW-5704] URL: https://github.com/apache/airflow/pull/6266#discussion_r336902442 ## File path: Dockerfile ## @@ -77,25

[GitHub] [airflow] ashb commented on a change in pull request #6266: [AIRFLOW-2439] Production Docker image support including refactoring of build scripts - depends on [AIRFLOW-5704]

2019-10-21 Thread GitBox
ashb commented on a change in pull request #6266: [AIRFLOW-2439] Production Docker image support including refactoring of build scripts - depends on [AIRFLOW-5704] URL: https://github.com/apache/airflow/pull/6266#discussion_r336917284 ## File path: Dockerfile ## @@ -334,5

[GitHub] [airflow] ashb commented on a change in pull request #6266: [AIRFLOW-2439] Production Docker image support including refactoring of build scripts - depends on [AIRFLOW-5704]

2019-10-21 Thread GitBox
ashb commented on a change in pull request #6266: [AIRFLOW-2439] Production Docker image support including refactoring of build scripts - depends on [AIRFLOW-5704] URL: https://github.com/apache/airflow/pull/6266#discussion_r336909165 ## File path: scripts/ci/ci_flake8.sh

[GitHub] [airflow] ashb commented on a change in pull request #6266: [AIRFLOW-2439] Production Docker image support including refactoring of build scripts - depends on [AIRFLOW-5704]

2019-10-21 Thread GitBox
ashb commented on a change in pull request #6266: [AIRFLOW-2439] Production Docker image support including refactoring of build scripts - depends on [AIRFLOW-5704] URL: https://github.com/apache/airflow/pull/6266#discussion_r336896918 ## File path: BREEZE.rst ## @@ -912,3

[GitHub] [airflow] ashb commented on a change in pull request #6266: [AIRFLOW-2439] Production Docker image support including refactoring of build scripts - depends on [AIRFLOW-5704]

2019-10-21 Thread GitBox
ashb commented on a change in pull request #6266: [AIRFLOW-2439] Production Docker image support including refactoring of build scripts - depends on [AIRFLOW-5704] URL: https://github.com/apache/airflow/pull/6266#discussion_r336901053 ## File path: Dockerfile ## @@ -77,25

[GitHub] [airflow] ashb commented on a change in pull request #6266: [AIRFLOW-2439] Production Docker image support including refactoring of build scripts - depends on [AIRFLOW-5704]

2019-10-21 Thread GitBox
ashb commented on a change in pull request #6266: [AIRFLOW-2439] Production Docker image support including refactoring of build scripts - depends on [AIRFLOW-5704] URL: https://github.com/apache/airflow/pull/6266#discussion_r336914812 ## File path: tests/operators/test_operators.py

[GitHub] [airflow] ashb commented on a change in pull request #6266: [AIRFLOW-2439] Production Docker image support including refactoring of build scripts - depends on [AIRFLOW-5704]

2019-10-21 Thread GitBox
ashb commented on a change in pull request #6266: [AIRFLOW-2439] Production Docker image support including refactoring of build scripts - depends on [AIRFLOW-5704] URL: https://github.com/apache/airflow/pull/6266#discussion_r336914233 ## File path: setup.py ## @@ -287,46

[GitHub] [airflow] ashb commented on a change in pull request #6266: [AIRFLOW-2439] Production Docker image support including refactoring of build scripts - depends on [AIRFLOW-5704]

2019-10-21 Thread GitBox
ashb commented on a change in pull request #6266: [AIRFLOW-2439] Production Docker image support including refactoring of build scripts - depends on [AIRFLOW-5704] URL: https://github.com/apache/airflow/pull/6266#discussion_r336900127 ## File path: Dockerfile ## @@ -77,25

[GitHub] [airflow] ashb commented on a change in pull request #6266: [AIRFLOW-2439] Production Docker image support including refactoring of build scripts - depends on [AIRFLOW-5704]

2019-10-21 Thread GitBox
ashb commented on a change in pull request #6266: [AIRFLOW-2439] Production Docker image support including refactoring of build scripts - depends on [AIRFLOW-5704] URL: https://github.com/apache/airflow/pull/6266#discussion_r336896656 ## File path: BREEZE.rst ## @@ -912,3

[GitHub] [airflow] mik-laj commented on issue #6306: [AIRFLOW-5632] Rename ComputeEngine operators

2019-10-21 Thread GitBox
mik-laj commented on issue #6306: [AIRFLOW-5632] Rename ComputeEngine operators URL: https://github.com/apache/airflow/pull/6306#issuecomment-544420987 Travis is sad. Can you fix it? This is an automated message from the Apach

[GitHub] [airflow] ashb commented on a change in pull request #6266: [AIRFLOW-2439] Production Docker image support including refactoring of build scripts - depends on [AIRFLOW-5704]

2019-10-21 Thread GitBox
ashb commented on a change in pull request #6266: [AIRFLOW-2439] Production Docker image support including refactoring of build scripts - depends on [AIRFLOW-5704] URL: https://github.com/apache/airflow/pull/6266#discussion_r336895542 ## File path: .travis.yml ## @@ -32,3

[GitHub] [airflow] ashb commented on a change in pull request #6266: [AIRFLOW-2439] Production Docker image support including refactoring of build scripts - depends on [AIRFLOW-5704]

2019-10-21 Thread GitBox
ashb commented on a change in pull request #6266: [AIRFLOW-2439] Production Docker image support including refactoring of build scripts - depends on [AIRFLOW-5704] URL: https://github.com/apache/airflow/pull/6266#discussion_r336894816 ## File path: .pre-commit-config.yaml

[GitHub] [airflow] nuclearpinguin commented on a change in pull request #6299: [AIRFLOW-5631] Change way of running GCP system tests

2019-10-21 Thread GitBox
nuclearpinguin commented on a change in pull request #6299: [AIRFLOW-5631] Change way of running GCP system tests URL: https://github.com/apache/airflow/pull/6299#discussion_r336893648 ## File path: tests/gcp/operators/test_cloud_sql_system.py ## @@ -17,42 +17,34 @@ # spe

[GitHub] [airflow] ashb commented on issue #6230: [AIRFLOW-5413] Allow K8S worker pod to be configured from JSON/YAML file

2019-10-21 Thread GitBox
ashb commented on issue #6230: [AIRFLOW-5413] Allow K8S worker pod to be configured from JSON/YAML file URL: https://github.com/apache/airflow/pull/6230#issuecomment-544407807 > `path_to_deployment_file` is not super clear what it means - could the name be something like `path_to_pod_templ

[GitHub] [airflow] mik-laj commented on a change in pull request #6299: [AIRFLOW-5631] Change way of running GCP system tests

2019-10-21 Thread GitBox
mik-laj commented on a change in pull request #6299: [AIRFLOW-5631] Change way of running GCP system tests URL: https://github.com/apache/airflow/pull/6299#discussion_r336888129 ## File path: tests/gcp/operators/test_cloud_sql_system.py ## @@ -17,42 +17,34 @@ # specific l

[GitHub] [airflow] mik-laj commented on a change in pull request #6299: [AIRFLOW-5631] Change way of running GCP system tests

2019-10-21 Thread GitBox
mik-laj commented on a change in pull request #6299: [AIRFLOW-5631] Change way of running GCP system tests URL: https://github.com/apache/airflow/pull/6299#discussion_r336887683 ## File path: airflow/utils/log/colored_log.py ## @@ -30,7 +30,7 @@ ARGS = {"attrs": ["bold"]}

[jira] [Commented] (AIRFLOW-5699) Add more tests for Dataflow integration

2019-10-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16955850#comment-16955850 ] ASF GitHub Bot commented on AIRFLOW-5699: - potiuk commented on pull request #63

[jira] [Commented] (AIRFLOW-5699) Add more tests for Dataflow integration

2019-10-21 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16955851#comment-16955851 ] ASF subversion and git services commented on AIRFLOW-5699: -- Co

[jira] [Resolved] (AIRFLOW-5699) Add more tests for Dataflow integration

2019-10-21 Thread Jarek Potiuk (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5699?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jarek Potiuk resolved AIRFLOW-5699. --- Fix Version/s: 2.0.0 Resolution: Fixed > Add more tests for Dataflow integration > -

[GitHub] [airflow] codecov-io edited a comment on issue #6344: [AIRFLOW-5665] Add path_exists method to SFTPHook

2019-10-21 Thread GitBox
codecov-io edited a comment on issue #6344: [AIRFLOW-5665] Add path_exists method to SFTPHook URL: https://github.com/apache/airflow/pull/6344#issuecomment-544265427 # [Codecov](https://codecov.io/gh/apache/airflow/pull/6344?src=pr&el=h1) Report > Merging [#6344](https://codecov.io/gh/

[GitHub] [airflow] codecov-io edited a comment on issue #6344: [AIRFLOW-5665] Add path_exists method to SFTPHook

2019-10-21 Thread GitBox
codecov-io edited a comment on issue #6344: [AIRFLOW-5665] Add path_exists method to SFTPHook URL: https://github.com/apache/airflow/pull/6344#issuecomment-544265427 # [Codecov](https://codecov.io/gh/apache/airflow/pull/6344?src=pr&el=h1) Report > Merging [#6344](https://codecov.io/gh/

[GitHub] [airflow] codecov-io edited a comment on issue #6344: [AIRFLOW-5665] Add path_exists method to SFTPHook

2019-10-21 Thread GitBox
codecov-io edited a comment on issue #6344: [AIRFLOW-5665] Add path_exists method to SFTPHook URL: https://github.com/apache/airflow/pull/6344#issuecomment-544265427 # [Codecov](https://codecov.io/gh/apache/airflow/pull/6344?src=pr&el=h1) Report > Merging [#6344](https://codecov.io/gh/

[GitHub] [airflow] potiuk merged pull request #6369: [AIRFLOW-5699][part of AIRFLOW-5697][depends on AIRFLOW-5698] Add more tests for Dataflow integration

2019-10-21 Thread GitBox
potiuk merged pull request #6369: [AIRFLOW-5699][part of AIRFLOW-5697][depends on AIRFLOW-5698] Add more tests for Dataflow integration URL: https://github.com/apache/airflow/pull/6369 This is an automated message from the A

[jira] [Commented] (AIRFLOW-5698) Organize Dataflow tests

2019-10-21 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16955847#comment-16955847 ] ASF subversion and git services commented on AIRFLOW-5698: -- Co

[jira] [Commented] (AIRFLOW-5698) Organize Dataflow tests

2019-10-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16955845#comment-16955845 ] ASF GitHub Bot commented on AIRFLOW-5698: - potiuk commented on pull request #63

[jira] [Resolved] (AIRFLOW-5698) Organize Dataflow tests

2019-10-21 Thread Jarek Potiuk (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5698?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jarek Potiuk resolved AIRFLOW-5698. --- Fix Version/s: 2.0.0 Resolution: Fixed > Organize Dataflow tests > -

[GitHub] [airflow] potiuk merged pull request #6368: [AIRFLOW-5698][part of AIRFLOW-5697] Organize Dataflow tests

2019-10-21 Thread GitBox
potiuk merged pull request #6368: [AIRFLOW-5698][part of AIRFLOW-5697] Organize Dataflow tests URL: https://github.com/apache/airflow/pull/6368 This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] [airflow] mik-laj commented on a change in pull request #6230: [AIRFLOW-5413] Allow K8S worker pod to be configured from JSON/YAML file

2019-10-21 Thread GitBox
mik-laj commented on a change in pull request #6230: [AIRFLOW-5413] Allow K8S worker pod to be configured from JSON/YAML file URL: https://github.com/apache/airflow/pull/6230#discussion_r336879740 ## File path: airflow/kubernetes/pod_generator.py ## @@ -62,75 +68,116 @@ cl

[GitHub] [airflow] mik-laj edited a comment on issue #6230: [AIRFLOW-5413] Allow K8S pod to be configured from JSON/YAML file

2019-10-21 Thread GitBox
mik-laj edited a comment on issue #6230: [AIRFLOW-5413] Allow K8S pod to be configured from JSON/YAML file URL: https://github.com/apache/airflow/pull/6230#issuecomment-544392238 Hello. I started working on support for similar functionality for the operator. https://github.com/apa

[GitHub] [airflow] mik-laj commented on issue #6230: [AIRFLOW-5413] Allow K8S pod to be configured from JSON/YAML file

2019-10-21 Thread GitBox
mik-laj commented on issue #6230: [AIRFLOW-5413] Allow K8S pod to be configured from JSON/YAML file URL: https://github.com/apache/airflow/pull/6230#issuecomment-544392238 Hello. I started working on support for similar functionality for the operator. https://github.com/apache/air

[GitHub] [airflow] mik-laj commented on a change in pull request #6230: [AIRFLOW-5413] Allow K8S pod to be configured from JSON/YAML file

2019-10-21 Thread GitBox
mik-laj commented on a change in pull request #6230: [AIRFLOW-5413] Allow K8S pod to be configured from JSON/YAML file URL: https://github.com/apache/airflow/pull/6230#discussion_r336872367 ## File path: airflow/executors/kubernetes_executor.py ## @@ -546,9 +556,7 @@ def _

[GitHub] [airflow] mik-laj commented on a change in pull request #6230: [AIRFLOW-5413] Allow K8S pod to be configured from JSON/YAML file

2019-10-21 Thread GitBox
mik-laj commented on a change in pull request #6230: [AIRFLOW-5413] Allow K8S pod to be configured from JSON/YAML file URL: https://github.com/apache/airflow/pull/6230#discussion_r336871929 ## File path: tests/integration/kubernetes/test_kubernetes_pod_operator.py ## @@ -9

[jira] [Closed] (AIRFLOW-5689) Side-Input in Python3 fails to pickle class

2019-10-21 Thread Jannik Franz (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5689?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jannik Franz closed AIRFLOW-5689. - Resolution: Invalid > Side-Input in Python3 fails to pickle class > ---

[jira] [Reopened] (AIRFLOW-5689) Side-Input in Python3 fails to pickle class

2019-10-21 Thread Jannik Franz (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5689?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jannik Franz reopened AIRFLOW-5689: --- > Side-Input in Python3 fails to pickle class > --- > >

[jira] [Closed] (AIRFLOW-5689) Side-Input in Python3 fails to pickle class

2019-10-21 Thread Jannik Franz (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5689?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jannik Franz closed AIRFLOW-5689. - Resolution: Invalid Sorry, this was supposed to go to the Beam JIRA. My bad, will reopen over t

[GitHub] [airflow] mik-laj commented on a change in pull request #6230: [AIRFLOW-5413] Allow K8S pod to be configured from JSON/YAML file

2019-10-21 Thread GitBox
mik-laj commented on a change in pull request #6230: [AIRFLOW-5413] Allow K8S pod to be configured from JSON/YAML file URL: https://github.com/apache/airflow/pull/6230#discussion_r336870706 ## File path: airflow/kubernetes/worker_configuration.py ## @@ -28,7 +28,11 @@

[GitHub] [airflow] mik-laj commented on a change in pull request #6230: [AIRFLOW-5413] Allow K8S pod to be configured from JSON/YAML file

2019-10-21 Thread GitBox
mik-laj commented on a change in pull request #6230: [AIRFLOW-5413] Allow K8S pod to be configured from JSON/YAML file URL: https://github.com/apache/airflow/pull/6230#discussion_r336870624 ## File path: airflow/kubernetes/pod_generator.py ## @@ -301,51 +352,151 @@ def rec

[GitHub] [airflow] mik-laj commented on a change in pull request #6230: [AIRFLOW-5413] Allow K8S pod to be configured from JSON/YAML file

2019-10-21 Thread GitBox
mik-laj commented on a change in pull request #6230: [AIRFLOW-5413] Allow K8S pod to be configured from JSON/YAML file URL: https://github.com/apache/airflow/pull/6230#discussion_r336869991 ## File path: airflow/kubernetes/pod_generator.py ## @@ -301,51 +352,151 @@ def rec

<    1   2