[GitHub] [airflow] codecov-io edited a comment on issue #6644: [AIRFLOW-6047] Simplify the logging configuration template

2019-11-22 Thread GitBox
codecov-io edited a comment on issue #6644: [AIRFLOW-6047] Simplify the logging configuration template URL: https://github.com/apache/airflow/pull/6644#issuecomment-557738689 # [Codecov](https://codecov.io/gh/apache/airflow/pull/6644?src=pr=h1) Report > Merging

[GitHub] [airflow] codecov-io edited a comment on issue #6644: [AIRFLOW-6047] Simplify the logging configuration template

2019-11-22 Thread GitBox
codecov-io edited a comment on issue #6644: [AIRFLOW-6047] Simplify the logging configuration template URL: https://github.com/apache/airflow/pull/6644#issuecomment-557738689 # [Codecov](https://codecov.io/gh/apache/airflow/pull/6644?src=pr=h1) Report > Merging

[GitHub] [airflow] KKcorps commented on a change in pull request #6515: [AIRFLOW-XXX] GSoD: How to make DAGs production ready

2019-11-22 Thread GitBox
KKcorps commented on a change in pull request #6515: [AIRFLOW-XXX] GSoD: How to make DAGs production ready URL: https://github.com/apache/airflow/pull/6515#discussion_r349858383 ## File path: docs/best-practices.rst ## @@ -0,0 +1,271 @@ + .. Licensed to the Apache

[GitHub] [airflow] mik-laj edited a comment on issue #6644: [AIRFLOW-6047] Simplify the logging configuration template

2019-11-22 Thread GitBox
mik-laj edited a comment on issue #6644: [AIRFLOW-6047] Simplify the logging configuration template URL: https://github.com/apache/airflow/pull/6644#issuecomment-557766452 I am working on direct integration with [Google Stackdriver Logging](https://cloud.google.com/logging/). WIP version

[GitHub] [airflow] mik-laj commented on issue #6644: [AIRFLOW-6047] Simplify the logging configuration template

2019-11-22 Thread GitBox
mik-laj commented on issue #6644: [AIRFLOW-6047] Simplify the logging configuration template URL: https://github.com/apache/airflow/pull/6644#issuecomment-557766452 I am working on direct integration with Google Stackdriver. WIP version is available on my company fork.

[GitHub] [airflow] KKcorps commented on a change in pull request #6295: [AIRFLOW-XXX] GSoD: Adding Task re-run documentation

2019-11-22 Thread GitBox
KKcorps commented on a change in pull request #6295: [AIRFLOW-XXX] GSoD: Adding Task re-run documentation URL: https://github.com/apache/airflow/pull/6295#discussion_r349855620 ## File path: docs/scheduler.rst ## @@ -32,161 +30,31 @@ Airflow production environment. To

[jira] [Resolved] (AIRFLOW-6048) Make K8s Pod Operator's "_set_*" methods static

2019-11-22 Thread Xiaodong Deng (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-6048?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xiaodong Deng resolved AIRFLOW-6048. Resolution: Resolved > Make K8s Pod Operator's "_set_*" methods static >

[jira] [Updated] (AIRFLOW-6048) Make K8s Pod Operator's "_set_*" methods static

2019-11-22 Thread Xiaodong Deng (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-6048?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xiaodong Deng updated AIRFLOW-6048: --- Summary: Make K8s Pod Operator's "_set_*" methods static (was: Make K8s Pod Operator's

[GitHub] [airflow] XD-DENG commented on issue #6645: [AIRFLOW-6048] Make K8s Pod Operator's methods static

2019-11-22 Thread GitBox
XD-DENG commented on issue #6645: [AIRFLOW-6048] Make K8s Pod Operator's methods static URL: https://github.com/apache/airflow/pull/6645#issuecomment-557759504 Hi @kaxil , when I merged, I made a minor change in your commit subject to avoid potential misunderstanding **"Make K8s

[jira] [Commented] (AIRFLOW-6048) Make K8s Pod Operator's methods static

2019-11-22 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-6048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16980638#comment-16980638 ] ASF subversion and git services commented on AIRFLOW-6048: -- Commit

[jira] [Commented] (AIRFLOW-6048) Make K8s Pod Operator's methods static

2019-11-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-6048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16980637#comment-16980637 ] ASF GitHub Bot commented on AIRFLOW-6048: - XD-DENG commented on pull request #6645:

[GitHub] [airflow] XD-DENG merged pull request #6645: [AIRFLOW-6048] Make K8s Pod Operator's methods static

2019-11-22 Thread GitBox
XD-DENG merged pull request #6645: [AIRFLOW-6048] Make K8s Pod Operator's methods static URL: https://github.com/apache/airflow/pull/6645 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [airflow] XD-DENG commented on issue #6644: [AIRFLOW-6047] Simplify the logging configuration template

2019-11-22 Thread GitBox
XD-DENG commented on issue #6644: [AIRFLOW-6047] Simplify the logging configuration template URL: https://github.com/apache/airflow/pull/6644#issuecomment-557758424 Hi @mik-laj , sure I will take a look. Meanwhile curious what new integration you're planning? If you already have

[GitHub] [airflow] codecov-io edited a comment on issue #6647: [AIRFLOW-6049] set propagate True when needed in airflow test

2019-11-22 Thread GitBox
codecov-io edited a comment on issue #6647: [AIRFLOW-6049] set propagate True when needed in airflow test URL: https://github.com/apache/airflow/pull/6647#issuecomment-557755219 # [Codecov](https://codecov.io/gh/apache/airflow/pull/6647?src=pr=h1) Report > Merging

[GitHub] [airflow] codecov-io commented on issue #6647: [AIRFLOW-6049] set propagate True when needed in airflow test

2019-11-22 Thread GitBox
codecov-io commented on issue #6647: [AIRFLOW-6049] set propagate True when needed in airflow test URL: https://github.com/apache/airflow/pull/6647#issuecomment-557755219 # [Codecov](https://codecov.io/gh/apache/airflow/pull/6647?src=pr=h1) Report > Merging

[GitHub] [airflow] codecov-io commented on issue #6645: [AIRFLOW-6048] Make K8s Pod Operator's methods static

2019-11-22 Thread GitBox
codecov-io commented on issue #6645: [AIRFLOW-6048] Make K8s Pod Operator's methods static URL: https://github.com/apache/airflow/pull/6645#issuecomment-557749825 # [Codecov](https://codecov.io/gh/apache/airflow/pull/6645?src=pr=h1) Report > Merging

[GitHub] [airflow] kaxil opened a new pull request #6648: [AIRFLOW-XXX] Add TypeHints to kubernetes_pod_operator

2019-11-22 Thread GitBox
kaxil opened a new pull request #6648: [AIRFLOW-XXX] Add TypeHints to kubernetes_pod_operator URL: https://github.com/apache/airflow/pull/6648 Make sure you have checked _all_ steps below. ### Jira - [x] My PR addresses the following [Airflow

[GitHub] [airflow] kaxil merged pull request #6646: [AIRFLOW-XXX] Fix typo in gcp/hooks/test_base.py

2019-11-22 Thread GitBox
kaxil merged pull request #6646: [AIRFLOW-XXX] Fix typo in gcp/hooks/test_base.py URL: https://github.com/apache/airflow/pull/6646 This is an automated message from the Apache Git Service. To respond to the message, please

[jira] [Commented] (AIRFLOW-6049) airflow test double prints when the task log handler is already StreamHandler

2019-11-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-6049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16980588#comment-16980588 ] ASF GitHub Bot commented on AIRFLOW-6049: - pingzh commented on pull request #6647:

[GitHub] [airflow] pingzh opened a new pull request #6647: [AIRFLOW-6049] set propagate True when needed in airflow test

2019-11-22 Thread GitBox
pingzh opened a new pull request #6647: [AIRFLOW-6049] set propagate True when needed in airflow test URL: https://github.com/apache/airflow/pull/6647 when airflow.task handlers don't have StreamHandler Make sure you have checked _all_ steps below. ### Jira - [x] My PR

[GitHub] [airflow] houqp commented on a change in pull request #6553: [AIRFLOW-5902] avoid unnecessary sleep to maintain local task job heart rate

2019-11-22 Thread GitBox
houqp commented on a change in pull request #6553: [AIRFLOW-5902] avoid unnecessary sleep to maintain local task job heart rate URL: https://github.com/apache/airflow/pull/6553#discussion_r349843733 ## File path: airflow/jobs/base_job.py ## @@ -171,17 +171,14 @@ def

[GitHub] [airflow] houqp commented on issue #6553: [AIRFLOW-5902] avoid unnecessary sleep to maintain local task job heart rate

2019-11-22 Thread GitBox
houqp commented on issue #6553: [AIRFLOW-5902] avoid unnecessary sleep to maintain local task job heart rate URL: https://github.com/apache/airflow/pull/6553#issuecomment-557743080 @jj-ian this exactly how I came to this patch :) Feel free to apply this patch to your cluster, we have been

[GitHub] [airflow] houqp commented on a change in pull request #6553: [AIRFLOW-5902] avoid unnecessary sleep to maintain local task job heart rate

2019-11-22 Thread GitBox
houqp commented on a change in pull request #6553: [AIRFLOW-5902] avoid unnecessary sleep to maintain local task job heart rate URL: https://github.com/apache/airflow/pull/6553#discussion_r349843267 ## File path: airflow/jobs/base_job.py ## @@ -171,17 +171,14 @@ def

[jira] [Created] (AIRFLOW-6049) airflow test double prints when the task log handler is already StreamHandler

2019-11-22 Thread Ping Zhang (Jira)
Ping Zhang created AIRFLOW-6049: --- Summary: airflow test double prints when the task log handler is already StreamHandler Key: AIRFLOW-6049 URL: https://issues.apache.org/jira/browse/AIRFLOW-6049

[GitHub] [airflow] codecov-io edited a comment on issue #6644: [AIRFLOW-6047] Simplify the logging configuration template

2019-11-22 Thread GitBox
codecov-io edited a comment on issue #6644: [AIRFLOW-6047] Simplify the logging configuration template URL: https://github.com/apache/airflow/pull/6644#issuecomment-557738689 # [Codecov](https://codecov.io/gh/apache/airflow/pull/6644?src=pr=h1) Report > Merging

[GitHub] [airflow] codecov-io commented on issue #6644: [AIRFLOW-6047] Simplify the logging configuration template

2019-11-22 Thread GitBox
codecov-io commented on issue #6644: [AIRFLOW-6047] Simplify the logging configuration template URL: https://github.com/apache/airflow/pull/6644#issuecomment-557738689 # [Codecov](https://codecov.io/gh/apache/airflow/pull/6644?src=pr=h1) Report > Merging

[GitHub] [airflow] kaxil opened a new pull request #6646: [AIRFLOW-XXX] Fix typo in gcp/hooks/test_base.py

2019-11-22 Thread GitBox
kaxil opened a new pull request #6646: [AIRFLOW-XXX] Fix typo in gcp/hooks/test_base.py URL: https://github.com/apache/airflow/pull/6646 Make sure you have checked _all_ steps below. ### Jira - [x] My PR addresses the following [Airflow

[jira] [Commented] (AIRFLOW-6048) Make K8s Pod Operator's methods static

2019-11-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-6048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16980578#comment-16980578 ] ASF GitHub Bot commented on AIRFLOW-6048: - kaxil commented on pull request #6645:

[jira] [Updated] (AIRFLOW-6048) Make K8s Pod Operator's methods static

2019-11-22 Thread Kaxil Naik (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-6048?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kaxil Naik updated AIRFLOW-6048: Description: `_set_resources` and `_set_name` methods in KubernetesPodOperator can be converted

[GitHub] [airflow] kaxil opened a new pull request #6645: [AIRFLOW-6048] Make K8s Pod Operator's methods static

2019-11-22 Thread GitBox
kaxil opened a new pull request #6645: [AIRFLOW-6048] Make K8s Pod Operator's methods static URL: https://github.com/apache/airflow/pull/6645 Make sure you have checked _all_ steps below. ### Jira - [x] My PR addresses the following [Airflow

[jira] [Updated] (AIRFLOW-6048) Make K8s Pod Operator's methods static

2019-11-22 Thread Kaxil Naik (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-6048?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kaxil Naik updated AIRFLOW-6048: Description: `_set_resources` and `_set_name` methods can be converted into static methods >

[jira] [Created] (AIRFLOW-6048) Make K8s Pod Operator's methods static

2019-11-22 Thread Kaxil Naik (Jira)
Kaxil Naik created AIRFLOW-6048: --- Summary: Make K8s Pod Operator's methods static Key: AIRFLOW-6048 URL: https://issues.apache.org/jira/browse/AIRFLOW-6048 Project: Apache Airflow Issue Type:

[GitHub] [airflow] mik-laj commented on issue #6644: [AIRFLOW-6047] Simplify the logging configuration template

2019-11-22 Thread GitBox
mik-laj commented on issue #6644: [AIRFLOW-6047] Simplify the logging configuration template URL: https://github.com/apache/airflow/pull/6644#issuecomment-557731804 This is important to me because I want to add new integration that will require a lot of more configuration options

[GitHub] [airflow] mik-laj commented on issue #6644: [AIRFLOW-6047] Simplify the logging configuration template

2019-11-22 Thread GitBox
mik-laj commented on issue #6644: [AIRFLOW-6047] Simplify the logging configuration template URL: https://github.com/apache/airflow/pull/6644#issuecomment-557723131 CC: @XD-DENG, @ashb, @serkef This is an automated message

[jira] [Commented] (AIRFLOW-6044) Standardize the Code Structure in kube_pod_operator.py

2019-11-22 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-6044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16980558#comment-16980558 ] ASF subversion and git services commented on AIRFLOW-6044: -- Commit

[jira] [Commented] (AIRFLOW-6047) Simplify the logging configuration template

2019-11-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-6047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16980556#comment-16980556 ] ASF GitHub Bot commented on AIRFLOW-6047: - mik-laj commented on pull request #6644:

[GitHub] [airflow] yimingl17 commented on issue #6565: [AIRFLOW-5909] Enable mapping to BYTEs type to sql_to_gcs operator

2019-11-22 Thread GitBox
yimingl17 commented on issue #6565: [AIRFLOW-5909] Enable mapping to BYTEs type to sql_to_gcs operator URL: https://github.com/apache/airflow/pull/6565#issuecomment-557722339 Hi @OmerJog, Can I get another review on this PR? Thank you!

[GitHub] [airflow] mik-laj opened a new pull request #6644: [AIRFLOW-6047] Simplify the logging configuration template

2019-11-22 Thread GitBox
mik-laj opened a new pull request #6644: [AIRFLOW-6047] Simplify the logging configuration template URL: https://github.com/apache/airflow/pull/6644 Make sure you have checked _all_ steps below. ### Jira - [ ] My PR addresses the following [Airflow

[jira] [Created] (AIRFLOW-6047) Simplify the logging configuration template

2019-11-22 Thread Kamil Bregula (Jira)
Kamil Bregula created AIRFLOW-6047: -- Summary: Simplify the logging configuration template Key: AIRFLOW-6047 URL: https://issues.apache.org/jira/browse/AIRFLOW-6047 Project: Apache Airflow

[GitHub] [airflow] codecov-io edited a comment on issue #6565: [AIRFLOW-5909] Enable mapping to BYTEs type to sql_to_gcs operator

2019-11-22 Thread GitBox
codecov-io edited a comment on issue #6565: [AIRFLOW-5909] Enable mapping to BYTEs type to sql_to_gcs operator URL: https://github.com/apache/airflow/pull/6565#issuecomment-553578834 # [Codecov](https://codecov.io/gh/apache/airflow/pull/6565?src=pr=h1) Report > Merging

[GitHub] [airflow] codecov-io edited a comment on issue #6565: [AIRFLOW-5909] Enable mapping to BYTEs type to sql_to_gcs operator

2019-11-22 Thread GitBox
codecov-io edited a comment on issue #6565: [AIRFLOW-5909] Enable mapping to BYTEs type to sql_to_gcs operator URL: https://github.com/apache/airflow/pull/6565#issuecomment-553578834 # [Codecov](https://codecov.io/gh/apache/airflow/pull/6565?src=pr=h1) Report > Merging

[GitHub] [airflow] codecov-io edited a comment on issue #6565: [AIRFLOW-5909] Enable mapping to BYTEs type to sql_to_gcs operator

2019-11-22 Thread GitBox
codecov-io edited a comment on issue #6565: [AIRFLOW-5909] Enable mapping to BYTEs type to sql_to_gcs operator URL: https://github.com/apache/airflow/pull/6565#issuecomment-553578834 # [Codecov](https://codecov.io/gh/apache/airflow/pull/6565?src=pr=h1) Report > Merging

[jira] [Commented] (AIRFLOW-6046) Fix Alembic migrations & sync it to 1.10.*

2019-11-22 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-6046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16980545#comment-16980545 ] ASF subversion and git services commented on AIRFLOW-6046: -- Commit

[GitHub] [airflow] kaxil merged pull request #6642: [AIRFLOW-6046] Fix Alembic migrations & sync it to 1.10.*

2019-11-22 Thread GitBox
kaxil merged pull request #6642: [AIRFLOW-6046] Fix Alembic migrations & sync it to 1.10.* URL: https://github.com/apache/airflow/pull/6642 This is an automated message from the Apache Git Service. To respond to the

[jira] [Commented] (AIRFLOW-6046) Fix Alembic migrations & sync it to 1.10.*

2019-11-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-6046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16980544#comment-16980544 ] ASF GitHub Bot commented on AIRFLOW-6046: - kaxil commented on pull request #6642:

[jira] [Resolved] (AIRFLOW-6046) Fix Alembic migrations & sync it to 1.10.*

2019-11-22 Thread Kaxil Naik (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-6046?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kaxil Naik resolved AIRFLOW-6046. - Resolution: Fixed > Fix Alembic migrations & sync it to 1.10.* >

[jira] [Closed] (AIRFLOW-1717) AttributeError while clicking on dag on webUI

2019-11-22 Thread Ash Berlin-Taylor (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-1717?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ash Berlin-Taylor closed AIRFLOW-1717. -- Resolution: Fixed > AttributeError while clicking on dag on webUI >

[jira] [Commented] (AIRFLOW-5935) Logs are not sent S3 by S3TaskHandler

2019-11-22 Thread Ash Berlin-Taylor (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16980542#comment-16980542 ] Ash Berlin-Taylor commented on AIRFLOW-5935: For anyone else coming across this and

[GitHub] [airflow] ashb commented on a change in pull request #6601: [AIRFLOW-6010] Remove cyclic imports and pylint disables

2019-11-22 Thread GitBox
ashb commented on a change in pull request #6601: [AIRFLOW-6010] Remove cyclic imports and pylint disables URL: https://github.com/apache/airflow/pull/6601#discussion_r349814787 ## File path: airflow/utils/db.py ## @@ -336,8 +336,12 @@ def resetdb(): Clear out the

[jira] [Commented] (AIRFLOW-6040) Airflow scheduler with kubernetes executor fails :- Unknown error in KubernetesJobWatcher

2019-11-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-6040?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16980540#comment-16980540 ] ASF GitHub Bot commented on AIRFLOW-6040: - maxirus commented on pull request #6643:

[GitHub] [airflow] maxirus opened a new pull request #6643: [AIRFLOW-6040] Fix KubernetesJobWatcher Read time out error

2019-11-22 Thread GitBox
maxirus opened a new pull request #6643: [AIRFLOW-6040] Fix KubernetesJobWatcher Read time out error URL: https://github.com/apache/airflow/pull/6643 ### Jira - [ ] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues -

[GitHub] [airflow] jj-ookla commented on issue #6553: [AIRFLOW-5902] avoid unnecessary sleep to maintain local task job heart rate

2019-11-22 Thread GitBox
jj-ookla commented on issue #6553: [AIRFLOW-5902] avoid unnecessary sleep to maintain local task job heart rate URL: https://github.com/apache/airflow/pull/6553#issuecomment-557706681 If the unit test changes are not approved, I would really like to see the removal of heart beat logging

[GitHub] [airflow] kaxil commented on a change in pull request #6601: [AIRFLOW-6010] Remove cyclic imports and pylint disables

2019-11-22 Thread GitBox
kaxil commented on a change in pull request #6601: [AIRFLOW-6010] Remove cyclic imports and pylint disables URL: https://github.com/apache/airflow/pull/6601#discussion_r349808012 ## File path: airflow/utils/db.py ## @@ -336,8 +336,12 @@ def resetdb(): Clear out the

[GitHub] [airflow] kaxil commented on a change in pull request #6601: [AIRFLOW-6010] Remove cyclic imports and pylint disables

2019-11-22 Thread GitBox
kaxil commented on a change in pull request #6601: [AIRFLOW-6010] Remove cyclic imports and pylint disables URL: https://github.com/apache/airflow/pull/6601#discussion_r349807337 ## File path: airflow/utils/db.py ## @@ -336,6 +336,8 @@ def resetdb(): Clear out the

[GitHub] [airflow] kaxil commented on a change in pull request #6601: [AIRFLOW-6010] Remove cyclic imports and pylint disables

2019-11-22 Thread GitBox
kaxil commented on a change in pull request #6601: [AIRFLOW-6010] Remove cyclic imports and pylint disables URL: https://github.com/apache/airflow/pull/6601#discussion_r349807159 ## File path: airflow/utils/db.py ## @@ -336,6 +336,8 @@ def resetdb(): Clear out the

[GitHub] [airflow] potiuk commented on a change in pull request #6601: [AIRFLOW-6010] Remove cyclic imports and pylint disables

2019-11-22 Thread GitBox
potiuk commented on a change in pull request #6601: [AIRFLOW-6010] Remove cyclic imports and pylint disables URL: https://github.com/apache/airflow/pull/6601#discussion_r349806750 ## File path: airflow/utils/db.py ## @@ -336,6 +336,8 @@ def resetdb(): Clear out the

[GitHub] [airflow] potiuk commented on a change in pull request #6601: [AIRFLOW-6010] Remove cyclic imports and pylint disables

2019-11-22 Thread GitBox
potiuk commented on a change in pull request #6601: [AIRFLOW-6010] Remove cyclic imports and pylint disables URL: https://github.com/apache/airflow/pull/6601#discussion_r349806750 ## File path: airflow/utils/db.py ## @@ -336,6 +336,8 @@ def resetdb(): Clear out the

[GitHub] [airflow] kaxil commented on a change in pull request #6601: [AIRFLOW-6010] Remove cyclic imports and pylint disables

2019-11-22 Thread GitBox
kaxil commented on a change in pull request #6601: [AIRFLOW-6010] Remove cyclic imports and pylint disables URL: https://github.com/apache/airflow/pull/6601#discussion_r349806276 ## File path: airflow/models/baseoperator.py ## @@ -235,29 +234,26 @@ class derived from this

[GitHub] [airflow] kaxil commented on a change in pull request #6601: [AIRFLOW-6010] Remove cyclic imports and pylint disables

2019-11-22 Thread GitBox
kaxil commented on a change in pull request #6601: [AIRFLOW-6010] Remove cyclic imports and pylint disables URL: https://github.com/apache/airflow/pull/6601#discussion_r349806164 ## File path: airflow/models/baseoperator.py ## @@ -26,19 +26,18 @@ import warnings from

[GitHub] [airflow] kaxil commented on a change in pull request #6601: [AIRFLOW-6010] Remove cyclic imports and pylint disables

2019-11-22 Thread GitBox
kaxil commented on a change in pull request #6601: [AIRFLOW-6010] Remove cyclic imports and pylint disables URL: https://github.com/apache/airflow/pull/6601#discussion_r349805433 ## File path: airflow/utils/db.py ## @@ -336,6 +336,8 @@ def resetdb(): Clear out the

[jira] [Commented] (AIRFLOW-6016) Remove redundant config option `remote_logging`

2019-11-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-6016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16980519#comment-16980519 ] ASF GitHub Bot commented on AIRFLOW-6016: - ashb commented on pull request #6610: [AIRFLOW-6016]

[jira] [Closed] (AIRFLOW-6016) Remove redundant config option `remote_logging`

2019-11-22 Thread Ash Berlin-Taylor (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-6016?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ash Berlin-Taylor closed AIRFLOW-6016. -- Resolution: Won't Fix > Remove redundant config option `remote_logging` >

[GitHub] [airflow] ashb closed pull request #6610: [AIRFLOW-6016] Remove redundant setting `remote_logging`

2019-11-22 Thread GitBox
ashb closed pull request #6610: [AIRFLOW-6016] Remove redundant setting `remote_logging` URL: https://github.com/apache/airflow/pull/6610 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [airflow] ashb commented on a change in pull request #6515: [AIRFLOW-XXX] GSoD: How to make DAGs production ready

2019-11-22 Thread GitBox
ashb commented on a change in pull request #6515: [AIRFLOW-XXX] GSoD: How to make DAGs production ready URL: https://github.com/apache/airflow/pull/6515#discussion_r349801794 ## File path: docs/best-practices.rst ## @@ -0,0 +1,296 @@ + .. Licensed to the Apache Software

[GitHub] [airflow] ashb commented on a change in pull request #6515: [AIRFLOW-XXX] GSoD: How to make DAGs production ready

2019-11-22 Thread GitBox
ashb commented on a change in pull request #6515: [AIRFLOW-XXX] GSoD: How to make DAGs production ready URL: https://github.com/apache/airflow/pull/6515#discussion_r349800313 ## File path: docs/best-practices.rst ## @@ -0,0 +1,296 @@ + .. Licensed to the Apache Software

[GitHub] [airflow] ashb commented on a change in pull request #6515: [AIRFLOW-XXX] GSoD: How to make DAGs production ready

2019-11-22 Thread GitBox
ashb commented on a change in pull request #6515: [AIRFLOW-XXX] GSoD: How to make DAGs production ready URL: https://github.com/apache/airflow/pull/6515#discussion_r349798847 ## File path: docs/best-practices.rst ## @@ -0,0 +1,296 @@ + .. Licensed to the Apache Software

[GitHub] [airflow] ashb commented on a change in pull request #6515: [AIRFLOW-XXX] GSoD: How to make DAGs production ready

2019-11-22 Thread GitBox
ashb commented on a change in pull request #6515: [AIRFLOW-XXX] GSoD: How to make DAGs production ready URL: https://github.com/apache/airflow/pull/6515#discussion_r349800893 ## File path: docs/best-practices.rst ## @@ -0,0 +1,271 @@ + .. Licensed to the Apache Software

[GitHub] [airflow] ashb commented on a change in pull request #6515: [AIRFLOW-XXX] GSoD: How to make DAGs production ready

2019-11-22 Thread GitBox
ashb commented on a change in pull request #6515: [AIRFLOW-XXX] GSoD: How to make DAGs production ready URL: https://github.com/apache/airflow/pull/6515#discussion_r349799603 ## File path: docs/best-practices.rst ## @@ -0,0 +1,296 @@ + .. Licensed to the Apache Software

[GitHub] [airflow] ashb commented on a change in pull request #6515: [AIRFLOW-XXX] GSoD: How to make DAGs production ready

2019-11-22 Thread GitBox
ashb commented on a change in pull request #6515: [AIRFLOW-XXX] GSoD: How to make DAGs production ready URL: https://github.com/apache/airflow/pull/6515#discussion_r349800563 ## File path: docs/best-practices.rst ## @@ -0,0 +1,296 @@ + .. Licensed to the Apache Software

[GitHub] [airflow] ashb commented on a change in pull request #6515: [AIRFLOW-XXX] GSoD: How to make DAGs production ready

2019-11-22 Thread GitBox
ashb commented on a change in pull request #6515: [AIRFLOW-XXX] GSoD: How to make DAGs production ready URL: https://github.com/apache/airflow/pull/6515#discussion_r349801887 ## File path: docs/best-practices.rst ## @@ -0,0 +1,296 @@ + .. Licensed to the Apache Software

[GitHub] [airflow] codecov-io commented on issue #6642: [AIRFLOW-6046] Fix Alembic migrations & sync it to 1.10.*

2019-11-22 Thread GitBox
codecov-io commented on issue #6642: [AIRFLOW-6046] Fix Alembic migrations & sync it to 1.10.* URL: https://github.com/apache/airflow/pull/6642#issuecomment-557701476 # [Codecov](https://codecov.io/gh/apache/airflow/pull/6642?src=pr=h1) Report > Merging

[GitHub] [airflow] potiuk commented on a change in pull request #6601: [AIRFLOW-6010] Remove cyclic imports and pylint disables

2019-11-22 Thread GitBox
potiuk commented on a change in pull request #6601: [AIRFLOW-6010] Remove cyclic imports and pylint disables URL: https://github.com/apache/airflow/pull/6601#discussion_r349801707 ## File path: airflow/utils/db.py ## @@ -336,6 +336,8 @@ def resetdb(): Clear out the

[GitHub] [airflow] potiuk commented on a change in pull request #6601: [AIRFLOW-6010] Remove cyclic imports and pylint disables

2019-11-22 Thread GitBox
potiuk commented on a change in pull request #6601: [AIRFLOW-6010] Remove cyclic imports and pylint disables URL: https://github.com/apache/airflow/pull/6601#discussion_r349801488 ## File path: airflow/utils/db.py ## @@ -336,6 +336,8 @@ def resetdb(): Clear out the

[GitHub] [airflow] potiuk commented on a change in pull request #6601: [AIRFLOW-6010] Remove cyclic imports and pylint disables

2019-11-22 Thread GitBox
potiuk commented on a change in pull request #6601: [AIRFLOW-6010] Remove cyclic imports and pylint disables URL: https://github.com/apache/airflow/pull/6601#discussion_r349799576 ## File path: airflow/serialization/serialized_dag.py ## @@ -111,27 +95,26 @@ def

[GitHub] [airflow] potiuk commented on a change in pull request #6601: [AIRFLOW-6010] Remove cyclic imports and pylint disables

2019-11-22 Thread GitBox
potiuk commented on a change in pull request #6601: [AIRFLOW-6010] Remove cyclic imports and pylint disables URL: https://github.com/apache/airflow/pull/6601#discussion_r349799060 ## File path: airflow/serialization/serialization_base.py ## @@ -43,8 +44,8 @@ FAILED =

[GitHub] [airflow] potiuk commented on a change in pull request #6601: [AIRFLOW-6010] Remove cyclic imports and pylint disables

2019-11-22 Thread GitBox
potiuk commented on a change in pull request #6601: [AIRFLOW-6010] Remove cyclic imports and pylint disables URL: https://github.com/apache/airflow/pull/6601#discussion_r349799131 ## File path: airflow/serialization/serialized_baseoperator.py ## @@ -66,34 +66,13 @@ def

[GitHub] [airflow] potiuk commented on a change in pull request #6601: [AIRFLOW-6010] Remove cyclic imports and pylint disables

2019-11-22 Thread GitBox
potiuk commented on a change in pull request #6601: [AIRFLOW-6010] Remove cyclic imports and pylint disables URL: https://github.com/apache/airflow/pull/6601#discussion_r349796698 ## File path: airflow/models/baseoperator.py ## @@ -393,27 +390,28 @@ def __init__(

[GitHub] [airflow] ashb commented on a change in pull request #6295: [AIRFLOW-XXX] GSoD: Adding Task re-run documentation

2019-11-22 Thread GitBox
ashb commented on a change in pull request #6295: [AIRFLOW-XXX] GSoD: Adding Task re-run documentation URL: https://github.com/apache/airflow/pull/6295#discussion_r349796135 ## File path: docs/dag-run.rst ## @@ -0,0 +1,197 @@ + .. Licensed to the Apache Software

[GitHub] [airflow] ashb commented on a change in pull request #6295: [AIRFLOW-XXX] GSoD: Adding Task re-run documentation

2019-11-22 Thread GitBox
ashb commented on a change in pull request #6295: [AIRFLOW-XXX] GSoD: Adding Task re-run documentation URL: https://github.com/apache/airflow/pull/6295#discussion_r349795840 ## File path: docs/dag-run.rst ## @@ -0,0 +1,197 @@ + .. Licensed to the Apache Software

[GitHub] [airflow] ashb commented on a change in pull request #6295: [AIRFLOW-XXX] GSoD: Adding Task re-run documentation

2019-11-22 Thread GitBox
ashb commented on a change in pull request #6295: [AIRFLOW-XXX] GSoD: Adding Task re-run documentation URL: https://github.com/apache/airflow/pull/6295#discussion_r349795364 ## File path: docs/scheduler.rst ## @@ -32,161 +30,31 @@ Airflow production environment. To kick

[GitHub] [airflow] ashb commented on a change in pull request #6295: [AIRFLOW-XXX] GSoD: Adding Task re-run documentation

2019-11-22 Thread GitBox
ashb commented on a change in pull request #6295: [AIRFLOW-XXX] GSoD: Adding Task re-run documentation URL: https://github.com/apache/airflow/pull/6295#discussion_r349795064 ## File path: docs/scheduler.rst ## @@ -32,161 +30,31 @@ Airflow production environment. To kick

[GitHub] [airflow] potiuk commented on a change in pull request #6601: [AIRFLOW-6010] Remove cyclic imports and pylint disables

2019-11-22 Thread GitBox
potiuk commented on a change in pull request #6601: [AIRFLOW-6010] Remove cyclic imports and pylint disables URL: https://github.com/apache/airflow/pull/6601#discussion_r349794337 ## File path: airflow/models/baseoperator.py ## @@ -298,7 +294,7 @@ def __init__(

[GitHub] [airflow] potiuk commented on a change in pull request #6601: [AIRFLOW-6010] Remove cyclic imports and pylint disables

2019-11-22 Thread GitBox
potiuk commented on a change in pull request #6601: [AIRFLOW-6010] Remove cyclic imports and pylint disables URL: https://github.com/apache/airflow/pull/6601#discussion_r349792003 ## File path: airflow/models/baseoperator.py ## @@ -281,7 +277,7 @@ class derived from this

[GitHub] [airflow] potiuk commented on a change in pull request #6601: [AIRFLOW-6010] Remove cyclic imports and pylint disables

2019-11-22 Thread GitBox
potiuk commented on a change in pull request #6601: [AIRFLOW-6010] Remove cyclic imports and pylint disables URL: https://github.com/apache/airflow/pull/6601#discussion_r349790556 ## File path: airflow/models/baseoperator.py ## @@ -235,29 +234,26 @@ class derived from

[GitHub] [airflow] kaxil commented on issue #6642: [AIRFLOW-6046] Fix Alembic migrations & sync it to 1.10.*

2019-11-22 Thread GitBox
kaxil commented on issue #6642: [AIRFLOW-6046] Fix Alembic migrations & sync it to 1.10.* URL: https://github.com/apache/airflow/pull/6642#issuecomment-557690556 > OK, I managed to test it. Using the same approach with running alembic directly. Looks good to me. Thanks for

[GitHub] [airflow] potiuk commented on a change in pull request #6601: [AIRFLOW-6010] Remove cyclic imports and pylint disables

2019-11-22 Thread GitBox
potiuk commented on a change in pull request #6601: [AIRFLOW-6010] Remove cyclic imports and pylint disables URL: https://github.com/apache/airflow/pull/6601#discussion_r349789507 ## File path: airflow/models/baseoperator.py ## @@ -235,29 +234,26 @@ class derived from

[GitHub] [airflow] mattinbits commented on issue #6642: [AIRFLOW-6046] Fix Alembic migrations & sync it to 1.10.*

2019-11-22 Thread GitBox
mattinbits commented on issue #6642: [AIRFLOW-6046] Fix Alembic migrations & sync it to 1.10.* URL: https://github.com/apache/airflow/pull/6642#issuecomment-557683642 OK, I managed to test it. Using the same approach with running alembic directly. Looks good to me.

[GitHub] [airflow-site] kgabryje opened a new pull request #188: set hollow button background to white

2019-11-22 Thread GitBox
kgabryje opened a new pull request #188: set hollow button background to white URL: https://github.com/apache/airflow-site/pull/188 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [airflow] kaxil commented on issue #5079: [AIRFLOW-4285] Update task dependency context defination and usage

2019-11-22 Thread GitBox
kaxil commented on issue #5079: [AIRFLOW-4285] Update task dependency context defination and usage URL: https://github.com/apache/airflow/pull/5079#issuecomment-557674309 I get the following error when I try to click on the Task of a new DAG that has not yet run: ```

[jira] [Comment Edited] (AIRFLOW-6040) Airflow scheduler with kubernetes executor fails :- Unknown error in KubernetesJobWatcher

2019-11-22 Thread Max (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-6040?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16980186#comment-16980186 ] Max edited comment on AIRFLOW-6040 at 11/22/19 7:15 PM: We ran into this same

[GitHub] [airflow] kaxil commented on issue #6352: [AIRFLOW-5683] Add propagate_skipped_state to SubDagOperator

2019-11-22 Thread GitBox
kaxil commented on issue #6352: [AIRFLOW-5683] Add propagate_skipped_state to SubDagOperator URL: https://github.com/apache/airflow/pull/6352#issuecomment-557651366 Hmm yes and no. I am just being skeptical as this implementation change can cause currently unknown errors. It may work

[GitHub] [airflow] milton0825 edited a comment on issue #6352: [AIRFLOW-5683] Add propagate_skipped_state to SubDagOperator

2019-11-22 Thread GitBox
milton0825 edited a comment on issue #6352: [AIRFLOW-5683] Add propagate_skipped_state to SubDagOperator URL: https://github.com/apache/airflow/pull/6352#issuecomment-557650379 The change to the interface of `SubDagOperator` is a breaking change since we no longer provide the type

[GitHub] [airflow] milton0825 commented on issue #6352: [AIRFLOW-5683] Add propagate_skipped_state to SubDagOperator

2019-11-22 Thread GitBox
milton0825 commented on issue #6352: [AIRFLOW-5683] Add propagate_skipped_state to SubDagOperator URL: https://github.com/apache/airflow/pull/6352#issuecomment-557650379 The change to the interface of `SubDagOperator` is a breaking change since we no longer provide the type `executors`.

[GitHub] [airflow] kaxil commented on issue #6392: [AIRFLOW-5648] Add ClearTaskOperator for clearing tasks in a DAG

2019-11-22 Thread GitBox
kaxil commented on issue #6392: [AIRFLOW-5648] Add ClearTaskOperator for clearing tasks in a DAG URL: https://github.com/apache/airflow/pull/6392#issuecomment-557644040 Thanks @yuqian90 will definitely look at it over the weekend or next week.

[GitHub] [airflow] kaxil commented on issue #6352: [AIRFLOW-5683] Add propagate_skipped_state to SubDagOperator

2019-11-22 Thread GitBox
kaxil commented on issue #6352: [AIRFLOW-5683] Add propagate_skipped_state to SubDagOperator URL: https://github.com/apache/airflow/pull/6352#issuecomment-557643598 Include 5498 in 1.10.* would be a big change in behavior. Ideally, it would be good to somehow backport this to v1-10-*

[GitHub] [airflow] mattinbits commented on issue #6642: [AIRFLOW-6046] Fix Alembic migrations & sync it to 1.10.*

2019-11-22 Thread GitBox
mattinbits commented on issue #6642: [AIRFLOW-6046] Fix Alembic migrations & sync it to 1.10.* URL: https://github.com/apache/airflow/pull/6642#issuecomment-557642054 I can but unfortunately it might take a few days- I was testing this in the office and will be back there Tuesday

[GitHub] [airflow] drexpp commented on issue #6635: [AIRFLOW-6033] Fix UI Crash at "Landing Times" when change task_id wi…

2019-11-22 Thread GitBox
drexpp commented on issue #6635: [AIRFLOW-6033] Fix UI Crash at "Landing Times" when change task_id wi… URL: https://github.com/apache/airflow/pull/6635#issuecomment-557641694 The given error is quite weird ``` 44) FAIL: test_heartbeat_failed_fast

[GitHub] [airflow] kaxil edited a comment on issue #6642: [AIRFLOW-6046] Fix Alembic migrations & sync it to 1.10.*

2019-11-22 Thread GitBox
kaxil edited a comment on issue #6642: [AIRFLOW-6046] Fix Alembic migrations & sync it to 1.10.* URL: https://github.com/apache/airflow/pull/6642#issuecomment-557640161 I have tested it with: ```bash mkdir airflow_templ export AIRFLOW_HOME=~/airflow_templ mkvirtualenv

[GitHub] [airflow] kaxil edited a comment on issue #6642: [AIRFLOW-6046] Fix Alembic migrations & sync it to 1.10.*

2019-11-22 Thread GitBox
kaxil edited a comment on issue #6642: [AIRFLOW-6046] Fix Alembic migrations & sync it to 1.10.* URL: https://github.com/apache/airflow/pull/6642#issuecomment-557640161 I have tested it with: ```bash mkdir airflow_templ export AIRFLOW_HOME=~/airflow_templ mkvirtualenv

[GitHub] [airflow] kaxil commented on issue #6642: [AIRFLOW-6046] Fix Alembic migrations & sync it to 1.10.*

2019-11-22 Thread GitBox
kaxil commented on issue #6642: [AIRFLOW-6046] Fix Alembic migrations & sync it to 1.10.* URL: https://github.com/apache/airflow/pull/6642#issuecomment-557640161 I have tested it with: ``` mkdir airflow_templ export AIRFLOW_HOME=~/airflow_templ mkvirtualenv airflow_templ

  1   2   3   >