[GitHub] [airflow] ashb opened a new pull request #7534: [AIRFLOW-6867] Fix bug in kill zombies

2020-02-25 Thread GitBox
ashb opened a new pull request #7534: [AIRFLOW-6867] Fix bug in kill zombies URL: https://github.com/apache/airflow/pull/7534 The refactor in #7488 introduced a scheduler-breaking bug. I am not happy about merging this without a unit test to stop it breaking again, but given how

[GitHub] [airflow] codecov-io edited a comment on issue #7527: [AIRFLOW-6907] Simplify SchedulerJob

2020-02-25 Thread GitBox
codecov-io edited a comment on issue #7527: [AIRFLOW-6907] Simplify SchedulerJob URL: https://github.com/apache/airflow/pull/7527#issuecomment-590717059 # [Codecov](https://codecov.io/gh/apache/airflow/pull/7527?src=pr=h1) Report > :exclamation: No coverage uploaded for pull request

[GitHub] [airflow] yustoris commented on issue #6337: [AIRFLOW-5659] - Add support for ephemeral storage on KubernetesPodOp…

2020-02-25 Thread GitBox
yustoris commented on issue #6337: [AIRFLOW-5659] - Add support for ephemeral storage on KubernetesPodOp… URL: https://github.com/apache/airflow/pull/6337#issuecomment-590856588 Is any progress? This is an automated message

[GitHub] [airflow] stale[bot] commented on issue #6375: [AIRFLOW-5706] Add KubernetesPodYamlOperator

2020-02-25 Thread GitBox
stale[bot] commented on issue #6375: [AIRFLOW-5706] Add KubernetesPodYamlOperator URL: https://github.com/apache/airflow/pull/6375#issuecomment-590854881 This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity

[GitHub] [airflow] ashb commented on a change in pull request #7527: [AIRFLOW-6907] Simplify SchedulerJob

2020-02-25 Thread GitBox
ashb commented on a change in pull request #7527: [AIRFLOW-6907] Simplify SchedulerJob URL: https://github.com/apache/airflow/pull/7527#discussion_r383838670 ## File path: airflow/jobs/scheduler_job.py ## @@ -1098,37 +1094,20 @@ def _find_executable_task_instances(self,

[GitHub] [airflow] ashb commented on issue #7484: [AIRFLOW-6864] Make airflow/jobs pylint compatible

2020-02-25 Thread GitBox
ashb commented on issue #7484: [AIRFLOW-6864] Make airflow/jobs pylint compatible URL: https://github.com/apache/airflow/pull/7484#issuecomment-590834990 @nuclearpinguin See https://github.com/apache/airflow/pull/7527/files#r383812108 -- this is my only outstanding query about this PR.

[GitHub] [airflow] mik-laj commented on a change in pull request #7527: [AIRFLOW-6907] Simplify SchedulerJob

2020-02-25 Thread GitBox
mik-laj commented on a change in pull request #7527: [AIRFLOW-6907] Simplify SchedulerJob URL: https://github.com/apache/airflow/pull/7527#discussion_r383830531 ## File path: airflow/providers/google/cloud/hooks/stackdriver.py ## @@ -29,7 +29,7 @@ from

[jira] [Created] (AIRFLOW-6913) CLONE - Allow filtering by all columns in Browse Logs view

2020-02-25 Thread Ebrima Jallow (Jira)
Ebrima Jallow created AIRFLOW-6913: -- Summary: CLONE - Allow filtering by all columns in Browse Logs view Key: AIRFLOW-6913 URL: https://issues.apache.org/jira/browse/AIRFLOW-6913 Project: Apache

[GitHub] [airflow] mik-laj commented on a change in pull request #7527: [AIRFLOW-6907] Simplify SchedulerJob

2020-02-25 Thread GitBox
mik-laj commented on a change in pull request #7527: [AIRFLOW-6907] Simplify SchedulerJob URL: https://github.com/apache/airflow/pull/7527#discussion_r383821345 ## File path: airflow/jobs/scheduler_job.py ## @@ -1098,37 +1094,20 @@ def

[GitHub] [airflow] mik-laj commented on a change in pull request #7527: [AIRFLOW-6907] Simplify SchedulerJob

2020-02-25 Thread GitBox
mik-laj commented on a change in pull request #7527: [AIRFLOW-6907] Simplify SchedulerJob URL: https://github.com/apache/airflow/pull/7527#discussion_r383821345 ## File path: airflow/jobs/scheduler_job.py ## @@ -1098,37 +1094,20 @@ def

[GitHub] [airflow] mik-laj commented on a change in pull request #7489: [AIRFLOW-6869][WIP] Bulk fetch DAGRuns for _process_task_instances

2020-02-25 Thread GitBox
mik-laj commented on a change in pull request #7489: [AIRFLOW-6869][WIP] Bulk fetch DAGRuns for _process_task_instances URL: https://github.com/apache/airflow/pull/7489#discussion_r383814846 ## File path: airflow/jobs/scheduler_job.py ## @@ -631,16 +632,16 @@ def

[GitHub] [airflow] mik-laj commented on a change in pull request #7489: [AIRFLOW-6869][WIP] Bulk fetch DAGRuns for _process_task_instances

2020-02-25 Thread GitBox
mik-laj commented on a change in pull request #7489: [AIRFLOW-6869][WIP] Bulk fetch DAGRuns for _process_task_instances URL: https://github.com/apache/airflow/pull/7489#discussion_r383814563 ## File path: airflow/models/dagrun.py ## @@ -125,14 +125,16 @@ def

[GitHub] [airflow] ashb commented on a change in pull request #7527: [AIRFLOW-6907] Simplify SchedulerJob

2020-02-25 Thread GitBox
ashb commented on a change in pull request #7527: [AIRFLOW-6907] Simplify SchedulerJob URL: https://github.com/apache/airflow/pull/7527#discussion_r383813867 ## File path: airflow/providers/google/cloud/hooks/stackdriver.py ## @@ -29,7 +29,7 @@ from

[GitHub] [airflow] mik-laj commented on a change in pull request #7481: [AIRFLOW-6862][WIP] Do not check the freshness of fresh DAG

2020-02-25 Thread GitBox
mik-laj commented on a change in pull request #7481: [AIRFLOW-6862][WIP] Do not check the freshness of fresh DAG URL: https://github.com/apache/airflow/pull/7481#discussion_r383813761 ## File path: tests/jobs/test_scheduler_job.py ## @@ -1010,7 +1010,7 @@ def

[GitHub] [airflow] ashb commented on a change in pull request #7527: [AIRFLOW-6907] Simplify SchedulerJob

2020-02-25 Thread GitBox
ashb commented on a change in pull request #7527: [AIRFLOW-6907] Simplify SchedulerJob URL: https://github.com/apache/airflow/pull/7527#discussion_r383813377 ## File path: airflow/providers/google/cloud/hooks/stackdriver.py ## @@ -29,7 +29,7 @@ from

[GitHub] [airflow] ashb commented on a change in pull request #7527: [AIRFLOW-6907] Simplify SchedulerJob

2020-02-25 Thread GitBox
ashb commented on a change in pull request #7527: [AIRFLOW-6907] Simplify SchedulerJob URL: https://github.com/apache/airflow/pull/7527#discussion_r383812108 ## File path: airflow/jobs/scheduler_job.py ## @@ -1098,37 +1094,20 @@ def _find_executable_task_instances(self,

[GitHub] [airflow] mik-laj commented on issue #7533: [AIRFLOW-5485] - scheduler_job: replace == None with is

2020-02-25 Thread GitBox
mik-laj commented on issue #7533: [AIRFLOW-5485] - scheduler_job: replace == None with is URL: https://github.com/apache/airflow/pull/7533#issuecomment-590812592 I did it earlier in this PR: https://github.com/apache/airflow/pull/7527

[jira] [Resolved] (AIRFLOW-5924) Automatically unify bucket name and key in S3Hook

2020-02-25 Thread Felix Uellendall (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5924?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Felix Uellendall resolved AIRFLOW-5924. --- Resolution: Fixed > Automatically unify bucket name and key in S3Hook >

[jira] [Commented] (AIRFLOW-5924) Automatically unify bucket name and key in S3Hook

2020-02-25 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17044316#comment-17044316 ] ASF subversion and git services commented on AIRFLOW-5924: -- Commit

[jira] [Commented] (AIRFLOW-5924) Automatically unify bucket name and key in S3Hook

2020-02-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17044315#comment-17044315 ] ASF GitHub Bot commented on AIRFLOW-5924: - feluelle commented on pull request #6574:

[GitHub] [airflow] feluelle merged pull request #6574: [AIRFLOW-5924] Automatically unify bucket name and key in S3Hook

2020-02-25 Thread GitBox
feluelle merged pull request #6574: [AIRFLOW-5924] Automatically unify bucket name and key in S3Hook URL: https://github.com/apache/airflow/pull/6574 This is an automated message from the Apache Git Service. To respond to

[GitHub] [airflow] ashb commented on issue #7269: [AIRFLOW-6651] Add Redis Heartbeat option

2020-02-25 Thread GitBox
ashb commented on issue #7269: [AIRFLOW-6651] Add Redis Heartbeat option URL: https://github.com/apache/airflow/pull/7269#issuecomment-590800040 A question: Have you looked to see if this feature is built in to celery? Is it possible we could rely on celery more for this?

[GitHub] [airflow] ashb commented on issue #7269: [AIRFLOW-6651] Add Redis Heartbeat option

2020-02-25 Thread GitBox
ashb commented on issue #7269: [AIRFLOW-6651] Add Redis Heartbeat option URL: https://github.com/apache/airflow/pull/7269#issuecomment-590799186 I can see this being useful so long as it does actually reduce DB load/active connections :)

[GitHub] [airflow] codecov-io edited a comment on issue #6574: [AIRFLOW-5924] Automatically unify bucket name and key in S3Hook

2020-02-25 Thread GitBox
codecov-io edited a comment on issue #6574: [AIRFLOW-5924] Automatically unify bucket name and key in S3Hook URL: https://github.com/apache/airflow/pull/6574#issuecomment-553548307 # [Codecov](https://codecov.io/gh/apache/airflow/pull/6574?src=pr=h1) Report > Merging

[GitHub] [airflow] feluelle commented on issue #6576: [AIRFLOW-5922] Add option to specify the mysql client library used in MySqlHook

2020-02-25 Thread GitBox
feluelle commented on issue #6576: [AIRFLOW-5922] Add option to specify the mysql client library used in MySqlHook URL: https://github.com/apache/airflow/pull/6576#issuecomment-590781661 I did rebase. I will investigate the issue further when I have more time for it :)

[GitHub] [airflow] nuclearpinguin commented on issue #7484: [AIRFLOW-6864] Make airflow/jobs pylint compatible

2020-02-25 Thread GitBox
nuclearpinguin commented on issue #7484: [AIRFLOW-6864] Make airflow/jobs pylint compatible URL: https://github.com/apache/airflow/pull/7484#issuecomment-590767204 @kaxil @potiuk @mik-laj @ashb are we good to go? This is an

[jira] [Commented] (AIRFLOW-659) Automatic Refresh on DAG Graph View

2020-02-25 Thread Ashley Collins (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17044279#comment-17044279 ] Ashley Collins commented on AIRFLOW-659: I would also like this feature. I was thinking of

[GitHub] [airflow] nuclearpinguin commented on issue #6371: [AIRFLOW-5691] Rewrite Dataproc operators to use python library

2020-02-25 Thread GitBox
nuclearpinguin commented on issue #6371: [AIRFLOW-5691] Rewrite Dataproc operators to use python library URL: https://github.com/apache/airflow/pull/6371#issuecomment-590757917 There's a JIRA: https://issues.apache.org/jira/browse/AIRFLOW-5691 No change was intentional. Also, this

[GitHub] [airflow] blcksrx commented on issue #7422: [AIRFLOW-6809] Test for presto operators

2020-02-25 Thread GitBox
blcksrx commented on issue #7422: [AIRFLOW-6809] Test for presto operators URL: https://github.com/apache/airflow/pull/7422#issuecomment-590757616 > Flake8 errors: > > ``` > tests/providers/apache/hive/operators/test_hive.py:156:14: F821 undefined name 'HdfsSensor' >

[GitHub] [airflow] codecov-io edited a comment on issue #7484: [AIRFLOW-6864] Make airflow/jobs pylint compatible

2020-02-25 Thread GitBox
codecov-io edited a comment on issue #7484: [AIRFLOW-6864] Make airflow/jobs pylint compatible URL: https://github.com/apache/airflow/pull/7484#issuecomment-590051665 # [Codecov](https://codecov.io/gh/apache/airflow/pull/7484?src=pr=h1) Report > :exclamation: No coverage uploaded for

[GitHub] [airflow] Fokko commented on issue #7533: [AIRFLOW-5485] - scheduler_job: replace == None with is

2020-02-25 Thread GitBox
Fokko commented on issue #7533: [AIRFLOW-5485] - scheduler_job: replace == None with is URL: https://github.com/apache/airflow/pull/7533#issuecomment-590755676 Thanks @saurabhdhupar for the contribution. Let's wait for the CI.

[GitHub] [airflow] Fokko commented on a change in pull request #7533: [AIRFLOW-5485] - scheduler_job: replace == None with is

2020-02-25 Thread GitBox
Fokko commented on a change in pull request #7533: [AIRFLOW-5485] - scheduler_job: replace == None with is URL: https://github.com/apache/airflow/pull/7533#discussion_r383736315 ## File path: airflow/jobs/scheduler_job.py ## @@ -915,7 +915,7 @@ class

[GitHub] [airflow] Fokko commented on a change in pull request #7533: [AIRFLOW-5485] - scheduler_job: replace == None with is

2020-02-25 Thread GitBox
Fokko commented on a change in pull request #7533: [AIRFLOW-5485] - scheduler_job: replace == None with is URL: https://github.com/apache/airflow/pull/7533#discussion_r383736315 ## File path: airflow/jobs/scheduler_job.py ## @@ -915,7 +915,7 @@ class

[jira] [Commented] (AIRFLOW-6815) Dag Graph View Javascript Error

2020-02-25 Thread Ashley Collins (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-6815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17044246#comment-17044246 ] Ashley Collins commented on AIRFLOW-6815: - We saw the same thing when Chrome was upgraded to

[jira] [Resolved] (AIRFLOW-6909) Prepare backport packages on post-test stage

2020-02-25 Thread Tomasz Urbaszek (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-6909?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tomasz Urbaszek resolved AIRFLOW-6909. -- Fix Version/s: 1.10.10 Resolution: Done > Prepare backport packages on

[jira] [Commented] (AIRFLOW-6909) Prepare backport packages on post-test stage

2020-02-25 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-6909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17044237#comment-17044237 ] ASF subversion and git services commented on AIRFLOW-6909: -- Commit

[jira] [Commented] (AIRFLOW-6909) Prepare backport packages on post-test stage

2020-02-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-6909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17044236#comment-17044236 ] ASF GitHub Bot commented on AIRFLOW-6909: - nuclearpinguin commented on pull request #7529:

[GitHub] [airflow] nuclearpinguin merged pull request #7529: [AIRFLOW-6909] Prepare backport packages on post-test stage

2020-02-25 Thread GitBox
nuclearpinguin merged pull request #7529: [AIRFLOW-6909] Prepare backport packages on post-test stage URL: https://github.com/apache/airflow/pull/7529 This is an automated message from the Apache Git Service. To respond to

[jira] [Comment Edited] (AIRFLOW-5071) Thousand os Executor reports task instance X finished (success) although the task says its queued. Was the task killed externally?

2020-02-25 Thread Adam Angeli (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17044214#comment-17044214 ] Adam Angeli edited comment on AIRFLOW-5071 at 2/25/20 8:24 AM: --- Another

[jira] [Comment Edited] (AIRFLOW-5071) Thousand os Executor reports task instance X finished (success) although the task says its queued. Was the task killed externally?

2020-02-25 Thread Adam Angeli (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17044214#comment-17044214 ] Adam Angeli edited comment on AIRFLOW-5071 at 2/25/20 8:20 AM: --- Another

[GitHub] [airflow] saurabhdhupar opened a new pull request #7533: Fix for Airflow 5485

2020-02-25 Thread GitBox
saurabhdhupar opened a new pull request #7533: Fix for Airflow 5485 URL: https://github.com/apache/airflow/pull/7533 --- Issue link: WILL BE INSERTED BY [boring-cyborg](https://github.com/kaxil/boring-cyborg) Make sure to mark the boxes below before creating PR: [x] - [x ]

[jira] [Comment Edited] (AIRFLOW-5071) Thousand os Executor reports task instance X finished (success) although the task says its queued. Was the task killed externally?

2020-02-25 Thread Adam Angeli (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17044214#comment-17044214 ] Adam Angeli edited comment on AIRFLOW-5071 at 2/25/20 8:16 AM: --- Another

[jira] [Commented] (AIRFLOW-5071) Thousand os Executor reports task instance X finished (success) although the task says its queued. Was the task killed externally?

2020-02-25 Thread Adam Angeli (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17044214#comment-17044214 ] Adam Angeli commented on AIRFLOW-5071: -- Another variant of this involves {{_executeHelper}} from

[GitHub] [airflow] kaxil merged pull request #7530: [AIRFLOW-XXXX] Update docs on starting Kubernetes tests

2020-02-25 Thread GitBox
kaxil merged pull request #7530: [AIRFLOW-] Update docs on starting Kubernetes tests URL: https://github.com/apache/airflow/pull/7530 This is an automated message from the Apache Git Service. To respond to the message,

<    1   2   3