[GitHub] [airflow] mik-laj commented on a change in pull request #8267: Less aggressive eager upgrade of requirements

2020-04-13 Thread GitBox
mik-laj commented on a change in pull request #8267: Less aggressive eager upgrade of requirements URL: https://github.com/apache/airflow/pull/8267#discussion_r407572370 ## File path: scripts/ci/in_container/run_generate_requirements.sh ## @@ -23,6 +23,20 @@ HANDLERS="$(

[jira] [Resolved] (AIRFLOW-5308) Pass credentials object to pandas_gbq

2020-04-13 Thread Kamil Bregula (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5308?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kamil Bregula resolved AIRFLOW-5308. Fix Version/s: 2.0.0 Resolution: Fixed > Pass credentials object to pandas_gbq >

[jira] [Reopened] (AIRFLOW-5308) Pass credentials object to pandas_gbq

2020-04-13 Thread Kamil Bregula (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5308?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kamil Bregula reopened AIRFLOW-5308: > Pass credentials object to pandas_gbq > - > >

[GitHub] [airflow] mik-laj edited a comment on issue #8171: Handle missing object in webserver

2020-04-13 Thread GitBox
mik-laj edited a comment on issue #8171: Handle missing object in webserver URL: https://github.com/apache/airflow/issues/8171#issuecomment-612943432 For clarity. This contribution does not have to solve all problems in one PR. I will be happy even if one problem is solved. And another

[GitHub] [airflow] mik-laj commented on issue #8171: Handle missing object in webserver

2020-04-13 Thread GitBox
mik-laj commented on issue #8171: Handle missing object in webserver URL: https://github.com/apache/airflow/issues/8171#issuecomment-612943432 For clarity. This contribution does not have to solve all problems in one PR. I will be happy even if one problem is solved. And another person

[GitHub] [airflow] boittega commented on issue #8246: Docs: LatestOnlyOperator documentation is misleading

2020-04-13 Thread GitBox
boittega commented on issue #8246: Docs: LatestOnlyOperator documentation is misleading URL: https://github.com/apache/airflow/issues/8246#issuecomment-612942051 The documentation has being updated fixing the confusions, the code in the documentation is also out of date, the new dag has

[GitHub] [airflow] boittega opened a new pull request #8268: Update the tree view of dag on Concepts Last Run Only

2020-04-13 Thread GitBox
boittega opened a new pull request #8268: Update the tree view of dag on Concepts Last Run Only URL: https://github.com/apache/airflow/pull/8268 The tree view on Concepts -> Last Run Only documentation (https://airflow.apache.org/docs/stable/concepts.html#latest-run-only) was showing

[GitHub] [airflow] boring-cyborg[bot] commented on issue #8268: Update the tree view of dag on Concepts Last Run Only

2020-04-13 Thread GitBox
boring-cyborg[bot] commented on issue #8268: Update the tree view of dag on Concepts Last Run Only URL: https://github.com/apache/airflow/pull/8268#issuecomment-612941573 Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are

[GitHub] [airflow] mik-laj commented on issue #8171: Handle missing object in webserver

2020-04-13 Thread GitBox
mik-laj commented on issue #8171: Handle missing object in webserver URL: https://github.com/apache/airflow/issues/8171#issuecomment-612939805 It should be something similar. The most important thing is that no mushrooms appear, but user-readable error messages. For example: When

[GitHub] [airflow] alexandraabbas commented on issue #8200: Create guide for BigQuery operators

2020-04-13 Thread GitBox
alexandraabbas commented on issue #8200: Create guide for BigQuery operators URL: https://github.com/apache/airflow/issues/8200#issuecomment-612936209 @mik-laj Please, assign the ticket to me, thanks! This is an automated

[GitHub] [airflow] mik-laj commented on issue #8213: Fix issue #8163 where gcp auth fails

2020-04-13 Thread GitBox
mik-laj commented on issue #8213: Fix issue #8163 where gcp auth fails URL: https://github.com/apache/airflow/pull/8213#issuecomment-612932944 @iamshwin Travis is working again. Can you fix errors? This is an automated

[GitHub] [airflow] mik-laj edited a comment on issue #8213: Fix issue #8163 where gcp auth fails

2020-04-13 Thread GitBox
mik-laj edited a comment on issue #8213: Fix issue #8163 where gcp auth fails URL: https://github.com/apache/airflow/pull/8213#issuecomment-612932944 @iamshwin Travis is working again. Can you fix errors, please? This is an

[GitHub] [airflow] dferguson992 commented on issue #7407: [AIRFLOW-6786] Add KafkaConsumerHook, KafkaProduerHook and KafkaSensor

2020-04-13 Thread GitBox
dferguson992 commented on issue #7407: [AIRFLOW-6786] Add KafkaConsumerHook, KafkaProduerHook and KafkaSensor URL: https://github.com/apache/airflow/pull/7407#issuecomment-612929452 > Hi, @dferguson992, I'm having similar needs related to airflow-kafka. May I try to help you with this

[GitHub] [airflow] mik-laj commented on issue #8107: AIP-32 - Airflow REST API - High-level info

2020-04-13 Thread GitBox
mik-laj commented on issue #8107: AIP-32 - Airflow REST API - High-level info URL: https://github.com/apache/airflow/issues/8107#issuecomment-612925322 Continuation of the API discussion.

[GitHub] [airflow] zachliu commented on a change in pull request #6007: [AIRFLOW-2310] Enable AWS Glue Job Integration

2020-04-13 Thread GitBox
zachliu commented on a change in pull request #6007: [AIRFLOW-2310] Enable AWS Glue Job Integration URL: https://github.com/apache/airflow/pull/6007#discussion_r407476975 ## File path: airflow/providers/amazon/aws/operators/glue.py ## @@ -0,0 +1,117 @@ +# -*- coding:

[GitHub] [airflow] zachliu commented on a change in pull request #6007: [AIRFLOW-2310] Enable AWS Glue Job Integration

2020-04-13 Thread GitBox
zachliu commented on a change in pull request #6007: [AIRFLOW-2310] Enable AWS Glue Job Integration URL: https://github.com/apache/airflow/pull/6007#discussion_r407476975 ## File path: airflow/providers/amazon/aws/operators/glue.py ## @@ -0,0 +1,117 @@ +# -*- coding:

[GitHub] [airflow] BasPH commented on issue #8244: Add Option for BashOperator to Set State to SKIPPED

2020-04-13 Thread GitBox
BasPH commented on issue #8244: Add Option for BashOperator to Set State to SKIPPED URL: https://github.com/apache/airflow/pull/8244#issuecomment-612891837 I can imagine this to be useful in certain conditions, but too specific as it is right now. To make it useful for all Airflow

[GitHub] [airflow] potiuk merged pull request #8155: Fix tests and documentation for CLI 'connections add'

2020-04-13 Thread GitBox
potiuk merged pull request #8155: Fix tests and documentation for CLI 'connections add' URL: https://github.com/apache/airflow/pull/8155 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [airflow] boring-cyborg[bot] commented on issue #8155: Fix tests and documentation for CLI 'connections add'

2020-04-13 Thread GitBox
boring-cyborg[bot] commented on issue #8155: Fix tests and documentation for CLI 'connections add' URL: https://github.com/apache/airflow/pull/8155#issuecomment-612887862 Awesome work, congrats on your first merged pull request!

[GitHub] [airflow] potiuk commented on issue #8155: Fix tests and documentation for CLI 'connections add'

2020-04-13 Thread GitBox
potiuk commented on issue #8155: Fix tests and documentation for CLI 'connections add' URL: https://github.com/apache/airflow/pull/8155#issuecomment-612887765 Nice! Thanks @mebelousov ! This is an automated message from the

[GitHub] [airflow] potiuk commented on issue #8005: Use annotated tags for releases?

2020-04-13 Thread GitBox
potiuk commented on issue #8005: Use annotated tags for releases? URL: https://github.com/apache/airflow/issues/8005#issuecomment-612886244 I think we can discuss this as one of the possibilities to use when we discuss how we approach 2.0 versioning and release. WDYT @ashb ?

[GitHub] [airflow] michaelosthege commented on issue #5519: [AIRFLOW-4543] Update slack operator to support slackclient v2

2020-04-13 Thread GitBox
michaelosthege commented on issue #5519: [AIRFLOW-4543] Update slack operator to support slackclient v2 URL: https://github.com/apache/airflow/pull/5519#issuecomment-612877033 With Python 2.x EOL and slackclient 1.x being deprecated for a while now, can this issue be re-opened, @serkef ?

[GitHub] [airflow] stale[bot] commented on issue #6565: [AIRFLOW-5909] Enable mapping to BYTEs type to sql_to_gcs operator

2020-04-13 Thread GitBox
stale[bot] commented on issue #6565: [AIRFLOW-5909] Enable mapping to BYTEs type to sql_to_gcs operator URL: https://github.com/apache/airflow/pull/6565#issuecomment-612870402 This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no

[GitHub] [airflow] ramkrishnan8994 commented on issue #6337: [AIRFLOW-5659] - Add support for ephemeral storage on KubernetesPodOp…

2020-04-13 Thread GitBox
ramkrishnan8994 commented on issue #6337: [AIRFLOW-5659] - Add support for ephemeral storage on KubernetesPodOp… URL: https://github.com/apache/airflow/pull/6337#issuecomment-612870043 > > When will this be added to apache-airflow 1.10.10 pip package. Need this ephemeral storage support

[GitHub] [airflow] waleedsamy commented on issue #8082: [AIRFLOW-4355] removed task should not lead to dagrun success

2020-04-13 Thread GitBox
waleedsamy commented on issue #8082: [AIRFLOW-4355] removed task should not lead to dagrun success URL: https://github.com/apache/airflow/pull/8082#issuecomment-612869509 1+ This is an automated message from the Apache Git

[jira] [Commented] (AIRFLOW-4078) Allow filtering by all columns in Browse Logs view

2020-04-13 Thread Cesar Mauricio (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-4078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17082248#comment-17082248 ] Cesar Mauricio commented on AIRFLOW-4078: - Hi [~pujitha.jaji28], as already mentioned i'm

[GitHub] [airflow] codecov-io edited a comment on issue #8267: Less aggressive eager upgrade of requirements

2020-04-13 Thread GitBox
codecov-io edited a comment on issue #8267: Less aggressive eager upgrade of requirements URL: https://github.com/apache/airflow/pull/8267#issuecomment-612863712 # [Codecov](https://codecov.io/gh/apache/airflow/pull/8267?src=pr=h1) Report > Merging

[GitHub] [airflow] codecov-io edited a comment on issue #8267: Less aggressive eager upgrade of requirements

2020-04-13 Thread GitBox
codecov-io edited a comment on issue #8267: Less aggressive eager upgrade of requirements URL: https://github.com/apache/airflow/pull/8267#issuecomment-612863712 # [Codecov](https://codecov.io/gh/apache/airflow/pull/8267?src=pr=h1) Report > Merging

[GitHub] [airflow] codecov-io commented on issue #8267: Less aggressive eager upgrade of requirements

2020-04-13 Thread GitBox
codecov-io commented on issue #8267: Less aggressive eager upgrade of requirements URL: https://github.com/apache/airflow/pull/8267#issuecomment-612863712 # [Codecov](https://codecov.io/gh/apache/airflow/pull/8267?src=pr=h1) Report > Merging

[GitHub] [airflow] BasPH commented on a change in pull request #8266: Fix non updating DAG code by checking against last modification time

2020-04-13 Thread GitBox
BasPH commented on a change in pull request #8266: Fix non updating DAG code by checking against last modification time URL: https://github.com/apache/airflow/pull/8266#discussion_r407435793 ## File path: airflow/models/dagcode.py ## @@ -124,15 +124,14 @@ def

[GitHub] [airflow] kaxil commented on a change in pull request #8266: Fix non updating DAG code by checking against last modification time

2020-04-13 Thread GitBox
kaxil commented on a change in pull request #8266: Fix non updating DAG code by checking against last modification time URL: https://github.com/apache/airflow/pull/8266#discussion_r407435121 ## File path: airflow/models/dagcode.py ## @@ -124,15 +124,14 @@ def

[GitHub] [airflow] BasPH edited a comment on issue #8266: Fix non updating DAG code by checking against last modification time

2020-04-13 Thread GitBox
BasPH edited a comment on issue #8266: Fix non updating DAG code by checking against last modification time URL: https://github.com/apache/airflow/pull/8266#issuecomment-612859408 Done. If there is a strong reason to only write after a certain interval, we can make it configurable, but

[GitHub] [airflow] BasPH commented on issue #8266: Fix non updating DAG code by checking against last modification time

2020-04-13 Thread GitBox
BasPH commented on issue #8266: Fix non updating DAG code by checking against last modification time URL: https://github.com/apache/airflow/pull/8266#issuecomment-612859408 Done. If there is a strong reason to only write after a certain interval, we can make it configurable, but for now I

[GitHub] [airflow] kaxil commented on issue #8266: Fix non updating DAG code by checking against last modification time

2020-04-13 Thread GitBox
kaxil commented on issue #8266: Fix non updating DAG code by checking against last modification time URL: https://github.com/apache/airflow/pull/8266#issuecomment-612857738 Yeah, I agree. Can you fix the static test please? cc @anitakar Was there a reason for a 120s threshold? Just

[jira] [Assigned] (AIRFLOW-4685) Make airflow/www Pylint compatible

2020-04-13 Thread Jira
[ https://issues.apache.org/jira/browse/AIRFLOW-4685?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexandre Cazé reassigned AIRFLOW-4685: --- Assignee: Alexandre Cazé > Make airflow/www Pylint compatible >

[GitHub] [airflow] rcjsuen commented on issue #8171: Handle missing object in webserver

2020-04-13 Thread GitBox
rcjsuen commented on issue #8171: Handle missing object in webserver URL: https://github.com/apache/airflow/issues/8171#issuecomment-612843205 @mik-laj Hi, what is your expected fix for this issue? Are you looking for something like this? ``` if dag is None: response =

[GitHub] [airflow] stale[bot] commented on issue #7331: [AIRFLOW-6657] Deprecate BaseBranchOperator

2020-04-13 Thread GitBox
stale[bot] commented on issue #7331: [AIRFLOW-6657] Deprecate BaseBranchOperator URL: https://github.com/apache/airflow/pull/7331#issuecomment-612836459 This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity

[GitHub] [airflow] potiuk commented on issue #8008: Custom Facebook Ads Operator

2020-04-13 Thread GitBox
potiuk commented on issue #8008: Custom Facebook Ads Operator URL: https://github.com/apache/airflow/pull/8008#issuecomment-612833979 I think there was a change in MyPy in the meantime and you will have to wait until #8267 is merged (it fixes the problem) and rebase again I am afraid.

[GitHub] [airflow] potiuk opened a new pull request #8267: Less aggressive eager upgrade of requirements

2020-04-13 Thread GitBox
potiuk opened a new pull request #8267: Less aggressive eager upgrade of requirements URL: https://github.com/apache/airflow/pull/8267 With this change requirements are only eagerly upgraded when generating requirements when setup.py changes. They are also eagerly upgraded when you

[GitHub] [airflow] BasPH edited a comment on issue #8266: Fix non updating DAG code by checking against last modification time

2020-04-13 Thread GitBox
BasPH edited a comment on issue #8266: Fix non updating DAG code by checking against last modification time URL: https://github.com/apache/airflow/pull/8266#issuecomment-612806547 > The reason we might want to make this number configurable is so that we don't write to the table more often

[GitHub] [airflow] BasPH commented on issue #8266: Fix non updating DAG code by checking against last modification time

2020-04-13 Thread GitBox
BasPH commented on issue #8266: Fix non updating DAG code by checking against last modification time URL: https://github.com/apache/airflow/pull/8266#issuecomment-612806547 > The reason we might want to make this number configurable is so that we don't write to the table more often than

[GitHub] [airflow] randr97 commented on issue #8008: Custom Facebook Ads Operator

2020-04-13 Thread GitBox
randr97 commented on issue #8008: Custom Facebook Ads Operator URL: https://github.com/apache/airflow/pull/8008#issuecomment-612806356 > Hey @randr97 -> I'd love to merge this one. Can you please rebase and regenerate the requirements? Sure thing, will do

[GitHub] [airflow] potiuk merged pull request #7900: Convert properties with query to real methods

2020-04-13 Thread GitBox
potiuk merged pull request #7900: Convert properties with query to real methods URL: https://github.com/apache/airflow/pull/7900 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [airflow] potiuk commented on issue #8008: Custom Facebook Ads Operator

2020-04-13 Thread GitBox
potiuk commented on issue #8008: Custom Facebook Ads Operator URL: https://github.com/apache/airflow/pull/8008#issuecomment-612794535 Hey @randr97 -> I'd love to merge this one. Can you please rebase and regenerate the requirements?

[GitHub] [airflow] potiuk commented on issue #8145: Drop redundant project id null checks.

2020-04-13 Thread GitBox
potiuk commented on issue #8145: Drop redundant project id null checks. URL: https://github.com/apache/airflow/pull/8145#issuecomment-612794117 Thanks @jmcarp! Great change! This is an automated message from the Apache Git

[GitHub] [airflow] potiuk merged pull request #8145: Drop redundant project id null checks.

2020-04-13 Thread GitBox
potiuk merged pull request #8145: Drop redundant project id null checks. URL: https://github.com/apache/airflow/pull/8145 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [airflow] potiuk merged pull request #8216: Added GoogleDisplayVideo360UploadLineItemsOperator

2020-04-13 Thread GitBox
potiuk merged pull request #8216: Added GoogleDisplayVideo360UploadLineItemsOperator URL: https://github.com/apache/airflow/pull/8216 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [airflow] dhthakkar-apttus removed a comment on issue #6920: [AIRFLOW-6366] Fix migrations for MS SQL Server

2020-04-13 Thread GitBox
dhthakkar-apttus removed a comment on issue #6920: [AIRFLOW-6366] Fix migrations for MS SQL Server URL: https://github.com/apache/airflow/pull/6920#issuecomment-612777515 We are getting same issue again in version 1.10.10.

[GitHub] [airflow] dhthakkar-apttus commented on issue #6920: [AIRFLOW-6366] Fix migrations for MS SQL Server

2020-04-13 Thread GitBox
dhthakkar-apttus commented on issue #6920: [AIRFLOW-6366] Fix migrations for MS SQL Server URL: https://github.com/apache/airflow/pull/6920#issuecomment-612777515 We are getting same issue again in version 1.10.10. This is

[GitHub] [airflow] potiuk merged pull request #8261: Help for breeze commands contain relevant flags.

2020-04-13 Thread GitBox
potiuk merged pull request #8261: Help for breeze commands contain relevant flags. URL: https://github.com/apache/airflow/pull/8261 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [airflow] larryzhu2018 commented on issue #7141: [AIRFLOW-6544] add log_id to end_of_log mark log record

2020-04-13 Thread GitBox
larryzhu2018 commented on issue #7141: [AIRFLOW-6544] add log_id to end_of_log mark log record URL: https://github.com/apache/airflow/pull/7141#issuecomment-612774261 Can you please help to move this forward? This is an

[GitHub] [airflow] larryzhu2018 commented on issue #7141: [AIRFLOW-6544] add log_id to end_of_log mark log record

2020-04-13 Thread GitBox
larryzhu2018 commented on issue #7141: [AIRFLOW-6544] add log_id to end_of_log mark log record URL: https://github.com/apache/airflow/pull/7141#issuecomment-612774103 > Any updates on this? Not sure why, but this seems stuck. Any help wanted? can you please help to move this

<    1   2