[GitHub] [airflow] wittfabian commented on issue #5659: [AIRFLOW-5033] Switched to snakebite-py3

2020-04-14 Thread GitBox
wittfabian commented on issue #5659: [AIRFLOW-5033] Switched to snakebite-py3 URL: https://github.com/apache/airflow/pull/5659#issuecomment-613833088 Is it still planned to switch to PyArrow in the future? We only encounter problems with snakebite in our projects.

[GitHub] [airflow] zhongjiajie edited a comment on issue #7683: [AIRFLOW-7033] Change dag and task state meanwhile

2020-04-14 Thread GitBox
zhongjiajie edited a comment on issue #7683: [AIRFLOW-7033] Change dag and task state meanwhile URL: https://github.com/apache/airflow/pull/7683#issuecomment-613830825 Ok, I will try to * Remove "DAG" button in Task Instance dialog in Graph view * Add task instances in dag run dialog

[GitHub] [airflow] zhongjiajie commented on issue #7683: [AIRFLOW-7033] Change dag and task state meanwhile

2020-04-14 Thread GitBox
zhongjiajie commented on issue #7683: [AIRFLOW-7033] Change dag and task state meanwhile URL: https://github.com/apache/airflow/pull/7683#issuecomment-613831990 And BTW, I alway check DAG view at first, because in big dag with many tasks, I think it's more straightforward about the

[GitHub] [airflow] zhongjiajie commented on issue #7683: [AIRFLOW-7033] Change dag and task state meanwhile

2020-04-14 Thread GitBox
zhongjiajie commented on issue #7683: [AIRFLOW-7033] Change dag and task state meanwhile URL: https://github.com/apache/airflow/pull/7683#issuecomment-613830825 Ok, I will try to * Remove "DAG" button in Task Instance dialog in Graph view * Add task instances in dag run dialog in

[GitHub] [airflow] potiuk opened a new pull request #8314: Production image is now built automatically in Dockerhub

2020-04-14 Thread GitBox
potiuk opened a new pull request #8314: Production image is now built automatically in Dockerhub URL: https://github.com/apache/airflow/pull/8314 --- Make sure to mark the boxes below before creating PR: [x] - [x] Description above provides context of the change - [x] Unit

[GitHub] [airflow] potiuk commented on issue #8184: Upgrade Azure storage blob and Azure file share

2020-04-14 Thread GitBox
potiuk commented on issue #8184: Upgrade Azure storage blob and Azure file share URL: https://github.com/apache/airflow/pull/8184#issuecomment-613824447 Untortunately not (yet). We have been toying with a possibility of adding extra wheel package or adding separate requirements.txt per

[GitHub] [airflow] ramkrishnan8994 edited a comment on issue #6337: [AIRFLOW-5659] - Add support for ephemeral storage on KubernetesPodOp…

2020-04-14 Thread GitBox
ramkrishnan8994 edited a comment on issue #6337: [AIRFLOW-5659] - Add support for ephemeral storage on KubernetesPodOp… URL: https://github.com/apache/airflow/pull/6337#issuecomment-613823396 > > > > When will this be added to apache-airflow 1.10.10 pip package. Need this ephemeral

[GitHub] [airflow] potiuk commented on a change in pull request #8304: [Airflow-5565] Add extra_args param to s3hook

2020-04-14 Thread GitBox
potiuk commented on a change in pull request #8304: [Airflow-5565] Add extra_args param to s3hook URL: https://github.com/apache/airflow/pull/8304#discussion_r408587530 ## File path: airflow/providers/amazon/aws/hooks/s3.py ## @@ -576,19 +578,21 @@ def load_file_obj(self,

[GitHub] [airflow] ramkrishnan8994 commented on issue #6337: [AIRFLOW-5659] - Add support for ephemeral storage on KubernetesPodOp…

2020-04-14 Thread GitBox
ramkrishnan8994 commented on issue #6337: [AIRFLOW-5659] - Add support for ephemeral storage on KubernetesPodOp… URL: https://github.com/apache/airflow/pull/6337#issuecomment-613823396 > > > > When will this be added to apache-airflow 1.10.10 pip package. Need this ephemeral storage

[GitHub] [airflow] dimberman commented on issue #8219: Add migration waiting script and log cleaner

2020-04-14 Thread GitBox
dimberman commented on issue #8219: Add migration waiting script and log cleaner URL: https://github.com/apache/airflow/pull/8219#issuecomment-613813496 @ashb changing that "and v" in the argument parsing broke a lot of things in non-trivial ways. I think if we want to fix how we parse

[GitHub] [airflow] mik-laj commented on a change in pull request #8313: Simplify handling of downloaded files in Dataflow

2020-04-14 Thread GitBox
mik-laj commented on a change in pull request #8313: Simplify handling of downloaded files in Dataflow URL: https://github.com/apache/airflow/pull/8313#discussion_r408575682 ## File path: airflow/providers/google/cloud/operators/dataflow.py ## @@ -471,85 +473,42 @@ def

[GitHub] [airflow] mik-laj opened a new pull request #8313: Simplify handling of downloaded files in Dataflow

2020-04-14 Thread GitBox
mik-laj opened a new pull request #8313: Simplify handling of downloaded files in Dataflow URL: https://github.com/apache/airflow/pull/8313 --- Make sure to mark the boxes below before creating PR: [x] - [X] Description above provides context of the change - [X] Unit tests

[GitHub] [airflow] zhongjiajie edited a comment on issue #7650: [AIRFLOW-7008] Add perf kit with common used decorators/contexts

2020-04-14 Thread GitBox
zhongjiajie edited a comment on issue #7650: [AIRFLOW-7008] Add perf kit with common used decorators/contexts URL: https://github.com/apache/airflow/pull/7650#issuecomment-613794873 Looking forward your public blog, BTW, code LGTM, except TESTING.rst what you mention above

[GitHub] [airflow] zhongjiajie edited a comment on issue #7650: [AIRFLOW-7008] Add perf kit with common used decorators/contexts

2020-04-14 Thread GitBox
zhongjiajie edited a comment on issue #7650: [AIRFLOW-7008] Add perf kit with common used decorators/contexts URL: https://github.com/apache/airflow/pull/7650#issuecomment-613794873 Looking forward your public blog, BTW, code LGTM

[GitHub] [airflow] zhongjiajie commented on issue #7650: [AIRFLOW-7008] Add perf kit with common used decorators/contexts

2020-04-14 Thread GitBox
zhongjiajie commented on issue #7650: [AIRFLOW-7008] Add perf kit with common used decorators/contexts URL: https://github.com/apache/airflow/pull/7650#issuecomment-613794873 Looking forward your public blog, BTW, code LGTM

[GitHub] [airflow] mik-laj commented on issue #7650: [AIRFLOW-7008] Add perf kit with common used decorators/contexts

2020-04-14 Thread GitBox
mik-laj commented on issue #7650: [AIRFLOW-7008] Add perf kit with common used decorators/contexts URL: https://github.com/apache/airflow/pull/7650#issuecomment-613784971 I saw this article, but I'm afraid we should check and update it first. I started to write internal materials for my

[GitHub] [airflow] mik-laj commented on issue #7650: [AIRFLOW-7008] Add perf kit with common used decorators/contexts

2020-04-14 Thread GitBox
mik-laj commented on issue #7650: [AIRFLOW-7008] Add perf kit with common used decorators/contexts URL: https://github.com/apache/airflow/pull/7650#issuecomment-613780821 I will add a short note in the file TESTING.rst. This

[GitHub] [airflow] zhongjiajie commented on issue #7650: [AIRFLOW-7008] Add perf kit with common used decorators/contexts

2020-04-14 Thread GitBox
zhongjiajie commented on issue #7650: [AIRFLOW-7008] Add perf kit with common used decorators/contexts URL: https://github.com/apache/airflow/pull/7650#issuecomment-613780352 BTW, I find out we have some scheduler doc only in confluence

[GitHub] [airflow] codecov-io commented on issue #8312: Change delete-on-success to delete-on-failure

2020-04-14 Thread GitBox
codecov-io commented on issue #8312: Change delete-on-success to delete-on-failure URL: https://github.com/apache/airflow/pull/8312#issuecomment-613780382 # [Codecov](https://codecov.io/gh/apache/airflow/pull/8312?src=pr=h1) Report > Merging

[GitHub] [airflow] zhongjiajie commented on issue #7650: [AIRFLOW-7008] Add perf kit with common used decorators/contexts

2020-04-14 Thread GitBox
zhongjiajie commented on issue #7650: [AIRFLOW-7008] Add perf kit with common used decorators/contexts URL: https://github.com/apache/airflow/pull/7650#issuecomment-613779057 > In my opinion, the CONTRIBUTOR Guide should contain the most important information for beginners. Make

[GitHub] [airflow] zhongjiajie commented on a change in pull request #7650: [AIRFLOW-7008] Add perf kit with common used decorators/contexts

2020-04-14 Thread GitBox
zhongjiajie commented on a change in pull request #7650: [AIRFLOW-7008] Add perf kit with common used decorators/contexts URL: https://github.com/apache/airflow/pull/7650#discussion_r408540897 ## File path: scripts/perf/perf_kit/__init__.py ## @@ -0,0 +1,119 @@ +#

[GitHub] [airflow] mik-laj commented on issue #7650: [AIRFLOW-7008] Add perf kit with common used decorators/contexts

2020-04-14 Thread GitBox
mik-laj commented on issue #7650: [AIRFLOW-7008] Add perf kit with common used decorators/contexts URL: https://github.com/apache/airflow/pull/7650#issuecomment-613775703 @zhongjiajie I am afraid that this file will be too long if we add any information. In my opinion, the CONTRIBUTOR

[GitHub] [airflow] zhongjiajie commented on issue #7650: [AIRFLOW-7008] Add perf kit with common used decorators/contexts

2020-04-14 Thread GitBox
zhongjiajie commented on issue #7650: [AIRFLOW-7008] Add perf kit with common used decorators/contexts URL: https://github.com/apache/airflow/pull/7650#issuecomment-613769496 Should we add some document to `CONTRIBUTING.rst` too?

[GitHub] [airflow] dimberman opened a new pull request #8312: Change delete-on-success to delete-on-failure

2020-04-14 Thread GitBox
dimberman opened a new pull request #8312: Change delete-on-success to delete-on-failure URL: https://github.com/apache/airflow/pull/8312 It makes more sense to by-default not delete failed pods Users should explicitly state they want these pods deleted. This feature has not yet

[GitHub] [airflow] davinchia commented on issue #8129: API Endpoints - CRUD - DAG Runs

2020-04-14 Thread GitBox
davinchia commented on issue #8129: API Endpoints - CRUD - DAG Runs URL: https://github.com/apache/airflow/issues/8129#issuecomment-613763951 +1. we currently use the experimental api to start dag runs, and have to jump through lots of hoops to get the status of a current dag run. allowing

[GitHub] [airflow] boring-cyborg[bot] commented on issue #8311: Task Duration Missing from the Graph View Tool-tip for Running Tasks

2020-04-14 Thread GitBox
boring-cyborg[bot] commented on issue #8311: Task Duration Missing from the Graph View Tool-tip for Running Tasks URL: https://github.com/apache/airflow/issues/8311#issuecomment-613760976 Thanks for opening your first issue here! Be sure to follow the issue template!

[GitHub] [airflow] shane-graham opened a new issue #8311: Task Duration Missing from the Graph View Tool-tip for Running Tasks

2020-04-14 Thread GitBox
shane-graham opened a new issue #8311: Task Duration Missing from the Graph View Tool-tip for Running Tasks URL: https://github.com/apache/airflow/issues/8311 **Apache Airflow version**: 1.10.10 **Environment**: - **Cloud provider or hardware configuration**: AWS EC2

[GitHub] [airflow] codecov-io edited a comment on issue #8287: [AIRFLOW-4363] Fix JSON encoding error

2020-04-14 Thread GitBox
codecov-io edited a comment on issue #8287: [AIRFLOW-4363] Fix JSON encoding error URL: https://github.com/apache/airflow/pull/8287#issuecomment-613752847 # [Codecov](https://codecov.io/gh/apache/airflow/pull/8287?src=pr=h1) Report > Merging

[GitHub] [airflow] codecov-io commented on issue #8287: [AIRFLOW-4363] Fix JSON encoding error

2020-04-14 Thread GitBox
codecov-io commented on issue #8287: [AIRFLOW-4363] Fix JSON encoding error URL: https://github.com/apache/airflow/pull/8287#issuecomment-613752847 # [Codecov](https://codecov.io/gh/apache/airflow/pull/8287?src=pr=h1) Report > Merging

[GitHub] [airflow] jloehel commented on a change in pull request #8256: updated _write_args on PythonVirtualenvOperator

2020-04-14 Thread GitBox
jloehel commented on a change in pull request #8256: updated _write_args on PythonVirtualenvOperator URL: https://github.com/apache/airflow/pull/8256#discussion_r408517234 ## File path: airflow/operators/python_operator.py ## @@ -330,13 +330,28 @@ def

[jira] [Commented] (AIRFLOW-6295) Create guide for BigQuery service operator

2020-04-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-6295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17083710#comment-17083710 ] ASF GitHub Bot commented on AIRFLOW-6295: - mik-laj commented on pull request #8276:

[GitHub] [airflow] boring-cyborg[bot] commented on issue #8276: [AIRFLOW-6295] Create guide for BigQuery operators

2020-04-14 Thread GitBox
boring-cyborg[bot] commented on issue #8276: [AIRFLOW-6295] Create guide for BigQuery operators URL: https://github.com/apache/airflow/pull/8276#issuecomment-613745467 Awesome work, congrats on your first merged pull request!

[GitHub] [airflow] mik-laj closed issue #8200: Create guide for BigQuery operators

2020-04-14 Thread GitBox
mik-laj closed issue #8200: Create guide for BigQuery operators URL: https://github.com/apache/airflow/issues/8200 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [airflow] mik-laj merged pull request #8276: [AIRFLOW-6295] Create guide for BigQuery operators

2020-04-14 Thread GitBox
mik-laj merged pull request #8276: [AIRFLOW-6295] Create guide for BigQuery operators URL: https://github.com/apache/airflow/pull/8276 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [airflow] mik-laj commented on issue #8279: Protect /rendered page from invalid DAG ids (#8171)

2020-04-14 Thread GitBox
mik-laj commented on issue #8279: Protect /rendered page from invalid DAG ids (#8171) URL: https://github.com/apache/airflow/pull/8279#issuecomment-613742808 We have not previously validated data (we have only validation provided by FAB) and we have to come up with good practises. You may

[GitHub] [airflow] kaxil commented on issue #6337: [AIRFLOW-5659] - Add support for ephemeral storage on KubernetesPodOp…

2020-04-14 Thread GitBox
kaxil commented on issue #6337: [AIRFLOW-5659] - Add support for ephemeral storage on KubernetesPodOp… URL: https://github.com/apache/airflow/pull/6337#issuecomment-613740389 > > > When will this be added to apache-airflow 1.10.10 pip package. Need this ephemeral storage support in one of

[GitHub] [airflow] kaxil commented on issue #8287: [AIRFLOW-4363] Fix JSON encoding error

2020-04-14 Thread GitBox
kaxil commented on issue #8287: [AIRFLOW-4363] Fix JSON encoding error URL: https://github.com/apache/airflow/pull/8287#issuecomment-613738323 Can you please add new unit tests too This is an automated message from the Apache

[GitHub] [airflow] kaxil commented on issue #7683: [AIRFLOW-7033] Change dag and task state meanwhile

2020-04-14 Thread GitBox
kaxil commented on issue #7683: [AIRFLOW-7033] Change dag and task state meanwhile URL: https://github.com/apache/airflow/pull/7683#issuecomment-613737841 > Yes that’s the window I meant. > > Don‘t you think it would make more sense to add an optional button "task instances" next

[GitHub] [airflow] kaxil commented on issue #8184: Upgrade Azure storage blob and Azure file share

2020-04-14 Thread GitBox
kaxil commented on issue #8184: Upgrade Azure storage blob and Azure file share URL: https://github.com/apache/airflow/pull/8184#issuecomment-613737260 Ya it is a bummer. @potiuk Can we handle different versions of the package in the current providers model?

[GitHub] [airflow] kaxil commented on issue #7626: [AIRFLOW-5575] Cannot use the mark future success/failure feature in the UI

2020-04-14 Thread GitBox
kaxil commented on issue #7626: [AIRFLOW-5575] Cannot use the mark future success/failure feature in the UI URL: https://github.com/apache/airflow/pull/7626#issuecomment-613736364 > @crhyatt I have no idea why it's doing that... can you rebase again? I'm not too worried about codecov

[GitHub] [airflow] mik-laj edited a comment on issue #8279: Protect /rendered page from invalid DAG ids (#8171)

2020-04-14 Thread GitBox
mik-laj edited a comment on issue #8279: Protect /rendered page from invalid DAG ids (#8171) URL: https://github.com/apache/airflow/pull/8279#issuecomment-613732733 I open following page: ```

[GitHub] [airflow] mik-laj closed issue #8301: Support Duration in AwsHook when using assume role

2020-04-14 Thread GitBox
mik-laj closed issue #8301: Support Duration in AwsHook when using assume role URL: https://github.com/apache/airflow/issues/8301 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [airflow] mik-laj commented on issue #8301: Support Duration in AwsHook when using assume role

2020-04-14 Thread GitBox
mik-laj commented on issue #8301: Support Duration in AwsHook when using assume role URL: https://github.com/apache/airflow/issues/8301#issuecomment-613735539 We don't cheery pick new changes related to operators to Airflow 1.10, but we want to release operators from Ariflow 2.0 as a pip

[jira] [Commented] (AIRFLOW-4235) home page dags table: highlight rows on mouse hover

2020-04-14 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-4235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17083692#comment-17083692 ] ASF subversion and git services commented on AIRFLOW-4235: -- Commit

[jira] [Commented] (AIRFLOW-6320) Add quarterly to crontab presets

2020-04-14 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-6320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17083697#comment-17083697 ] ASF subversion and git services commented on AIRFLOW-6320: -- Commit

[jira] [Commented] (AIRFLOW-7019) Add visual indication of failure to pause/unpause a dag

2020-04-14 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-7019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17083693#comment-17083693 ] ASF subversion and git services commented on AIRFLOW-7019: -- Commit

[jira] [Commented] (AIRFLOW-6697) Base date and Search in Graph view don't dim when modal activate

2020-04-14 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-6697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17083691#comment-17083691 ] ASF subversion and git services commented on AIRFLOW-6697: -- Commit

[jira] [Commented] (AIRFLOW-6351) security - ui - Add Cross Site Scripting defence

2020-04-14 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-6351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17083695#comment-17083695 ] ASF subversion and git services commented on AIRFLOW-6351: -- Commit

[jira] [Commented] (AIRFLOW-4038) Remove DagBag from /home

2020-04-14 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-4038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17083694#comment-17083694 ] ASF subversion and git services commented on AIRFLOW-4038: -- Commit

[jira] [Commented] (AIRFLOW-7049) Make show_paused persistent across navigation

2020-04-14 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-7049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17083696#comment-17083696 ] ASF subversion and git services commented on AIRFLOW-7049: -- Commit

[GitHub] [airflow] maganaluis commented on a change in pull request #8256: updated _write_args on PythonVirtualenvOperator

2020-04-14 Thread GitBox
maganaluis commented on a change in pull request #8256: updated _write_args on PythonVirtualenvOperator URL: https://github.com/apache/airflow/pull/8256#discussion_r408498490 ## File path: airflow/operators/python_operator.py ## @@ -330,13 +330,28 @@ def

[GitHub] [airflow] snazzyfox commented on issue #8301: Support Duration in AwsHook when using assume role

2020-04-14 Thread GitBox
snazzyfox commented on issue #8301: Support Duration in AwsHook when using assume role URL: https://github.com/apache/airflow/issues/8301#issuecomment-613734429 After digging a little into the code, it appears that #7619 introduced the ability to set arbitrary kwargs for the assume role

[GitHub] [airflow] mik-laj commented on issue #8171: Handle missing object in webserver

2020-04-14 Thread GitBox
mik-laj commented on issue #8171: Handle missing object in webserver URL: https://github.com/apache/airflow/issues/8171#issuecomment-613733028 This is a user experience problem, but it is also a security problem. If we see similar messages, it means that we haven't verified enough input

[GitHub] [airflow] mik-laj commented on issue #8279: Protect /rendered page from invalid DAG ids (#8171)

2020-04-14 Thread GitBox
mik-laj commented on issue #8279: Protect /rendered page from invalid DAG ids (#8171) URL: https://github.com/apache/airflow/pull/8279#issuecomment-613732733 I open following page: ```

[GitHub] [airflow] kaxil opened a new pull request #8310: Remove unused Scheduler "authenticate" config

2020-04-14 Thread GitBox
kaxil opened a new pull request #8310: Remove unused Scheduler "authenticate" config URL: https://github.com/apache/airflow/pull/8310 I can't find any usage of this config. I checked some commits 3 years ago but couldn't find one. --- Make sure to mark the boxes below before

[GitHub] [airflow] kaxil commented on issue #8309: Remove deprecated `secure_model` config

2020-04-14 Thread GitBox
kaxil commented on issue #8309: Remove deprecated `secure_model` config URL: https://github.com/apache/airflow/pull/8309#issuecomment-613726668 > Should we also remove this option from airflow/unittests.cfg and airflow/config_templates/default_test.cfg? Oh yes, updated

[GitHub] [airflow] mik-laj commented on issue #8309: Remove deprecated `secure_model` config

2020-04-14 Thread GitBox
mik-laj commented on issue #8309: Remove deprecated `secure_model` config URL: https://github.com/apache/airflow/pull/8309#issuecomment-613725449 Should we also remove this option from airflow/unittests.cfg and airflow/config_templates/default_test.cfg?

[GitHub] [airflow] kaxil opened a new pull request #8309: Remove deprecated `secure_model` config

2020-04-14 Thread GitBox
kaxil opened a new pull request #8309: Remove deprecated `secure_model` config URL: https://github.com/apache/airflow/pull/8309 `secure_mode` config was only available for Flask-admin UI --- Make sure to mark the boxes below before creating PR: [x] - [x] Description above

[GitHub] [airflow] codecov-io edited a comment on issue #8304: [Airflow-5565] Add extra_args param to s3hook

2020-04-14 Thread GitBox
codecov-io edited a comment on issue #8304: [Airflow-5565] Add extra_args param to s3hook URL: https://github.com/apache/airflow/pull/8304#issuecomment-613717834 # [Codecov](https://codecov.io/gh/apache/airflow/pull/8304?src=pr=h1) Report > Merging

[GitHub] [airflow] kaxil edited a comment on issue #8308: Fix Extra Links in Gannt View

2020-04-14 Thread GitBox
kaxil edited a comment on issue #8308: Fix Extra Links in Gannt View URL: https://github.com/apache/airflow/pull/8308#issuecomment-613717782 > Should we add tests to avoid regression? Was just typing that :D . We don't have any tests for Modal or at least I don't know, so any

[GitHub] [airflow] codecov-io commented on issue #8304: [Airflow-5565] Add extra_args param to s3hook

2020-04-14 Thread GitBox
codecov-io commented on issue #8304: [Airflow-5565] Add extra_args param to s3hook URL: https://github.com/apache/airflow/pull/8304#issuecomment-613717834 # [Codecov](https://codecov.io/gh/apache/airflow/pull/8304?src=pr=h1) Report > Merging

[GitHub] [airflow] kaxil commented on issue #8308: Fix Extra Links in Gannt View

2020-04-14 Thread GitBox
kaxil commented on issue #8308: Fix Extra Links in Gannt View URL: https://github.com/apache/airflow/pull/8308#issuecomment-613717782 > Should we add tests to avoid regression? Was just typing that :D This is an

[GitHub] [airflow] codecov-io edited a comment on issue #7650: [AIRFLOW-7008] Add perf kit with common used decorators/contexts

2020-04-14 Thread GitBox
codecov-io edited a comment on issue #7650: [AIRFLOW-7008] Add perf kit with common used decorators/contexts URL: https://github.com/apache/airflow/pull/7650#issuecomment-596778149 # [Codecov](https://codecov.io/gh/apache/airflow/pull/7650?src=pr=h1) Report > Merging

[GitHub] [airflow] codecov-io edited a comment on issue #7650: [AIRFLOW-7008] Add perf kit with common used decorators/contexts

2020-04-14 Thread GitBox
codecov-io edited a comment on issue #7650: [AIRFLOW-7008] Add perf kit with common used decorators/contexts URL: https://github.com/apache/airflow/pull/7650#issuecomment-596778149 # [Codecov](https://codecov.io/gh/apache/airflow/pull/7650?src=pr=h1) Report > Merging

[GitHub] [airflow] kaxil commented on issue #8308: Fix Extra Links in Gannt View

2020-04-14 Thread GitBox
kaxil commented on issue #8308: Fix Extra Links in Gannt View URL: https://github.com/apache/airflow/pull/8308#issuecomment-613716622 I am not sure how to add a test for this. Any suggestions @ashb ? This is an automated

[GitHub] [airflow] codecov-io edited a comment on issue #7650: [AIRFLOW-7008] Add perf kit with common used decorators/contexts

2020-04-14 Thread GitBox
codecov-io edited a comment on issue #7650: [AIRFLOW-7008] Add perf kit with common used decorators/contexts URL: https://github.com/apache/airflow/pull/7650#issuecomment-596778149 # [Codecov](https://codecov.io/gh/apache/airflow/pull/7650?src=pr=h1) Report > Merging

[GitHub] [airflow] mik-laj commented on issue #8308: Fix Extra Links in Gannt View

2020-04-14 Thread GitBox
mik-laj commented on issue #8308: Fix Extra Links in Gannt View URL: https://github.com/apache/airflow/pull/8308#issuecomment-613716227 Should we add tests to avoid regression? This is an automated message from the Apache Git

[GitHub] [airflow] kaxil opened a new pull request #8308: Fix Extra Links in Gannt View

2020-04-14 Thread GitBox
kaxil opened a new pull request #8308: Fix Extra Links in Gannt View URL: https://github.com/apache/airflow/pull/8308 Extra link didn't appear after changes in https://github.com/apache/airflow/pull/8220 for Gantt View **Before**:

[GitHub] [airflow] kaxil merged pull request #8302: Remove unused code from Gannt View

2020-04-14 Thread GitBox
kaxil merged pull request #8302: Remove unused code from Gannt View URL: https://github.com/apache/airflow/pull/8302 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [airflow] kaxil commented on issue #8302: Remove unused code from Gannt View

2020-04-14 Thread GitBox
kaxil commented on issue #8302: Remove unused code from Gannt View URL: https://github.com/apache/airflow/pull/8302#issuecomment-613715343 > Is extra links still working on Gantt view? No, it doesn't work. Fixing it a separate PR

[jira] [Commented] (AIRFLOW-6320) Add quarterly to crontab presets

2020-04-14 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-6320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17083642#comment-17083642 ] ASF subversion and git services commented on AIRFLOW-6320: -- Commit

[jira] [Updated] (AIRFLOW-6320) Add quarterly to crontab presets

2020-04-14 Thread Kaxil Naik (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-6320?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kaxil Naik updated AIRFLOW-6320: Fix Version/s: (was: 2.0.0) 1.10.11 > Add quarterly to crontab presets >

[GitHub] [airflow] mik-laj edited a comment on issue #8303: BingAds to Google storage

2020-04-14 Thread GitBox
mik-laj edited a comment on issue #8303: BingAds to Google storage URL: https://github.com/apache/airflow/issues/8303#issuecomment-613706066 If you are looking for Airflow experts who can write ETL/integration/etc and help with Airflow, I can recommend my company. @turbaszek, @potiuk

[GitHub] [airflow] mik-laj commented on issue #8303: BingAds to Google storage

2020-04-14 Thread GitBox
mik-laj commented on issue #8303: BingAds to Google storage URL: https://github.com/apache/airflow/issues/8303#issuecomment-613706066 If you are looking for Airflow experts who can write integration and help with Airflow, I can recommend my company. @turbaszek, @potiuk and me are most

[GitHub] [airflow] mik-laj commented on issue #7724: [AIRFLOW-1536] Inherit umask from parent process in daemon mode

2020-04-14 Thread GitBox
mik-laj commented on issue #7724: [AIRFLOW-1536] Inherit umask from parent process in daemon mode URL: https://github.com/apache/airflow/pull/7724#issuecomment-613703252 @potiuk @ivorynoise What is the progress of this PR? I see a rich discussion and acceptance of the change, but can I

[GitHub] [airflow] mik-laj commented on issue #8276: [AIRFLOW-6295] Create guide for BigQuery operators

2020-04-14 Thread GitBox
mik-laj commented on issue #8276: [AIRFLOW-6295] Create guide for BigQuery operators URL: https://github.com/apache/airflow/pull/8276#issuecomment-613701658 Airflow has a very active GCP user community. For sure you won't run out of tasks.  I will try to regularly create new tickets

[GitHub] [airflow] alexandraabbas commented on issue #8276: [AIRFLOW-6295] Create guide for BigQuery operators

2020-04-14 Thread GitBox
alexandraabbas commented on issue #8276: [AIRFLOW-6295] Create guide for BigQuery operators URL: https://github.com/apache/airflow/pull/8276#issuecomment-613699282 Yay! I work a lot with Airflow on GCP so I'll probably contribute more around that :)

[GitHub] [airflow] jloehel commented on a change in pull request #8256: updated _write_args on PythonVirtualenvOperator

2020-04-14 Thread GitBox
jloehel commented on a change in pull request #8256: updated _write_args on PythonVirtualenvOperator URL: https://github.com/apache/airflow/pull/8256#discussion_r408456448 ## File path: airflow/operators/python_operator.py ## @@ -330,13 +330,28 @@ def

[GitHub] [airflow] rcjsuen opened a new pull request #8307: Add simple tests for SqliteOperator

2020-04-14 Thread GitBox
rcjsuen opened a new pull request #8307: Add simple tests for SqliteOperator URL: https://github.com/apache/airflow/pull/8307 Improve code coverage by adding a few simple tests for the SqliteOperator. This was created to address one of the files mentioned by #8278. --- Make

[GitHub] [airflow] alexandraabbas commented on issue #8276: [AIRFLOW-6295] Create guide for BigQuery operators

2020-04-14 Thread GitBox
alexandraabbas commented on issue #8276: [AIRFLOW-6295] Create guide for BigQuery operators URL: https://github.com/apache/airflow/pull/8276#issuecomment-613697383 I added the bigquery howto to `operators-and-hooks-ref.rst`

[GitHub] [airflow] mik-laj edited a comment on issue #8276: [AIRFLOW-6295] Create guide for BigQuery operators

2020-04-14 Thread GitBox
mik-laj edited a comment on issue #8276: [AIRFLOW-6295] Create guide for BigQuery operators URL: https://github.com/apache/airflow/pull/8276#issuecomment-613694828 One more thing. Can you add this guide to the operators reference?

[GitHub] [airflow] mik-laj commented on issue #8276: [AIRFLOW-6295] Create guide for BigQuery operators

2020-04-14 Thread GitBox
mik-laj commented on issue #8276: [AIRFLOW-6295] Create guide for BigQuery operators URL: https://github.com/apache/airflow/pull/8276#issuecomment-613694828 One more thing. Can you add this guide to the operators refence list?

[GitHub] [airflow] mik-laj commented on issue #8277: WIP : [AIRFLOW-8187] Extend elastic DAG with a binary tree, grid, star

2020-04-14 Thread GitBox
mik-laj commented on issue #8277: WIP : [AIRFLOW-8187] Extend elastic DAG with a binary tree, grid, star URL: https://github.com/apache/airflow/pull/8277#issuecomment-613693536 Thank you very much for working on this change. I need this very much in my upcoming works.

[GitHub] [airflow] KevinKobi commented on issue #8303: BingAds to Google storage

2020-04-14 Thread GitBox
KevinKobi commented on issue #8303: BingAds to Google storage URL: https://github.com/apache/airflow/issues/8303#issuecomment-613693272 Sadly I don't have the time. We are even paying to a company to bring the data for us due to lack of time to work on the ETLs from scratch.

[GitHub] [airflow] mik-laj commented on issue #8277: WIP : [AIRFLOW-8187] Extend elastic DAG with a binary tree, grid, star

2020-04-14 Thread GitBox
mik-laj commented on issue #8277: WIP : [AIRFLOW-8187] Extend elastic DAG with a binary tree, grid, star URL: https://github.com/apache/airflow/pull/8277#issuecomment-613693089 DAGs looks perfect.

[GitHub] [airflow] alexandraabbas commented on a change in pull request #8276: [AIRFLOW-6295] Create guide for BigQuery operators

2020-04-14 Thread GitBox
alexandraabbas commented on a change in pull request #8276: [AIRFLOW-6295] Create guide for BigQuery operators URL: https://github.com/apache/airflow/pull/8276#discussion_r408449738 ## File path: docs/howto/operator/gcp/bigquery.rst ## @@ -0,0 +1,334 @@ + .. Licensed to

[GitHub] [airflow] mik-laj commented on a change in pull request #8277: WIP : [AIRFLOW-8187] Extend elastic DAG with a binary tree, grid, star

2020-04-14 Thread GitBox
mik-laj commented on a change in pull request #8277: WIP : [AIRFLOW-8187] Extend elastic DAG with a binary tree, grid, star URL: https://github.com/apache/airflow/pull/8277#discussion_r408448901 ## File path: airflow/models/baseoperator.py ## @@ -1239,6 +1239,36 @@ def

[GitHub] [airflow] KevinKobi opened a new issue #8306: Ability to see subdags tasks within parent dag

2020-04-14 Thread GitBox
KevinKobi opened a new issue #8306: Ability to see subdags tasks within parent dag URL: https://github.com/apache/airflow/issues/8306 **Description** Ability to see subdags task within parent dag. The idea is to add button or something similar that will convert all subdags to

[GitHub] [airflow] mik-laj commented on a change in pull request #8256: updated _write_args on PythonVirtualenvOperator

2020-04-14 Thread GitBox
mik-laj commented on a change in pull request #8256: updated _write_args on PythonVirtualenvOperator URL: https://github.com/apache/airflow/pull/8256#discussion_r408441020 ## File path: airflow/operators/python_operator.py ## @@ -330,13 +330,28 @@ def

[GitHub] [airflow] mik-laj edited a comment on issue #7650: [AIRFLOW-7008] Add perf kit with common used decorators/contexts

2020-04-14 Thread GitBox
mik-laj edited a comment on issue #7650: [AIRFLOW-7008] Add perf kit with common used decorators/contexts URL: https://github.com/apache/airflow/pull/7650#issuecomment-613682797 I added documentation. Does someone want to look at these changes? That would be helpful. CC: @zhongjiajie

[GitHub] [airflow] mik-laj commented on issue #7650: [AIRFLOW-7008] Add perf kit with common used decorators/contexts

2020-04-14 Thread GitBox
mik-laj commented on issue #7650: [AIRFLOW-7008] Add perf kit with common used decorators/contexts URL: https://github.com/apache/airflow/pull/7650#issuecomment-613682797 I added documentation. Do you want someone to look at these changes?

[GitHub] [airflow] mik-laj commented on a change in pull request #8276: [Airflow-6295] Create guide for BigQuery operators

2020-04-14 Thread GitBox
mik-laj commented on a change in pull request #8276: [Airflow-6295] Create guide for BigQuery operators URL: https://github.com/apache/airflow/pull/8276#discussion_r408434837 ## File path: docs/howto/operator/gcp/bigquery.rst ## @@ -0,0 +1,334 @@ + .. Licensed to the

[GitHub] [airflow] jloehel commented on a change in pull request #8256: updated _write_args on PythonVirtualenvOperator

2020-04-14 Thread GitBox
jloehel commented on a change in pull request #8256: updated _write_args on PythonVirtualenvOperator URL: https://github.com/apache/airflow/pull/8256#discussion_r408434493 ## File path: airflow/operators/python_operator.py ## @@ -330,13 +330,28 @@ def

[GitHub] [airflow] KevinKobi commented on issue #5281: WIP: [AIRFLOW-4506] Make GIT_SYNC_DEPTH and GIT_SYNC_REV configurable

2020-04-14 Thread GitBox
KevinKobi commented on issue #5281: WIP: [AIRFLOW-4506] Make GIT_SYNC_DEPTH and GIT_SYNC_REV configurable URL: https://github.com/apache/airflow/pull/5281#issuecomment-613680856 `GIT_SYNC_REV` was added https://github.com/apache/airflow/pull/6350 but not `GIT_SYNC_DEPTH` :( are there

[GitHub] [airflow] mik-laj commented on a change in pull request #8256: updated _write_args on PythonVirtualenvOperator

2020-04-14 Thread GitBox
mik-laj commented on a change in pull request #8256: updated _write_args on PythonVirtualenvOperator URL: https://github.com/apache/airflow/pull/8256#discussion_r408432209 ## File path: airflow/operators/python_operator.py ## @@ -330,13 +330,28 @@ def

[GitHub] [airflow] mik-laj commented on issue #8303: BingAds to Google storage

2020-04-14 Thread GitBox
mik-laj commented on issue #8303: BingAds to Google storage URL: https://github.com/apache/airflow/issues/8303#issuecomment-613678253 Would you like to work on this issue? Apache Airflow is an open-source project without paid technical support. Each code is contributed by community

[GitHub] [airflow] mik-laj edited a comment on issue #8301: Support Duration in AwsHook when using assume role

2020-04-14 Thread GitBox
mik-laj edited a comment on issue #8301: Support Duration in AwsHook when using assume role URL: https://github.com/apache/airflow/issues/8301#issuecomment-613676708 Would you like to work on this issue? Apache Airflow is an open-source project without paid technical support. Each

[GitHub] [airflow] mik-laj commented on issue #8301: Support Duration in AwsHook when using assume role

2020-04-14 Thread GitBox
mik-laj commented on issue #8301: Support Duration in AwsHook when using assume role URL: https://github.com/apache/airflow/issues/8301#issuecomment-613676708 Would you like to work on this issue? Apache Airflow is an open-source project without paid technical support. Each problem is

[GitHub] [airflow] kaxil commented on a change in pull request #8299: Clarify docs for on delete_worker_pods_on_success

2020-04-14 Thread GitBox
kaxil commented on a change in pull request #8299: Clarify docs for on delete_worker_pods_on_success URL: https://github.com/apache/airflow/pull/8299#discussion_r408429470 ## File path: airflow/config_templates/config.yml ## @@ -1754,7 +1754,9 @@ default: "True"

[GitHub] [airflow] kaxil commented on a change in pull request #8299: Clarify docs for on delete_worker_pods_on_success

2020-04-14 Thread GitBox
kaxil commented on a change in pull request #8299: Clarify docs for on delete_worker_pods_on_success URL: https://github.com/apache/airflow/pull/8299#discussion_r408429552 ## File path: airflow/config_templates/default_airflow.cfg ## @@ -815,7 +815,9 @@

  1   2   3   4   >