[GitHub] [airflow] khyurri commented on issue #8285: Improve idempodency in CloudDataTransferServiceCreateJobOperator

khyurri commented on issue #8285: Improve idempodency in CloudDataTransferServiceCreateJobOperator URL: https://github.com/apache/airflow/issues/8285#issuecomment-613473685 I can get it, Looks like easy and helpful This

[GitHub] [airflow] khyurri commented on issue #8288: Eventlet with CeleryExecutor not working in Airflow 1.10.9 version

khyurri commented on issue #8288: Eventlet with CeleryExecutor not working in Airflow 1.10.9 version URL: https://github.com/apache/airflow/issues/8288#issuecomment-613470960 Can't reproduce at `1.10.10`. airflow.cfg (non default values) ``` sql_alchemy_conn =

[GitHub] [airflow] khyurri edited a comment on issue #8288: Eventlet with CeleryExecutor not working in Airflow 1.10.9 version

khyurri edited a comment on issue #8288: Eventlet with CeleryExecutor not working in Airflow 1.10.9 version URL: https://github.com/apache/airflow/issues/8288#issuecomment-613470960 Can't reproduce at `1.10.10`. My airflow.cfg (non default values) ``` sql_alchemy_conn =

[GitHub] [airflow] potiuk commented on issue #8297: Customizable configurable footer in admin web interface

potiuk commented on issue #8297: Customizable configurable footer in admin web interface URL: https://github.com/apache/airflow/issues/8297#issuecomment-613461939 @MShekow Could you please provide a link to the regulations? I believe they apply only to public websites and Airflow's web

[GitHub] [airflow] potiuk closed issue #8297: Customizable configurable footer in admin web interface

potiuk closed issue #8297: Customizable configurable footer in admin web interface URL: https://github.com/apache/airflow/issues/8297 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [airflow] ashb commented on issue #8296: Make execute and on_kill as abstractmethod in baseoperator

ashb commented on issue #8296: Make execute and on_kill as abstractmethod in baseoperator URL: https://github.com/apache/airflow/pull/8296#issuecomment-613460520 How many don't have an on_kill? Could the default on_kill be to kill any child processes?

[GitHub] [airflow] codecov-io edited a comment on issue #8228: Expose Airflow Webserver Port in Production Docker Image

codecov-io edited a comment on issue #8228: Expose Airflow Webserver Port in Production Docker Image URL: https://github.com/apache/airflow/pull/8228#issuecomment-613449528 # [Codecov](https://codecov.io/gh/apache/airflow/pull/8228?src=pr=h1) Report > Merging

[GitHub] [airflow] codecov-io edited a comment on issue #8228: Expose Airflow Webserver Port in Production Docker Image

codecov-io edited a comment on issue #8228: Expose Airflow Webserver Port in Production Docker Image URL: https://github.com/apache/airflow/pull/8228#issuecomment-613449528 # [Codecov](https://codecov.io/gh/apache/airflow/pull/8228?src=pr=h1) Report > Merging

[GitHub] [airflow] codecov-io edited a comment on issue #8228: Expose Airflow Webserver Port in Production Docker Image

codecov-io edited a comment on issue #8228: Expose Airflow Webserver Port in Production Docker Image URL: https://github.com/apache/airflow/pull/8228#issuecomment-613449528 # [Codecov](https://codecov.io/gh/apache/airflow/pull/8228?src=pr=h1) Report > Merging

[GitHub] [airflow] randr97 edited a comment on issue #7887: Custom Facebook Ads Operator

randr97 edited a comment on issue #7887: Custom Facebook Ads Operator URL: https://github.com/apache/airflow/issues/7887#issuecomment-613448554 @mik-laj Any thoughts? Next Steps - - [ ] FB reports to S3 Bucket (AWS integration) (Operator) - [ ] Audience onboarding to FB (Hook)

[GitHub] [airflow] codecov-io commented on issue #8228: Expose Airflow Webserver Port in Production Docker Image

codecov-io commented on issue #8228: Expose Airflow Webserver Port in Production Docker Image URL: https://github.com/apache/airflow/pull/8228#issuecomment-613449528 # [Codecov](https://codecov.io/gh/apache/airflow/pull/8228?src=pr=h1) Report > Merging

[GitHub] [airflow] randr97 edited a comment on issue #7887: Custom Facebook Ads Operator

randr97 edited a comment on issue #7887: Custom Facebook Ads Operator URL: https://github.com/apache/airflow/issues/7887#issuecomment-613448554 @mik-laj Any thoughts? Next Steps - - [ ] FB reports to S3 Bucket (AWS integration) - [ ] Audience onboarding to FB - [ ] Creative

[GitHub] [airflow] randr97 commented on issue #7887: Custom Facebook Ads Operator

randr97 commented on issue #7887: Custom Facebook Ads Operator URL: https://github.com/apache/airflow/issues/7887#issuecomment-613448554 Next Steps - - [ ] FB reports to S3 Bucket (AWS integration) - [ ] Audience onboarding to FB - [ ] Creative Bulk Upload

[GitHub] [airflow-site] kaxil opened a new pull request #264: Redirect Airflow 1.10.10 API/Macros/CLI refs to new URLs

kaxil opened a new pull request #264: Redirect Airflow 1.10.10 API/Macros/CLI refs to new URLs URL: https://github.com/apache/airflow-site/pull/264 I have already published this on asf-site branch so you can check the below URLs to verify they work fine:

[airflow-site] 01/01: Redirect Airflow 1.10.10 API/Macros/CLI refs to new URLs

This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a commit to branch redirect-new-urls in repository https://gitbox.apache.org/repos/asf/airflow-site.git commit 711a17a87af49f4677f64c0407779715344f3284 Author: Kaxil Naik AuthorDate: Tue Apr 14 14:33:43 2020

[airflow-site] branch redirect-new-urls created (now 711a17a)

This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a change to branch redirect-new-urls in repository https://gitbox.apache.org/repos/asf/airflow-site.git. at 711a17a Redirect Airflow 1.10.10 API/Macros/CLI refs to new URLs This branch includes the

[airflow-site] 01/01: Redirect API/Macros/CLI refs to new URLs

This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/airflow-site.git commit 1b31f60331686ccc143fdb2f82f6437f48f5c1d1 Author: Kaxil Naik AuthorDate: Tue Apr 14 13:54:59 2020 +0100

[GitHub] [airflow] boring-cyborg[bot] commented on issue #8297: Customizable configurable footer in admin web interface

boring-cyborg[bot] commented on issue #8297: Customizable configurable footer in admin web interface URL: https://github.com/apache/airflow/issues/8297#issuecomment-613444908 Thanks for opening your first issue here! Be sure to follow the issue template!

[airflow-site] branch asf-site updated (8138e7a -> 1b31f60)

This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a change to branch asf-site in repository https://gitbox.apache.org/repos/asf/airflow-site.git. discard 8138e7a Redirect API/Macros/CLI refs to new URLs new 1b31f60 Redirect API/Macros/CLI refs to new

[GitHub] [airflow] MShekow opened a new issue #8297: Customizable configurable footer in admin web interface

MShekow opened a new issue #8297: Customizable configurable footer in admin web interface URL: https://github.com/apache/airflow/issues/8297 **Description** The footer area of the HTML template of the admin web interface should be customizable. The server admin should be able to

[airflow-site] 01/01: Redirect API/Macros/CLI refs to new URLs

This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/airflow-site.git commit 8138e7a94f4aed015eb3c3c2bd0c79bae266 Author: Kaxil Naik AuthorDate: Tue Apr 14 13:54:59 2020 +0100

[airflow-site] branch asf-site updated (4fa68a8 -> 8138e7a)

This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a change to branch asf-site in repository https://gitbox.apache.org/repos/asf/airflow-site.git. discard 4fa68a8 Redirect API/Macros/CLI refs to new URLs new 8138e7a Redirect API/Macros/CLI refs to new

[GitHub] [airflow] zhongjiajie commented on issue #7683: [AIRFLOW-7033] Change dag and task state meanwhile

zhongjiajie commented on issue #7683: [AIRFLOW-7033] Change dag and task state meanwhile URL: https://github.com/apache/airflow/pull/7683#issuecomment-613443087 ping @kaxil @mik-laj @feluelle again, I need one more approval/review here

[airflow-site] 01/01: Redirect API/Macros/CLI refs to new URLs

This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/airflow-site.git commit 4fa68a8025c61ddb73bfcc2f09223c1a5a124f9f Author: Kaxil Naik AuthorDate: Tue Apr 14 13:54:59 2020 +0100

[airflow-site] branch asf-site updated (b1cbe42 -> 4fa68a8)

This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a change to branch asf-site in repository https://gitbox.apache.org/repos/asf/airflow-site.git. discard b1cbe42 Redirect API/Macros/CLI refs to new URLs new 4fa68a8 Redirect API/Macros/CLI refs to new

[GitHub] [airflow] zhongjiajie commented on issue #8231: Dag bulk_sync_to_db dag_tag only remove not exists

zhongjiajie commented on issue #8231: Dag bulk_sync_to_db dag_tag only remove not exists URL: https://github.com/apache/airflow/pull/8231#issuecomment-613439829 @mik-laj Not sure about it, Is it both two way we just delete/add `orm_dags` object but not query database? we just bulk to

[airflow-site] branch asf-site updated (d3ced78 -> b1cbe42)

This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a change to branch asf-site in repository https://gitbox.apache.org/repos/asf/airflow-site.git. discard d3ced78 Redirect API/Macros/CLI refs to new URLs new b1cbe42 Redirect API/Macros/CLI refs to new

[airflow-site] 01/01: Redirect API/Macros/CLI refs to new URLs

This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/airflow-site.git commit b1cbe42747f8af8bcf6cefc4dec0fc6607055569 Author: Kaxil Naik AuthorDate: Tue Apr 14 13:54:59 2020 +0100

[GitHub] [airflow] potiuk commented on issue #8270: Provide official airflow chart

potiuk commented on issue #8270: Provide official airflow chart URL: https://github.com/apache/airflow/issues/8270#issuecomment-613437257 Indeed. We are working on the helm chart with @dimberman and there already few suggestions on the changes that will need to be added to the image/helm

[airflow-site] 01/01: Redirect API/Macros/CLI refs to new URLs

This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/airflow-site.git commit d3ced785b37f444769d1072ac87cb2dc8eae98e0 Author: Kaxil Naik AuthorDate: Tue Apr 14 13:54:59 2020 +0100

[airflow-site] branch asf-site updated (dc45639 -> d3ced78)

This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a change to branch asf-site in repository https://gitbox.apache.org/repos/asf/airflow-site.git. discard dc45639 Redirect API/Macros/CLI refs to new URLs new d3ced78 Redirect API/Macros/CLI refs to new

[GitHub] [airflow] kaxil commented on issue #6850: [AIRFLOW-6296] add ODBC hook & deprecation warning for pymssql

kaxil commented on issue #6850: [AIRFLOW-6296] add ODBC hook & deprecation warning for pymssql URL: https://github.com/apache/airflow/pull/6850#issuecomment-613433365 Yes, this was indeed pushed back to 2.0. Like @potiuk mentioned is there a specific need for this operator which the

[airflow-site] 01/01: Redirect API/Macros/CLI refs to new URLs

This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/airflow-site.git commit dc45639f9ce4233f6911d39e2e1ac361bbdab157 Author: Kaxil Naik AuthorDate: Tue Apr 14 13:54:59 2020 +0100

[airflow-site] branch asf-site updated (7637c60 -> dc45639)

This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a change to branch asf-site in repository https://gitbox.apache.org/repos/asf/airflow-site.git. discard 7637c60 Redirect API/Macros/CLI refs to new URLs new dc45639 Redirect API/Macros/CLI refs to new

[GitHub] [airflow] potiuk commented on issue #8008: Custom Facebook Ads Operator

potiuk commented on issue #8008: Custom Facebook Ads Operator URL: https://github.com/apache/airflow/pull/8008#issuecomment-613432339 Thanks @randr97 ! This is an automated message from the Apache Git Service. To respond to

[GitHub] [airflow] potiuk merged pull request #8008: Custom Facebook Ads Operator

potiuk merged pull request #8008: Custom Facebook Ads Operator URL: https://github.com/apache/airflow/pull/8008 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [airflow] boring-cyborg[bot] commented on issue #8008: Custom Facebook Ads Operator

boring-cyborg[bot] commented on issue #8008: Custom Facebook Ads Operator URL: https://github.com/apache/airflow/pull/8008#issuecomment-613432272 Awesome work, congrats on your first merged pull request! This is an

[GitHub] [airflow] potiuk edited a comment on issue #6850: [AIRFLOW-6296] add ODBC hook & deprecation warning for pymssql

potiuk edited a comment on issue #6850: [AIRFLOW-6296] add ODBC hook & deprecation warning for pymssql URL: https://github.com/apache/airflow/pull/6850#issuecomment-613431744 Looking at the history it was problematic to import to 1.10.10 and @kaxil decided to leave it in 2.0. While trying

[GitHub] [airflow] potiuk commented on issue #6850: [AIRFLOW-6296] add ODBC hook & deprecation warning for pymssql

potiuk commented on issue #6850: [AIRFLOW-6296] add ODBC hook & deprecation warning for pymssql URL: https://github.com/apache/airflow/pull/6850#issuecomment-613431744 Looking at the history it was problematic to import to 1.10.10 and @kaxil decided to leave for 2.0. While trying to

[airflow-site] 01/01: Redirect API/Macros/CLI refs to new URLs

This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/airflow-site.git commit 7637c60ca04b60ddba6edf62dc66865a60f941e0 Author: Kaxil Naik AuthorDate: Tue Apr 14 13:54:59 2020 +0100

[airflow-site] branch asf-site updated (5dc5138 -> 7637c60)

This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a change to branch asf-site in repository https://gitbox.apache.org/repos/asf/airflow-site.git. discard 5dc5138 Redirect API/Macros/CLI refs to new URLs new 7637c60 Redirect API/Macros/CLI refs to new

[airflow-site] branch asf-site updated (e3b38c3 -> 5dc5138)

This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a change to branch asf-site in repository https://gitbox.apache.org/repos/asf/airflow-site.git. discard e3b38c3 fixup! Redirect API/Macros/CLI refs to new URLs discard de2f5c6 Redirect API/Macros/CLI refs

[airflow-site] 01/01: Redirect API/Macros/CLI refs to new URLs

This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/airflow-site.git commit 5dc513820b27668bea62f557ec99b7ed8de336ab Author: Kaxil Naik AuthorDate: Tue Apr 14 13:54:59 2020 +0100

[GitHub] [airflow] potiuk commented on issue #8287: [AIRFLOW-4363] Fix JSON encoding error

potiuk commented on issue #8287: [AIRFLOW-4363] Fix JSON encoding error URL: https://github.com/apache/airflow/pull/8287#issuecomment-613427998 You have some pylint errors . Can you fix them please :) ? This is an automated

[airflow-site] branch asf-site updated: fixup! Redirect API/Macros/CLI refs to new URLs

This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/airflow-site.git The following commit(s) were added to refs/heads/asf-site by this push: new e3b38c3 fixup! Redirect

[airflow-site] branch asf-site updated: Redirect API/Macros/CLI refs to new URLs

This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/airflow-site.git The following commit(s) were added to refs/heads/asf-site by this push: new de2f5c6 Redirect API/Macros/CLI

[GitHub] [airflow] zhongjiajie commented on issue #8296: Make execute and on_kill as abstractmethod in baseoperator

zhongjiajie commented on issue #8296: Make execute and on_kill as abstractmethod in baseoperator URL: https://github.com/apache/airflow/pull/8296#issuecomment-613424394 Create a draft PR to hear opinions, If agree with that I will continue, WDYT, @potiuk @kaxil @ashb @mik-laj @turbaszek

[GitHub] [airflow] codecov-io edited a comment on issue #8213: Fix issue #8163 where gcp auth fails

codecov-io edited a comment on issue #8213: Fix issue #8163 where gcp auth fails URL: https://github.com/apache/airflow/pull/8213#issuecomment-613422737 # [Codecov](https://codecov.io/gh/apache/airflow/pull/8213?src=pr=h1) Report > Merging

[GitHub] [airflow] codecov-io edited a comment on issue #8213: Fix issue #8163 where gcp auth fails

codecov-io edited a comment on issue #8213: Fix issue #8163 where gcp auth fails URL: https://github.com/apache/airflow/pull/8213#issuecomment-613422737 # [Codecov](https://codecov.io/gh/apache/airflow/pull/8213?src=pr=h1) Report > Merging

[GitHub] [airflow] zhongjiajie commented on issue #8296: Make execute and on_kill as abstractmethod in baseoperator

zhongjiajie commented on issue #8296: Make execute and on_kill as abstractmethod in baseoperator URL: https://github.com/apache/airflow/pull/8296#issuecomment-613422886 Today in my production environment worker full CPU and found out in `airflow-1.10.0` `SSHOperator` without `on_kill`

[GitHub] [airflow] codecov-io commented on issue #8213: Fix issue #8163 where gcp auth fails

codecov-io commented on issue #8213: Fix issue #8163 where gcp auth fails URL: https://github.com/apache/airflow/pull/8213#issuecomment-613422737 # [Codecov](https://codecov.io/gh/apache/airflow/pull/8213?src=pr=h1) Report > Merging

[GitHub] [airflow] zhongjiajie opened a new pull request #8296: Make execute and on_kill as abstractmethod in baseoperator

zhongjiajie opened a new pull request #8296: Make execute and on_kill as abstractmethod in baseoperator URL: https://github.com/apache/airflow/pull/8296 Each subclass of baseoperator should implement on_kill function to avoid make failed/success in dag UI or task instance up_for_retry

[GitHub] [airflow] codecov-io edited a comment on issue #8276: [Airflow-6295] Create guide for BigQuery operators

codecov-io edited a comment on issue #8276: [Airflow-6295] Create guide for BigQuery operators URL: https://github.com/apache/airflow/pull/8276#issuecomment-613415905 # [Codecov](https://codecov.io/gh/apache/airflow/pull/8276?src=pr=h1) Report > Merging

[GitHub] [airflow] codecov-io commented on issue #8276: [Airflow-6295] Create guide for BigQuery operators

codecov-io commented on issue #8276: [Airflow-6295] Create guide for BigQuery operators URL: https://github.com/apache/airflow/pull/8276#issuecomment-613415905 # [Codecov](https://codecov.io/gh/apache/airflow/pull/8276?src=pr=h1) Report > Merging

[GitHub] [airflow] kaxil commented on issue #8293: Architecture diagram on Documentation is broken

kaxil commented on issue #8293: Architecture diagram on Documentation is broken URL: https://github.com/apache/airflow/issues/8293#issuecomment-613410354 Thanks for raising the issue, will fix it today @r3da-hash . @mik-laj Hmm I installed it but looks like `pip3` vs `pip`. Anyways,

[GitHub] [airflow] potiuk commented on issue #8290: Add airflow info command

potiuk commented on issue #8290: Add airflow info command URL: https://github.com/apache/airflow/pull/8290#issuecomment-613400920 https://www.file.io/ -> I am using that to submit logs from our CI builds. They have a nice feature that it's truly ephemeral - i.e. only one person can

[GitHub] [airflow] potiuk commented on issue #8228: Expose Airflow Webserver Port in Production Docker Image

potiuk commented on issue #8228: Expose Airflow Webserver Port in Production Docker Image URL: https://github.com/apache/airflow/pull/8228#issuecomment-613400027 > Should I add docs regarding that in this PR? Just a note about what you said not using both at the same time?

[GitHub] [airflow] potiuk commented on issue #8292: Bump supported mysqlclient to <1.5

potiuk commented on issue #8292: Bump supported mysqlclient to <1.5 URL: https://github.com/apache/airflow/issues/8292#issuecomment-613399520 I will take a look later this week. I have plans to review al the requirements and remove some conflicting ones.

[GitHub] [airflow] feluelle commented on issue #8228: Expose Airflow Webserver Port in Production Docker Image

feluelle commented on issue #8228: Expose Airflow Webserver Port in Production Docker Image URL: https://github.com/apache/airflow/pull/8228#issuecomment-613399645 Should I add docs regarding that in this PR? Just a note about what you said not using both at the same time?

[GitHub] [airflow] mik-laj commented on issue #8290: Add airflow info command

mik-laj commented on issue #8290: Add airflow info command URL: https://github.com/apache/airflow/pull/8290#issuecomment-613399205 @potiuk Do you know any service that allows us to add notes anonymously? I suspect that most services will require an API KEY.

[GitHub] [airflow] feluelle commented on issue #8228: Expose Airflow Webserver Port in Production Docker Image

feluelle commented on issue #8228: Expose Airflow Webserver Port in Production Docker Image URL: https://github.com/apache/airflow/pull/8228#issuecomment-613398714 Yes that is true. It is not only that - both are using the same database if for example both (by default) have backend mysql

[GitHub] [airflow] feluelle edited a comment on issue #8228: Expose Airflow Webserver Port in Production Docker Image

feluelle edited a comment on issue #8228: Expose Airflow Webserver Port in Production Docker Image URL: https://github.com/apache/airflow/pull/8228#issuecomment-613398714 Yes that is true. It is not only that - both are using the same database if for example both (by default) have backend

[GitHub] [airflow] potiuk commented on issue #8231: Dag bulk_sync_to_db dag_tag only remove not exists

potiuk commented on issue #8231: Dag bulk_sync_to_db dag_tag only remove not exists URL: https://github.com/apache/airflow/pull/8231#issuecomment-613398809 > I ran `tests.models.test_dag.TestDag.test_bulk_sync_to_db` test with query tracking. I love that we have this tool @mik-laj

[GitHub] [airflow] potiuk commented on issue #8228: Expose Airflow Webserver Port in Production Docker Image

potiuk commented on issue #8228: Expose Airflow Webserver Port in Production Docker Image URL: https://github.com/apache/airflow/pull/8228#issuecomment-613396962 I think there are more reasons why you cannot run both prod/ci in parallel - they use the same docker-compose configuration and

[GitHub] [airflow] mik-laj commented on issue #8231: Dag bulk_sync_to_db dag_tag only remove not exists

mik-laj commented on issue #8231: Dag bulk_sync_to_db dag_tag only remove not exists URL: https://github.com/apache/airflow/pull/8231#issuecomment-613395942 I ran `tests.models.test_dag.TestDag.test_bulk_sync_to_db` test with query tracking. ![Screenshot 2020-04-14 at 13 48

[GitHub] [airflow] feluelle edited a comment on issue #8228: Expose Airflow Webserver Port in Production Docker Image

feluelle edited a comment on issue #8228: Expose Airflow Webserver Port in Production Docker Image URL: https://github.com/apache/airflow/pull/8228#issuecomment-613394829 But then you won't be able to test prod image locally while having airflow ci running, because both are using the same

[GitHub] [airflow] potiuk commented on a change in pull request #8290: Add airflow info command

potiuk commented on a change in pull request #8290: Add airflow info command URL: https://github.com/apache/airflow/pull/8290#discussion_r408075141 ## File path: airflow/cli/commands/info_command.py ## @@ -0,0 +1,318 @@ +# Licensed to the Apache Software Foundation (ASF)

[GitHub] [airflow] feluelle commented on issue #8228: Expose Airflow Webserver Port in Production Docker Image

feluelle commented on issue #8228: Expose Airflow Webserver Port in Production Docker Image URL: https://github.com/apache/airflow/pull/8228#issuecomment-613394829 But then you won't be able to test prod image locally while having airflow ci running, because both are using the same port

[GitHub] [airflow] potiuk commented on a change in pull request #8290: Add airflow info command

potiuk commented on a change in pull request #8290: Add airflow info command URL: https://github.com/apache/airflow/pull/8290#discussion_r408073303 ## File path: airflow/cli/commands/info_command.py ## @@ -0,0 +1,318 @@ +# Licensed to the Apache Software Foundation (ASF)

[GitHub] [airflow] potiuk commented on issue #8228: Expose Airflow Webserver Port in Production Docker Image

potiuk commented on issue #8228: Expose Airflow Webserver Port in Production Docker Image URL: https://github.com/apache/airflow/pull/8228#issuecomment-613391557 Indeed. I think we should move ports to "base.yaml". I can't think of any reason why it would be harm.

[GitHub] [airflow] iamshwin commented on issue #8213: Fix issue #8163 where gcp auth fails

iamshwin commented on issue #8213: Fix issue #8163 where gcp auth fails URL: https://github.com/apache/airflow/pull/8213#issuecomment-613391202 @mik-laj, thanks for the help! This is an automated message from the Apache Git

[GitHub] [airflow] feluelle commented on issue #8228: Expose Airflow Webserver Port in Production Docker Image

feluelle commented on issue #8228: Expose Airflow Webserver Port in Production Docker Image URL: https://github.com/apache/airflow/pull/8228#issuecomment-613390895 But the `skip` mounting flag is misleading when we also map ports, isn't it? You won't think that when you do not mount you

[GitHub] [airflow] potiuk merged pull request #8294: Fixed typo in _PrestoToGCSPrestoCursorAdapter

potiuk merged pull request #8294: Fixed typo in _PrestoToGCSPrestoCursorAdapter URL: https://github.com/apache/airflow/pull/8294 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [airflow] feluelle commented on issue #8228: Expose Airflow Webserver Port in Production Docker Image

feluelle commented on issue #8228: Expose Airflow Webserver Port in Production Docker Image URL: https://github.com/apache/airflow/pull/8228#issuecomment-613389048 > we should not map the: "airflow, common, dags, requirements, scripts" in production image. They might be totally misleading

[GitHub] [airflow] feluelle edited a comment on issue #8228: Expose Airflow Webserver Port in Production Docker Image

feluelle edited a comment on issue #8228: Expose Airflow Webserver Port in Production Docker Image URL: https://github.com/apache/airflow/pull/8228#issuecomment-613389048 > we should not map the: "airflow, common, dags, requirements, scripts" in production image. They might be totally

[GitHub] [airflow] mik-laj opened a new pull request #8295: Fix TOC on "Presto To GCS Guide"

mik-laj opened a new pull request #8295: Fix TOC on "Presto To GCS Guide" URL: https://github.com/apache/airflow/pull/8295 Before:  After the

[GitHub] [airflow] codecov-io edited a comment on issue #8294: Fixed typo in _PrestoToGCSPrestoCursorAdapter

codecov-io edited a comment on issue #8294: Fixed typo in _PrestoToGCSPrestoCursorAdapter URL: https://github.com/apache/airflow/pull/8294#issuecomment-613388647 # [Codecov](https://codecov.io/gh/apache/airflow/pull/8294?src=pr=h1) Report > Merging

[GitHub] [airflow] codecov-io commented on issue #8294: Fixed typo in _PrestoToGCSPrestoCursorAdapter

codecov-io commented on issue #8294: Fixed typo in _PrestoToGCSPrestoCursorAdapter URL: https://github.com/apache/airflow/pull/8294#issuecomment-613388647 # [Codecov](https://codecov.io/gh/apache/airflow/pull/8294?src=pr=h1) Report > Merging

[GitHub] [airflow] feluelle edited a comment on issue #8228: Expose Airflow Webserver Port in Production Docker Image

feluelle edited a comment on issue #8228: Expose Airflow Webserver Port in Production Docker Image URL: https://github.com/apache/airflow/pull/8228#issuecomment-613384798 I also had an issue with volumes being mounted `GET`ting on `/home`: ``` Traceback (most recent call last):

[GitHub] [airflow] feluelle commented on issue #8229: Proper version is displayed when running prod image via Breeze

feluelle commented on issue #8229: Proper version is displayed when running prod image via Breeze URL: https://github.com/apache/airflow/pull/8229#issuecomment-613386403 Will do - thanks for helping :) This is an automated

[GitHub] [airflow] potiuk commented on issue #8229: Proper version is displayed when running prod image via Breeze

potiuk commented on issue #8229: Proper version is displayed when running prod image via Breeze URL: https://github.com/apache/airflow/pull/8229#issuecomment-613385311 Luckily I have not yet merged it so you can still fix it :)

[GitHub] [airflow] feluelle commented on a change in pull request #8228: Expose Airflow Webserver Port in Production Docker Image

feluelle commented on a change in pull request #8228: Expose Airflow Webserver Port in Production Docker Image URL: https://github.com/apache/airflow/pull/8228#discussion_r408062746 ## File path: scripts/ci/docker-compose/local-prod.yml ## @@ -0,0 +1,49 @@ +# Licensed to

[GitHub] [airflow] potiuk commented on issue #8229: Proper version is displayed when running prod image via Breeze

potiuk commented on issue #8229: Proper version is displayed when running prod image via Breeze URL: https://github.com/apache/airflow/pull/8229#issuecomment-613385135 YEah. I think the reason was source mapping to inside the container. I left comment in #8228 to remove all the

[GitHub] [airflow] feluelle commented on issue #8228: Expose Airflow Webserver Port in Production Docker Image

feluelle commented on issue #8228: Expose Airflow Webserver Port in Production Docker Image URL: https://github.com/apache/airflow/pull/8228#issuecomment-613384798 I also had an issue with volumes being mounted on `/home`: ``` Traceback (most recent call last): File

[GitHub] [airflow] potiuk commented on a change in pull request #8228: Expose Airflow Webserver Port in Production Docker Image

potiuk commented on a change in pull request #8228: Expose Airflow Webserver Port in Production Docker Image URL: https://github.com/apache/airflow/pull/8228#discussion_r408061941 ## File path: scripts/ci/docker-compose/local-prod.yml ## @@ -0,0 +1,49 @@ +# Licensed to

[GitHub] [airflow] feluelle commented on issue #8229: Proper version is displayed when running prod image via Breeze

feluelle commented on issue #8229: Proper version is displayed when running prod image via Breeze URL: https://github.com/apache/airflow/pull/8229#issuecomment-613383743 with `--skip-mounting-local-sources` I cannot reach the webserver probably because the compose file (local-prod) won't

[GitHub] [airflow] mik-laj commented on a change in pull request #8213: Fix issue #8163 where gcp auth fails

mik-laj commented on a change in pull request #8213: Fix issue #8163 where gcp auth fails URL: https://github.com/apache/airflow/pull/8213#discussion_r408059713 ## File path: tests/providers/google/common/hooks/test_base_google.py ## @@ -421,6 +421,19 @@ def

[GitHub] [airflow] mik-laj commented on a change in pull request #8213: Fix issue #8163 where gcp auth fails

mik-laj commented on a change in pull request #8213: Fix issue #8163 where gcp auth fails URL: https://github.com/apache/airflow/pull/8213#discussion_r408059997 ## File path: tests/providers/google/common/hooks/test_base_google.py ## @@ -421,6 +421,19 @@ def

[GitHub] [airflow] potiuk commented on issue #8229: Proper version is displayed when running prod image via Breeze

potiuk commented on issue #8229: Proper version is displayed when running prod image via Breeze URL: https://github.com/apache/airflow/pull/8229#issuecomment-613381547 Can you try the same with ``--skip-mounting-local-sources`` switch? I think this might be the reason and we might want to

[GitHub] [airflow] mik-laj commented on a change in pull request #8213: Fix issue #8163 where gcp auth fails

mik-laj commented on a change in pull request #8213: Fix issue #8163 where gcp auth fails URL: https://github.com/apache/airflow/pull/8213#discussion_r408058702 ## File path: tests/providers/google/common/hooks/test_base_google.py ## @@ -421,6 +421,19 @@ def

[GitHub] [airflow] mik-laj commented on issue #8291: Enforce Connections & Pools

mik-laj commented on issue #8291: Enforce Connections & Pools URL: https://github.com/apache/airflow/issues/8291#issuecomment-613380583 You can currently use cluster policy and set the appropriate pool for your tasks. https://airflow.readthedocs.io/en/latest/concepts.html#cluster-policy

[GitHub] [airflow] potiuk commented on issue #8229: Proper version is displayed when running prod image via Breeze

potiuk commented on issue #8229: Proper version is displayed when running prod image via Breeze URL: https://github.com/apache/airflow/pull/8229#issuecomment-613380876 it is :). Looking at it This is an automated message

[GitHub] [airflow] feluelle edited a comment on issue #8229: Proper version is displayed when running prod image via Breeze

feluelle edited a comment on issue #8229: Proper version is displayed when running prod image via Breeze URL: https://github.com/apache/airflow/pull/8229#issuecomment-613380034 @potiuk That is really weird -> `$AIRFLOW_VERSION` shows `1.10.10` also `airflow version` shows `1.10.10` but

[GitHub] [airflow] feluelle commented on issue #8229: Proper version is displayed when running prod image via Breeze

feluelle commented on issue #8229: Proper version is displayed when running prod image via Breeze URL: https://github.com/apache/airflow/pull/8229#issuecomment-613380034 @potiuk That is really weird -> `$AIRFLOW_VERSION` shows `1.10.10` also `airflow version` shows `1.10.10` but endpoint

[jira] [Commented] (AIRFLOW-603) db.py pessimistic_connection_handling not compatible with Oracle

[ https://issues.apache.org/jira/browse/AIRFLOW-603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17083114#comment-17083114 ] Kamil Bregula commented on AIRFLOW-603: --- In Oracle, it should be `SELECT 1 FROM dual;` > db.py

[GitHub] [airflow] michalslowikowski00 opened a new pull request #8294: Fixed typo in _PrestoToGCSPrestoCursorAdapter

michalslowikowski00 opened a new pull request #8294: Fixed typo in _PrestoToGCSPrestoCursorAdapter URL: https://github.com/apache/airflow/pull/8294 Fixed typo where param was **kwwargs --- Make sure to mark the boxes below before creating PR: [x] - [x] Description above

[GitHub] [airflow] mik-laj commented on issue #8293: Architecture diagram on Documentation is broken

mik-laj commented on issue #8293: Architecture diagram on Documentation is broken URL: https://github.com/apache/airflow/issues/8293#issuecomment-613344371 @kaxil Do you have graphviz installed? > The following additional application must be installed to use the project: > >

[jira] [Work started] (AIRFLOW-4357) Tool tip offset when using RBAC

[ https://issues.apache.org/jira/browse/AIRFLOW-4357?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on AIRFLOW-4357 started by Ash Berlin-Taylor. -- > Tool tip offset when using RBAC >

[GitHub] [airflow] ashb commented on a change in pull request #8269: [AIRFLOW-4357] Fix SVG tooltip positioning with custom scripting

ashb commented on a change in pull request #8269: [AIRFLOW-4357] Fix SVG tooltip positioning with custom scripting URL: https://github.com/apache/airflow/pull/8269#discussion_r408007203 ## File path: airflow/www/templates/airflow/dags.html ## @@ -554,5 +552,33 @@ DAGs

[GitHub] [airflow] turbaszek commented on a change in pull request #8240: GCP SparkR Example

turbaszek commented on a change in pull request #8240: GCP SparkR Example URL: https://github.com/apache/airflow/pull/8240#discussion_r406746389 ## File path: tests/providers/google/cloud/operators/test_dataproc_system.py ## @@ -35,16 +37,28 @@ print(words) """

<    1   2   3   4   >