[airflow] branch master updated: Don't reuse MY_DIR in breeze to mean different folder from ci/_utils.sh (#9098)

2020-06-01 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/master by this push: new 3dd81b7 Don't reuse MY_DIR in breeze to mean d

[GitHub] [airflow] potiuk merged pull request #9098: Don't reuse MY_DIR in breeze to mean different folder from ci/_utils.sh

2020-06-01 Thread GitBox
potiuk merged pull request #9098: URL: https://github.com/apache/airflow/pull/9098 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[airflow] branch master updated: Enable configurable git sync depth (#9094)

2020-06-01 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/master by this push: new 93e924d Enable configurable git sync depth (#

[GitHub] [airflow] potiuk merged pull request #9094: Fix/git sync depth

2020-06-01 Thread GitBox
potiuk merged pull request #9094: URL: https://github.com/apache/airflow/pull/9094 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #9094: Fix/git sync depth

2020-06-01 Thread GitBox
boring-cyborg[bot] commented on pull request #9094: URL: https://github.com/apache/airflow/pull/9094#issuecomment-637310122 Awesome work, congrats on your first merged pull request! This is an automated message from the A

[GitHub] [airflow-site] mschickensoup commented on a change in pull request #268: adding a logo for sift use case

2020-06-01 Thread GitBox
mschickensoup commented on a change in pull request #268: URL: https://github.com/apache/airflow-site/pull/268#discussion_r433649947 ## File path: landing-pages/site/content/en/use-cases/sift.md ## @@ -0,0 +1,32 @@ +--- +title: "Sift" +linkTitle: "Sift" +quote: +text: "Airf

[GitHub] [airflow] bertosantamaria commented on issue #8128: API Endpoints - CRUD - DAG Model

2020-06-01 Thread GitBox
bertosantamaria commented on issue #8128: URL: https://github.com/apache/airflow/issues/8128#issuecomment-637305330 Hi @mik-laj, Congrats on getting https://github.com/apache/airflow/pull/8721 merged. Now that it has cleared I’d love to start helping with this issue. Can I proceed by fo

[GitHub] [airflow] potiuk commented on pull request #9039: Updated missing parameters for docker image building

2020-06-01 Thread GitBox
potiuk commented on pull request #9039: URL: https://github.com/apache/airflow/pull/9039#issuecomment-637303768 @turbaszek @mik-laj -> simple doc change please :) This is an automated message from the Apache Git Service. To r

[GitHub] [airflow] potiuk commented on a change in pull request #8974: Vault has now VaultHook not only SecretBackend

2020-06-01 Thread GitBox
potiuk commented on a change in pull request #8974: URL: https://github.com/apache/airflow/pull/8974#discussion_r433642968 ## File path: airflow/providers/hashicorp/hooks/vault.py ## @@ -0,0 +1,310 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more cont

[GitHub] [airflow] potiuk commented on a change in pull request #8974: Vault has now VaultHook not only SecretBackend

2020-06-01 Thread GitBox
potiuk commented on a change in pull request #8974: URL: https://github.com/apache/airflow/pull/8974#discussion_r433628897 ## File path: airflow/providers/hashicorp/hooks/vault.py ## @@ -0,0 +1,310 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more cont

[GitHub] [airflow] mik-laj commented on a change in pull request #9001: Add airflow plugin command

2020-06-01 Thread GitBox
mik-laj commented on a change in pull request #9001: URL: https://github.com/apache/airflow/pull/9001#discussion_r433603683 ## File path: docs/plugins.rst ## @@ -28,6 +28,9 @@ The python modules in the ``plugins`` folder get imported, and **hooks**, **operators**, **sensors**,

[GitHub] [airflow] mik-laj commented on a change in pull request #9001: Add airflow plugin command

2020-06-01 Thread GitBox
mik-laj commented on a change in pull request #9001: URL: https://github.com/apache/airflow/pull/9001#discussion_r433603520 ## File path: tests/cli/commands/test_plugins_command.py ## @@ -0,0 +1,96 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more cont

[GitHub] [airflow] houqp commented on pull request #8721: Add OpenAPI specification (II)

2020-06-01 Thread GitBox
houqp commented on pull request #8721: URL: https://github.com/apache/airflow/pull/8721#issuecomment-637211126 thanks @mik-laj for driving this and congrats everyone for a big milestone :) This is an automated message from th

[jira] [Commented] (AIRFLOW-4851) Refactor K8S related code to use vendored k8s library

2020-06-01 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-4851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17121450#comment-17121450 ] ASF subversion and git services commented on AIRFLOW-4851: -- Co

[jira] [Commented] (AIRFLOW-4851) Refactor K8S related code to use vendored k8s library

2020-06-01 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-4851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17121449#comment-17121449 ] ASF subversion and git services commented on AIRFLOW-4851: -- Co

[jira] [Commented] (AIRFLOW-4851) Refactor K8S related code to use vendored k8s library

2020-06-01 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-4851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17121451#comment-17121451 ] ASF subversion and git services commented on AIRFLOW-4851: -- Co

[airflow] branch v1-10-test updated (e676e59 -> aaaa366)

2020-06-01 Thread dimberman
This is an automated email from the ASF dual-hosted git repository. dimberman pushed a change to branch v1-10-test in repository https://gitbox.apache.org/repos/asf/airflow.git. omit e676e59 [AIRFLOW-4851] Refactor K8S codebase with k8s API models (#5481) new 366 [AIRFLOW-4851] R

[jira] [Commented] (AIRFLOW-4851) Refactor K8S related code to use vendored k8s library

2020-06-01 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-4851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17121435#comment-17121435 ] ASF subversion and git services commented on AIRFLOW-4851: -- Co

[jira] [Commented] (AIRFLOW-4851) Refactor K8S related code to use vendored k8s library

2020-06-01 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-4851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17121434#comment-17121434 ] ASF subversion and git services commented on AIRFLOW-4851: -- Co

[jira] [Commented] (AIRFLOW-4851) Refactor K8S related code to use vendored k8s library

2020-06-01 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-4851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17121433#comment-17121433 ] ASF subversion and git services commented on AIRFLOW-4851: -- Co

[airflow] branch v1-10-test updated (0aff02b -> e676e59)

2020-06-01 Thread dimberman
This is an automated email from the ASF dual-hosted git repository. dimberman pushed a change to branch v1-10-test in repository https://gitbox.apache.org/repos/asf/airflow.git. omit 0aff02b [AIRFLOW-4851] Refactor K8S codebase with k8s API models (#5481) add e676e59 [AIRFLOW-4851] R

[jira] [Commented] (AIRFLOW-4851) Refactor K8S related code to use vendored k8s library

2020-06-01 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-4851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17121431#comment-17121431 ] ASF subversion and git services commented on AIRFLOW-4851: -- Co

[jira] [Commented] (AIRFLOW-4851) Refactor K8S related code to use vendored k8s library

2020-06-01 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-4851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17121429#comment-17121429 ] ASF subversion and git services commented on AIRFLOW-4851: -- Co

[jira] [Commented] (AIRFLOW-4851) Refactor K8S related code to use vendored k8s library

2020-06-01 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-4851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17121430#comment-17121430 ] ASF subversion and git services commented on AIRFLOW-4851: -- Co

[GitHub] [airflow] kaxil commented on a change in pull request #8974: Vault has now VaultHook not only SecretBackend

2020-06-01 Thread GitBox
kaxil commented on a change in pull request #8974: URL: https://github.com/apache/airflow/pull/8974#discussion_r433556742 ## File path: airflow/providers/hashicorp/hooks/vault.py ## @@ -0,0 +1,310 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contr

[jira] [Commented] (AIRFLOW-4851) Refactor K8S related code to use vendored k8s library

2020-06-01 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-4851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17121425#comment-17121425 ] ASF subversion and git services commented on AIRFLOW-4851: -- Co

[airflow] branch v1-10-test updated (0aff02b -> e676e59)

2020-06-01 Thread dimberman
This is an automated email from the ASF dual-hosted git repository. dimberman pushed a change to branch v1-10-test in repository https://gitbox.apache.org/repos/asf/airflow.git. omit 0aff02b [AIRFLOW-4851] Refactor K8S codebase with k8s API models (#5481) add e676e59 [AIRFLOW-4851] R

[jira] [Commented] (AIRFLOW-4851) Refactor K8S related code to use vendored k8s library

2020-06-01 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-4851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17121424#comment-17121424 ] ASF subversion and git services commented on AIRFLOW-4851: -- Co

[jira] [Commented] (AIRFLOW-4851) Refactor K8S related code to use vendored k8s library

2020-06-01 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-4851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17121426#comment-17121426 ] ASF subversion and git services commented on AIRFLOW-4851: -- Co

[airflow] branch v1-10-test updated (0aff02b -> e676e59)

2020-06-01 Thread dimberman
This is an automated email from the ASF dual-hosted git repository. dimberman pushed a change to branch v1-10-test in repository https://gitbox.apache.org/repos/asf/airflow.git. omit 0aff02b [AIRFLOW-4851] Refactor K8S codebase with k8s API models (#5481) add e676e59 [AIRFLOW-4851] R

[GitHub] [airflow] kaxil commented on a change in pull request #9001: Add airflow plugin command

2020-06-01 Thread GitBox
kaxil commented on a change in pull request #9001: URL: https://github.com/apache/airflow/pull/9001#discussion_r433553968 ## File path: tests/cli/commands/test_plugins_command.py ## @@ -0,0 +1,96 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contri

[GitHub] [airflow] kaxil commented on a change in pull request #9001: Add airflow plugin command

2020-06-01 Thread GitBox
kaxil commented on a change in pull request #9001: URL: https://github.com/apache/airflow/pull/9001#discussion_r433553631 ## File path: docs/plugins.rst ## @@ -28,6 +28,9 @@ The python modules in the ``plugins`` folder get imported, and **hooks**, **operators**, **sensors**, *

[GitHub] [airflow] mik-laj commented on pull request #9030: Allow using Airflow with Flask CLI

2020-06-01 Thread GitBox
mik-laj commented on pull request #9030: URL: https://github.com/apache/airflow/pull/9030#issuecomment-637179399 @turbaszek I fixed the side effects. Can you look at it again? This is an automated message from the Apache Git

[GitHub] [airflow] mik-laj commented on a change in pull request #9030: Allow using Airflow with Flask CLI

2020-06-01 Thread GitBox
mik-laj commented on a change in pull request #9030: URL: https://github.com/apache/airflow/pull/9030#discussion_r433541076 ## File path: tests/cli/commands/test_task_command.py ## @@ -170,9 +170,10 @@ def test_task_state(self): def test_task_states_for_dag_run(self):

[GitHub] [airflow] mik-laj commented on a change in pull request #9030: Allow using Airflow with Flask CLI

2020-06-01 Thread GitBox
mik-laj commented on a change in pull request #9030: URL: https://github.com/apache/airflow/pull/9030#discussion_r433541242 ## File path: tests/cli/commands/test_task_command.py ## @@ -201,7 +202,7 @@ def test_task_states_for_dag_run(self): tablefmt

[GitHub] [airflow] mik-laj commented on a change in pull request #9030: Allow using Airflow with Flask CLI

2020-06-01 Thread GitBox
mik-laj commented on a change in pull request #9030: URL: https://github.com/apache/airflow/pull/9030#discussion_r433540921 ## File path: tests/cli/commands/test_celery_command.py ## @@ -29,9 +29,6 @@ from airflow.configuration import conf from tests.test_utils.config import

[GitHub] [airflow] ashb opened a new pull request #9098: Don't reuse MY_DIR in breeze to mean different folder from ci/_utils.sh

2020-06-01 Thread GitBox
ashb opened a new pull request #9098: URL: https://github.com/apache/airflow/pull/9098 scripts/ci/*.sh uses MY_DIR to mean scripts/ci, but in `breeze` MY_DIR is the same as AIRFLOW_SOURCES. When jumping back-and-forth between ci/_utils.sh, breeze, and ci/ci_*.sh it can be confusing to

[GitHub] [airflow] kaxil closed issue #9053: Airflow scheduler not starting

2020-06-01 Thread GitBox
kaxil closed issue #9053: URL: https://github.com/apache/airflow/issues/9053 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

[GitHub] [airflow] mik-laj commented on issue #8630: Apache Beam 2.20.0 will break the DataFlowOperator

2020-06-01 Thread GitBox
mik-laj commented on issue #8630: URL: https://github.com/apache/airflow/issues/8630#issuecomment-637157009 I am working on a thorough modernization of integration with Dataflow, so in the next versions Airflow will have better support for this service. https://github.com/apache/airflow

[GitHub] [airflow] mik-laj commented on issue #8630: Apache Beam 2.20.0 will break the DataFlowOperator

2020-06-01 Thread GitBox
mik-laj commented on issue #8630: URL: https://github.com/apache/airflow/issues/8630#issuecomment-637156099 System tests are run manually, so they would not detect this problem. We hope to add system testing support to CI soon. However, this is not a commercial project, so it is not easy.

[GitHub] [airflow] aaltay commented on issue #8630: Apache Beam 2.20.0 will break the DataFlowOperator

2020-06-01 Thread GitBox
aaltay commented on issue #8630: URL: https://github.com/apache/airflow/issues/8630#issuecomment-637154317 As a future improvement, would it be possible to have an integration test using DataFlowOperator and beam head? This

[GitHub] [airflow] mik-laj merged pull request #8721: Add OpenAPI specification (II)

2020-06-01 Thread GitBox
mik-laj merged pull request #8721: URL: https://github.com/apache/airflow/pull/8721 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[airflow] branch master updated: Add OpenAPI specification (II) (#8721)

2020-06-01 Thread kamilbregula
This is an automated email from the ASF dual-hosted git repository. kamilbregula pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/master by this push: new 20f8982 Add OpenAPI specification (II) (

[GitHub] [airflow] mik-laj edited a comment on pull request #8721: Add OpenAPI specification (II)

2020-06-01 Thread GitBox
mik-laj edited a comment on pull request #8721: URL: https://github.com/apache/airflow/pull/8721#issuecomment-637060020 https://user-images.githubusercontent.com/12058428/83446606-3b26ed80-a44f-11ea-97a9-4047d22e64cd.png";> https://user-images.githubusercontent.com/12058428/83446608-3cf0b

[GitHub] [airflow] mik-laj commented on pull request #8721: Add OpenAPI specification (II)

2020-06-01 Thread GitBox
mik-laj commented on pull request #8721: URL: https://github.com/apache/airflow/pull/8721#issuecomment-637060020 https://user-images.githubusercontent.com/12058428/83446606-3b26ed80-a44f-11ea-97a9-4047d22e64cd.png";> https://user-images.githubusercontent.com/12058428/83446608-3cf0b100-a44

[GitHub] [airflow] ashb commented on pull request #8721: Add OpenAPI specification (II)

2020-06-01 Thread GitBox
ashb commented on pull request #8721: URL: https://github.com/apache/airflow/pull/8721#issuecomment-637056700 :tada: This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [airflow] kaxil commented on pull request #8721: Add OpenAPI specification (II)

2020-06-01 Thread GitBox
kaxil commented on pull request #8721: URL: https://github.com/apache/airflow/pull/8721#issuecomment-637055576 > Curious, wonder why Mergeable is failing here... Because of "dont-merge" label This is an automated messa

[GitHub] [airflow] ashb commented on pull request #8721: Add OpenAPI specification (II)

2020-06-01 Thread GitBox
ashb commented on pull request #8721: URL: https://github.com/apache/airflow/pull/8721#issuecomment-637055116 Curious, wonder why Mergeable is failing here... This is an automated message from the Apache Git Service. To respo

[GitHub] [airflow] ashb commented on pull request #9092: airflow_local_settings is not a "template" file

2020-06-01 Thread GitBox
ashb commented on pull request #9092: URL: https://github.com/apache/airflow/pull/9092#issuecomment-637049988 I made a hash of this PR, will re-ping once I've sorted it out. This is an automated message from the Apache Git Se

[GitHub] [airflow] ashb commented on pull request #9092: airflow_local_settings is not a "template" file

2020-06-01 Thread GitBox
ashb commented on pull request #9092: URL: https://github.com/apache/airflow/pull/9092#issuecomment-637049545 > Should we update docs? > https://airflow.readthedocs.io/en/latest/howto/write-logs.html#advanced-configuration Oh yes, good call. -

[GitHub] [airflow] mik-laj commented on a change in pull request #8721: Add OpenAPI specification (II)

2020-06-01 Thread GitBox
mik-laj commented on a change in pull request #8721: URL: https://github.com/apache/airflow/pull/8721#discussion_r433431474 ## File path: openapi.yaml ## @@ -0,0 +1,2411 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements.

[GitHub] [airflow] ashb commented on a change in pull request #8721: Add OpenAPI specification (II)

2020-06-01 Thread GitBox
ashb commented on a change in pull request #8721: URL: https://github.com/apache/airflow/pull/8721#discussion_r433425647 ## File path: openapi.yaml ## @@ -0,0 +1,2411 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. Se

[GitHub] [airflow] ashb commented on pull request #8721: Add OpenAPI specification (II)

2020-06-01 Thread GitBox
ashb commented on pull request #8721: URL: https://github.com/apache/airflow/pull/8721#issuecomment-637039960 Yeah not a fan of xcomKey vs key but not a blocker from me. This is an automated message from the Apache Git Servic

[GitHub] [airflow] ashb commented on a change in pull request #8721: Add OpenAPI specification (II)

2020-06-01 Thread GitBox
ashb commented on a change in pull request #8721: URL: https://github.com/apache/airflow/pull/8721#discussion_r433422217 ## File path: openapi.yaml ## @@ -0,0 +1,2412 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. Se

[GitHub] [airflow] ashb commented on a change in pull request #8721: Add OpenAPI specification (II)

2020-06-01 Thread GitBox
ashb commented on a change in pull request #8721: URL: https://github.com/apache/airflow/pull/8721#discussion_r433420019 ## File path: openapi.yaml ## @@ -0,0 +1,2412 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. Se

[GitHub] [airflow] samuelkhtu commented on issue #8525: SQLBranchOperator

2020-06-01 Thread GitBox
samuelkhtu commented on issue #8525: URL: https://github.com/apache/airflow/issues/8525#issuecomment-637028324 Hello @jeffolsi , the new operator is in. Maybe we can close this issue? This is an automated message from the Apa

[GitHub] [airflow] samuelkhtu commented on pull request #8942: #8525 Add SQL Branch Operator

2020-06-01 Thread GitBox
samuelkhtu commented on pull request #8942: URL: https://github.com/apache/airflow/pull/8942#issuecomment-637024265 > Nice @samuelkhtu ! Thank you everyone's help! @potiuk @mik-laj @eladkal This is an automated messag

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #8942: #8525 Add SQL Branch Operator

2020-06-01 Thread GitBox
boring-cyborg[bot] commented on pull request #8942: URL: https://github.com/apache/airflow/pull/8942#issuecomment-637023543 Awesome work, congrats on your first merged pull request! This is an automated message from the A

[GitHub] [airflow] potiuk commented on pull request #8942: #8525 Add SQL Branch Operator

2020-06-01 Thread GitBox
potiuk commented on pull request #8942: URL: https://github.com/apache/airflow/pull/8942#issuecomment-637023708 Nice @samuelkhtu ! This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [airflow] potiuk merged pull request #8942: #8525 Add SQL Branch Operator

2020-06-01 Thread GitBox
potiuk merged pull request #8942: URL: https://github.com/apache/airflow/pull/8942 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[airflow] branch master updated: #8525 Add SQL Branch Operator (#8942)

2020-06-01 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/master by this push: new 55b9b8f #8525 Add SQL Branch Operator (#8942)

[GitHub] [airflow] Fokko commented on pull request #8710: Make list trailing comma usage consistent

2020-06-01 Thread GitBox
Fokko commented on pull request #8710: URL: https://github.com/apache/airflow/pull/8710#issuecomment-637009002 There is an [AIP already](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=99844429) (more than a year ago). For me, it feels like we're being held back by Airflow

[GitHub] [airflow] samuelkhtu commented on a change in pull request #8942: #8525 Add SQL Branch Operator

2020-06-01 Thread GitBox
samuelkhtu commented on a change in pull request #8942: URL: https://github.com/apache/airflow/pull/8942#discussion_r433387332 ## File path: tests/operators/test_sql_branch_operator.py ## @@ -0,0 +1,479 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or m

[GitHub] [airflow] samuelkhtu commented on a change in pull request #8942: #8525 Add SQL Branch Operator

2020-06-01 Thread GitBox
samuelkhtu commented on a change in pull request #8942: URL: https://github.com/apache/airflow/pull/8942#discussion_r433382917 ## File path: airflow/operators/sql_branch_operator.py ## @@ -0,0 +1,174 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more co

[GitHub] [airflow] OmairK opened a new pull request #9097: [WIP] Scheama and CRUD endpoints Pool

2020-06-01 Thread GitBox
OmairK opened a new pull request #9097: URL: https://github.com/apache/airflow/pull/9097 --- Make sure to mark the boxes below before creating PR: [x] - [ ] Description above provides context of the change - [ ] Unit tests coverage for changes (not needed for documentation chang

[GitHub] [airflow] Hasan-J commented on pull request #9067: [AIRFLOW-8608] Make conn_id unique in Connections table

2020-06-01 Thread GitBox
Hasan-J commented on pull request #9067: URL: https://github.com/apache/airflow/pull/9067#issuecomment-636969504 I have removed the test method `test_connection_metastore_secrets_backend` in `tests/secrets/test_secrets_backends.py` based on the fact that it's using mutiple connections with

[GitHub] [airflow] boring-cyborg[bot] commented on issue #9096: Calendar Based Scheduling Pattern - Scheduler Feature in DAG

2020-06-01 Thread GitBox
boring-cyborg[bot] commented on issue #9096: URL: https://github.com/apache/airflow/issues/9096#issuecomment-636957855 Thanks for opening your first issue here! Be sure to follow the issue template! This is an automated

[GitHub] [airflow] abdul-786 opened a new issue #9096: Calendar Based Scheduling Pattern - Scheduler Feature in DAG

2020-06-01 Thread GitBox
abdul-786 opened a new issue #9096: URL: https://github.com/apache/airflow/issues/9096 The current airflow scheduler architecture can scan the DAG, understand the cron schedule defined in the DAG and submit a task to a local/remote executor. This works best for most of use cases to automat

[GitHub] [airflow] houqp commented on a change in pull request #8721: Add OpenAPI specification (II)

2020-06-01 Thread GitBox
houqp commented on a change in pull request #8721: URL: https://github.com/apache/airflow/pull/8721#discussion_r433323200 ## File path: openapi.yaml ## @@ -0,0 +1,2412 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. S

[GitHub] [airflow] eladkal commented on a change in pull request #8942: #8525 Add SQL Branch Operator

2020-06-01 Thread GitBox
eladkal commented on a change in pull request #8942: URL: https://github.com/apache/airflow/pull/8942#discussion_r433322424 ## File path: tests/operators/test_sql_branch_operator.py ## @@ -0,0 +1,479 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more

[GitHub] [airflow] potiuk commented on pull request #8721: Add OpenAPI specification (II)

2020-06-01 Thread GitBox
potiuk commented on pull request #8721: URL: https://github.com/apache/airflow/pull/8721#issuecomment-636919618 I think we should submit with xcom_key as we know that it at least compile in open-api generator. So I suggest we merge it as is. @ashb -> I think the two interns are pretty muc

[GitHub] [airflow] seelmann edited a comment on pull request #9087: Query TaskReschedule only if task is UP_FOR_RESCHEDULE

2020-06-01 Thread GitBox
seelmann edited a comment on pull request #9087: URL: https://github.com/apache/airflow/pull/9087#issuecomment-636907078 Makes perfect sense, +1. Another optimization could be to not fetch all `TaskReschedule` objects but only the first one. Similar in `ready_to_reschedule.py` only t

[GitHub] [airflow] seelmann commented on pull request #9087: Query TaskReschedule only if task is UP_FOR_RESCHEDULE

2020-06-01 Thread GitBox
seelmann commented on pull request #9087: URL: https://github.com/apache/airflow/pull/9087#issuecomment-636907078 Makes perfect sense, +1. Another optimization could be to not fetch all `TaskReschedule` objects but only the first one. Similar in `ready_to_reschedule.py` only the last

[GitHub] [airflow] ephraimbuddy opened a new pull request #9095: [WIP] Add connection schema

2020-06-01 Thread GitBox
ephraimbuddy opened a new pull request #9095: URL: https://github.com/apache/airflow/pull/9095 --- Make sure to mark the boxes below before creating PR: [x] - [ ] Description above provides context of the change - [ ] Unit tests coverage for changes (not needed for documentation

[GitHub] [airflow] mik-laj edited a comment on pull request #8721: Add OpenAPI specification (II)

2020-06-01 Thread GitBox
mik-laj edited a comment on pull request #8721: URL: https://github.com/apache/airflow/pull/8721#issuecomment-636904636 Can I still help in finishing this change? I think that the discussion between `xcom_key` and `key` is not a big issues, and even goes beyond the scope of this change. We

[GitHub] [airflow] mik-laj commented on pull request #8721: Add OpenAPI specification (II)

2020-06-01 Thread GitBox
mik-laj commented on pull request #8721: URL: https://github.com/apache/airflow/pull/8721#issuecomment-636904636 Can I still help in finishing this change? I think that the discussion between `xcom_key` and `key` is not a significant barrier, and even goes beyond the scope of this change.

[GitHub] [airflow] kaxil commented on a change in pull request #9094: Fix/git sync depth

2020-06-01 Thread GitBox
kaxil commented on a change in pull request #9094: URL: https://github.com/apache/airflow/pull/9094#discussion_r433265857 ## File path: airflow/config_templates/config.yml ## @@ -1945,6 +1945,14 @@ type: string example: ~ default: "" +- name: git_sync_d

[GitHub] [airflow] potiuk commented on a change in pull request #9094: Fix/git sync depth

2020-06-01 Thread GitBox
potiuk commented on a change in pull request #9094: URL: https://github.com/apache/airflow/pull/9094#discussion_r433264206 ## File path: airflow/config_templates/config.yml ## @@ -1945,6 +1945,14 @@ type: string example: ~ default: "" +- name: git_sync_

[GitHub] [airflow] mgorsk1 opened a new pull request #9094: Fix/git sync depth

2020-06-01 Thread GitBox
mgorsk1 opened a new pull request #9094: URL: https://github.com/apache/airflow/pull/9094 This PR resolves bug https://github.com/apache/airflow/issues/9093 --- Make sure to mark the boxes below before creating PR: [x] - [x] Description above provides context of the change

[GitHub] [airflow] potiuk closed pull request #8710: Make list trailing comma usage consistent

2020-06-01 Thread GitBox
potiuk closed pull request #8710: URL: https://github.com/apache/airflow/pull/8710 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [airflow] potiuk commented on pull request #8710: Make list trailing comma usage consistent

2020-06-01 Thread GitBox
potiuk commented on pull request #8710: URL: https://github.com/apache/airflow/pull/8710#issuecomment-636887320 @tedmiston - I do appreciate intentions, and I perfectly understand your thinking. That would also be my natural instinct what you described and I did it in the past in Airflow -

[GitHub] [airflow] mgorsk1 opened a new issue #9093: Enable configuration for GIT_SYNC_DEPTH in Kubernetes Executor

2020-06-01 Thread GitBox
mgorsk1 opened a new issue #9093: URL: https://github.com/apache/airflow/issues/9093 **Apache Airflow version**: 1.10.7 **Kubernetes version (if you are using kubernetes)** (use `kubectl version`): ~/PycharmProjects » oc version

[GitHub] [airflow] boring-cyborg[bot] commented on issue #9093: Enable configuration for GIT_SYNC_DEPTH in Kubernetes Executor

2020-06-01 Thread GitBox
boring-cyborg[bot] commented on issue #9093: URL: https://github.com/apache/airflow/issues/9093#issuecomment-636881077 Thanks for opening your first issue here! Be sure to follow the issue template! This is an automated

[GitHub] [airflow] mik-laj commented on pull request #9092: airflow_local_settings is not a "template" file

2020-06-01 Thread GitBox
mik-laj commented on pull request #9092: URL: https://github.com/apache/airflow/pull/9092#issuecomment-636875319 Should we update docs? https://airflow.readthedocs.io/en/latest/howto/write-logs.html#advanced-configuration

[GitHub] [airflow] mik-laj commented on a change in pull request #9092: airflow_local_settings is not a "template" file

2020-06-01 Thread GitBox
mik-laj commented on a change in pull request #9092: URL: https://github.com/apache/airflow/pull/9092#discussion_r433248371 ## File path: airflow/logging_config.py ## @@ -99,3 +103,234 @@ def _get_handler(name): "Configured task_log_reader {!r} was not a handle

[GitHub] [airflow] ashb commented on a change in pull request #9092: airflow_local_settings is not a "template" file

2020-06-01 Thread GitBox
ashb commented on a change in pull request #9092: URL: https://github.com/apache/airflow/pull/9092#discussion_r433246412 ## File path: airflow/config_templates/airflow_local_settings.py ## @@ -15,242 +15,15 @@ # KIND, either express or implied. See the License for the # spec

[jira] [Commented] (AIRFLOW-6786) Adding KafkaConsumerHook, KafkaProducerHook, and KafkaSensor

2020-06-01 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-6786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17121027#comment-17121027 ] ASF GitHub Bot commented on AIRFLOW-6786: - dferguson992 commented on pull reque

[GitHub] [airflow] dferguson992 commented on pull request #7407: [AIRFLOW-6786] Add KafkaConsumerHook, KafkaProduerHook and KafkaSensor

2020-06-01 Thread GitBox
dferguson992 commented on pull request #7407: URL: https://github.com/apache/airflow/pull/7407#issuecomment-636867130 okay so this one is confusing me. currently the build is halted during the "backport packages" build step because of the following error: "ModuleNotFoundError: No module n

[GitHub] [airflow] mik-laj commented on issue #9083: Links to Stackdriver in WebUI

2020-06-01 Thread GitBox
mik-laj commented on issue #9083: URL: https://github.com/apache/airflow/issues/9083#issuecomment-636860585 @mdediana I assigned you to this ticket. This is an automated message from the Apache Git Service. To respond to the

[GitHub] [airflow] mdediana commented on issue #9083: Links to Stackdriver in WebUI

2020-06-01 Thread GitBox
mdediana commented on issue #9083: URL: https://github.com/apache/airflow/issues/9083#issuecomment-636859913 @mik-laj I can work on this. This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] [airflow] mik-laj commented on a change in pull request #9091: [WIP] [8649] Add support for multiple cron expressions as schedule interval

2020-06-01 Thread GitBox
mik-laj commented on a change in pull request #9091: URL: https://github.com/apache/airflow/pull/9091#discussion_r433226615 ## File path: airflow/models/dag.py ## @@ -59,7 +58,7 @@ log = logging.getLogger(__name__) -ScheduleInterval = Union[str, timedelta, relativedelta] +

[GitHub] [airflow] kaxil commented on a change in pull request #9092: airflow_local_settings is not a "template" file

2020-06-01 Thread GitBox
kaxil commented on a change in pull request #9092: URL: https://github.com/apache/airflow/pull/9092#discussion_r433224247 ## File path: airflow/logging_config.py ## @@ -54,8 +58,8 @@ def configure_logging(): else: logging_class_path = 'airflow.config_templates.' \

[GitHub] [airflow] kaxil commented on a change in pull request #9092: airflow_local_settings is not a "template" file

2020-06-01 Thread GitBox
kaxil commented on a change in pull request #9092: URL: https://github.com/apache/airflow/pull/9092#discussion_r433224621 ## File path: airflow/logging_config.py ## @@ -54,8 +58,8 @@ def configure_logging(): else: logging_class_path = 'airflow.config_templates.' \

[GitHub] [airflow] kaxil commented on a change in pull request #9092: airflow_local_settings is not a "template" file

2020-06-01 Thread GitBox
kaxil commented on a change in pull request #9092: URL: https://github.com/apache/airflow/pull/9092#discussion_r433223379 ## File path: airflow/logging_config.py ## @@ -54,8 +58,8 @@ def configure_logging(): else: logging_class_path = 'airflow.config_templates.' \

[GitHub] [airflow] mik-laj commented on pull request #8710: Make list trailing comma usage consistent

2020-06-01 Thread GitBox
mik-laj commented on pull request #8710: URL: https://github.com/apache/airflow/pull/8710#issuecomment-636851283 You can use the activity graph when choosing a reviewer. Just choose one person at random and ping them. https://github.com/apache/airflow/pulse

[GitHub] [airflow] kaxil commented on a change in pull request #9092: airflow_local_settings is not a "template" file

2020-06-01 Thread GitBox
kaxil commented on a change in pull request #9092: URL: https://github.com/apache/airflow/pull/9092#discussion_r433222777 ## File path: airflow/logging_config.py ## @@ -54,8 +58,8 @@ def configure_logging(): else: logging_class_path = 'airflow.config_templates.' \

[GitHub] [airflow] mik-laj commented on pull request #8710: Make list trailing comma usage consistent

2020-06-01 Thread GitBox
mik-laj commented on pull request #8710: URL: https://github.com/apache/airflow/pull/8710#issuecomment-636850131 Now we have a lot of differences between Airflow 1.10 and 2.0, so even more every conflict is even more painful. However, I am not a release manager, so I do not want to take th

[GitHub] [airflow] kaxil commented on a change in pull request #9092: airflow_local_settings is not a "template" file

2020-06-01 Thread GitBox
kaxil commented on a change in pull request #9092: URL: https://github.com/apache/airflow/pull/9092#discussion_r433221380 ## File path: airflow/config_templates/airflow_local_settings.py ## @@ -15,242 +15,15 @@ # KIND, either express or implied. See the License for the # spe

[GitHub] [airflow] kaxil commented on a change in pull request #9092: airflow_local_settings is not a "template" file

2020-06-01 Thread GitBox
kaxil commented on a change in pull request #9092: URL: https://github.com/apache/airflow/pull/9092#discussion_r433221096 ## File path: airflow/config_templates/airflow_local_settings.py ## @@ -15,242 +15,15 @@ # KIND, either express or implied. See the License for the # spe

[GitHub] [airflow] kaxil commented on a change in pull request #9092: airflow_local_settings is not a "template" file

2020-06-01 Thread GitBox
kaxil commented on a change in pull request #9092: URL: https://github.com/apache/airflow/pull/9092#discussion_r433220734 ## File path: UPDATING.md ## @@ -458,6 +458,15 @@ The following configurations have been moved from `[core]` to the new `[logging] * `dag_processor_manage

  1   2   >