[GitHub] [airflow] mik-laj commented on pull request #9283: Allow Lazy Logging

2020-06-14 Thread GitBox
mik-laj commented on pull request #9283: URL: https://github.com/apache/airflow/pull/9283#issuecomment-643734491 It should be detected by pylint. Why it not works? Should we change pylint configuration? logging-not-lazy (W1201): Specify string format arguments as logging func

[GitHub] [airflow] mik-laj commented on pull request #9281: Merge comparisons with "in" operator in DagBag

2020-06-14 Thread GitBox
mik-laj commented on pull request #9281: URL: https://github.com/apache/airflow/pull/9281#issuecomment-643734783 Should it be detected by pylint or other linter? This is an automated message from the Apache Git Service. To re

[GitHub] [airflow] mik-laj commented on pull request #9282: Simplify "if expression" to increase the code readability

2020-06-14 Thread GitBox
mik-laj commented on pull request #9282: URL: https://github.com/apache/airflow/pull/9282#issuecomment-643734927 Should it be detected by pylint? simplifiable-if-statement (R0102): The if statement can be replaced with %s Used when an if statement can be replaced with ‘bool(t

[GitHub] [airflow] boring-cyborg[bot] commented on issue #9285: Webserver with "old ui" wont render after upgrade 1.10.2 -> 1.10.10 because wrong check conditions

2020-06-14 Thread GitBox
boring-cyborg[bot] commented on issue #9285: URL: https://github.com/apache/airflow/issues/9285#issuecomment-643740822 Thanks for opening your first issue here! Be sure to follow the issue template! This is an automated

[GitHub] [airflow] efisher-ias opened a new issue #9285: Webserver with "old ui" wont render after upgrade 1.10.2 -> 1.10.10 because wrong check conditions

2020-06-14 Thread GitBox
efisher-ias opened a new issue #9285: URL: https://github.com/apache/airflow/issues/9285 --> **Apache Airflow version**: 1.10.10 **Kubernetes version (if you are using kubernetes)** (use `kubectl version`): NA **Environment**: - **Cloud provider or hardware confi

[GitHub] [airflow] zorseti commented on issue #9166: DAG run fails when task instance is still running

2020-06-14 Thread GitBox
zorseti commented on issue #9166: URL: https://github.com/apache/airflow/issues/9166#issuecomment-643746964 May be you have set dagrun_timeout in your dag? This is an automated message from the Apache Git Service. To respond

[GitHub] [airflow] ashb commented on pull request #9276: Add airflow upgrade_check command (MVP)

2020-06-14 Thread GitBox
ashb commented on pull request #9276: URL: https://github.com/apache/airflow/pull/9276#issuecomment-643751191 A nice framework This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [airflow] ashb commented on a change in pull request #9276: Add airflow upgrade_check command (MVP)

2020-06-14 Thread GitBox
ashb commented on a change in pull request #9276: URL: https://github.com/apache/airflow/pull/9276#discussion_r439817307 ## File path: airflow/upgrade/rules/conn_type_is_not_nullable.py ## @@ -0,0 +1,43 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more

[GitHub] [airflow] ashb commented on pull request #9276: Add airflow upgrade_check command (MVP)

2020-06-14 Thread GitBox
ashb commented on pull request #9276: URL: https://github.com/apache/airflow/pull/9276#issuecomment-643751631 We should possibly just so this directly on 1.10 branches though. The way I said we would do upgrades was "install latest 1.10 version, fix warnings, then install 2.0”. Doing

[GitHub] [airflow] ashb commented on a change in pull request #9276: Add airflow upgrade_check command (MVP)

2020-06-14 Thread GitBox
ashb commented on a change in pull request #9276: URL: https://github.com/apache/airflow/pull/9276#discussion_r439817070 ## File path: airflow/upgrade/formatters/base_formatter.py ## @@ -0,0 +1,33 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contr

[GitHub] [airflow] kaxil merged pull request #9284: Remove trailing comma in setup_backport_packages.py

2020-06-14 Thread GitBox
kaxil merged pull request #9284: URL: https://github.com/apache/airflow/pull/9284 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[airflow] branch master updated (1698db4 -> d066d33)

2020-06-14 Thread kaxilnaik
This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git. from 1698db4 Update pre-commit-hooks repo version (#9195) add d066d33 Remove trailing comma in setup_backport_p

[airflow] branch master updated (1698db4 -> d066d33)

2020-06-14 Thread kaxilnaik
This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git. from 1698db4 Update pre-commit-hooks repo version (#9195) add d066d33 Remove trailing comma in setup_backport_p

[GitHub] [airflow] zorseti commented on issue #8521: MySQL deadlock when using DAG serialization

2020-06-14 Thread GitBox
zorseti commented on issue #8521: URL: https://github.com/apache/airflow/issues/8521#issuecomment-643755226 I encountered the same problem. Is this problem solved now? The following two SQL statements will report an error: ERROR - (_mysql_exceptions.OperationalError) (1213, 'Deadlock f

[GitHub] [airflow] kaxil merged pull request #9281: Merge comparisons with "in" operator in DagBag

2020-06-14 Thread GitBox
kaxil merged pull request #9281: URL: https://github.com/apache/airflow/pull/9281 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [airflow] kaxil commented on pull request #9281: Merge comparisons with "in" operator in DagBag

2020-06-14 Thread GitBox
kaxil commented on pull request #9281: URL: https://github.com/apache/airflow/pull/9281#issuecomment-643755795 > Should it be detected by pylint or other linter? Yup will take a look today on our pylint configs This is

[airflow] branch master updated (d066d33 -> e148f34)

2020-06-14 Thread kaxilnaik
This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git. from d066d33 Remove trailing comma in setup_backport_packages.py (#9284) add e148f34 Merge comparisons with "in

[GitHub] [airflow] kaxil merged pull request #9283: Allow Lazy Logging

2020-06-14 Thread GitBox
kaxil merged pull request #9283: URL: https://github.com/apache/airflow/pull/9283 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [airflow] kaxil commented on pull request #9283: Allow Lazy Logging

2020-06-14 Thread GitBox
kaxil commented on pull request #9283: URL: https://github.com/apache/airflow/pull/9283#issuecomment-643755857 > It should be detected by pylint. Why it not works? Should we change pylint configuration? > > logging-not-lazy (W1201): > Specify string format arguments as logging fun

[airflow] branch master updated (e148f34 -> ea7a8f7)

2020-06-14 Thread kaxilnaik
This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git. from e148f34 Merge comparisons with "in" operator in DagBag (#9281) add ea7a8f7 Allow Lazy Logging (#9283) No

[GitHub] [airflow] ephraimbuddy commented on a change in pull request #9227: Add event log endpoints

2020-06-14 Thread GitBox
ephraimbuddy commented on a change in pull request #9227: URL: https://github.com/apache/airflow/pull/9227#discussion_r439822479 ## File path: airflow/api_connexion/endpoints/event_log_endpoint.py ## @@ -15,19 +15,42 @@ # specific language governing permissions and limitations

[GitHub] [airflow] ephraimbuddy commented on pull request #9273: implement api v1 for variables

2020-06-14 Thread GitBox
ephraimbuddy commented on pull request #9273: URL: https://github.com/apache/airflow/pull/9273#issuecomment-643758547 > @OmairK the api tests should have already covered serialization and deserialization code path, no? Do you have an example in mind where a refactor will cause issue that w

[GitHub] [airflow] kaxil commented on a change in pull request #9227: Add event log endpoints

2020-06-14 Thread GitBox
kaxil commented on a change in pull request #9227: URL: https://github.com/apache/airflow/pull/9227#discussion_r439823752 ## File path: airflow/api_connexion/endpoints/event_log_endpoint.py ## @@ -15,19 +15,42 @@ # specific language governing permissions and limitations # und

[GitHub] [airflow] kaxil opened a new pull request #9286: Make airflow/settings.py Pylint compatible

2020-06-14 Thread GitBox
kaxil opened a new pull request #9286: URL: https://github.com/apache/airflow/pull/9286 Pylint wasn't detecting logging issues in settings.py file as it was included in pylint todo list --- Make sure to mark the boxes below before creating PR: [x] - [x] Description above pr

[GitHub] [airflow] stale[bot] closed pull request #7632: [AIRFLOW-6991] Allow passing arbitrary arguments to psycopg2

2020-06-14 Thread GitBox
stale[bot] closed pull request #7632: URL: https://github.com/apache/airflow/pull/7632 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [airflow] stale[bot] commented on pull request #8639: Fix typo

2020-06-14 Thread GitBox
stale[bot] commented on pull request #8639: URL: https://github.com/apache/airflow/pull/8639#issuecomment-643759810 This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[jira] [Commented] (AIRFLOW-6991) Allow setting search_path in connection UI for postgres connections

2020-06-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-6991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17135137#comment-17135137 ] ASF GitHub Bot commented on AIRFLOW-6991: - stale[bot] closed pull request #7632

[GitHub] [airflow] kaxil opened a new pull request #9287: Make experimental/endpoints.py Pylint compatible

2020-06-14 Thread GitBox
kaxil opened a new pull request #9287: URL: https://github.com/apache/airflow/pull/9287 Make experimental/endpoints.py Pylint compatible --- Make sure to mark the boxes below before creating PR: [x] - [x] Description above provides context of the change - [x] Unit tests c

[GitHub] [airflow] kaxil merged pull request #9286: Make airflow/settings.py Pylint compatible

2020-06-14 Thread GitBox
kaxil merged pull request #9286: URL: https://github.com/apache/airflow/pull/9286 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[airflow] branch master updated (ea7a8f7 -> 2dc85a9)

2020-06-14 Thread kaxilnaik
This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git. from ea7a8f7 Allow Lazy Logging (#9283) add 2dc85a9 Make airflow/settings.py Pylint compatible (#9286) No new

[GitHub] [airflow] kaxil opened a new pull request #9288: Make airflow/models/errors.py Pylint compatible

2020-06-14 Thread GitBox
kaxil opened a new pull request #9288: URL: https://github.com/apache/airflow/pull/9288 Make airflow/models/errors.py Pylint compatible --- Make sure to mark the boxes below before creating PR: [x] - [x] Description above provides context of the change - [x] Unit tests co

[GitHub] [airflow] kaxil opened a new pull request #9289: Make airflow/models/skipmixin.py Pylint compatible

2020-06-14 Thread GitBox
kaxil opened a new pull request #9289: URL: https://github.com/apache/airflow/pull/9289 Make airflow/models/skipmixin.py Pylint compatible --- Make sure to mark the boxes below before creating PR: [x] - [x] Description above provides context of the change - [x] Unit tests

[GitHub] [airflow] ephraimbuddy commented on a change in pull request #9170: [WIP] Read only endpoint for XCom #8134

2020-06-14 Thread GitBox
ephraimbuddy commented on a change in pull request #9170: URL: https://github.com/apache/airflow/pull/9170#discussion_r439827391 ## File path: airflow/api_connexion/endpoints/xcom_endpoint.py ## @@ -26,18 +32,35 @@ def delete_xcom_entry(): raise NotImplementedError("Not im

[airflow] branch revert-9286-settings.py-compatible created (now c269432)

2020-06-14 Thread kaxilnaik
This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a change to branch revert-9286-settings.py-compatible in repository https://gitbox.apache.org/repos/asf/airflow.git. at c269432 Revert "Make airflow/settings.py Pylint compatible (#9286)" This branch inc

[airflow] 01/01: Revert "Make airflow/settings.py Pylint compatible (#9286)"

2020-06-14 Thread kaxilnaik
This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a commit to branch revert-9286-settings.py-compatible in repository https://gitbox.apache.org/repos/asf/airflow.git commit c2694321630bdf5eba8aeb708cc900ef93bbe52a Author: Kaxil Naik AuthorDate: Sun Jun 14 14:07

[GitHub] [airflow] kaxil commented on a change in pull request #9227: Add event log endpoints

2020-06-14 Thread GitBox
kaxil commented on a change in pull request #9227: URL: https://github.com/apache/airflow/pull/9227#discussion_r439835162 ## File path: tests/api_connexion/schemas/test_event_log_schema.py ## @@ -0,0 +1,126 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or

[GitHub] [airflow] kaxil commented on a change in pull request #9227: Add event log endpoints

2020-06-14 Thread GitBox
kaxil commented on a change in pull request #9227: URL: https://github.com/apache/airflow/pull/9227#discussion_r439835162 ## File path: tests/api_connexion/schemas/test_event_log_schema.py ## @@ -0,0 +1,126 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #9290: Detect automatically the lack of reference to the guide in the operator descriptions

2020-06-14 Thread GitBox
boring-cyborg[bot] commented on pull request #9290: URL: https://github.com/apache/airflow/pull/9290#issuecomment-643773538 Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contr

[GitHub] [airflow] ivan-afonichkin opened a new pull request #9290: Detect automatically the lack of reference to the guide in the operator descriptions

2020-06-14 Thread GitBox
ivan-afonichkin opened a new pull request #9290: URL: https://github.com/apache/airflow/pull/9290 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

[GitHub] [airflow] ivan-afonichkin commented on issue #8894: Detect automatically the lack of reference to the guide in the operator descriptions

2020-06-14 Thread GitBox
ivan-afonichkin commented on issue #8894: URL: https://github.com/apache/airflow/issues/8894#issuecomment-643775828 Hello @mik-laj, I created PR to tackle this issue using the first approach you suggested (make it directly through `docs/build` without importing any modules). Would you mind

[GitHub] [airflow] kaxil commented on issue #9285: Webserver with "old ui" wont render after upgrade 1.10.2 -> 1.10.10 because wrong check conditions

2020-06-14 Thread GitBox
kaxil commented on issue #9285: URL: https://github.com/apache/airflow/issues/9285#issuecomment-643779253 Duplicate of https://github.com/apache/airflow/issues/8752 This is an automated message from the Apache Git Service. To

[GitHub] [airflow] kaxil closed issue #9285: Webserver with "old ui" wont render after upgrade 1.10.2 -> 1.10.10 because wrong check conditions

2020-06-14 Thread GitBox
kaxil closed issue #9285: URL: https://github.com/apache/airflow/issues/9285 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

[GitHub] [airflow] kaxil opened a new pull request #9292: Fix cyclic imports

2020-06-14 Thread GitBox
kaxil opened a new pull request #9292: URL: https://github.com/apache/airflow/pull/9292 Fixes the following error: ``` * Module airflow.providers.yandex.hooks.yandex airflow/providers/yandex/hooks/yandex.py:1:0: R0401: Cyclic import (airflow.settings -> airflow.util

[GitHub] [airflow] mik-laj opened a new pull request #9291: Refactor create_app in airflow/www/app.py

2020-06-14 Thread GitBox
mik-laj opened a new pull request #9291: URL: https://github.com/apache/airflow/pull/9291 This function was too long. It was very difficult to trace how it works. I divided it into 15 functions in 7 modules, which I am sure will facilitate its development. This file was also excluded from

[GitHub] [airflow] kaxil commented on issue #9275: Decrypt secrets from SystemsManagerParameterStoreBackend

2020-06-14 Thread GitBox
kaxil commented on issue #9275: URL: https://github.com/apache/airflow/issues/9275#issuecomment-643780290 Related PR: https://github.com/apache/airflow/pull/9214 This is an automated message from the Apache Git Service. To re

[GitHub] [airflow] mik-laj commented on issue #8894: Detect automatically the lack of reference to the guide in the operator descriptions

2020-06-14 Thread GitBox
mik-laj commented on issue #8894: URL: https://github.com/apache/airflow/issues/8894#issuecomment-643780803 @ivan-afonichkin I will try to look at it on Monday. I am very happy that this has been achieved. I did not think that so many problems could be detected. --

[GitHub] [airflow] stale[bot] commented on pull request #7682: [AIRFLOW-7031] Airflow WinRM endpoint is hardcoded to HTTP

2020-06-14 Thread GitBox
stale[bot] commented on pull request #7682: URL: https://github.com/apache/airflow/pull/7682#issuecomment-643781682 This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[jira] [Commented] (AIRFLOW-7031) Airflow WinRM endpoint is hardcoded to HTTP

2020-06-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-7031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17135195#comment-17135195 ] ASF GitHub Bot commented on AIRFLOW-7031: - stale[bot] commented on pull request

[GitHub] [airflow] kaxil merged pull request #9292: Fix cyclic imports

2020-06-14 Thread GitBox
kaxil merged pull request #9292: URL: https://github.com/apache/airflow/pull/9292 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[airflow] branch master updated (2dc85a9 -> ce589d8)

2020-06-14 Thread kaxilnaik
This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git. from 2dc85a9 Make airflow/settings.py Pylint compatible (#9286) add ce589d8 Fix cyclic imports (#9292) No new

[GitHub] [airflow] kaxil commented on a change in pull request #9291: Refactor create_app in airflow/www/app.py

2020-06-14 Thread GitBox
kaxil commented on a change in pull request #9291: URL: https://github.com/apache/airflow/pull/9291#discussion_r439842919 ## File path: airflow/www/extensions/init_security.py ## @@ -0,0 +1,44 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contribut

[GitHub] [airflow] kaxil commented on a change in pull request #9291: Refactor create_app in airflow/www/app.py

2020-06-14 Thread GitBox
kaxil commented on a change in pull request #9291: URL: https://github.com/apache/airflow/pull/9291#discussion_r439843127 ## File path: airflow/www/extensions/init_views.py ## @@ -0,0 +1,118 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor

[GitHub] [airflow] mik-laj commented on pull request #9291: Refactor create_app in airflow/www/app.py

2020-06-14 Thread GitBox
mik-laj commented on pull request #9291: URL: https://github.com/apache/airflow/pull/9291#issuecomment-643785824 @kaxil Fixed. Thank you so much for the quick review. This is an automated message from the Apache Git Service.

[GitHub] [airflow] mik-laj commented on a change in pull request #9291: Refactor create_app in airflow/www/app.py

2020-06-14 Thread GitBox
mik-laj commented on a change in pull request #9291: URL: https://github.com/apache/airflow/pull/9291#discussion_r439843508 ## File path: airflow/www/extensions/init_views.py ## @@ -0,0 +1,118 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contribut

[GitHub] [airflow] mik-laj commented on a change in pull request #9291: Refactor create_app in airflow/www/app.py

2020-06-14 Thread GitBox
mik-laj commented on a change in pull request #9291: URL: https://github.com/apache/airflow/pull/9291#discussion_r439843526 ## File path: airflow/www/extensions/init_security.py ## @@ -0,0 +1,44 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contrib

[GitHub] [airflow] kaxil opened a new pull request #9293: Use actions/cache@v2 for all static checks

2020-06-14 Thread GitBox
kaxil opened a new pull request #9293: URL: https://github.com/apache/airflow/pull/9293 We upgraded to v2 in https://github.com/apache/airflow/pull/8265 for other places in `.github/workflows/ci.yml`. This was left, so fixing it. --- Make sure to mark the boxes below before creati

[GitHub] [airflow] kaxil merged pull request #9270: Add airflow GitHub script

2020-06-14 Thread GitBox
kaxil merged pull request #9270: URL: https://github.com/apache/airflow/pull/9270 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[airflow] branch master updated: Add dev script to compare GH issues against merges (#9270)

2020-06-14 Thread kaxilnaik
This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/master by this push: new cef1df4 Add dev script to compare GH issues

[GitHub] [airflow] kaxil closed pull request #9282: Simplify "if expression" to increase the code readability

2020-06-14 Thread GitBox
kaxil closed pull request #9282: URL: https://github.com/apache/airflow/pull/9282 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [airflow] kaxil opened a new pull request #9294: WIP: Test Pylint 2.5.3

2020-06-14 Thread GitBox
kaxil opened a new pull request #9294: URL: https://github.com/apache/airflow/pull/9294 --- Make sure to mark the boxes below before creating PR: [x] - [ ] Description above provides context of the change - [ ] Unit tests coverage for changes (not needed for documentation change

[GitHub] [airflow] mik-laj merged pull request #9291: Refactor create_app in airflow/www/app.py

2020-06-14 Thread GitBox
mik-laj merged pull request #9291: URL: https://github.com/apache/airflow/pull/9291 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[airflow] branch master updated (cef1df4 -> 2362853)

2020-06-14 Thread kamilbregula
This is an automated email from the ASF dual-hosted git repository. kamilbregula pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git. from cef1df4 Add dev script to compare GH issues against merges (#9270) add 2362853 Refactor create_app in a

[GitHub] [airflow] kaxil merged pull request #9214: Decrypt secrets from SystemsManagerParameterStoreBackend

2020-06-14 Thread GitBox
kaxil merged pull request #9214: URL: https://github.com/apache/airflow/pull/9214 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #9214: Decrypt secrets from SystemsManagerParameterStoreBackend

2020-06-14 Thread GitBox
boring-cyborg[bot] commented on pull request #9214: URL: https://github.com/apache/airflow/pull/9214#issuecomment-643790749 Awesome work, congrats on your first merged pull request! This is an automated message from the A

[airflow] branch master updated (2362853 -> ffb8574)

2020-06-14 Thread kaxilnaik
This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git. from 2362853 Refactor create_app in airflow/www/app.py (#9291) add ffb8574 Decrypt secrets from SystemsManagerP

[GitHub] [airflow] ephraimbuddy commented on pull request #9227: Add event log endpoints

2020-06-14 Thread GitBox
ephraimbuddy commented on pull request #9227: URL: https://github.com/apache/airflow/pull/9227#issuecomment-643795997 Thanks! @kaxil This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [airflow] jkbngl closed pull request #9218: Mssql to oracle operator

2020-06-14 Thread GitBox
jkbngl closed pull request #9218: URL: https://github.com/apache/airflow/pull/9218 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [airflow] jkbngl commented on pull request #9218: Mssql to oracle operator

2020-06-14 Thread GitBox
jkbngl commented on pull request #9218: URL: https://github.com/apache/airflow/pull/9218#issuecomment-643802087 @jhtimmins I will fix try to fix the issues from the failing checks and open a new pull request, thanks for the heads up

[GitHub] [airflow] OmairK commented on pull request #9273: implement api v1 for variables

2020-06-14 Thread GitBox
OmairK commented on pull request #9273: URL: https://github.com/apache/airflow/pull/9273#issuecomment-643803609 > @OmairK the api tests should have already covered serialization and deserialization code path, no? Do you have an example in mind where a refactor will cause issue that won't b

[GitHub] [airflow] OmairK commented on pull request #9273: implement api v1 for variables

2020-06-14 Thread GitBox
OmairK commented on pull request #9273: URL: https://github.com/apache/airflow/pull/9273#issuecomment-643805306 > I think, writing tests improve code coverage? @ephraimbuddy No not necessarily, my understanding of code coverage is based on [this](https://coverage.readthedocs.io/en/v4

[GitHub] [airflow] feluelle closed issue #9275: Decrypt secrets from SystemsManagerParameterStoreBackend

2020-06-14 Thread GitBox
feluelle closed issue #9275: URL: https://github.com/apache/airflow/issues/9275 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [airflow] jkbngl opened a new pull request #9295: added mssql to oracle transfer operator

2020-06-14 Thread GitBox
jkbngl opened a new pull request #9295: URL: https://github.com/apache/airflow/pull/9295 --- Make sure to mark the boxes below before creating PR: [x] Added Operator to transfer data from MSSql to Oracle, building on top of oracleToOracleTransfer operator. - [X] Description

[GitHub] [airflow] mik-laj commented on issue #8137: API Endpoint - Dag source

2020-06-14 Thread GitBox
mik-laj commented on issue #8137: URL: https://github.com/apache/airflow/issues/8137#issuecomment-643810952 @TobKed Do you need any help? If you need help, feel free to write or call. This is an automated message from the Ap

[GitHub] [airflow] houqp commented on a change in pull request #9170: [WIP] Read only endpoint for XCom #8134

2020-06-14 Thread GitBox
houqp commented on a change in pull request #9170: URL: https://github.com/apache/airflow/pull/9170#discussion_r439860327 ## File path: airflow/api_connexion/endpoints/xcom_endpoint.py ## @@ -26,18 +32,35 @@ def delete_xcom_entry(): raise NotImplementedError("Not implement

[GitHub] [airflow] mik-laj commented on issue #8136: API Endpoint - Config

2020-06-14 Thread GitBox
mik-laj commented on issue #8136: URL: https://github.com/apache/airflow/issues/8136#issuecomment-643811326 @vbmade2000 How do you do? Do you need any help? A lot is going on in the project. If you feel the inspiration then you can look at merged or unmerged PRs. https://github.com/ap

[GitHub] [airflow] mik-laj edited a comment on issue #8136: API Endpoint - Config

2020-06-14 Thread GitBox
mik-laj edited a comment on issue #8136: URL: https://github.com/apache/airflow/issues/8136#issuecomment-643811326 @vbmade2000 How do you do? Do you need any help? A lot is going on in the project. If you need some inspiration then you can look at merged or unmerged PRs. https://githu

[GitHub] [airflow] mik-laj commented on issue #8132: API Endpoints - Read-only - Task Instance

2020-06-14 Thread GitBox
mik-laj commented on issue #8132: URL: https://github.com/apache/airflow/issues/8132#issuecomment-643811543 @GMarkfjard How do you do? Do you need any help? A lot is going on in the project. If you need some inspiration then you can look at merged or unmerged PRs. https://github.com/ap

[GitHub] [airflow] mik-laj commented on issue #8128: API Endpoints - Read-only - DAG

2020-06-14 Thread GitBox
mik-laj commented on issue #8128: URL: https://github.com/apache/airflow/issues/8128#issuecomment-643811683 @bertosantamaria How do you do? Do you need any help? A lot is going on in the project. If you need some inspiration then you can look at merged or unmerged PRs. https://github.c

[GitHub] [airflow] houqp commented on pull request #9273: implement api v1 for variables

2020-06-14 Thread GitBox
houqp commented on pull request #9273: URL: https://github.com/apache/airflow/pull/9273#issuecomment-643811896 > I think, writing tests improve code coverage? As @OmairK already mentioned, duplicated tests that test the same code path won't increase code coverage. In fact it will mak

[GitHub] [airflow] mik-laj commented on issue #8140: API Endpoint - Extra Links

2020-06-14 Thread GitBox
mik-laj commented on issue #8140: URL: https://github.com/apache/airflow/issues/8140#issuecomment-643811976 @michalslowikowski00 How do you do? I wonder if you need help. If so, you definitely know how to contact me. This is

[GitHub] [airflow] mik-laj edited a comment on issue #8140: API Endpoint - Extra Links

2020-06-14 Thread GitBox
mik-laj edited a comment on issue #8140: URL: https://github.com/apache/airflow/issues/8140#issuecomment-643811976 @michalslowikowski00 How do you do? I wonder if you need help. If so, please contact me. This is an automated

[GitHub] [airflow] mik-laj closed issue #9200: CLI tool wrappers doesn't support pipe

2020-06-14 Thread GitBox
mik-laj closed issue #9200: URL: https://github.com/apache/airflow/issues/9200 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[GitHub] [airflow] mik-laj commented on issue #9237: Inclusive or exclusive range fitlers in API

2020-06-14 Thread GitBox
mik-laj commented on issue #9237: URL: https://github.com/apache/airflow/issues/9237#issuecomment-643814002 @houqp I haven't started the discussion on the mailing list about this problem yet, but maybe you have some thought?

[GitHub] [airflow] houqp commented on issue #9237: Inclusive or exclusive range filters in API

2020-06-14 Thread GitBox
houqp commented on issue #9237: URL: https://github.com/apache/airflow/issues/9237#issuecomment-643820077 @mik-laj yes, ` [start_xxx, end_xxx)` is much easier to use than ` [start_xxx, end_xxx]` from a client's point of view. If we don't want to support all 4 comparison operators, then I w

[GitHub] [airflow] potiuk commented on issue #9237: Inclusive or exclusive range filters in API

2020-06-14 Thread GitBox
potiuk commented on issue #9237: URL: https://github.com/apache/airflow/issues/9237#issuecomment-643821659 Yep. Agree using GTE and LT is a better approach. I think it also encourages good patterns. However I think this is only valid in case of dates, not durations. For duration i w

[GitHub] [airflow] potiuk merged pull request #9293: Use actions/cache@v2 for all static checks

2020-06-14 Thread GitBox
potiuk merged pull request #9293: URL: https://github.com/apache/airflow/pull/9293 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[airflow] branch master updated: Use actions/cache@v2 (#9293)

2020-06-14 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/master by this push: new a38c35a Use actions/cache@v2 (#9293) a38c35a i

[GitHub] [airflow] ephraimbuddy commented on a change in pull request #9266: add crud endpoint for connections

2020-06-14 Thread GitBox
ephraimbuddy commented on a change in pull request #9266: URL: https://github.com/apache/airflow/pull/9266#discussion_r439868448 ## File path: airflow/api_connexion/endpoints/connection_endpoint.py ## @@ -47,31 +55,53 @@ def get_connection(connection_id, session): @provide

[airflow] branch master updated: Make airflow/models/skipmixin.py Pylint compatible (#9289)

2020-06-14 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/master by this push: new 4c7f4b4 Make airflow/models/skipmixin.py Pylin

[GitHub] [airflow] potiuk merged pull request #9289: Make airflow/models/skipmixin.py Pylint compatible

2020-06-14 Thread GitBox
potiuk merged pull request #9289: URL: https://github.com/apache/airflow/pull/9289 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [airflow] ephraimbuddy commented on a change in pull request #9295: added mssql to oracle transfer operator

2020-06-14 Thread GitBox
ephraimbuddy commented on a change in pull request #9295: URL: https://github.com/apache/airflow/pull/9295#discussion_r439869177 ## File path: airflow/contrib/operators/mssql_to_oracle_transfer.py ## @@ -0,0 +1,92 @@ +# +# Licensed to the Apache Software Foundation (ASF) under

[GitHub] [airflow] ephraimbuddy commented on a change in pull request #9295: added mssql to oracle transfer operator

2020-06-14 Thread GitBox
ephraimbuddy commented on a change in pull request #9295: URL: https://github.com/apache/airflow/pull/9295#discussion_r439869251 ## File path: airflow/contrib/operators/mssql_to_oracle_transfer.py ## @@ -0,0 +1,92 @@ +# +# Licensed to the Apache Software Foundation (ASF) under

[GitHub] [airflow] ephraimbuddy commented on a change in pull request #9295: added mssql to oracle transfer operator

2020-06-14 Thread GitBox
ephraimbuddy commented on a change in pull request #9295: URL: https://github.com/apache/airflow/pull/9295#discussion_r439869177 ## File path: airflow/contrib/operators/mssql_to_oracle_transfer.py ## @@ -0,0 +1,92 @@ +# +# Licensed to the Apache Software Foundation (ASF) under

[GitHub] [airflow] ephraimbuddy commented on a change in pull request #9295: added mssql to oracle transfer operator

2020-06-14 Thread GitBox
ephraimbuddy commented on a change in pull request #9295: URL: https://github.com/apache/airflow/pull/9295#discussion_r439869418 ## File path: airflow/contrib/operators/mssql_to_oracle_transfer.py ## @@ -0,0 +1,92 @@ +# +# Licensed to the Apache Software Foundation (ASF) under

[GitHub] [airflow] ephraimbuddy commented on a change in pull request #9295: added mssql to oracle transfer operator

2020-06-14 Thread GitBox
ephraimbuddy commented on a change in pull request #9295: URL: https://github.com/apache/airflow/pull/9295#discussion_r439869459 ## File path: airflow/contrib/operators/mssql_to_oracle_transfer.py ## @@ -0,0 +1,92 @@ +# +# Licensed to the Apache Software Foundation (ASF) under

[GitHub] [airflow] mik-laj commented on a change in pull request #9266: add crud endpoint for connections

2020-06-14 Thread GitBox
mik-laj commented on a change in pull request #9266: URL: https://github.com/apache/airflow/pull/9266#discussion_r439869565 ## File path: airflow/api_connexion/endpoints/connection_endpoint.py ## @@ -47,31 +55,53 @@ def get_connection(connection_id, session): @provide_sess

[GitHub] [airflow] mik-laj commented on a change in pull request #9266: add crud endpoint for connections

2020-06-14 Thread GitBox
mik-laj commented on a change in pull request #9266: URL: https://github.com/apache/airflow/pull/9266#discussion_r439869721 ## File path: airflow/api_connexion/endpoints/connection_endpoint.py ## @@ -47,31 +55,53 @@ def get_connection(connection_id, session): @provide_sess

[GitHub] [airflow] ephraimbuddy commented on a change in pull request #9266: add crud endpoint for connections

2020-06-14 Thread GitBox
ephraimbuddy commented on a change in pull request #9266: URL: https://github.com/apache/airflow/pull/9266#discussion_r439870308 ## File path: airflow/api_connexion/endpoints/connection_endpoint.py ## @@ -47,31 +55,53 @@ def get_connection(connection_id, session): @provide

[GitHub] [airflow] jkbngl commented on pull request #9295: added mssql to oracle transfer operator

2020-06-14 Thread GitBox
jkbngl commented on pull request #9295: URL: https://github.com/apache/airflow/pull/9295#issuecomment-643826150 @ephraimbuddy thank you very much for your feedback, I have now added type annotations! This is an automated me

[GitHub] [airflow] xinbinhuang commented on a change in pull request #9243: [AIP-34] Rewrite SubDagOperator

2020-06-14 Thread GitBox
xinbinhuang commented on a change in pull request #9243: URL: https://github.com/apache/airflow/pull/9243#discussion_r439872489 ## File path: airflow/models/task_group.py ## @@ -0,0 +1,31 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor li

  1   2   >