[GitHub] [airflow] potiuk commented on a change in pull request #9631: Add function to get current context

2020-07-14 Thread GitBox
potiuk commented on a change in pull request #9631: URL: https://github.com/apache/airflow/pull/9631#discussion_r454831817 ## File path: airflow/task/context/current.py ## @@ -0,0 +1,69 @@ +# Licensed to the Apache Software Foundation (ASF) under one Review comment: new

[GitHub] [airflow] potiuk commented on a change in pull request #9631: Add function to get current context

2020-07-14 Thread GitBox
potiuk commented on a change in pull request #9631: URL: https://github.com/apache/airflow/pull/9631#discussion_r454831166 ## File path: airflow/models/taskinstance.py ## @@ -1132,7 +1133,8 @@ def signal_handler(signum, frame): # pylint: disable=unused-argument self.

[GitHub] [airflow] potiuk commented on issue #9826: Celery command failed

2020-07-14 Thread GitBox
potiuk commented on issue #9826: URL: https://github.com/apache/airflow/issues/9826#issuecomment-658581421 As explained in the issue - please post your questions/troubleshooting at the Slack. (There is #troubleshooting channel there). --

[GitHub] [airflow] potiuk closed issue #9826: Celery command failed

2020-07-14 Thread GitBox
potiuk closed issue #9826: URL: https://github.com/apache/airflow/issues/9826 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[GitHub] [airflow] zhbdesign commented on issue #9826: Celery command failed

2020-07-14 Thread GitBox
zhbdesign commented on issue #9826: URL: https://github.com/apache/airflow/issues/9826#issuecomment-658576075 Check the scheduler to see the following log: [2020-07-15 14:30:40,779] {scheduler_job.py:958} INFO - 2 tasks up for execution: [2020-07-15 14:30:40,891]

[GitHub] [airflow] milton0825 commented on a change in pull request #9824: Change DAG.clear to take dag_run_state

2020-07-14 Thread GitBox
milton0825 commented on a change in pull request #9824: URL: https://github.com/apache/airflow/pull/9824#discussion_r454785868 ## File path: airflow/models/dag.py ## @@ -1134,16 +1134,18 @@ def clear( do_it = utils.helpers.ask_yesno(question) if do_it: -

[GitHub] [airflow] milton0825 commented on a change in pull request #9824: Change DAG.clear to take dag_run_state

2020-07-14 Thread GitBox
milton0825 commented on a change in pull request #9824: URL: https://github.com/apache/airflow/pull/9824#discussion_r454785655 ## File path: airflow/models/dag.py ## @@ -1065,12 +1064,13 @@ def clear( instances = tis.all() for ti in instances:

[GitHub] [airflow] milton0825 commented on a change in pull request #9824: Change DAG.clear to take dag_run_state

2020-07-14 Thread GitBox
milton0825 commented on a change in pull request #9824: URL: https://github.com/apache/airflow/pull/9824#discussion_r454785478 ## File path: airflow/models/dag.py ## @@ -1026,26 +1025,26 @@ def clear( tis = tis.filter(TI.task_id.in_(self.task_ids)) if in

[GitHub] [airflow] zhbdesign opened a new issue #9826: Celery command failed

2020-07-14 Thread GitBox
zhbdesign opened a new issue #9826: URL: https://github.com/apache/airflow/issues/9826 I use a cluster of four machine components. When I execute the task, the task has been distributed, but there will be errors for each machine. The log is as follows: [2020-07-15 11:25:46,471: ERRO

[airflow] tag nightly-master updated (1a1a8db -> 5805a36)

2020-07-14 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to tag nightly-master in repository https://gitbox.apache.org/repos/asf/airflow.git. *** WARNING: tag nightly-master was modified! *** from 1a1a8db (commit) to 5805a36 (commit) from 1a

[GitHub] [airflow] morrme commented on a change in pull request #9775: improve typing for datadog provider

2020-07-14 Thread GitBox
morrme commented on a change in pull request #9775: URL: https://github.com/apache/airflow/pull/9775#discussion_r454739504 ## File path: airflow/providers/datadog/sensors/datadog.py ## @@ -39,15 +41,15 @@ class DatadogSensor(BaseSensorOperator): @apply_defaults def __

[jira] [Commented] (AIRFLOW-7014) Operator for Apache Kylin

2020-07-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-7014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17157798#comment-17157798 ] ASF GitHub Bot commented on AIRFLOW-7014: - liuyonghengheng commented on pull re

[GitHub] [airflow] liuyonghengheng commented on pull request #9149: [AIRFLOW-7014] Add Apache Kylin operator

2020-07-14 Thread GitBox
liuyonghengheng commented on pull request #9149: URL: https://github.com/apache/airflow/pull/9149#issuecomment-658492312 @potiuk Thank you very much! This is an automated message from the Apache Git Service. To respond to the

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #9825: Improve type hinting to provider cloudant

2020-07-14 Thread GitBox
boring-cyborg[bot] commented on pull request #9825: URL: https://github.com/apache/airflow/pull/9825#issuecomment-658468606 Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contr

[GitHub] [airflow] rafyzg opened a new pull request #9825: Improve type hinting to provider cloudant

2020-07-14 Thread GitBox
rafyzg opened a new pull request #9825: URL: https://github.com/apache/airflow/pull/9825 Adding type annotations to cloudant provider as per #9708 --- Make sure to mark the boxes below before creating PR: [x] - [x] Description above provides context of the change - [x] Unit

[GitHub] [airflow] milton0825 opened a new pull request #9824: Change DAG.clear to take dag_run_state

2020-07-14 Thread GitBox
milton0825 opened a new pull request #9824: URL: https://github.com/apache/airflow/pull/9824 --- Make sure to mark the boxes below before creating PR: [x] - [ ] Description above provides context of the change - [ ] Unit tests coverage for changes (not needed for documentation c

[GitHub] [airflow] dimon222 edited a comment on issue #8212: Can't read S3 remote logs using Airflow 1.10.9

2020-07-14 Thread GitBox
dimon222 edited a comment on issue #8212: URL: https://github.com/apache/airflow/issues/8212#issuecomment-658444006 @cmlad yes its the reason for sure. And HTTP vs HTTPS no difference. I randomly found potential fix in one of previously mentioned issues https://github.com/apache/ai

[GitHub] [airflow] dimon222 commented on issue #8212: Can't read S3 remote logs using Airflow 1.10.9

2020-07-14 Thread GitBox
dimon222 commented on issue #8212: URL: https://github.com/apache/airflow/issues/8212#issuecomment-658444006 @cmlad yes its the reason for sure. And HTTP vs HTTPS no difference. I randomly found potential fix in one of previously mentioned issues https://github.com/apache/airflow/i

[GitHub] [airflow] mik-laj commented on a change in pull request #9798: Guide for AI Platform (previously Machine Learning Engine) Operators

2020-07-14 Thread GitBox
mik-laj commented on a change in pull request #9798: URL: https://github.com/apache/airflow/pull/9798#discussion_r454671502 ## File path: docs/howto/operator/google/cloud/mlengine.rst ## @@ -0,0 +1,217 @@ + .. Licensed to the Apache Software Foundation (ASF) under one +or m

[GitHub] [airflow] vuppalli commented on a change in pull request #9798: Guide for AI Platform (previously Machine Learning Engine) Operators

2020-07-14 Thread GitBox
vuppalli commented on a change in pull request #9798: URL: https://github.com/apache/airflow/pull/9798#discussion_r454662915 ## File path: docs/howto/operator/google/cloud/mlengine.rst ## @@ -0,0 +1,217 @@ + .. Licensed to the Apache Software Foundation (ASF) under one +or

[GitHub] [airflow] mik-laj commented on a change in pull request #9798: Guide for AI Platform (previously Machine Learning Engine) Operators

2020-07-14 Thread GitBox
mik-laj commented on a change in pull request #9798: URL: https://github.com/apache/airflow/pull/9798#discussion_r454659035 ## File path: docs/howto/operator/google/cloud/mlengine.rst ## @@ -0,0 +1,217 @@ + .. Licensed to the Apache Software Foundation (ASF) under one +or m

[GitHub] [airflow] vuppalli commented on pull request #9798: Guide for AI Platform (previously Machine Learning Engine) Operators

2020-07-14 Thread GitBox
vuppalli commented on pull request #9798: URL: https://github.com/apache/airflow/pull/9798#issuecomment-658421169 @mik-laj Thanks for the suggestion, I did the rebase. How does everything look now? This is an automated messa

[GitHub] [airflow] kaxil commented on a change in pull request #9822: Add note in Updating.md about the change in `run_as_user` default

2020-07-14 Thread GitBox
kaxil commented on a change in pull request #9822: URL: https://github.com/apache/airflow/pull/9822#discussion_r454635632 ## File path: UPDATING.md ## @@ -1476,6 +1476,28 @@ auth_backend = airflow.api.auth.backend.default Since XCom values can contain pickled data, we would no

[GitHub] [airflow] kaxil commented on a change in pull request #9806: Add redoc docs to sphinx

2020-07-14 Thread GitBox
kaxil commented on a change in pull request #9806: URL: https://github.com/apache/airflow/pull/9806#discussion_r454629107 ## File path: docs/exts/sphinx_script_update.py ## @@ -0,0 +1,113 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor li

[airflow] branch master updated: Fix SqlAlchemy-Flask failure with python 3.8.4 (#9821)

2020-07-14 Thread kaxilnaik
This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/master by this push: new 5805a36 Fix SqlAlchemy-Flask failure with p

[GitHub] [airflow] kaxil merged pull request #9821: Fixes sqlalchemy flask failure with python 3.8.4

2020-07-14 Thread GitBox
kaxil merged pull request #9821: URL: https://github.com/apache/airflow/pull/9821 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [airflow] sjmiller609 opened a new issue #9823: Optional allow-list for operator name in metrics

2020-07-14 Thread GitBox
sjmiller609 opened a new issue #9823: URL: https://github.com/apache/airflow/issues/9823 **Description** I am seeking approval for a minor feature. We are using Airflow metrics, two of these metrics are airflow.operator_failures_.* and airflow.operator_successes_.*.

[GitHub] [airflow] boring-cyborg[bot] commented on issue #9823: Optional allow-list for operator name in metrics

2020-07-14 Thread GitBox
boring-cyborg[bot] commented on issue #9823: URL: https://github.com/apache/airflow/issues/9823#issuecomment-658390329 Thanks for opening your first issue here! Be sure to follow the issue template! This is an automated

[GitHub] [airflow] mik-laj commented on pull request #9806: Add redoc docs to sphinx

2020-07-14 Thread GitBox
mik-laj commented on pull request #9806: URL: https://github.com/apache/airflow/pull/9806#issuecomment-658387971 I updated the PR: He used this plugin and added the JS library download on demand (with cache). Demo: https://valuable-carpenter.surge.sh/

[GitHub] [airflow] mik-laj commented on pull request #9778: Enable setting the base url of the website

2020-07-14 Thread GitBox
mik-laj commented on pull request #9778: URL: https://github.com/apache/airflow/pull/9778#issuecomment-658386920 @dimberman The base_url option adds a prefix to each address (including health check), so this change looks good. This option is implemented as WSGI middleware, so it affects al

[GitHub] [airflow] dimberman commented on pull request #9778: Enable setting the base url of the website

2020-07-14 Thread GitBox
dimberman commented on pull request #9778: URL: https://github.com/apache/airflow/pull/9778#issuecomment-658383793 @vsimon I guess I'm a bit confused here, wouldn't that be testing the reverse proxy instead of airflow? Why would you need to access airflow via the reverse proxy for a health

[GitHub] [airflow] mik-laj commented on a change in pull request #9798: Guide for AI Platform (previously Machine Learning Engine) Operators

2020-07-14 Thread GitBox
mik-laj commented on a change in pull request #9798: URL: https://github.com/apache/airflow/pull/9798#discussion_r454601015 ## File path: CONTRIBUTING.rst ## @@ -314,14 +314,14 @@ This is the full list of those extras: .. START EXTRAS HERE all_dbs, amazon, apache.atlas, a

[GitHub] [airflow] mik-laj commented on pull request #9798: Guide for AI Platform (previously Machine Learning Engine) Operators

2020-07-14 Thread GitBox
mik-laj commented on pull request #9798: URL: https://github.com/apache/airflow/pull/9798#issuecomment-658375127 Here is more info about quarantined tests: https://github.com/apache/airflow/blob/master/TESTING.rst#quarantined-tests CI Build/ Push Prod images, CI Build/ Push CI images, C

[GitHub] [airflow] vuppalli commented on pull request #9798: Guide for AI Platform (previously Machine Learning Engine) Operators

2020-07-14 Thread GitBox
vuppalli commented on pull request #9798: URL: https://github.com/apache/airflow/pull/9798#issuecomment-658373375 @mik-laj Thanks so much for providing me slack link! The branch should be in sync with the Airflow repository now. Do you know why 3 checks were skipped and one is failing? -

[GitHub] [airflow] kaxil opened a new pull request #9822: Add note in Updating.md about the change in `run_as_user` default

2020-07-14 Thread GitBox
kaxil opened a new pull request #9822: URL: https://github.com/apache/airflow/pull/9822 Until Airflow 1.10.10 the default run_as_user config (https://airflow.readthedocs.io/en/1.10.10/configurations-ref.html#run-as-user) which defaulted it to root user `0` (https://github.com/apache/airfl

[GitHub] [airflow] potiuk commented on pull request #9821: Fixes sqlalchemy flask failure with python 3.8.4

2020-07-14 Thread GitBox
potiuk commented on pull request #9821: URL: https://github.com/apache/airflow/pull/9821#issuecomment-658355716 Yeah - somewhat version 5.0.1 became available for 3.6 but then removed for 3.7. I think this is because I actually run two generate requirements in parallell (by mistake :) ). T

[GitHub] [airflow] kaxil commented on pull request #9821: Fixes sqlalchemy flask failure with python 3.8.4

2020-07-14 Thread GitBox
kaxil commented on pull request #9821: URL: https://github.com/apache/airflow/pull/9821#issuecomment-658339979 ``` Could not find a version that satisfies the requirement google-ads==5.1.0 (from -c /opt/airflow/requirements/requirements-python3.6.txt (line 139)) (from versions: 0.1.0,

[airflow] branch v1-10-test updated: Fixes sqlalchemy flask failure with python 3.8.4

2020-07-14 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch v1-10-test in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/v1-10-test by this push: new e983da7 Fixes sqlalchemy flask failure

[GitHub] [airflow] kaxil commented on pull request #9821: Fixes sqlalchemy flask failure with python 3.8.4

2020-07-14 Thread GitBox
kaxil commented on pull request #9821: URL: https://github.com/apache/airflow/pull/9821#issuecomment-658314755 CI is failing :( This is an automated message from the Apache Git Service. To respond to the message, please log o

[GitHub] [airflow] mik-laj commented on pull request #9806: Add redoc docs to sphinx

2020-07-14 Thread GitBox
mik-laj commented on pull request #9806: URL: https://github.com/apache/airflow/pull/9806#issuecomment-658311120 @ad-m This will generate a file, but Sphinx won't be aware of it, so you won't be able to reference it in any way. ``` /opt/airflowairflow/docs/index.rst:104: WARNING: toct

[GitHub] [airflow] potiuk opened a new pull request #9821: Fixes sqlalchemy flask failure with python 3.8.4

2020-07-14 Thread GitBox
potiuk opened a new pull request #9821: URL: https://github.com/apache/airflow/pull/9821 --- Make sure to mark the boxes below before creating PR: [x] - [x] Description above provides context of the change - [x] Unit tests coverage for changes (not needed for documentation chang

[GitHub] [airflow] mik-laj commented on pull request #9747: [WIP] Add AzureBaseHook

2020-07-14 Thread GitBox
mik-laj commented on pull request #9747: URL: https://github.com/apache/airflow/pull/9747#issuecomment-658304397 > I mean if the documentation is specific enough to tell you how to set the values for login password extra I personally think we shouldn't add custom fields. The extra f

[GitHub] [airflow] mik-laj commented on pull request #9798: Guide for AI Platform (previously Machine Learning Engine) Operators

2020-07-14 Thread GitBox
mik-laj commented on pull request #9798: URL: https://github.com/apache/airflow/pull/9798#issuecomment-658300322 Please look here: https://apache-airflow.slack.com/archives/CCPRP7943/p1594733324313800 This is an automated me

[GitHub] [airflow] vuppalli commented on pull request #9798: Guide for AI Platform (previously Machine Learning Engine) Operators

2020-07-14 Thread GitBox
vuppalli commented on pull request #9798: URL: https://github.com/apache/airflow/pull/9798#issuecomment-658297975 @mik-laj Thank you so much for your comments! I have addressed them and pushed the changes. However, it looks like there are still some failed checks. Do you know what I can do

[jira] [Commented] (AIRFLOW-7014) Operator for Apache Kylin

2020-07-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-7014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17157493#comment-17157493 ] ASF GitHub Bot commented on AIRFLOW-7014: - potiuk commented on pull request #91

[GitHub] [airflow] potiuk commented on pull request #9149: [AIRFLOW-7014] Add Apache Kylin operator

2020-07-14 Thread GitBox
potiuk commented on pull request #9149: URL: https://github.com/apache/airflow/pull/9149#issuecomment-658279014 Merged. We had some temporary problem with Python 3.8.4 released last night breaking SQL Alchemy - that's why you got the errors. Thanks for your patience! -

[jira] [Commented] (AIRFLOW-7014) Operator for Apache Kylin

2020-07-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-7014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17157491#comment-17157491 ] ASF GitHub Bot commented on AIRFLOW-7014: - potiuk merged pull request #9149: UR

[jira] [Commented] (AIRFLOW-7014) Operator for Apache Kylin

2020-07-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-7014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17157492#comment-17157492 ] ASF GitHub Bot commented on AIRFLOW-7014: - boring-cyborg[bot] commented on pull

[airflow] branch master updated: Add kylin operator (#9149)

2020-07-14 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/master by this push: new a2c5389 Add kylin operator (#9149) a2c5389 is

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #9149: [AIRFLOW-7014] Add Apache Kylin operator

2020-07-14 Thread GitBox
boring-cyborg[bot] commented on pull request #9149: URL: https://github.com/apache/airflow/pull/9149#issuecomment-658278537 Awesome work, congrats on your first merged pull request! This is an automated message from the A

[GitHub] [airflow] potiuk merged pull request #9149: [AIRFLOW-7014] Add Apache Kylin operator

2020-07-14 Thread GitBox
potiuk merged pull request #9149: URL: https://github.com/apache/airflow/pull/9149 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #9667: Allow `replace` flag in gcs_to_gcs operator.

2020-07-14 Thread GitBox
boring-cyborg[bot] commented on pull request #9667: URL: https://github.com/apache/airflow/pull/9667#issuecomment-658276627 Awesome work, congrats on your first merged pull request! This is an automated message from the A

[airflow] branch master updated (4636fc6 -> ed5004c)

2020-07-14 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git. from 4636fc6 Python 3.8.4 release breaks our builds (#9820) add ed5004c Allow `replace` flag in gcs_to_gcs operato

[GitHub] [airflow] potiuk commented on pull request #9667: Allow `replace` flag in gcs_to_gcs operator.

2020-07-14 Thread GitBox
potiuk commented on pull request #9667: URL: https://github.com/apache/airflow/pull/9667#issuecomment-658276991 Thanks @royberkoweee :). Sometimes we miss a PR. Gentle Ping as you did is helpful!. Thanks! This is an automate

[GitHub] [airflow] potiuk merged pull request #9667: Allow `replace` flag in gcs_to_gcs operator.

2020-07-14 Thread GitBox
potiuk merged pull request #9667: URL: https://github.com/apache/airflow/pull/9667 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [airflow] potiuk commented on pull request #9667: Allow `replace` flag in gcs_to_gcs operator.

2020-07-14 Thread GitBox
potiuk commented on pull request #9667: URL: https://github.com/apache/airflow/pull/9667#issuecomment-658276362 Ah missed it :) This is an automated message from the Apache Git Service. To respond to the message, please log o

[airflow] branch master updated: Python 3.8.4 release breaks our builds (#9820)

2020-07-14 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/master by this push: new 4636fc6 Python 3.8.4 release breaks our builds

[GitHub] [airflow] potiuk merged pull request #9820: Python 3.8.4 release breaks our builds

2020-07-14 Thread GitBox
potiuk merged pull request #9820: URL: https://github.com/apache/airflow/pull/9820 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[airflow] branch v1-10-test updated: Python 3.8.4 release breaks our builds

2020-07-14 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch v1-10-test in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/v1-10-test by this push: new 699382b Python 3.8.4 release breaks ou

[GitHub] [airflow] houqp commented on a change in pull request #9631: Add function to get current context

2020-07-14 Thread GitBox
houqp commented on a change in pull request #9631: URL: https://github.com/apache/airflow/pull/9631#discussion_r454433163 ## File path: airflow/models/taskinstance.py ## @@ -1132,7 +1133,8 @@ def signal_handler(signum, frame): # pylint: disable=unused-argument self._

[airflow] branch master updated: For now cloud tools are not needed in CI (#9818)

2020-07-14 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/master by this push: new 69f82e6 For now cloud tools are not needed in

[GitHub] [airflow] potiuk merged pull request #9818: For now cloud tools are not needed in CI

2020-07-14 Thread GitBox
potiuk merged pull request #9818: URL: https://github.com/apache/airflow/pull/9818 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[airflow] branch master updated: Remove package.json and yarn.lock from the prod image (#9814)

2020-07-14 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/master by this push: new 593a0dd Remove package.json and yarn.lock from

[GitHub] [airflow] potiuk closed issue #9810: Yarn.lock should not be present in the prod image

2020-07-14 Thread GitBox
potiuk closed issue #9810: URL: https://github.com/apache/airflow/issues/9810 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[GitHub] [airflow] potiuk merged pull request #9814: Remove package.json and yarn.lock from the prod image

2020-07-14 Thread GitBox
potiuk merged pull request #9814: URL: https://github.com/apache/airflow/pull/9814 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [airflow] potiuk commented on a change in pull request #9820: Python 3.8.4 release breaks our builds

2020-07-14 Thread GitBox
potiuk commented on a change in pull request #9820: URL: https://github.com/apache/airflow/pull/9820#discussion_r454401506 ## File path: scripts/ci/libraries/_initialization.sh ## @@ -21,6 +21,13 @@ function initialize_common_environment { # default python Major/Minor vers

[GitHub] [airflow] feluelle commented on a change in pull request #9820: Python 3.8.4 release breaks our builds

2020-07-14 Thread GitBox
feluelle commented on a change in pull request #9820: URL: https://github.com/apache/airflow/pull/9820#discussion_r454398222 ## File path: scripts/ci/libraries/_initialization.sh ## @@ -21,6 +21,13 @@ function initialize_common_environment { # default python Major/Minor ve

[GitHub] [airflow] potiuk commented on pull request #9820: Python 3.8.4 release breaks our builds

2020-07-14 Thread GitBox
potiuk commented on pull request #9820: URL: https://github.com/apache/airflow/pull/9820#issuecomment-658211367 > Can you also add it to the README https://github.com/apache/airflow#additional-notes-on-python-version-requirements ? :) I will - but I think we need to know the root ca

[GitHub] [airflow] jhtimmins commented on issue #8111: Authentication in API

2020-07-14 Thread GitBox
jhtimmins commented on issue #8111: URL: https://github.com/apache/airflow/issues/8111#issuecomment-658210379 @mik-laj have you had a chance to look at what I added in https://github.com/jhtimmins/scratch-airflow-auth/blob/master/auth/__init__.py? Really that code is about defining the int

[GitHub] [airflow] potiuk opened a new pull request #9820: Python 3.8.4 release breaks our builds

2020-07-14 Thread GitBox
potiuk opened a new pull request #9820: URL: https://github.com/apache/airflow/pull/9820 --- Make sure to mark the boxes below before creating PR: [x] - [x] Description above provides context of the change - [x] Unit tests coverage for changes (not needed for documentation chang

[jira] [Commented] (AIRFLOW-3363) Plugin templates not rendered by Flask appbuilder's baseview

2020-07-14 Thread igor (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-3363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17157404#comment-17157404 ] igor commented on AIRFLOW-3363: --- Hello [~ran.zvi] I had the same issue, but after invest

[GitHub] [airflow] royberkoweee commented on pull request #9667: Allow `replace` flag in gcs_to_gcs operator.

2020-07-14 Thread GitBox
royberkoweee commented on pull request #9667: URL: https://github.com/apache/airflow/pull/9667#issuecomment-658197844 Hey guys, how does the process look like from this point? Merging into master etc This is an automated me

[airflow] branch master updated: Add type annotations for redis provider (#9815)

2020-07-14 Thread kamilbregula
This is an automated email from the ASF dual-hosted git repository. kamilbregula pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/master by this push: new 0a2acf0 Add type annotations for redis p

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #9815: Adding type annotations to redis provider

2020-07-14 Thread GitBox
boring-cyborg[bot] commented on pull request #9815: URL: https://github.com/apache/airflow/pull/9815#issuecomment-658192770 Awesome work, congrats on your first merged pull request! This is an automated message from the A

[GitHub] [airflow] mik-laj merged pull request #9815: Adding type annotations to redis provider

2020-07-14 Thread GitBox
mik-laj merged pull request #9815: URL: https://github.com/apache/airflow/pull/9815 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [airflow] morrme commented on a change in pull request #9775: improve typing for datadog provider

2020-07-14 Thread GitBox
morrme commented on a change in pull request #9775: URL: https://github.com/apache/airflow/pull/9775#discussion_r454371731 ## File path: airflow/providers/datadog/hooks/datadog.py ## @@ -115,8 +120,16 @@ def query_metric(self, return response # pylint: disable=t

[GitHub] [airflow] mik-laj commented on issue #8111: Authentication in API

2020-07-14 Thread GitBox
mik-laj commented on issue #8111: URL: https://github.com/apache/airflow/issues/8111#issuecomment-658191051 @ad-m I do not want to introduce any requirements on the client API. If you want, you can use OAuth2, but you can also implement Kerberos-based or other fashionable protocol.

[GitHub] [airflow] feluelle commented on a change in pull request #9819: Import Iterable from collections.abc in firestore operators

2020-07-14 Thread GitBox
feluelle commented on a change in pull request #9819: URL: https://github.com/apache/airflow/pull/9819#discussion_r454367658 ## File path: airflow/providers/google/firebase/operators/firestore.py ## @@ -15,7 +15,7 @@ # specific language governing permissions and limitations #

[airflow] 01/02: Fix small errors in image building documentation (#9792)

2020-07-14 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch v1-10-test in repository https://gitbox.apache.org/repos/asf/airflow.git commit 2f113fb688274dfc374b785b3771cc7fb9f2bf10 Author: Jarek Potiuk AuthorDate: Mon Jul 13 19:23:55 2020 +0200 Fix s

[airflow] branch v1-10-test updated (e434014 -> 90b66d0)

2020-07-14 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch v1-10-test in repository https://gitbox.apache.org/repos/asf/airflow.git. omit e434014 Update README to add Py 3.8 in supported versions (#9804) omit 702ad72 Fix small errors in image b

[airflow] 02/02: Update README to add Py 3.8 in supported versions (#9804)

2020-07-14 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch v1-10-test in repository https://gitbox.apache.org/repos/asf/airflow.git commit 90b66d0333bbebd36a1572c04a14fade6afe2f3d Author: Kaxil Naik AuthorDate: Tue Jul 14 08:11:54 2020 +0100 Update

[GitHub] [airflow] ad-m commented on issue #9808: Add tests for OpenAPI specification

2020-07-14 Thread GitBox
ad-m commented on issue #9808: URL: https://github.com/apache/airflow/issues/9808#issuecomment-658187916 I was not aware that connection are able to validate responses: https://github.com/apache/airflow/blob/53c0f2d987bf3dbfb59da283287f4aa7b72524ab/airflow/www/extensions/init_views.py#L1

[GitHub] [airflow] ad-m closed issue #9808: Add tests for OpenAPI specification

2020-07-14 Thread GitBox
ad-m closed issue #9808: URL: https://github.com/apache/airflow/issues/9808 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

[GitHub] [airflow] mik-laj commented on a change in pull request #9819: Import Iterable from collections.abc in firestore operators

2020-07-14 Thread GitBox
mik-laj commented on a change in pull request #9819: URL: https://github.com/apache/airflow/pull/9819#discussion_r454366178 ## File path: airflow/providers/google/firebase/operators/firestore.py ## @@ -15,7 +15,7 @@ # specific language governing permissions and limitations #

[GitHub] [airflow] mik-laj commented on a change in pull request #9631: Add function to get current context

2020-07-14 Thread GitBox
mik-laj commented on a change in pull request #9631: URL: https://github.com/apache/airflow/pull/9631#discussion_r454363463 ## File path: airflow/models/taskinstance.py ## @@ -1132,7 +1133,8 @@ def signal_handler(signum, frame): # pylint: disable=unused-argument self

[GitHub] [airflow] mik-laj commented on issue #9808: Add tests for OpenAPI specification

2020-07-14 Thread GitBox
mik-laj commented on issue #9808: URL: https://github.com/apache/airflow/issues/9808#issuecomment-658182931 We use [connexion](https://connexion.readthedocs.io/en/latest/request.html#request-validation) to handle this case. Do you want to add something more?

[GitHub] [airflow] mik-laj edited a comment on issue #9808: Add tests for OpenAPI specification

2020-07-14 Thread GitBox
mik-laj edited a comment on issue #9808: URL: https://github.com/apache/airflow/issues/9808#issuecomment-658182931 We use [connexion](https://connexion.readthedocs.io/en/latest/request.html#request-validation) to handle validation for request body, response body, and parameters. Do you w

[GitHub] [airflow] kaxil commented on a change in pull request #9631: Add function to get current context

2020-07-14 Thread GitBox
kaxil commented on a change in pull request #9631: URL: https://github.com/apache/airflow/pull/9631#discussion_r454355273 ## File path: airflow/task/context/current.py ## @@ -0,0 +1,69 @@ +# Licensed to the Apache Software Foundation (ASF) under one Review comment: yeah

[GitHub] [airflow] potiuk commented on pull request #9816: Helm chart can now place arbitrary config settings in to airflow.cfg

2020-07-14 Thread GitBox
potiuk commented on pull request #9816: URL: https://github.com/apache/airflow/pull/9816#issuecomment-658175454 > @aneesh-joseph You can already customize the running config via env vars: > > https://github.com/apache/airflow/blob/5ef332abdeba93c3877dde46a2693362b6feb273/chart/values

[GitHub] [airflow] ashb commented on pull request #9816: Helm chart can now place arbitrary config settings in to airflow.cfg

2020-07-14 Thread GitBox
ashb commented on pull request #9816: URL: https://github.com/apache/airflow/pull/9816#issuecomment-658173163 It's probably worth doing that and just clearly documenting that "These values are templated before use. Ensure anything is escaped". I'll update the PR. --

[GitHub] [airflow] Datkros commented on pull request #9695: Add support for remote logging to be injected into the airflow.cfg configmap in helm chart

2020-07-14 Thread GitBox
Datkros commented on pull request #9695: URL: https://github.com/apache/airflow/pull/9695#issuecomment-658164002 > > we'd lose visibility on what's the current configuration running by just looking at the source. > > In Airflow 1.101.11, I added new command - `airflow config`. Will t

[GitHub] [airflow] turbaszek opened a new pull request #9819: Import Iterable from collections.abc in firestore operators

2020-07-14 Thread GitBox
turbaszek opened a new pull request #9819: URL: https://github.com/apache/airflow/pull/9819 DeprecationWarning: Using or importing the ABCs from 'collections' instead of from 'collections.abc' is deprecated since Python 3.3, and in 3.9 it will stop working --- Make sure to ma

[GitHub] [airflow] ashb commented on pull request #9816: Helm chart can now place arbitrary config settings in to airflow.cfg

2020-07-14 Thread GitBox
ashb commented on pull request #9816: URL: https://github.com/apache/airflow/pull/9816#issuecomment-658162817 > > I thought about using `tpl`, but then you have to worry about escaping in the Values.yml. > > agree, but wouldn't something like this do the job? Yes, but my conce

[GitHub] [airflow] aneesh-joseph commented on pull request #9816: Helm chart can now place arbitrary config settings in to airflow.cfg

2020-07-14 Thread GitBox
aneesh-joseph commented on pull request #9816: URL: https://github.com/apache/airflow/pull/9816#issuecomment-658161779 > I thought about using `tpl`, but then you have to worry about escaping in the Values.yml. agree, but wouldn't something like this do the job? ``` airflow

[GitHub] [airflow] ashb commented on a change in pull request #9817: S3 upload session complete sensor

2020-07-14 Thread GitBox
ashb commented on a change in pull request #9817: URL: https://github.com/apache/airflow/pull/9817#discussion_r454333273 ## File path: airflow/providers/amazon/aws/sensors/s3_upload_session_complete.py ## @@ -0,0 +1,179 @@ + +# Licensed to the Apache Software Foundation (ASF) u

[GitHub] [airflow] anikarni commented on a change in pull request #9817: S3 upload session complete sensor

2020-07-14 Thread GitBox
anikarni commented on a change in pull request #9817: URL: https://github.com/apache/airflow/pull/9817#discussion_r454333010 ## File path: airflow/providers/amazon/aws/sensors/s3_upload_session_complete.py ## @@ -0,0 +1,179 @@ + +# Licensed to the Apache Software Foundation (AS

[GitHub] [airflow] ashb commented on a change in pull request #9817: S3 upload session complete sensor

2020-07-14 Thread GitBox
ashb commented on a change in pull request #9817: URL: https://github.com/apache/airflow/pull/9817#discussion_r454331148 ## File path: airflow/providers/amazon/aws/sensors/s3_upload_session_complete.py ## @@ -0,0 +1,179 @@ + +# Licensed to the Apache Software Foundation (ASF) u

[jira] [Commented] (AIRFLOW-7014) Operator for Apache Kylin

2020-07-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-7014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17157336#comment-17157336 ] ASF GitHub Bot commented on AIRFLOW-7014: - liuyonghengheng commented on pull re

[GitHub] [airflow] liuyonghengheng commented on pull request #9149: [AIRFLOW-7014] Add Apache Kylin operator

2020-07-14 Thread GitBox
liuyonghengheng commented on pull request #9149: URL: https://github.com/apache/airflow/pull/9149#issuecomment-658156250 @mik-laj @potiuk Hi Mik ,Hi Potiuk Will you find some time to merge this pr ? This pr has ben blocked too long time, so that there are some conflicts . After I resolve

[GitHub] [airflow-site] turbaszek opened a new pull request #273: Add new committers and PMCs

2020-07-14 Thread GitBox
turbaszek opened a new pull request #273: URL: https://github.com/apache/airflow-site/pull/273 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

  1   2   >