[GitHub] [airflow] scrambldchannel closed issue #9857: Breeze - selecting "all" integrations option doesn't work

2020-07-17 Thread GitBox
scrambldchannel closed issue #9857: URL: https://github.com/apache/airflow/issues/9857 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [airflow] scrambldchannel commented on issue #9857: Breeze - selecting "all" integrations option doesn't work

2020-07-17 Thread GitBox
scrambldchannel commented on issue #9857: URL: https://github.com/apache/airflow/issues/9857#issuecomment-660436967 Closing as resolved by https://github.com/apache/airflow/pull/9872 This is an automated message from the Apac

[jira] [Commented] (AIRFLOW-5644) Simplify TriggerDagRunOperator usage

2020-07-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17160345#comment-17160345 ] ASF GitHub Bot commented on AIRFLOW-5644: - shippy commented on pull request #63

[jira] [Commented] (AIRFLOW-4355) Externally triggered DAG is marked as 'success' even if a task has been 'removed'!

2020-07-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-4355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17160343#comment-17160343 ] ASF GitHub Bot commented on AIRFLOW-4355: - stale[bot] commented on pull request

[GitHub] [airflow] stale[bot] commented on pull request #9051: Solution proposal to fix mounting a volume problem with dockerswarmop…

2020-07-17 Thread GitBox
stale[bot] commented on pull request #9051: URL: https://github.com/apache/airflow/pull/9051#issuecomment-660434814 This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[GitHub] [airflow] stale[bot] closed pull request #8983: 8876 Provide option to time delta on upstream tasks in TimeDeltaSensor

2020-07-17 Thread GitBox
stale[bot] closed pull request #8983: URL: https://github.com/apache/airflow/pull/8983 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [airflow] stale[bot] commented on pull request #9020: [AIRFLOW-6931] Fixed migrations to find all dependencies for MSSQL wi…

2020-07-17 Thread GitBox
stale[bot] commented on pull request #9020: URL: https://github.com/apache/airflow/pull/9020#issuecomment-660434804 This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[jira] [Commented] (AIRFLOW-7033) Change dag and task state meanwhile

2020-07-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-7033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17160342#comment-17160342 ] ASF GitHub Bot commented on AIRFLOW-7033: - stale[bot] commented on pull request

[GitHub] [airflow] shippy commented on pull request #6317: [AIRFLOW-5644] Simplify TriggerDagRunOperator usage

2020-07-17 Thread GitBox
shippy commented on pull request #6317: URL: https://github.com/apache/airflow/pull/6317#issuecomment-660434937 Unless I overlooked something, it seems that the changes in TriggerDagRunOperator merged here seem to be missing form 1.10.11 - https://github.com/apache/airflow/blob/1.10.11/air

[jira] [Commented] (AIRFLOW-6931) One migration failed during "airflow initdb" in mssql server 2017

2020-07-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-6931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17160344#comment-17160344 ] ASF GitHub Bot commented on AIRFLOW-6931: - stale[bot] commented on pull request

[GitHub] [airflow] stale[bot] commented on pull request #8296: Make execute and on_kill as abstractmethod in baseoperator

2020-07-17 Thread GitBox
stale[bot] commented on pull request #8296: URL: https://github.com/apache/airflow/pull/8296#issuecomment-660434810 This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[GitHub] [airflow] stale[bot] commented on pull request #8082: [AIRFLOW-4355] removed task should not lead to dagrun success

2020-07-17 Thread GitBox
stale[bot] commented on pull request #8082: URL: https://github.com/apache/airflow/pull/8082#issuecomment-660434817 This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[GitHub] [airflow] stale[bot] commented on pull request #7683: [AIRFLOW-7033] Change dag and task state meanwhile

2020-07-17 Thread GitBox
stale[bot] commented on pull request #7683: URL: https://github.com/apache/airflow/pull/7683#issuecomment-660434813 This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[GitHub] [airflow] stale[bot] commented on pull request #9091: [WIP] [8649] Add support for multiple cron expressions as schedule interval

2020-07-17 Thread GitBox
stale[bot] commented on pull request #9091: URL: https://github.com/apache/airflow/pull/9091#issuecomment-660434807 This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[airflow] branch master updated: Added "all" to allowed breeze integrations and tried to clarify on fail (#9872)

2020-07-17 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/master by this push: new 64929ee Added "all" to allowed breeze integrat

[GitHub] [airflow] potiuk commented on pull request #9872: Added "all" to allowed breeze integrations and tried to clarify on fail

2020-07-17 Thread GitBox
potiuk commented on pull request #9872: URL: https://github.com/apache/airflow/pull/9872#issuecomment-660430582 Thanks @scrambldchannel ! This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] [airflow] potiuk merged pull request #9872: Added "all" to allowed breeze integrations and tried to clarify on fail

2020-07-17 Thread GitBox
potiuk merged pull request #9872: URL: https://github.com/apache/airflow/pull/9872 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [airflow] mik-laj edited a comment on issue #9873: Authentication to AWS using GCP credentials

2020-07-17 Thread GitBox
mik-laj edited a comment on issue #9873: URL: https://github.com/apache/airflow/issues/9873#issuecomment-660425099 @ad-m Not everyone uses Kubernetes on GCP. On the other hand, we can add more a well-known external OpenID Connect (OIDC)-compatible IdP in the nest step. Our GCP user communi

[GitHub] [airflow] mik-laj commented on issue #9873: Authentication to AWS using GCP credentials

2020-07-17 Thread GitBox
mik-laj commented on issue #9873: URL: https://github.com/apache/airflow/issues/9873#issuecomment-660425099 @ad-m Not everyone uses Kubernetes on GCP. On the other hand, we can add more a well-known external OpenID Connect (OIDC)-compatible IdP in the nest step. Our GCP user community is v

[GitHub] [airflow] aneesh-joseph edited a comment on pull request #9778: Enable setting the base url of the website

2020-07-17 Thread GitBox
aneesh-joseph edited a comment on pull request #9778: URL: https://github.com/apache/airflow/pull/9778#issuecomment-660422498 > @dimberman The base_url option adds a prefix to each address (including health check), so this change looks good. This option is implemented as WSGI middleware, s

[GitHub] [airflow] aneesh-joseph edited a comment on pull request #9778: Enable setting the base url of the website

2020-07-17 Thread GitBox
aneesh-joseph edited a comment on pull request #9778: URL: https://github.com/apache/airflow/pull/9778#issuecomment-660422498 > @dimberman The base_url option adds a prefix to each address (including health check), so this change looks good. This option is implemented as WSGI middleware, s

[GitHub] [airflow] aneesh-joseph edited a comment on pull request #9778: Enable setting the base url of the website

2020-07-17 Thread GitBox
aneesh-joseph edited a comment on pull request #9778: URL: https://github.com/apache/airflow/pull/9778#issuecomment-660422498 > @dimberman The base_url option adds a prefix to each address (including health check), so this change looks good. This option is implemented as WSGI middleware, s

[GitHub] [airflow] aneesh-joseph commented on pull request #9778: Enable setting the base url of the website

2020-07-17 Thread GitBox
aneesh-joseph commented on pull request #9778: URL: https://github.com/apache/airflow/pull/9778#issuecomment-660422498 > @dimberman The base_url option adds a prefix to each address (including health check), so this change looks good. This option is implemented as WSGI middleware, so it af

[GitHub] [airflow] zikun edited a comment on pull request #9730: DbApiHook: Support kwargs in get_pandas_df

2020-07-17 Thread GitBox
zikun edited a comment on pull request #9730: URL: https://github.com/apache/airflow/pull/9730#issuecomment-655886583 Static check failed: airflow/providers/google/cloud/hooks/bigquery.py:166: error: Signature of "get_pandas_df" incompatible with supertype "DbApiHook" Added kwarg

[GitHub] [airflow] zikun commented on pull request #9699: TimeSensor should consider the default_timezone config

2020-07-17 Thread GitBox
zikun commented on pull request #9699: URL: https://github.com/apache/airflow/pull/9699#issuecomment-660416593 > Can you please rebase on the master branch to remove conflicts? Done. Thanks for the review. Do you mind also taking a look at #9697? It offers idempotence for `tar

[airflow] tag nightly-master updated (892960d -> ba2b5e2)

2020-07-17 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to tag nightly-master in repository https://gitbox.apache.org/repos/asf/airflow.git. *** WARNING: tag nightly-master was modified! *** from 892960d (commit) to ba2b5e2 (commit) from 89

[airflow] tag nightly-master updated (892960d -> ba2b5e2)

2020-07-17 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to tag nightly-master in repository https://gitbox.apache.org/repos/asf/airflow.git. *** WARNING: tag nightly-master was modified! *** from 892960d (commit) to ba2b5e2 (commit) from 89

[GitHub] [airflow] ephraimbuddy commented on pull request #9759: Replace flask-oauthlib with Authlib

2020-07-17 Thread GitBox
ephraimbuddy commented on pull request #9759: URL: https://github.com/apache/airflow/pull/9759#issuecomment-660402073 I think since both Flask-Oauthlib and Authlib can coexist, It's safe to only update the breaking change. I have rolled back my changes on setup.py. We already have Authlib

[GitHub] [airflow-client-go] houqp merged pull request #1: Add generated go client

2020-07-17 Thread GitBox
houqp merged pull request #1: URL: https://github.com/apache/airflow-client-go/pull/1 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [airflow-client-go] houqp opened a new pull request #1: Add generated go client

2020-07-17 Thread GitBox
houqp opened a new pull request #1: URL: https://github.com/apache/airflow-client-go/pull/1 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [airflow-client-go] houqp closed pull request #1: Add generated go client

2020-07-17 Thread GitBox
houqp closed pull request #1: URL: https://github.com/apache/airflow-client-go/pull/1 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [airflow] ad-m edited a comment on issue #9873: Authentication to AWS using GCP credentials

2020-07-17 Thread GitBox
ad-m edited a comment on issue #9873: URL: https://github.com/apache/airflow/issues/9873#issuecomment-660390760 I don't have full knowledge of Airflow environment in Kubernetes, but can we use Google Kubernetes Service Account Token instead of Google ID Token? Then there is no limitation t

[GitHub] [airflow] ad-m commented on issue #9873: Authentication to AWS using GCP credentials

2020-07-17 Thread GitBox
ad-m commented on issue #9873: URL: https://github.com/apache/airflow/issues/9873#issuecomment-660390760 I don't have full knowledge of Airflow environment in Kubernetes, but can we use Google Kubernetes Service Account Token instead of Google ID Token? Then there is no limitation to the u

[GitHub] [airflow] mik-laj opened a new issue #9873: Authentication to AWS using GCP credentials

2020-07-17 Thread GitBox
mik-laj opened a new issue #9873: URL: https://github.com/apache/airflow/issues/9873 Hello, We can use [OpenID Connect Federation](https://docs.aws.amazon.com/IAM/latest/UserGuide/id_roles_providers.html) in [AWS Security Token Service](https://docs.aws.amazon.com/STS/latest/APIRef

[jira] [Commented] (AIRFLOW-6585) Timestamp bug in RefreshKubeConfigLoader

2020-07-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-6585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17160247#comment-17160247 ] ASF GitHub Bot commented on AIRFLOW-6585: - benjaminsky commented on pull reques

[GitHub] [airflow] benjaminsky commented on pull request #7153: [AIRFLOW-6585] Fixed Timestamp bug in RefreshKubeConfigLoader

2020-07-17 Thread GitBox
benjaminsky commented on pull request #7153: URL: https://github.com/apache/airflow/pull/7153#issuecomment-660366371 This is still an issue with EKS and Airflow v1.10.10. This PR fixes it. Can we reopen this PR? This is an a

[GitHub] [airflow] scrambldchannel opened a new pull request #9872: Added "all" to allowed breeze integrations and tried to clarify on fail

2020-07-17 Thread GitBox
scrambldchannel opened a new pull request #9872: URL: https://github.com/apache/airflow/pull/9872 This attempts to address https://github.com/apache/airflow/issues/9857 It is a tidied-up version of https://github.com/apache/airflow/pull/9858 that also tries to clarify the feedback

[GitHub] [airflow] scrambldchannel closed pull request #9858: Add "all" to list of valid breeze integrations

2020-07-17 Thread GitBox
scrambldchannel closed pull request #9858: URL: https://github.com/apache/airflow/pull/9858 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [airflow] pcandoalmeida commented on issue #9538: Add config variable for UI page title

2020-07-17 Thread GitBox
pcandoalmeida commented on issue #9538: URL: https://github.com/apache/airflow/issues/9538#issuecomment-660336778 Thanks @joshkadis! I've checked the linked code and I believe the referenced line renders the browser's window (page) title. If I understood correctly the suggestion was to ena

[GitHub] [airflow] JavierLopezT closed pull request #9865: Allow functions as plugins in airflow.utils

2020-07-17 Thread GitBox
JavierLopezT closed pull request #9865: URL: https://github.com/apache/airflow/pull/9865 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [airflow] JavierLopezT commented on pull request #9865: Allow functions as plugins in airflow.utils

2020-07-17 Thread GitBox
JavierLopezT commented on pull request #9865: URL: https://github.com/apache/airflow/pull/9865#issuecomment-660329581 Gotcha. Makes sense. I'll close the issue This is an automated message from the Apache Git Service. To resp

[GitHub] [airflow] boring-cyborg[bot] commented on issue #9871: Editing DAGs through ui

2020-07-17 Thread GitBox
boring-cyborg[bot] commented on issue #9871: URL: https://github.com/apache/airflow/issues/9871#issuecomment-660302816 Thanks for opening your first issue here! Be sure to follow the issue template! This is an automated

[GitHub] [airflow] apoorvanand opened a new issue #9871: Editing DAGs through ui

2020-07-17 Thread GitBox
apoorvanand opened a new issue #9871: URL: https://github.com/apache/airflow/issues/9871 Currenlty users can only view the code of DAG in ui but if it support the editing also it would be great feature to consider . This

[GitHub] [airflow] OmairK commented on pull request #9861: [WIP] Add test for GCSTaskHandler (#9600)

2020-07-17 Thread GitBox
OmairK commented on pull request #9861: URL: https://github.com/apache/airflow/pull/9861#issuecomment-660300888 @mik-laj I have been trying to understand why `test_gcs_write_fail_remote` has been failing. Can you help me? This the error I am getting. Thank in advance :smile: ``` E

[GitHub] [airflow] vanka56 commented on a change in pull request #9472: Add drop_partition functionality for HiveMetastoreHook

2020-07-17 Thread GitBox
vanka56 commented on a change in pull request #9472: URL: https://github.com/apache/airflow/pull/9472#discussion_r456321846 ## File path: tests/providers/apache/hive/hooks/test_hive.py ## @@ -557,6 +557,11 @@ def test_table_exists(self): self.hook.metastore.__enter__()

[GitHub] [airflow] mik-laj commented on issue #9461: Unclear documentation for the delegate_to parameter

2020-07-17 Thread GitBox
mik-laj commented on issue #9461: URL: https://github.com/apache/airflow/issues/9461#issuecomment-660258187 @olchas We first need to ask a basic question. Shouldn't we abandon support for this feature? In what cases does it work? In what cases does it not work? ---

[GitHub] [airflow] mik-laj commented on issue #8803: Impersonate service accounts while running GCP Operators without key material (if airflow is running on GCP)

2020-07-17 Thread GitBox
mik-laj commented on issue #8803: URL: https://github.com/apache/airflow/issues/8803#issuecomment-660250450 @olchas Sounds goods to me. Can you prepare a POC with one operator and no unit tests? This is an automated message

[GitHub] [airflow] joshkadis commented on issue #9538: Add config variable for UI page title

2020-07-17 Thread GitBox
joshkadis commented on issue #9538: URL: https://github.com/apache/airflow/issues/9538#issuecomment-660246274 Ha, I was just coming back to ask the same thing. Good luck @pcandoalmeida ! This is an automated message from the

[GitHub] [airflow] olchas commented on issue #8803: Impersonate service accounts while running GCP Operators without key material (if airflow is running on GCP)

2020-07-17 Thread GitBox
olchas commented on issue #8803: URL: https://github.com/apache/airflow/issues/8803#issuecomment-660234954 @mik-laj I agree, for users it will definitely be better to be able to specify it at task level. I was looking at implementation of [google.auth.impersonated_credentials modul

[GitHub] [airflow] mik-laj edited a comment on issue #9864: Allow localization of UI

2020-07-17 Thread GitBox
mik-laj edited a comment on issue #9864: URL: https://github.com/apache/airflow/issues/9864#issuecomment-660206356 We are open to supporting multiple languages. There have been attempts to do this before, but I have not seen the final results of this work. Could you please prepare a POC an

[GitHub] [airflow] mik-laj edited a comment on issue #8803: Impersonate service accounts while running GCP Operators without key material (if airflow is running on GCP)

2020-07-17 Thread GitBox
mik-laj edited a comment on issue #8803: URL: https://github.com/apache/airflow/issues/8803#issuecomment-660222575 @olchas It seems to me that we should define it at the task level. From the user's point of view, this should be as easy to use as in gcloud. ```bash gcloud \ --accou

[GitHub] [airflow] mik-laj edited a comment on issue #8803: Impersonate service accounts while running GCP Operators without key material (if airflow is running on GCP)

2020-07-17 Thread GitBox
mik-laj edited a comment on issue #8803: URL: https://github.com/apache/airflow/issues/8803#issuecomment-660222575 @olchas It seems to me that we should define it at the task level. From the user's point of view, this should be as easy to use as in gcloud. ```bash gcloud \ --accou

[GitHub] [airflow] mik-laj edited a comment on issue #8803: Impersonate service accounts while running GCP Operators without key material (if airflow is running on GCP)

2020-07-17 Thread GitBox
mik-laj edited a comment on issue #8803: URL: https://github.com/apache/airflow/issues/8803#issuecomment-660222575 @olchas It seems to me that we should define it at the task level. From the user's point of view, this should be as easy to use as in gcloud. ```bash gcloud \ --accou

[GitHub] [airflow] mik-laj edited a comment on issue #8803: Impersonate service accounts while running GCP Operators without key material (if airflow is running on GCP)

2020-07-17 Thread GitBox
mik-laj edited a comment on issue #8803: URL: https://github.com/apache/airflow/issues/8803#issuecomment-660222575 @olchas It seems to me that we should define it at the task level. From the user's point of view, this should be as easy to use as in gcloud. ```bash gcloud \ --accou

[GitHub] [airflow] mik-laj commented on issue #8803: Impersonate service accounts while running GCP Operators without key material (if airflow is running on GCP)

2020-07-17 Thread GitBox
mik-laj commented on issue #8803: URL: https://github.com/apache/airflow/issues/8803#issuecomment-660222575 @olchas It seems to me that we should define it at the task level. From the user's point of view, this should be as easy to use as in gcloud. ```bash gcloud \ --account=kami

[GitHub] [airflow] mik-laj commented on issue #9864: Allow localization of UI

2020-07-17 Thread GitBox
mik-laj commented on issue #9864: URL: https://github.com/apache/airflow/issues/9864#issuecomment-660206356 We are open to supporting multiple languages. There have been attempts to do this before, but I have not seen the final results of this work. Could you please prepare a POC and trans

[GitHub] [airflow] mik-laj commented on pull request #9865: Allow functions as plugins in airflow.utils

2020-07-17 Thread GitBox
mik-laj commented on pull request #9865: URL: https://github.com/apache/airflow/pull/9865#issuecomment-660203569 Hi. We plan to drop the support of plugins for operators, hooks in Airflow 2.0. For this reason, it doesn't seem like a good idea to add support for utils https://github.com/

[GitHub] [airflow] mik-laj commented on issue #9538: Add config variable for UI page title

2020-07-17 Thread GitBox
mik-laj commented on issue #9538: URL: https://github.com/apache/airflow/issues/9538#issuecomment-660200928 @pcandoalmeida I assigned you to this ticket.:-D This is an automated message from the Apache Git Service. To respon

[GitHub] [airflow] potiuk closed pull request #8708: FIX gid should be 0 according to best practices

2020-07-17 Thread GitBox
potiuk closed pull request #8708: URL: https://github.com/apache/airflow/pull/8708 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [airflow] potiuk commented on pull request #8708: FIX gid should be 0 according to best practices

2020-07-17 Thread GitBox
potiuk commented on pull request #8708: URL: https://github.com/apache/airflow/pull/8708#issuecomment-660159434 It's been implemented in #9545 This is an automated message from the Apache Git Service. To respond to the messa

[airflow] branch master updated: Fix typo in Task Lifecycle section (#9867)

2020-07-17 Thread kaxilnaik
This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/master by this push: new ba2b5e2 Fix typo in Task Lifecycle section

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #9867: fixing typo in Task Lifecycle section

2020-07-17 Thread GitBox
boring-cyborg[bot] commented on pull request #9867: URL: https://github.com/apache/airflow/pull/9867#issuecomment-660145677 Awesome work, congrats on your first merged pull request! This is an automated message from the A

[GitHub] [airflow] kaxil merged pull request #9867: fixing typo in Task Lifecycle section

2020-07-17 Thread GitBox
kaxil merged pull request #9867: URL: https://github.com/apache/airflow/pull/9867 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [airflow] kaxil commented on pull request #9868: Improve type annotations for ftp

2020-07-17 Thread GitBox
kaxil commented on pull request #9868: URL: https://github.com/apache/airflow/pull/9868#issuecomment-660144967 Thanks, @scrambldchannel :) This is an automated message from the Apache Git Service. To respond to the message, p

[GitHub] [airflow] kaxil merged pull request #9868: Improve type annotations for ftp

2020-07-17 Thread GitBox
kaxil merged pull request #9868: URL: https://github.com/apache/airflow/pull/9868 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[airflow] branch master updated: Improve type annotations for Ftp provider (#9868)

2020-07-17 Thread kaxilnaik
This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/master by this push: new 027cc16 Improve type annotations for Ftp pr

[GitHub] [airflow] kaxil commented on issue #9866: check-integrations pre commit test failing when it shouldn't

2020-07-17 Thread GitBox
kaxil commented on issue #9866: URL: https://github.com/apache/airflow/issues/9866#issuecomment-660142378 Fixed in https://github.com/apache/airflow/pull/9869 This is an automated message from the Apache Git Service. To respo

[GitHub] [airflow] kaxil closed issue #9866: check-integrations pre commit test failing when it shouldn't

2020-07-17 Thread GitBox
kaxil closed issue #9866: URL: https://github.com/apache/airflow/issues/9866 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

[airflow] branch master updated: Fix check_integration pre-commit test (#9869)

2020-07-17 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/master by this push: new cbfff65 Fix check_integration pre-commit test

[airflow] branch master updated: Fix check_integration pre-commit test (#9869)

2020-07-17 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/master by this push: new cbfff65 Fix check_integration pre-commit test

[GitHub] [airflow] potiuk commented on pull request #9869: Fix check_integration pre-commit test

2020-07-17 Thread GitBox
potiuk commented on pull request #9869: URL: https://github.com/apache/airflow/pull/9869#issuecomment-660131740 Thanks @scrambldchannel This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [airflow] potiuk merged pull request #9869: Fix check_integration pre-commit test

2020-07-17 Thread GitBox
potiuk merged pull request #9869: URL: https://github.com/apache/airflow/pull/9869 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [airflow] kaxil edited a comment on pull request #5048: [AIRFLOW-3370] Add stdout output options to Elasticsearch task log handler

2020-07-17 Thread GitBox
kaxil edited a comment on pull request #5048: URL: https://github.com/apache/airflow/pull/5048#issuecomment-660121750 Using `write_stdout=True` is causing issues for retrieving Logs for tasks using SubDagOperators (when using Subprocess to spawn tasks - no os.fork). Example: `

[jira] [Commented] (AIRFLOW-3370) Enhance current ES handler with stdout capability and more output options

2020-07-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-3370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17159948#comment-17159948 ] ASF GitHub Bot commented on AIRFLOW-3370: - kaxil edited a comment on pull reque

[jira] [Commented] (AIRFLOW-3370) Enhance current ES handler with stdout capability and more output options

2020-07-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-3370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17159946#comment-17159946 ] ASF GitHub Bot commented on AIRFLOW-3370: - kaxil edited a comment on pull reque

[jira] [Commented] (AIRFLOW-3370) Enhance current ES handler with stdout capability and more output options

2020-07-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-3370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17159945#comment-17159945 ] ASF GitHub Bot commented on AIRFLOW-3370: - kaxil commented on pull request #504

[GitHub] [airflow] kaxil edited a comment on pull request #5048: [AIRFLOW-3370] Add stdout output options to Elasticsearch task log handler

2020-07-17 Thread GitBox
kaxil edited a comment on pull request #5048: URL: https://github.com/apache/airflow/pull/5048#issuecomment-660121750 Using `write_stdout=True` is causing issues for retrieving Logs for tasks using SubDagOperators (when using Subprocess to spawn tasks - no os.fork). Example: `

[GitHub] [airflow] kaxil commented on pull request #5048: [AIRFLOW-3370] Add stdout output options to Elasticsearch task log handler

2020-07-17 Thread GitBox
kaxil commented on pull request #5048: URL: https://github.com/apache/airflow/pull/5048#issuecomment-660121750 Using `write_stdout=True` is causing issues for retrieving Logs for tasks using SubDagOperators (when using Subprocess to spawn tasks - no os.fork). Example: ``` E

[GitHub] [airflow] pcandoalmeida commented on issue #9538: Add config variable for UI page title

2020-07-17 Thread GitBox
pcandoalmeida commented on issue #9538: URL: https://github.com/apache/airflow/issues/9538#issuecomment-660118481 Hi there, I'm new to the project and was wondering if I could work on this? This is an automated message from t

[GitHub] [airflow] blcksrx commented on pull request #8918: Impala hook implention

2020-07-17 Thread GitBox
blcksrx commented on pull request #8918: URL: https://github.com/apache/airflow/pull/8918#issuecomment-660112766 No Problem. Thanks This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [airflow] kaxil commented on issue #9852: dag_run.conf is NoneType when running example_trigger_target_dag from example_dags

2020-07-17 Thread GitBox
kaxil commented on issue #9852: URL: https://github.com/apache/airflow/issues/9852#issuecomment-660110566 Saw your comment here: https://github.com/apache/airflow/pull/9853#issuecomment-659820987 will try to reproduce it today -

[GitHub] [airflow] kaxil commented on issue #9852: dag_run.conf is NoneType when running example_trigger_target_dag from example_dags

2020-07-17 Thread GitBox
kaxil commented on issue #9852: URL: https://github.com/apache/airflow/issues/9852#issuecomment-660108077 > > Thanks @kaxil! While this ensures that conf will always return a dictionary and not None, my issue is that conf is not being passed from the controller to the target dag at all - a

[GitHub] [airflow] uns1 commented on issue #9852: dag_run.conf is NoneType when running example_trigger_target_dag from example_dags

2020-07-17 Thread GitBox
uns1 commented on issue #9852: URL: https://github.com/apache/airflow/issues/9852#issuecomment-660105410 > Thanks @kaxil! While this ensures that conf will always return a dictionary and not None, my issue is that conf is not being passed from the controller to the target dag at all - as p

[GitHub] [airflow] uns1 opened a new issue #9870: conf is not getting passed from TriggerDagRunOperator controller dag to target dag

2020-07-17 Thread GitBox
uns1 opened a new issue #9870: URL: https://github.com/apache/airflow/issues/9870 **Apache Airflow version**: 1.10.9 & 1.10.11 **Environment**: - **Cloud provider or hardware configuration**: Local PC running Docker on Windows through WSL2 - **OS** (e.g. from /etc/os-release): Deb

[GitHub] [airflow] scrambldchannel opened a new pull request #9869: Fix check_integration pre-commit test

2020-07-17 Thread GitBox
scrambldchannel opened a new pull request #9869: URL: https://github.com/apache/airflow/pull/9869 This aims to fix the issue I raised here https://github.com/apache/airflow/issues/9866 --- Make sure to mark the boxes below before creating PR: [x] - [x] Description above

[GitHub] [airflow] OmairK commented on a change in pull request #9861: [WIP] Add test for GCSTaskHandler (#9600)

2020-07-17 Thread GitBox
OmairK commented on a change in pull request #9861: URL: https://github.com/apache/airflow/pull/9861#discussion_r456427052 ## File path: airflow/providers/google/cloud/log/gcs_task_handler.py ## @@ -55,8 +55,8 @@ def hook(self): except Exception as e: # pylint: disabl

[GitHub] [airflow] OmairK commented on a change in pull request #9861: [WIP] Add test for GCSTaskHandler (#9600)

2020-07-17 Thread GitBox
OmairK commented on a change in pull request #9861: URL: https://github.com/apache/airflow/pull/9861#discussion_r456427052 ## File path: airflow/providers/google/cloud/log/gcs_task_handler.py ## @@ -55,8 +55,8 @@ def hook(self): except Exception as e: # pylint: disabl

[GitHub] [airflow] OmairK commented on a change in pull request #9861: [WIP] Add test for GCSTaskHandler (#9600)

2020-07-17 Thread GitBox
OmairK commented on a change in pull request #9861: URL: https://github.com/apache/airflow/pull/9861#discussion_r456426965 ## File path: airflow/providers/google/cloud/log/gcs_task_handler.py ## @@ -165,7 +165,7 @@ def gcs_write(self, log, remote_log_location, append=True):

[GitHub] [airflow] kanga333 commented on pull request #9444: Add placement_strategy option

2020-07-17 Thread GitBox
kanga333 commented on pull request #9444: URL: https://github.com/apache/airflow/pull/9444#issuecomment-660088688 Thanks for your review. I think I've added unit tests. In the test, I set a new option to ECS operator and run it. And I'm making sure the options are set up correctly

[GitHub] [airflow] scrambldchannel opened a new pull request #9868: Improve type annotations for ftp

2020-07-17 Thread GitBox
scrambldchannel opened a new pull request #9868: URL: https://github.com/apache/airflow/pull/9868 Improved type annotations for ftp provider as per https://github.com/apache/airflow/issues/9708 This is a tidied-up version of https://github.com/apache/airflow/pull/9831 in which I got

[GitHub] [airflow] ArrichM opened a new pull request #9867: fixing typo in Task Lifecycle section

2020-07-17 Thread GitBox
ArrichM opened a new pull request #9867: URL: https://github.com/apache/airflow/pull/9867 --- Make sure to mark the boxes below before creating PR: [x] - [ ] Description above provides context of the change - [ ] Unit tests coverage for changes (not needed for documentation chan

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #9867: fixing typo in Task Lifecycle section

2020-07-17 Thread GitBox
boring-cyborg[bot] commented on pull request #9867: URL: https://github.com/apache/airflow/pull/9867#issuecomment-660078886 Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contr

[GitHub] [airflow] turbaszek commented on issue #8765: Create an `airflow upgrade-check` command in 1.10 to ease upgrade path to 2.0.

2020-07-17 Thread GitBox
turbaszek commented on issue #8765: URL: https://github.com/apache/airflow/issues/8765#issuecomment-660077522 > so we shouldn't change their files without confirmation (perhaps show a diff then ask y/n?) Bowler has this option --

[GitHub] [airflow] scrambldchannel commented on pull request #9831: Improve type annotations for ftp provider

2020-07-17 Thread GitBox
scrambldchannel commented on pull request #9831: URL: https://github.com/apache/airflow/pull/9831#issuecomment-660070262 Closed this and will clean up and re-open This is an automated message from the Apache Git Service. To r

[GitHub] [airflow] scrambldchannel closed pull request #9831: Improve type annotations for ftp provider

2020-07-17 Thread GitBox
scrambldchannel closed pull request #9831: URL: https://github.com/apache/airflow/pull/9831 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [airflow] kaxil commented on a change in pull request #9851: Update Serialized DAGs in Webserver when DAGs are Updated

2020-07-17 Thread GitBox
kaxil commented on a change in pull request #9851: URL: https://github.com/apache/airflow/pull/9851#discussion_r456393849 ## File path: airflow/models/serialized_dag.py ## @@ -212,3 +228,18 @@ def bulk_sync_to_db(dags: List[DAG], session=None): min_update_i

[GitHub] [airflow] kaxil commented on a change in pull request #9851: Update Serialized DAGs in Webserver when DAGs are Updated

2020-07-17 Thread GitBox
kaxil commented on a change in pull request #9851: URL: https://github.com/apache/airflow/pull/9851#discussion_r456393629 ## File path: docs/dag-serialization.rst ## @@ -58,11 +58,16 @@ Add the following settings in ``airflow.cfg``: [core] store_serialized_dags = True

[GitHub] [airflow] kaxil commented on a change in pull request #9851: Update Serialized DAGs in Webserver when DAGs are Updated

2020-07-17 Thread GitBox
kaxil commented on a change in pull request #9851: URL: https://github.com/apache/airflow/pull/9851#discussion_r456393768 ## File path: tests/models/test_dagbag.py ## @@ -657,3 +659,41 @@ def test_serialized_dags_are_written_to_db_on_sync(self): new_serialized_da

[GitHub] [airflow] kaxil commented on a change in pull request #9851: Update Serialized DAGs in Webserver when DAGs are Updated

2020-07-17 Thread GitBox
kaxil commented on a change in pull request #9851: URL: https://github.com/apache/airflow/pull/9851#discussion_r456393406 ## File path: airflow/models/dagbag.py ## @@ -151,10 +151,10 @@ def get_dag(self, dag_id): # Load from DB if not (yet) in the bag

[GitHub] [airflow] kaxil commented on pull request #9850: Don't Update Serialized DAGs in DB if DAG didn't change

2020-07-17 Thread GitBox
kaxil commented on pull request #9850: URL: https://github.com/apache/airflow/pull/9850#issuecomment-660040740 > With this change does it still make sense to have the `min_serialized_dag_update_interval` setting? At least in this PR it makes sense to keep it to avoid pulling Serializ

  1   2   >