jhtimmins commented on issue #10469:
URL: https://github.com/apache/airflow/issues/10469#issuecomment-678597419
@mik-laj @kaxil @ashb @potiuk Would love to hear your thoughts on renaming
permissions to make them consistent across the UI and API.
jhtimmins opened a new issue #10469:
URL: https://github.com/apache/airflow/issues/10469
## Rationale
Airflow currently has 185 permissions (where 1 permission is a combo of
Class + Action). The design of the permissions is inconsistent, making them
difficult to modify or organize into
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a commit to branch constraints-master
in repository https://gitbox.apache.org/repos/asf/airflow.git
The following commit(s) were added to refs/heads/constraints-master by this
push:
new a8d9dc7 Updating
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a commit to branch constraints-master
in repository https://gitbox.apache.org/repos/asf/airflow.git
The following commit(s) were added to refs/heads/constraints-master by this
push:
new a8d9dc7 Updating
kaxil opened a new pull request #10468:
URL: https://github.com/apache/airflow/pull/10468
Use PEP 577: https://www.python.org/dev/peps/pep-0577/
---
**^ Add meaningful description above**
Read the **[Pull Request
kaxil opened a new pull request #10467:
URL: https://github.com/apache/airflow/pull/10467
Few tabs weren't indented properly. This will now make it easy to copy paste
---
**^ Add meaningful description above**
Read the **[Pull Request
kaxil opened a new pull request #10466:
URL: https://github.com/apache/airflow/pull/10466
Add "Type Annotations" & Docstrings to `airflow/models/dagrun.py`
---
**^ Add meaningful description above**
Read the **[Pull Request
kaxil opened a new pull request #10465:
URL: https://github.com/apache/airflow/pull/10465
Use `self.assertEqual` instead of `self.assertIn` to do an exact match of
string name instead of partial match
---
**^ Add meaningful description above**
Read the **[Pull
kaxil opened a new pull request #10464:
URL: https://github.com/apache/airflow/pull/10464
- `self.check_content_in_response` already checks that response code is 200
- `self.assertEqual(None, ...)` -> `self.assertIsNone(...)`
- Fix typo: "succcess" -> `success`
---
kaxil opened a new pull request #10463:
URL: https://github.com/apache/airflow/pull/10463
`MockExcutor` -> `MockExecutor`
`ShortCircutExecutor` -> `ShortCircuitExecutor`
---
**^ Add meaningful description above**
Read the **[Pull Request
syudb opened a new pull request #10462:
URL: https://github.com/apache/airflow/pull/10462
This PR addresses an issue with the way GET requests were being built/sent.
In the original implementation, the request payload is sent in the body of the
request and not in the query string
boring-cyborg[bot] commented on pull request #10461:
URL: https://github.com/apache/airflow/pull/10461#issuecomment-678556493
Congratulations on your first Pull Request and welcome to the Apache Airflow
community! If you have any issues or are unsure about any anything please check
our
syudb opened a new pull request #10461:
URL: https://github.com/apache/airflow/pull/10461
This PR addresses an issue with the way GET requests were being built/sent.
In the original implementation, the request payload is sent in the body of the
request and not in the query string
kaxil opened a new pull request #10460:
URL: https://github.com/apache/airflow/pull/10460
Remove mentions of Airflow Gitter as it isn't that active.
---
**^ Add meaningful description above**
Read the **[Pull Request
kaxil opened a new pull request #10459:
URL: https://github.com/apache/airflow/pull/10459
`timeouted` -> `timed_out`
---
**^ Add meaningful description above**
Read the **[Pull Request
kaxil opened a new pull request #10458:
URL: https://github.com/apache/airflow/pull/10458
`waitfordone` -> `wait_for_done`
---
**^ Add meaningful description above**
Read the **[Pull Request
kaxil opened a new pull request #10457:
URL: https://github.com/apache/airflow/pull/10457
`assertEqual` will show show the proper diff instead of just "False is not
True" error
---
**^ Add meaningful description above**
Read the **[Pull Request
atsalolikhin-spokeo commented on issue #10389:
URL: https://github.com/apache/airflow/issues/10389#issuecomment-678534509
Yes, I did. I use GNU Screen, so I closed that window, and started another
window (which starts a fresh bash process).
On Fri, Aug 21, 2020 at 1:41 PM Jarek
dimon222 opened a new issue #10456:
URL: https://github.com/apache/airflow/issues/10456
kaxil commented on issue #10455:
URL: https://github.com/apache/airflow/issues/10455#issuecomment-678484327
aah nice, yes I have marked it for 1.10.13 :)
This is an automated message from the Apache Git Service.
To respond
potiuk commented on issue #10389:
URL: https://github.com/apache/airflow/issues/10389#issuecomment-678484017
Did you log out/log in as suggested by the message
? Bash cashes the binaries it uses so even if your PATH is updated you
might still use the old getopt. I believe there is a
rgrizzell edited a comment on issue #10024:
URL: https://github.com/apache/airflow/issues/10024#issuecomment-678469071
A further deep dive into this issue, I believe this is the result of default
behavior in the Python logging module.
When utilizing the [PercentStyle
rgrizzell edited a comment on issue #10024:
URL: https://github.com/apache/airflow/issues/10024#issuecomment-678469071
A further deep dive into this issue, I believe this is the result of default
behavior in the Python logging module.
When utilizing the [PercentStyle
ephraimbuddy commented on pull request #10333:
URL: https://github.com/apache/airflow/pull/10333#issuecomment-678475229
I don't really know what caused the earlier breeze issues廊. I had to delete
the branch and recreate it at an earlier commit. Then after rebasing, it
worked. However, I
gmontanola commented on pull request #10436:
URL: https://github.com/apache/airflow/pull/10436#issuecomment-678473322
Haha, the emojis are a courtesy of https://github.com/commitizen/cz-cli.
When you say if it is backwards compatible you mean if it will work with
older versions?
XD-DENG commented on issue #10455:
URL: https://github.com/apache/airflow/issues/10455#issuecomment-678470644
A kind ping to our K8S subject expert @dimberman ;-)
@kaxil we may want to address this doc change in our next release as well ?
If I missed or misunderstood anything,
XD-DENG opened a new issue #10455:
URL: https://github.com/apache/airflow/issues/10455
**What happened**:
In documentation about Kubenetes Executor
(https://airflow.apache.org/docs/stable/executor/kubernetes.html or
rgrizzell commented on issue #10024:
URL: https://github.com/apache/airflow/issues/10024#issuecomment-678469071
A further deep dive into this issue, I believe this is the result of default
behavior in the Python logging module.
When utilizing the [PercentStyle
atsalolikhin-spokeo commented on issue #10389:
URL: https://github.com/apache/airflow/issues/10389#issuecomment-678464759
I am using bash.
On Fri, Aug 21, 2020 at 12:48 PM Jarek Potiuk
wrote:
> Are you using zsh ? If so can you run the bash command suggested ? I think
>
This is an automated email from the ASF dual-hosted git repository.
potiuk pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/airflow.git.
from 7dd6e73 Mount gcloud kubeconifg to breeze (#10439)
add c979de7 Fixes problem with Python image not ready to
This is an automated email from the ASF dual-hosted git repository.
potiuk pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/airflow.git.
from 7dd6e73 Mount gcloud kubeconifg to breeze (#10439)
add c979de7 Fixes problem with Python image not ready to
potiuk merged pull request #10430:
URL: https://github.com/apache/airflow/pull/10430
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
potiuk commented on issue #10389:
URL: https://github.com/apache/airflow/issues/10389#issuecomment-678462371
Are you using zsh ? If so can you run the bash command suggested ? I think
inside the pre-commits we always use bash so the message is actually misleading
- I can correct it if we
This is an automated email from the ASF dual-hosted git repository.
turbaszek pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/airflow.git.
from 3357d8d Fix port number in webserver for kind setup (#10452)
add 7dd6e73 Mount gcloud kubeconifg to
This is an automated email from the ASF dual-hosted git repository.
turbaszek pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/airflow.git.
from 3357d8d Fix port number in webserver for kind setup (#10452)
add 7dd6e73 Mount gcloud kubeconifg to
turbaszek merged pull request #10439:
URL: https://github.com/apache/airflow/pull/10439
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
turbaszek commented on pull request #10453:
URL: https://github.com/apache/airflow/pull/10453#issuecomment-678451945
CC: @roitvt
This is an automated message from the Apache Git Service.
To respond to the message, please
turbaszek commented on a change in pull request #10447:
URL: https://github.com/apache/airflow/pull/10447#discussion_r474886643
##
File path: airflow/providers/cncf/kubernetes/hooks/kubernetes.py
##
@@ -46,11 +46,14 @@ def __init__(
):
super().__init__()
atsalolikhin-spokeo commented on issue #10389:
URL: https://github.com/apache/airflow/issues/10389#issuecomment-678445952
```
[~/git/airflow] fix/10389 ± pre-commit run build --verbose
Check if image build is
needed...Failed
- hook id: build
potiuk commented on pull request #10445:
URL: https://github.com/apache/airflow/pull/10445#issuecomment-678437459
Interesting - I will take a look if this was not some teething problem.
There is a potential problem I was anticipating might happen - which could have
similar behaviour.
potiuk commented on pull request #10446:
URL: https://github.com/apache/airflow/pull/10446#issuecomment-678435531
My questions was answered beautifully. Thanks @kaxil @turbaszek !
This is an automated message from the Apache
potiuk edited a comment on pull request #10446:
URL: https://github.com/apache/airflow/pull/10446#issuecomment-678435531
My question was answered beautifully. Thanks @kaxil @turbaszek !
This is an automated message from the
potiuk commented on pull request #10439:
URL: https://github.com/apache/airflow/pull/10439#issuecomment-678434145
Nice!
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
potiuk commented on a change in pull request #10441:
URL: https://github.com/apache/airflow/pull/10441#discussion_r474863556
##
File path: tests/conftest.py
##
@@ -38,11 +38,6 @@
sys.path.append(perf_directory)
-from perf_kit.sqlalchemy import ( # noqa: E402
potiuk commented on a change in pull request #10441:
URL: https://github.com/apache/airflow/pull/10441#discussion_r474863556
##
File path: tests/conftest.py
##
@@ -38,11 +38,6 @@
sys.path.append(perf_directory)
-from perf_kit.sqlalchemy import ( # noqa: E402
This is an automated email from the ASF dual-hosted git repository.
potiuk pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/airflow.git.
from f0727b3 Change provider configuration keys for OAuth (#9759)
add 3357d8d Fix port number in webserver for
This is an automated email from the ASF dual-hosted git repository.
potiuk pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/airflow.git.
from f0727b3 Change provider configuration keys for OAuth (#9759)
add 3357d8d Fix port number in webserver for
potiuk merged pull request #10452:
URL: https://github.com/apache/airflow/pull/10452
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
potiuk commented on issue #10389:
URL: https://github.com/apache/airflow/issues/10389#issuecomment-678425401
Hey @atsalolikhin-spokeo - please rebase to latest master. I fixed this
morning a Mac related problem that would look very much like this: #10440
potiuk commented on issue #10454:
URL: https://github.com/apache/airflow/issues/10454#issuecomment-678424669
Looking forward to it!
This is an automated message from the Apache Git Service.
To respond to the message, please
mik-laj commented on pull request #10052:
URL: https://github.com/apache/airflow/pull/10052#issuecomment-678412038
Are you planning to add impersonations for DataflowCreatePythonJobOperator
and DataflowCreateJavaJobOperator, GKEStartPodOperator and
BigQueryTablePartitionExistenceSensor?
mik-laj commented on pull request #10052:
URL: https://github.com/apache/airflow/pull/10052#issuecomment-678406046
I would like to do a review. Please wait a moment.
This is an automated message from the Apache Git Service.
jaketf opened a new issue #10454:
URL: https://github.com/apache/airflow/issues/10454
**Description**
Create a terraform integration for apache airflow.
**Use case / motivation**
Use terraform to manage ephemeral infrastructure used in airflow DAGs taking
advantage
atsalolikhin-spokeo commented on issue #10389:
URL: https://github.com/apache/airflow/issues/10389#issuecomment-678398482
```
[~/git/airflow] fix/10389 ± git commit --verify
No-tabs
turbaszek commented on pull request #10052:
URL: https://github.com/apache/airflow/pull/10052#issuecomment-678396131
That's huge. The docs look good and I hope that the auto refactors worked as
expected. Regarding the example, I think we should add it but we can create an
issue for that
atsalolikhin-spokeo commented on issue #10389:
URL: https://github.com/apache/airflow/issues/10389#issuecomment-678395214
```
[~/git/airflow] fix/10389 ± pre-commit run build --verbose
Check if image build is
needed...Failed
- hook id: build
mik-laj commented on a change in pull request #10447:
URL: https://github.com/apache/airflow/pull/10447#discussion_r474820447
##
File path: airflow/providers/cncf/kubernetes/hooks/kubernetes.py
##
@@ -46,11 +46,14 @@ def __init__(
):
super().__init__()
This is an automated email from the ASF dual-hosted git repository.
kamilbregula pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/airflow.git.
from 1cf1af6 Do not override in_container scripts when building the image
(#10442)
add f0727b3 Change
turbaszek commented on a change in pull request #10439:
URL: https://github.com/apache/airflow/pull/10439#discussion_r474811192
##
File path: scripts/ci/docker-compose/forward-credentials.yml
##
@@ -29,3 +29,4 @@ services:
- ${HOME}/.azure:/root/.azure:cached
-
This is an automated email from the ASF dual-hosted git repository.
kamilbregula pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/airflow.git.
from 1cf1af6 Do not override in_container scripts when building the image
(#10442)
add f0727b3 Change
smishra commented on issue #10451:
URL: https://github.com/apache/airflow/issues/10451#issuecomment-678385795
In case you want to answer it on StackOverflow (for others to find):
This is an automated email from the ASF dual-hosted git repository.
kamilbregula pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/airflow.git
The following commit(s) were added to refs/heads/master by this push:
new f0727b3 Change provider configuration
mik-laj closed issue #9662:
URL: https://github.com/apache/airflow/issues/9662
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
mik-laj merged pull request #9759:
URL: https://github.com/apache/airflow/pull/9759
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
turbaszek opened a new pull request #10453:
URL: https://github.com/apache/airflow/pull/10453
---
**^ Add meaningful description above**
Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)**
for more
turbaszek commented on a change in pull request #10304:
URL: https://github.com/apache/airflow/pull/10304#discussion_r474802652
##
File path: docs/howto/operator/google/cloud/dataprep.rst
##
@@ -17,7 +17,25 @@
Google Dataprep Operators
=
-`Google
turbaszek commented on a change in pull request #10304:
URL: https://github.com/apache/airflow/pull/10304#discussion_r474802652
##
File path: docs/howto/operator/google/cloud/dataprep.rst
##
@@ -17,7 +17,25 @@
Google Dataprep Operators
=
-`Google
ltken123 removed a comment on issue #8212:
URL: https://github.com/apache/airflow/issues/8212#issuecomment-678015944
> Having gotten remote logging working on 1.10.10 I've noticed there seems
to be a difference in how the workers handle the log upload versus the
webserver component. The
ephraimbuddy commented on pull request #10333:
URL: https://github.com/apache/airflow/pull/10333#issuecomment-678372479
Nice, I will do that.
This is an automated message from the Apache Git Service.
To respond to the
OmairK commented on pull request #10333:
URL: https://github.com/apache/airflow/pull/10333#issuecomment-678365011
@ephraimbuddy can you rebase to the latest master, #9740 is merged can you
update the error message for `patch_dag` endpoint, thanks in advance.
:smile_cat:
This is an automated email from the ASF dual-hosted git repository.
potiuk pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/airflow.git.
from fdd68ec Make system test work with 1.10 (#10444)
add 1cf1af6 Do not override in_container scripts when
This is an automated email from the ASF dual-hosted git repository.
potiuk pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/airflow.git.
from fdd68ec Make system test work with 1.10 (#10444)
add 1cf1af6 Do not override in_container scripts when
potiuk merged pull request #10442:
URL: https://github.com/apache/airflow/pull/10442
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
potiuk commented on pull request #10442:
URL: https://github.com/apache/airflow/pull/10442#issuecomment-678348127
Looks good:
https://github.com/potiuk/airflow/runs/1012859548?check_suite_focus=true
pushing it. I had to do another thing - disable the 6000 "skipped" tests in
integration
smishra opened a new issue #10451:
URL: https://github.com/apache/airflow/issues/10451
Looks like there is a bug in Airflow templated operator argument when it has
any string that ends with _.json._ Following is my DAG - please notice
**"--files", "s3://dummy/spark/application.json"** in
boring-cyborg[bot] commented on issue #10451:
URL: https://github.com/apache/airflow/issues/10451#issuecomment-678345450
Thanks for opening your first issue here! Be sure to follow the issue
template!
This is an
kaxil commented on pull request #10446:
URL: https://github.com/apache/airflow/pull/10446#issuecomment-678335857
> Using cli - right. Using webui - no. You can't create "custom conn type"
due to input validation. No strong opinion here, I just thought that having
this conn type may help
This is an automated email from the ASF dual-hosted git repository.
turbaszek pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/airflow.git
The following commit(s) were added to refs/heads/master by this push:
new fdd68ec Make system test work with 1.10
This is an automated email from the ASF dual-hosted git repository.
turbaszek pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/airflow.git
The following commit(s) were added to refs/heads/master by this push:
new fdd68ec Make system test work with 1.10
turbaszek merged pull request #10444:
URL: https://github.com/apache/airflow/pull/10444
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
turbaszek edited a comment on pull request #10446:
URL: https://github.com/apache/airflow/pull/10446#issuecomment-678327477
Using cli - right. Using webui - no. You can't create "custom conn type" due
to input validation. No strong opinion here, I just thought that having this
conn type
turbaszek commented on pull request #10446:
URL: https://github.com/apache/airflow/pull/10446#issuecomment-678327477
Using cli - right. Using webui - no. You can't create "custom conn type".
This is an automated message
This is an automated email from the ASF dual-hosted git repository.
potiuk pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/airflow.git.
from 95f4768 Building backport packages generates README files (#10445)
add 5bf47e3 Be nice to fork repositories
potiuk commented on pull request #10448:
URL: https://github.com/apache/airflow/pull/10448#issuecomment-678316064
Ah .. too fast .. .it took the old name from the commit :( . Sorry @kaxil ..
This is an automated message from
potiuk merged pull request #10448:
URL: https://github.com/apache/airflow/pull/10448
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
potiuk commented on issue #10450:
URL: https://github.com/apache/airflow/issues/10450#issuecomment-678313424
cc: @ad-m @turbaszek
This is an automated message from the Apache Git Service.
To respond to the message, please
potiuk opened a new issue #10450:
URL: https://github.com/apache/airflow/issues/10450
**Description**
We started pushing quite a number of images to GitHub Registry we should
clean them up.
**Use case / motivation**
We should run a cron action that should clean-up the
frosk1 opened a new issue #10449:
URL: https://github.com/apache/airflow/issues/10449
**Description**
There are several question (issues) on stack overflow, asking for the need
of a dynamic schedule interval. This means, the ability to change the schedule
interval after DAG
boring-cyborg[bot] commented on issue #10449:
URL: https://github.com/apache/airflow/issues/10449#issuecomment-678312262
Thanks for opening your first issue here! Be sure to follow the issue
template!
This is an
kaxil commented on pull request #10446:
URL: https://github.com/apache/airflow/pull/10446#issuecomment-678311136
> @kaxil but, don't we have user input validation on conn type in WebUI?
>
kaxil edited a comment on pull request #10446:
URL: https://github.com/apache/airflow/pull/10446#issuecomment-678311136
> @kaxil but, don't we have user input validation on conn type in WebUI?
>
This is an automated email from the ASF dual-hosted git repository.
turbaszek pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/airflow.git.
from 1e37186 Add update endpoint for DAG (#9101) (#9740)
add 95f4768 Building backport packages generates
This is an automated email from the ASF dual-hosted git repository.
turbaszek pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/airflow.git.
from 1e37186 Add update endpoint for DAG (#9101) (#9740)
add 95f4768 Building backport packages generates
turbaszek merged pull request #10445:
URL: https://github.com/apache/airflow/pull/10445
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
potiuk commented on pull request #10380:
URL: https://github.com/apache/airflow/pull/10380#issuecomment-678301385
Udpated the first review by @feluelle .
This is an automated message from the Apache Git Service.
To respond
turbaszek commented on pull request #10446:
URL: https://github.com/apache/airflow/pull/10446#issuecomment-678300185
And we do enforce:
```
The following args are required to add a connection: ['conn_uri or
conn_type']
```
potiuk commented on a change in pull request #10380:
URL: https://github.com/apache/airflow/pull/10380#discussion_r474708503
##
File path: CI.rst
##
@@ -17,6 +17,10 @@
.. contents:: :local:
+NOTE! This is the target architecture we are aspiring to. We have a
potiuk opened a new pull request #10448:
URL: https://github.com/apache/airflow/pull/10448
Only runs scheduled CI runs in the 'apache/airflow' forks
---
**^ Add meaningful description above**
Read the **[Pull Request
turbaszek commented on pull request #10446:
URL: https://github.com/apache/airflow/pull/10446#issuecomment-678296209
@kaxil but, don't we have user input validation on conn type in WebUI?
turbaszek commented on pull request #10445:
URL: https://github.com/apache/airflow/pull/10445#issuecomment-678295574
Not sure what's wrong here but the errors are definitely unrelated:
```
mypy: can't read file 'airflow/providers/amazon/aws/hooks/ses.py': No such
file or directory
1 - 100 of 158 matches
Mail list logo
