[GitHub] [airflow] jhtimmins commented on issue #8112: Authorization and Permissions

2020-08-26 Thread GitBox
jhtimmins commented on issue #8112: URL: https://github.com/apache/airflow/issues/8112#issuecomment-681564970 Thanks @mik-laj, here's the WIP PR to address this https://github.com/apache/airflow/pull/10594 This is an

[GitHub] [airflow] jhtimmins opened a new pull request #10594: Add permissions for stable API

2020-08-26 Thread GitBox
jhtimmins opened a new pull request #10594: URL: https://github.com/apache/airflow/pull/10594 --- **^ Add meaningful description above** Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for

[GitHub] [airflow] alexbegg edited a comment on issue #10434: Last Run links on home page UI not correct with RBAC UI

2020-08-26 Thread GitBox
alexbegg edited a comment on issue #10434: URL: https://github.com/apache/airflow/issues/10434#issuecomment-681534486 I tracked it down. The problem is an invalid value of `request.args.get('execution_date')` when `execution_date` is passed in the URL unencoded resulting in it not

[GitHub] [airflow] alexbegg edited a comment on issue #10434: Last Run links on home page UI not correct with RBAC UI

2020-08-26 Thread GitBox
alexbegg edited a comment on issue #10434: URL: https://github.com/apache/airflow/issues/10434#issuecomment-681534486 I tracked it down. The problem is an invalid value of `request.args.get('execution_date')` when `execution_date` is passed in the URL unencoded resulting in it not

[GitHub] [airflow] alexbegg commented on issue #10434: Last Run links on home page UI not correct with RBAC UI

2020-08-26 Thread GitBox
alexbegg commented on issue #10434: URL: https://github.com/apache/airflow/issues/10434#issuecomment-681534486 I tracked it down. The problem is an invalid value of `request.args.get('execution_date')` when passed in the URL unencoded resulting in not returning the correct pendulum

[GitHub] [airflow] alexbegg edited a comment on issue #10434: Last Run links on home page UI not correct with RBAC UI

2020-08-26 Thread GitBox
alexbegg edited a comment on issue #10434: URL: https://github.com/apache/airflow/issues/10434#issuecomment-681425221 I think I am able to replicate it now. It is only happening if the `execution_date` time is NOT `00:00:00` (in my first screenshot of my last comment, it was `07:00:00`,

[GitHub] [airflow] alexbegg commented on issue #10434: Last Run links on home page UI not correct with RBAC UI

2020-08-26 Thread GitBox
alexbegg commented on issue #10434: URL: https://github.com/apache/airflow/issues/10434#issuecomment-681425221 I think I am able to replicate it now. It is only happening if the `execution_date` time is NOT `00:00` (in my first screenshot of my last comment, it was `07:00`) because when

[GitHub] [airflow] dimberman commented on a change in pull request #10393: Simplify the K8sExecutor and K8sPodOperator

2020-08-26 Thread GitBox
dimberman commented on a change in pull request #10393: URL: https://github.com/apache/airflow/pull/10393#discussion_r478094698 ## File path: airflow/example_dags/example_kubernetes_executor_config.py ## @@ -52,60 +53,67 @@ def test_volume_mount(): start_task =

[GitHub] [airflow] bryzgaloff commented on pull request #10546: DockerOperator extra_hosts argument support added

2020-08-26 Thread GitBox
bryzgaloff commented on pull request #10546: URL: https://github.com/apache/airflow/pull/10546#issuecomment-681370371 Rerun black to pass CI/CD check. This is an automated message from the Apache Git Service. To respond to

[GitHub] [airflow] bryzgaloff commented on a change in pull request #10546: DockerOperator extra_hosts argument support added

2020-08-26 Thread GitBox
bryzgaloff commented on a change in pull request #10546: URL: https://github.com/apache/airflow/pull/10546#discussion_r478076977 ## File path: tests/providers/docker/operators/test_docker.py ## @@ -298,3 +249,22 @@ def test_execute_xcom_behavior(self, client_class_mock,

[GitHub] [airflow] dimberman commented on a change in pull request #10393: Simplify the K8sExecutor and K8sPodOperator

2020-08-26 Thread GitBox
dimberman commented on a change in pull request #10393: URL: https://github.com/apache/airflow/pull/10393#discussion_r478076339 ## File path: airflow/example_dags/example_kubernetes_executor_config.py ## @@ -52,60 +53,67 @@ def test_volume_mount(): start_task =

[GitHub] [airflow] raulk89 commented on issue #10569: Airflow shows "Log Url" localhost:8080, although I am using airflow behind nginx proxy on hostname:443 port

2020-08-26 Thread GitBox
raulk89 commented on issue #10569: URL: https://github.com/apache/airflow/issues/10569#issuecomment-681354052 Why https..? All other links are fine with http://localhost:8080 Raul Sent from my iPhone > On 27. Aug 2020, at 02:18, Kamil Breguła wrote: > > 

[GitHub] [airflow] chrismclennon commented on pull request #10315: Add retry_only_on_pod_launching_failure and log_container_statuses_on…

2020-08-26 Thread GitBox
chrismclennon commented on pull request #10315: URL: https://github.com/apache/airflow/pull/10315#issuecomment-681338417 Chiming in since I work with Adil and we make use of this in our Airflow installation. Our users have found this helpful to debug any Kubernetes related errors that

[GitHub] [airflow] vishal-swarankar-sdl commented on issue #8907: Airflow web UI is slow

2020-08-26 Thread GitBox
vishal-swarankar-sdl commented on issue #8907: URL: https://github.com/apache/airflow/issues/8907#issuecomment-681322121 I had the flexibility of updating the k8s cluster to 1.16.5, and that solved this issue for me. This

[GitHub] [airflow] xu-xiang commented on issue #10516: pkg_resources.DistributionNotFound: The 'apache-airflow==2.0.0.dev0' distribution was not found and is required by the application

2020-08-26 Thread GitBox
xu-xiang commented on issue #10516: URL: https://github.com/apache/airflow/issues/10516#issuecomment-681318818 @potiuk My pip version is 20.2.2 when i create this issues. Use `(airflowenv) ➜ airflow git:(master) ✗ python3.8 setup.py install` install airflow and error with

[GitHub] [airflow] xu-xiang commented on issue #10516: pkg_resources.DistributionNotFound: The 'apache-airflow==2.0.0.dev0' distribution was not found and is required by the application

2020-08-26 Thread GitBox
xu-xiang commented on issue #10516: URL: https://github.com/apache/airflow/issues/10516#issuecomment-681316952 ``` (airflowenv) ➜ pythonenv pip --version pip 20.2.2 from /Users/jax/xx/pythonenv/airflowenv/lib/python3.8/site-packages/pip (python 3.8) (airflowenv) ➜ pythonenv

[GitHub] [airflow] mik-laj opened a new issue #10593: Missing docs for logging

2020-08-26 Thread GitBox
mik-laj opened a new issue #10593: URL: https://github.com/apache/airflow/issues/10593 Hello, The configuration of the Airflow logger is not easy, as in most applications. We have many loggers, some loggers generate multiple streams and our architecture is heterogeneous, so we end

[GitHub] [airflow] skylarbpayne edited a comment on issue #8172: setproctitle causes "Expected in: flat namespace" error

2020-08-26 Thread GitBox
skylarbpayne edited a comment on issue #8172: URL: https://github.com/apache/airflow/issues/8172#issuecomment-681227551 ## Potential Fix Just see this to skip all the ugly details: So concretely, here's how to install with homebrew + get airflow to work (tried this from fresh

[GitHub] [airflow] skylarbpayne edited a comment on issue #8172: setproctitle causes "Expected in: flat namespace" error

2020-08-26 Thread GitBox
skylarbpayne edited a comment on issue #8172: URL: https://github.com/apache/airflow/issues/8172#issuecomment-681227551 ## Potential Fix Just see this to skip all the ugly details: So concretely, here's how to install with homebrew + get airflow to work (tried this from fresh

[GitHub] [airflow] skylarbpayne commented on issue #8172: setproctitle causes "Expected in: flat namespace" error

2020-08-26 Thread GitBox
skylarbpayne commented on issue #8172: URL: https://github.com/apache/airflow/issues/8172#issuecomment-681227551 ## Potential Fix Just see this to skip all the ugly details: So concretely, here's how to install with homebrew + get airflow to work (tried this from fresh install,

[GitHub] [airflow] alexbegg edited a comment on issue #10434: Last Run links on home page UI not correct with RBAC UI

2020-08-26 Thread GitBox
alexbegg edited a comment on issue #10434: URL: https://github.com/apache/airflow/issues/10434#issuecomment-681195969 @kaxil I can't reproduce this with Breeze. I ran `master` branch, `v1-10-stable` branch (with `rbac = True`), and even 1.10.11 tag (with `rbac = True`, to match my

[GitHub] [airflow] alexbegg commented on issue #10434: Last Run links on home page UI not correct with RBAC UI

2020-08-26 Thread GitBox
alexbegg commented on issue #10434: URL: https://github.com/apache/airflow/issues/10434#issuecomment-681195969 @kaxil I can't reproduce this with Breeze. I ran both `master` branch and `v1-10-stable` (with `rbac = True`) with Breeze and this issue does not come up, even though the issue

[GitHub] [airflow] houqp commented on a change in pull request #10153: [AIP-34] Alternative proposal: Add TaskGroup as a DAG construction helper and UI concept with example

2020-08-26 Thread GitBox
houqp commented on a change in pull request #10153: URL: https://github.com/apache/airflow/pull/10153#discussion_r477713551 ## File path: airflow/models/baseoperator.py ## @@ -382,7 +389,16 @@ def __init__( stacklevel=3 )

[airflow] branch master updated (8624224 -> 276a15a)

2020-08-26 Thread kamilbregula
This is an automated email from the ASF dual-hosted git repository. kamilbregula pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git. from 8624224 Remove Outdated SQLCheckOperator Docstring (#10589) add 276a15a Add info about update mask to

[airflow] branch master updated (8624224 -> 276a15a)

2020-08-26 Thread kamilbregula
This is an automated email from the ASF dual-hosted git repository. kamilbregula pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git. from 8624224 Remove Outdated SQLCheckOperator Docstring (#10589) add 276a15a Add info about update mask to

[GitHub] [airflow] mik-laj merged pull request #10572: add info about update mask to API doc introduction

2020-08-26 Thread GitBox
mik-laj merged pull request #10572: URL: https://github.com/apache/airflow/pull/10572 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [airflow] kaxil opened a new pull request #10592: Add Airflow 1.10.12 to breeze-complete

2020-08-26 Thread GitBox
kaxil opened a new pull request #10592: URL: https://github.com/apache/airflow/pull/10592 Add Airflow 1.10.12 to breeze-complete --- **^ Add meaningful description above** Read the **[Pull Request

[GitHub] [airflow] mik-laj commented on issue #10569: Airflow shows "Log Url" localhost:8080, although I am using airflow behind nginx proxy on hostname:443 port

2020-08-26 Thread GitBox
mik-laj commented on issue #10569: URL: https://github.com/apache/airflow/issues/10569#issuecomment-681172171 @raulk89 it should be set to ``https://localhost:8080``. This is an automated message from the Apache Git

[airflow] branch master updated (2fc9614 -> 8624224)

2020-08-26 Thread kaxilnaik
This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git. from 2fc9614 Fix typo in Custom XCom backend (#10588) add 8624224 Remove Outdated SQLCheckOperator Docstring

[GitHub] [airflow] YingboWang commented on pull request #5499: [AIRFLOW-3964][AIP-17] Build smart sensor

2020-08-26 Thread GitBox
YingboWang commented on pull request #5499: URL: https://github.com/apache/airflow/pull/5499#issuecomment-681165680 > Static checks were failing, I have pushed [ad5ada1](https://github.com/apache/airflow/commit/ad5ada1e2d116865c39374fd5f79f31005012a1b) to fix it. Hope you don't mind

[jira] [Commented] (AIRFLOW-3964) Consolidate and de-duplicate sensor tasks

2020-08-26 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-3964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17185515#comment-17185515 ] ASF GitHub Bot commented on AIRFLOW-3964: - YingboWang commented on pull request #5499: URL:

[airflow] branch master updated: Remove Outdated SQLCheckOperator Docstring (#10589)

2020-08-26 Thread kaxilnaik
This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/master by this push: new 8624224 Remove Outdated SQLCheckOperator

[GitHub] [airflow] kaxil merged pull request #10589: Outdated SQLCheckOperator Docstring

2020-08-26 Thread GitBox
kaxil merged pull request #10589: URL: https://github.com/apache/airflow/pull/10589 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #10589: Outdated SQLCheckOperator Docstring

2020-08-26 Thread GitBox
boring-cyborg[bot] commented on pull request #10589: URL: https://github.com/apache/airflow/pull/10589#issuecomment-681165385 Awesome work, congrats on your first merged pull request! This is an automated message from

[GitHub] [airflow] kaxil commented on pull request #5499: [AIRFLOW-3964][AIP-17] Build smart sensor

2020-08-26 Thread GitBox
kaxil commented on pull request #5499: URL: https://github.com/apache/airflow/pull/5499#issuecomment-681164399 Static checks were failing, I have pushed https://github.com/apache/airflow/pull/5499/commits/ad5ada1e2d116865c39374fd5f79f31005012a1b to fix it. Hope you don't mind

[jira] [Commented] (AIRFLOW-3964) Consolidate and de-duplicate sensor tasks

2020-08-26 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-3964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17185514#comment-17185514 ] ASF GitHub Bot commented on AIRFLOW-3964: - kaxil commented on pull request #5499: URL:

[GitHub] [airflow] kaxil commented on issue #8421: Hide sensitive data in UI

2020-08-26 Thread GitBox
kaxil commented on issue #8421: URL: https://github.com/apache/airflow/issues/8421#issuecomment-681163551 This should happen before the templates are rendered I think for hiding sensitive info in Rendered Fields This is an

[GitHub] [airflow] turbaszek commented on a change in pull request #10304: Added DataprepGetJobGroupOperator and DataprepRunJobGroupOperator for Dataprep service

2020-08-26 Thread GitBox
turbaszek commented on a change in pull request #10304: URL: https://github.com/apache/airflow/pull/10304#discussion_r477627256 ## File path: tests/providers/google/cloud/operators/test_dataprep_system.py ## @@ -0,0 +1,48 @@ +# +# Licensed to the Apache Software Foundation

[GitHub] [airflow] kaxil edited a comment on issue #10154: DAG_TAG table and foreign key constraint

2020-08-26 Thread GitBox
kaxil edited a comment on issue #10154: URL: https://github.com/apache/airflow/issues/10154#issuecomment-681154077 @ozw1z5rd It will return all the Classes/Models that are used in the project ```pycon In [1]: from airflow import models In [3]:

[GitHub] [airflow] kaxil edited a comment on issue #10154: DAG_TAG table and foreign key constraint

2020-08-26 Thread GitBox
kaxil edited a comment on issue #10154: URL: https://github.com/apache/airflow/issues/10154#issuecomment-681154077 @ozw1z5rd It will return all the Classes/Models that are used in the project ```python In [1]: from airflow import models In [3]:

[GitHub] [airflow] kaxil commented on issue #10154: DAG_TAG table and foreign key constraint

2020-08-26 Thread GitBox
kaxil commented on issue #10154: URL: https://github.com/apache/airflow/issues/10154#issuecomment-681154077 @ozw1z5rd It will return all the Classes/Models that are used in the project ``` In [1]: from airflow import models In [3]:

[jira] [Commented] (AIRFLOW-3964) Consolidate and de-duplicate sensor tasks

2020-08-26 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-3964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17185501#comment-17185501 ] ASF GitHub Bot commented on AIRFLOW-3964: - kaxil commented on pull request #5499: URL:

[GitHub] [airflow] kaxil commented on pull request #5499: [AIRFLOW-3964][AIP-17] Build smart sensor

2020-08-26 Thread GitBox
kaxil commented on pull request #5499: URL: https://github.com/apache/airflow/pull/5499#issuecomment-681152030 Apologies @YingboWang -- can you rebase to the master one last time please This is an automated message from the

[GitHub] [airflow] natemoseman commented on issue #8907: Airflow web UI is slow

2020-08-26 Thread GitBox
natemoseman commented on issue #8907: URL: https://github.com/apache/airflow/issues/8907#issuecomment-681151249 I had a similar issue with airflow running on kubernetes cluster that I was, fortunately, able to solve. Regular HTTP connections were taking a minimal of 5 seconds to

[GitHub] [airflow] turbaszek commented on a change in pull request #10304: Added DataprepGetJobGroupOperator and DataprepRunJobGroupOperator for Dataprep service

2020-08-26 Thread GitBox
turbaszek commented on a change in pull request #10304: URL: https://github.com/apache/airflow/pull/10304#discussion_r477615415 ## File path: airflow/providers/google/cloud/hooks/dataprep.py ## @@ -50,26 +54,60 @@ def _headers(self) -> Dict[str, str]: }

[GitHub] [airflow] turbaszek commented on a change in pull request #10304: Added DataprepGetJobGroupOperator and DataprepRunJobGroupOperator for Dataprep service

2020-08-26 Thread GitBox
turbaszek commented on a change in pull request #10304: URL: https://github.com/apache/airflow/pull/10304#discussion_r477614337 ## File path: airflow/providers/google/cloud/hooks/dataprep.py ## @@ -50,26 +54,60 @@ def _headers(self) -> Dict[str, str]: }

[GitHub] [airflow] turbaszek commented on a change in pull request #10304: Added DataprepGetJobGroupOperator and DataprepRunJobGroupOperator for Dataprep service

2020-08-26 Thread GitBox
turbaszek commented on a change in pull request #10304: URL: https://github.com/apache/airflow/pull/10304#discussion_r477613123 ## File path: tests/providers/google/cloud/operators/test_dataprep_system.py ## @@ -0,0 +1,48 @@ +# +# Licensed to the Apache Software Foundation

[GitHub] [airflow] mik-laj commented on a change in pull request #10590: Removed bad characters from AWS operator

2020-08-26 Thread GitBox
mik-laj commented on a change in pull request #10590: URL: https://github.com/apache/airflow/pull/10590#discussion_r477610364 ## File path: airflow/providers/amazon/aws/operators/athena.py ## @@ -127,7 +127,7 @@ def on_kill(self) -> None: Cancel the submitted athena

[GitHub] [airflow] turbaszek commented on a change in pull request #10304: Added DataprepGetJobGroupOperator and DataprepRunJobGroupOperator for Dataprep service

2020-08-26 Thread GitBox
turbaszek commented on a change in pull request #10304: URL: https://github.com/apache/airflow/pull/10304#discussion_r477609796 ## File path: tests/providers/google/cloud/operators/test_dataprep_system.py ## @@ -0,0 +1,48 @@ +# +# Licensed to the Apache Software Foundation

[GitHub] [airflow] turbaszek commented on a change in pull request #10304: Added DataprepGetJobGroupOperator and DataprepRunJobGroupOperator for Dataprep service

2020-08-26 Thread GitBox
turbaszek commented on a change in pull request #10304: URL: https://github.com/apache/airflow/pull/10304#discussion_r477609682 ## File path: airflow/providers/google/cloud/hooks/dataprep.py ## @@ -40,7 +41,10 @@ class GoogleDataprepHook(BaseHook): def __init__(self,

[GitHub] [airflow] turbaszek commented on a change in pull request #10304: Added DataprepGetJobGroupOperator and DataprepRunJobGroupOperator for Dataprep service

2020-08-26 Thread GitBox
turbaszek commented on a change in pull request #10304: URL: https://github.com/apache/airflow/pull/10304#discussion_r477609564 ## File path: airflow/providers/google/cloud/hooks/dataprep.py ## @@ -40,7 +41,10 @@ class GoogleDataprepHook(BaseHook): def __init__(self,

[GitHub] [airflow] turbaszek commented on a change in pull request #10304: Added DataprepGetJobGroupOperator and DataprepRunJobGroupOperator for Dataprep service

2020-08-26 Thread GitBox
turbaszek commented on a change in pull request #10304: URL: https://github.com/apache/airflow/pull/10304#discussion_r477609212 ## File path: docs/howto/operator/google/cloud/dataprep.rst ## @@ -17,7 +17,29 @@ Google Dataprep Operators = -`Google

[GitHub] [airflow] turbaszek commented on a change in pull request #10304: Added DataprepGetJobGroupOperator and DataprepRunJobGroupOperator for Dataprep service

2020-08-26 Thread GitBox
turbaszek commented on a change in pull request #10304: URL: https://github.com/apache/airflow/pull/10304#discussion_r477608830 ## File path: airflow/providers/google/cloud/operators/dataprep.py ## @@ -49,6 +48,68 @@ def __init__(self, *, job_id: int, **kwargs) -> None:

[GitHub] [airflow] turbaszek commented on a change in pull request #10304: Added DataprepGetJobGroupOperator and DataprepRunJobGroupOperator for Dataprep service

2020-08-26 Thread GitBox
turbaszek commented on a change in pull request #10304: URL: https://github.com/apache/airflow/pull/10304#discussion_r477608592 ## File path: airflow/providers/google/cloud/operators/dataprep.py ## @@ -49,6 +48,68 @@ def __init__(self, *, job_id: int, **kwargs) -> None:

[GitHub] [airflow] turbaszek commented on a change in pull request #10304: Added DataprepGetJobGroupOperator and DataprepRunJobGroupOperator for Dataprep service

2020-08-26 Thread GitBox
turbaszek commented on a change in pull request #10304: URL: https://github.com/apache/airflow/pull/10304#discussion_r477608450 ## File path: airflow/providers/google/cloud/operators/dataprep.py ## @@ -49,6 +48,68 @@ def __init__(self, *, job_id: int, **kwargs) -> None:

[GitHub] [airflow] turbaszek commented on a change in pull request #10304: Added DataprepGetJobGroupOperator and DataprepRunJobGroupOperator for Dataprep service

2020-08-26 Thread GitBox
turbaszek commented on a change in pull request #10304: URL: https://github.com/apache/airflow/pull/10304#discussion_r477608267 ## File path: airflow/providers/google/cloud/hooks/dataprep.py ## @@ -50,26 +54,60 @@ def _headers(self) -> Dict[str, str]: }

[GitHub] [airflow] turbaszek commented on a change in pull request #10304: Added DataprepGetJobGroupOperator and DataprepRunJobGroupOperator for Dataprep service

2020-08-26 Thread GitBox
turbaszek commented on a change in pull request #10304: URL: https://github.com/apache/airflow/pull/10304#discussion_r477607766 ## File path: airflow/providers/google/cloud/hooks/dataprep.py ## @@ -40,7 +41,10 @@ class GoogleDataprepHook(BaseHook): def __init__(self,

[GitHub] [airflow] kaxil commented on a change in pull request #10303: Add docs for how airflow manages packages and imports

2020-08-26 Thread GitBox
kaxil commented on a change in pull request #10303: URL: https://github.com/apache/airflow/pull/10303#discussion_r477603292 ## File path: docs/modules_management.rst ## @@ -0,0 +1,238 @@ + .. Licensed to the Apache Software Foundation (ASF) under one +or more contributor

[GitHub] [airflow] kaxil commented on issue #10194: Ability to better support odd scheduling time

2020-08-26 Thread GitBox
kaxil commented on issue #10194: URL: https://github.com/apache/airflow/issues/10194#issuecomment-681135547 Have a look at https://lists.apache.org/thread.html/5bdf8415b78e65efb3219eb7f8e2afa37afa592341653eb053422055%40%3Cdev.airflow.apache.org%3E for some ideas from Max (the creator of

[GitHub] [airflow] ashb commented on pull request #10556: Fix timestamp tooltip redundancy

2020-08-26 Thread GitBox
ashb commented on pull request #10556: URL: https://github.com/apache/airflow/pull/10556#issuecomment-681120764 I don't think it was intentional, no, but someone would have to git bisect to work out when the change was made to be sure

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #10591: Added Plexus as an Airflow provider

2020-08-26 Thread GitBox
boring-cyborg[bot] commented on pull request #10591: URL: https://github.com/apache/airflow/pull/10591#issuecomment-681118065 Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our

[GitHub] [airflow] millertracy opened a new pull request #10591: Added Plexus as an Airflow provider

2020-08-26 Thread GitBox
millertracy opened a new pull request #10591: URL: https://github.com/apache/airflow/pull/10591 --- **^ Add meaningful description above** Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for

[GitHub] [airflow] mik-laj commented on a change in pull request #10303: Add docs for how airflow manages packages and imports

2020-08-26 Thread GitBox
mik-laj commented on a change in pull request #10303: URL: https://github.com/apache/airflow/pull/10303#discussion_r477582202 ## File path: docs/modules_management.rst ## @@ -0,0 +1,238 @@ + .. Licensed to the Apache Software Foundation (ASF) under one +or more contributor

[GitHub] [airflow] kaxil commented on pull request #9639: Add secrets backend for microsoft azure key vault

2020-08-26 Thread GitBox
kaxil commented on pull request #9639: URL: https://github.com/apache/airflow/pull/9639#issuecomment-681107887 @flolas Please feel free to create a new PR, looks like @elwinarens might be busy This is an automated message

[GitHub] [airflow] kaxil commented on a change in pull request #10303: Add docs for how airflow manages packages and imports

2020-08-26 Thread GitBox
kaxil commented on a change in pull request #10303: URL: https://github.com/apache/airflow/pull/10303#discussion_r477568354 ## File path: docs/modules_management.rst ## @@ -0,0 +1,238 @@ + .. Licensed to the Apache Software Foundation (ASF) under one +or more contributor

[GitHub] [airflow] michalslowikowski00 opened a new pull request #10590: Removed bad characters from AWS operator

2020-08-26 Thread GitBox
michalslowikowski00 opened a new pull request #10590: URL: https://github.com/apache/airflow/pull/10590 I found bad characters in AWS operator and I think they should be removed from code. This is an automated message from

[GitHub] [airflow] kaxil commented on a change in pull request #10303: Add docs for how airflow manages packages and imports

2020-08-26 Thread GitBox
kaxil commented on a change in pull request #10303: URL: https://github.com/apache/airflow/pull/10303#discussion_r477567198 ## File path: docs/modules_management.rst ## @@ -0,0 +1,238 @@ + .. Licensed to the Apache Software Foundation (ASF) under one +or more contributor

[GitHub] [airflow] rynmccrmck opened a new pull request #10589: outdated docstring

2020-08-26 Thread GitBox
rynmccrmck opened a new pull request #10589: URL: https://github.com/apache/airflow/pull/10589 This method is now implemented --- **^ Add meaningful description above** Read the **[Pull Request

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #10589: outdated docstring

2020-08-26 Thread GitBox
boring-cyborg[bot] commented on pull request #10589: URL: https://github.com/apache/airflow/pull/10589#issuecomment-681096583 Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our

[GitHub] [airflow] michalslowikowski00 commented on a change in pull request #10304: Added operator, hook, docs and tests for Dataprep

2020-08-26 Thread GitBox
michalslowikowski00 commented on a change in pull request #10304: URL: https://github.com/apache/airflow/pull/10304#discussion_r477551063 ## File path: tests/conftest.py ## @@ -251,6 +253,9 @@ def pytest_configure(config): config.addinivalue_line( "markers",

[GitHub] [airflow] kaxil commented on issue #10469: Make permissions consistent between UI and API

2020-08-26 Thread GitBox
kaxil commented on issue #10469: URL: https://github.com/apache/airflow/issues/10469#issuecomment-681086447 >Airflow.can_refresh_all => Dag.can_read Since `/refresh` also needs `can_dag_edit` permissions, I think `refresh_all` should be the same. But other than that, doc

[GitHub] [airflow] ryw edited a comment on pull request #10556: Fix timestamp tooltip redundancy

2020-08-26 Thread GitBox
ryw edited a comment on pull request #10556: URL: https://github.com/apache/airflow/pull/10556#issuecomment-681081461 @ashb do you know if we changed this intentionally, to simplify Airflow UI. An idea is that we could show the (i) icon if there is a was a difference between

[GitHub] [airflow] ryw commented on pull request #10556: Fix timestamp tooltip redundancy

2020-08-26 Thread GitBox
ryw commented on pull request #10556: URL: https://github.com/apache/airflow/pull/10556#issuecomment-681081461 @ashb do you know if we changed this intentionally, to simplify Airflow UI. It could be that an (i) icon is shown (maybe in red?) if there is a was a difference between last_run

[GitHub] [airflow] kaxil commented on a change in pull request #10546: DockerOperator extra_hosts argument support added

2020-08-26 Thread GitBox
kaxil commented on a change in pull request #10546: URL: https://github.com/apache/airflow/pull/10546#discussion_r477537654 ## File path: tests/providers/docker/operators/test_docker.py ## @@ -298,3 +249,22 @@ def test_execute_xcom_behavior(self, client_class_mock,

[GitHub] [airflow] dimon222 commented on issue #8212: Can't read S3 remote logs using Airflow 1.10.9

2020-08-26 Thread GitBox
dimon222 commented on issue #8212: URL: https://github.com/apache/airflow/issues/8212#issuecomment-681077018 Solution mentioned above by me > @cmlad yes its the reason for sure. And HTTP vs HTTPS no difference. > > I randomly found potential fix in one of previously mentioned

[GitHub] [airflow] kaxil commented on issue #10586: KubernetesPodOperator truncates logs

2020-08-26 Thread GitBox
kaxil commented on issue #10586: URL: https://github.com/apache/airflow/issues/10586#issuecomment-681076412 tagging in @dimberman if you have any idea about this This is an automated message from the Apache Git Service. To

[GitHub] [airflow] dimberman commented on a change in pull request #10393: Simplify the K8sExecutor and K8sPodOperator

2020-08-26 Thread GitBox
dimberman commented on a change in pull request #10393: URL: https://github.com/apache/airflow/pull/10393#discussion_r477530455 ## File path: airflow/example_dags/example_kubernetes_executor_config.py ## @@ -52,60 +53,67 @@ def test_volume_mount(): start_task =

[GitHub] [airflow] kaxil commented on a change in pull request #10393: Simplify the K8sExecutor and K8sPodOperator

2020-08-26 Thread GitBox
kaxil commented on a change in pull request #10393: URL: https://github.com/apache/airflow/pull/10393#discussion_r477529000 ## File path: airflow/example_dags/example_kubernetes_executor_config.py ## @@ -52,60 +53,67 @@ def test_volume_mount(): start_task =

[GitHub] [airflow] dimberman commented on a change in pull request #10393: Simplify the K8sExecutor and K8sPodOperator

2020-08-26 Thread GitBox
dimberman commented on a change in pull request #10393: URL: https://github.com/apache/airflow/pull/10393#discussion_r477527689 ## File path: airflow/example_dags/example_kubernetes_executor_config.py ## @@ -52,60 +53,67 @@ def test_volume_mount(): start_task =

[GitHub] [airflow] kaxil commented on a change in pull request #10393: Simplify the K8sExecutor and K8sPodOperator

2020-08-26 Thread GitBox
kaxil commented on a change in pull request #10393: URL: https://github.com/apache/airflow/pull/10393#discussion_r477525125 ## File path: telepresence.log ## @@ -0,0 +1,36 @@ + 0.0 TEL | Telepresence 0.105 launched at Mon Aug 24 20:51:33 2020 Review comment: Don't

[GitHub] [airflow] dimberman commented on a change in pull request #10393: Simplify the K8sExecutor and K8sPodOperator

2020-08-26 Thread GitBox
dimberman commented on a change in pull request #10393: URL: https://github.com/apache/airflow/pull/10393#discussion_r477525529 ## File path: airflow/example_dags/example_kubernetes_executor_config.py ## @@ -52,60 +53,67 @@ def test_volume_mount(): start_task =

[GitHub] [airflow] kaxil commented on a change in pull request #10393: Simplify the K8sExecutor and K8sPodOperator

2020-08-26 Thread GitBox
kaxil commented on a change in pull request #10393: URL: https://github.com/apache/airflow/pull/10393#discussion_r477522918 ## File path: airflow/providers/cncf/kubernetes/operators/kubernetes_pod.py ## @@ -365,43 +351,53 @@ def create_new_pod_for_operator(self, labels,

[GitHub] [airflow] kaxil commented on a change in pull request #10393: Simplify the K8sExecutor and K8sPodOperator

2020-08-26 Thread GitBox
kaxil commented on a change in pull request #10393: URL: https://github.com/apache/airflow/pull/10393#discussion_r477517592 ## File path: airflow/executors/kubernetes_executor.py ## @@ -70,116 +69,25 @@ class KubeConfig: # pylint: disable=too-many-instance-attributes

[GitHub] [airflow] kaxil commented on a change in pull request #10393: Simplify the K8sExecutor and K8sPodOperator

2020-08-26 Thread GitBox
kaxil commented on a change in pull request #10393: URL: https://github.com/apache/airflow/pull/10393#discussion_r477516328 ## File path: airflow/example_dags/example_kubernetes_executor_config.py ## @@ -52,60 +53,67 @@ def test_volume_mount(): start_task =

[airflow-site] branch asf-site updated: Update asf-site to output generated at a624457

2020-08-26 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/airflow-site.git The following commit(s) were added to refs/heads/asf-site by this push: new e7705b5 Update asf-site to

[GitHub] [airflow-site] kaxil opened a new pull request #290: Change 1.10.10 -> 1.10.12

2020-08-26 Thread GitBox
kaxil opened a new pull request #290: URL: https://github.com/apache/airflow-site/pull/290 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[airflow-site] branch fix-typo created (now 4e25699)

2020-08-26 Thread kaxilnaik
This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a change to branch fix-typo in repository https://gitbox.apache.org/repos/asf/airflow-site.git. at 4e25699 Change 1.10.10 -> 1.10.12 This branch includes the following new commits: new 4e25699

[GitHub] [airflow-site] kaxil merged pull request #290: Change 1.10.10 -> 1.10.12

2020-08-26 Thread GitBox
kaxil merged pull request #290: URL: https://github.com/apache/airflow-site/pull/290 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[airflow-site] branch master updated: Change 1.10.10 -> 1.10.12 (#290)

2020-08-26 Thread kaxilnaik
This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/airflow-site.git The following commit(s) were added to refs/heads/master by this push: new a624457 Change 1.10.10 -> 1.10.12

[airflow-site] 01/01: Change 1.10.10 -> 1.10.12

2020-08-26 Thread kaxilnaik
This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a commit to branch fix-typo in repository https://gitbox.apache.org/repos/asf/airflow-site.git commit 4e25699596304d3102d65697a6f38a4017886f96 Author: Kaxil Naik AuthorDate: Wed Aug 26 19:08:37 2020 +0100

[GitHub] [airflow] kaxil edited a comment on pull request #10588: Fix typo in Custom XCom backend

2020-08-26 Thread GitBox
kaxil edited a comment on pull request #10588: URL: https://github.com/apache/airflow/pull/10588#issuecomment-681037384 Merged it before CI to fix the master This is an automated message from the Apache Git Service. To

[airflow] branch master updated: Fix typo in Custom XCom backend (#10588)

2020-08-26 Thread kaxilnaik
This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/master by this push: new 2fc9614 Fix typo in Custom XCom backend

[GitHub] [airflow] kaxil commented on pull request #10588: Fix typo in Custom XCom backend

2020-08-26 Thread GitBox
kaxil commented on pull request #10588: URL: https://github.com/apache/airflow/pull/10588#issuecomment-681037384 Merged it to before CI to fix the master This is an automated message from the Apache Git Service. To respond

[GitHub] [airflow] kaxil merged pull request #10588: Fix typo in Custom XCom backend

2020-08-26 Thread GitBox
kaxil merged pull request #10588: URL: https://github.com/apache/airflow/pull/10588 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [airflow] kaxil opened a new pull request #10588: Fix typo in Custom XCom backend

2020-08-26 Thread GitBox
kaxil opened a new pull request #10588: URL: https://github.com/apache/airflow/pull/10588 --- **^ Add meaningful description above** Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more

[airflow-site] branch asf-site updated: Update asf-site to output generated at bead826

2020-08-26 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/airflow-site.git The following commit(s) were added to refs/heads/asf-site by this push: new 134ef1b Update asf-site to

[GitHub] [airflow-site] kaxil merged pull request #289: Add Airflow 1.10.12 Blogpost

2020-08-26 Thread GitBox
kaxil merged pull request #289: URL: https://github.com/apache/airflow-site/pull/289 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[airflow-site] branch master updated: Add Airflow 1.10.12 Blogpost (#289)

2020-08-26 Thread kaxilnaik
This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/airflow-site.git The following commit(s) were added to refs/heads/master by this push: new bead826 Add Airflow 1.10.12 Blogpost

[airflow] branch master updated: Improve Docstring for AWS Athena Hook/Operator (#10580)

2020-08-26 Thread xddeng
This is an automated email from the ASF dual-hosted git repository. xddeng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/master by this push: new 8349061 Improve Docstring for AWS Athena

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #10580: Improve Docstring for AWS Athena Hook/Operator

2020-08-26 Thread GitBox
boring-cyborg[bot] commented on pull request #10580: URL: https://github.com/apache/airflow/pull/10580#issuecomment-681033468 Awesome work, congrats on your first merged pull request! This is an automated message from

  1   2   3   >